Commit graph

12089 commits

Author SHA1 Message Date
Michael Kohl
b4afd5ee14
Disallow /ahoy/* in robots.txt (#18531) 2022-10-04 12:26:43 +02:00
depfu[bot]
fd6aaccc08
Update omniauth-github to version 2.0.1 (#18524)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2022-10-03 12:43:15 -06:00
depfu[bot]
3fd4eaffdd
Update omniauth-apple to version 1.2.0 (#18528)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2022-10-03 11:57:27 -06:00
depfu[bot]
a9524dca09
Update all Yarn dependencies (2022-10-03) (#18527)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2022-10-03 10:45:32 -06:00
Ridhwana
9361d2426f
✂️✂️✂️ Part 1: Remove Sponsorship (#18512)
* feat: remove initializeSponsorshipVisibility and related code

* feat: remove sponsorships from sidebar

* feat: remove sponsorships from the admin - route, controller, view, spec

* feat: remove the admin menu item

* feat: remove the i8n for admin sponsors controller

* feat: sponsorship decorator was not being used anywhere

* feat: sponsorship slack messenger was not being used anywhere

* feat: remove the sponsorship_headline that gets configures on the admin

* feat: remove the /sponsors page

* feat: remove renedring of single_sponsor partial and associated partials

* feat: remove the navigation link rake task for sponsors

* feat: remove sponsorship from tags

* feat: remove i8n constants used

* remove sponsor references in text to the privacy page

* feat: remove the sponsorship detail from the organization page

* feat: remove the sponsors css that was used for app/views/pages/sponsors.html.erb

* feat: remove the sponsorship i8n that was used in the slack messengers

* feat: swap out the decorators to use Article as an example

* feat: remove spec to show sponsors on home page

* feat: update the specs to use Article Decorator instead of the Sponsorship Decorator

* fix: use direct and not all

* fix: remove tests for tag sponsorship

* fix: remove organization sponsorship test

* feat: remove more i8n
2022-10-03 16:26:32 +02:00
Fernando Valverde
e5e36a2e2d
Comment fragment link when signed out (#18517)
* Comment fragment link when signed out

* Optional chaining for article path

* Fix comment liquid tag rendering

* Extract signed in/out logic into helper

* Debugging specs

* Fix specs

* Use named empty anchor to link comments with id_code
2022-10-03 07:58:34 -06:00
Fernando Valverde
3b575acb56
Remove featured_number from articles table (#18514) 2022-09-29 15:07:17 -06:00
Fernando Valverde
a36e7027af
Snackbar error message in comments image upload (#18504)
* Snackbar error message in comments image upload

* Shorter inline comment
2022-09-29 14:07:11 -06:00
Joshua Wehner
ed2bfe59c1
Restore DisplayAd search (#18511)
* Restore DisplayAd search

* Add tests for search behavior
2022-09-29 10:27:09 +02:00
depfu[bot]
f11726c749
Update strong_migrations to version 1.3.1 (#18516)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2022-09-28 16:08:31 -06:00
Ridhwana
b6b9087bfb
Refactor: no need to pass through the ahoy event name dynamically. (#18498)
* refactor: the name does not need to be passed through dynamically

* refactor: the name does not need to be passed through dynamically

* chore: remove name from the js doc
2022-09-28 19:21:38 +02:00
Fernando Valverde
c57acc25ea
Remove featured number usage from articles (#18510) 2022-09-28 08:59:03 -06:00
depfu[bot]
5fad13f11b
[ruby] Update sidekiq: 6.5.6 → 6.5.7 (patch) (#18507)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2022-09-28 10:21:44 -04:00
depfu[bot]
c7e021c94d
Update recaptcha to version 5.12.3 (#18506)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2022-09-27 15:14:36 -06:00
depfu[bot]
cb4f52ab93
Update octokit to version 5.6.1 (#18505)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2022-09-27 10:22:49 -06:00
Ben Halpern
cd5c86c760
Feed experiment for 09-26-2022 (#18501)
* Feed experiment for 09-26-2022

* Fix variant

* Add proper tests
2022-09-27 08:48:15 -06:00
depfu[bot]
3972147204
Update all Yarn dependencies (2022-09-26) (#18497)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2022-09-27 07:41:11 -06:00
Ridhwana
5fa58a9c73
feat: remove possible spam abuse (#18499) 2022-09-26 20:01:10 +02:00
Ridhwana
968dda60d2
feat: remove latest articles (#18500) 2022-09-26 19:35:34 +02:00
Joshua Wehner
98077a8df6
DisplayAdEvent tracking changes (#18460)
* Make user_id optional for DisplayAdEvent

* Track when DisplayAd is visible to user

* Tidy up a bit

* Deleting a user account should nullify related DisplayAdEvents

* Update tests with new association details
2022-09-26 16:33:03 +02:00
depfu[bot]
2c8f93c5c5
[ruby] Update pg_query: 2.1.3 → 2.1.4 (patch) (#18496)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2022-09-26 10:19:59 -04:00
depfu[bot]
76f3b34db0
[js] Update all Yarn dependencies (2022-09-23) (#18421)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Mac Siri <krairit.siri@gmail.com>
2022-09-23 15:25:03 -04:00
Rajat Talesra
7b0f8b6011
Design fixes for badges (#18445)
* Design fixes for badges

* Badges UI fixes

* Shifted styles to scss file

* Removed gray functionality for badge
2022-09-23 23:32:28 +05:30
Josh Puetz
17aaa7afa8
Remove Josh from core team (#18480) 2022-09-23 09:19:44 -05:00
Ridhwana
9dee48dbc2
Add tracking for the registration flow - "Clicked on Create Account" (#18459)
* refactor: move trackEvents to a utilities folder so that it can be re-used

* feat: add a function called trackCommentClicks and use it on the articlePage

* feat: update the auth widget to take the correct properties

* feat: add create account tracking method for hamburger

* feat: add create account tracking method for sidebar left

* feat: whoops, sidebar tracking info added

* feat: add the feed card create account tracking

* feat: whoops add the id to the dom

* feat: add top nav create account tracking

* feat: create account tracking for the registration modal

* fix: callback instead of invoking + rename class

* fix: js-prepend

* feat: some showLogin event tracking

* use the tracking propert

* x - feed.jsx

* fix: oops I removed hidden

* track from the search login

* feat: add tracking for follow button

* fix: main_stories is only being called in view/articles and both are including the FollowButtons pack

* comments track

* feat: remove punc (.)

* chore: cahnge working

* chore: remove tracking-id from modal

* feat: remove ecmascript features

* refactor: rename some events

* feat: referrer page

* feat: add a secondary source for the follow buttons

* feat: remove file that is not used

* chore: rename key

* feat: use @utilities

* feat: add spec for create account clicks

* feat: add key referrer

* fix: tests

* fix: oops

* chore: add commented test

* test for tracking

* feat: update the change by 1

* feat: aggregate_failures

* feat: add data-no-instant back

* feat: try a different way of testing

* refactor: change secondary_source to referring_souce

* feat: change ahoy event test

* feat: add a version number to ahoy tracking

* feat: change the href to pathname

* feat: reply comment tracking

* fix: to be present syntax

* feat: use href instead of pathname

* chore: do not track tags and podcasts follow and remove referrer

* feat: add readinglist

* fix: remove referrer from test

* feat: fail gracefully in instances where there is no tracking data
2022-09-22 16:03:49 +02:00
Josh Puetz
519632cffb
Jump to comments button (#18457)
Co-authored-by: Fernando Valverde <fernando@visualcosita.com>
2022-09-22 08:58:20 -05:00
Mac Siri
41987116c7
Replace webdriver with cuprite (#18476)
* Replace webdriver with cuprite

* Fix broken spec

* Fix broken spec

* Fix broken spec

* Fix broken spec
2022-09-22 08:23:42 -04:00
Fernando Valverde
bebd1d459c
Remove brand_color2 from users_settings (#18473)
* Remove brand_color2 from users_settings

* Remove occurences of brand_color2
2022-09-21 11:21:29 -06:00
Ben Halpern
828d568443
Feed experiment for 09-20-2022 (#18475)
* Feed experiment for 09-20-2022

* Fix yaml indentation

* Fix typo in config
2022-09-21 12:19:38 -04:00
depfu[bot]
5cda9e136e
[ruby] Update fog-aws: 3.14.0 → 3.15.0 (minor) (#18470)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2022-09-21 09:54:20 -05:00
Mac Siri
071d874c33
Add back Badge#path (#18471)
* Add back Badge#path

* Update app/models/badge.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2022-09-20 09:01:29 -04:00
Joshua Wehner
fb87165654
Try front-end hiding ads for user setting (#18444)
* Try front-end hiding ads for user setting

* CI does not like ?.
2022-09-20 09:17:03 +02:00
depfu[bot]
f47f905382
[ruby] Update all development Bundler dependencies (2022-09-19) (#18469)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2022-09-19 10:35:34 -04:00
Anna Buianova
e432c06312
Modified the misleading comment (history was removed) (#18455) 2022-09-19 11:37:24 +03:00
Fernando Valverde
f4155984c5
Article collection cleanup callback (#18456)
* Collection cleanup callback

* Fix cleanup check

* fix specs
2022-09-16 14:08:20 -06:00
Josh Puetz
55c716da6e
Feed experiment for 09-15-2022 (#18463) 2022-09-16 11:27:42 -05:00
Anna Buianova
455399bdba
Rubocop fixes (#18461)
* Rubocop fixes

* Fixed most Capybara/SpecificMatcher violations

* Moved flash notice texts to locales
2022-09-16 15:25:48 +03:00
Fernando Valverde
2ca01b0c9a
Minor margin added + different anchor in link (#18450) 2022-09-15 08:57:30 -06:00
VISHAL DEEPAK
b84fa1da08
Sort comments reopen (#18349)
* Sort comments in articles page

* Clickable area in sort comments article is now more approriate

* Comments subtitle is now responsive in articles page

* Consider comments sort order for cache in articles page

* On selecting sort option the refreshed page lands to comments section
2022-09-13 11:37:48 -06:00
Rajat Talesra
5559067e34
Revert "Revert "Entire profile badge redesign" & "Badges page redesign" (#18446)" (#18447)
This reverts commit d7f70eb85b.
2022-09-13 22:06:37 +05:30
Rajat Talesra
d7f70eb85b
Revert "Entire profile badge redesign" & "Badges page redesign" (#18446)
Co-authored-by: Mac Siri <krairit.siri@gmail.com>
2022-09-13 11:39:46 -04:00
Ridhwana
162ddb81e2
Fix the profile page of other users (#18443)
* fix: lonely div

* chore: whitespace
2022-09-13 17:12:31 +05:30
Rajat Talesra
f1176900f0
Badges page redesign (#18419)
* Badges homepage redesign

* badges.scss

* Attempt at solving badge ci check

* Added badge prompt

* Merged with main

* Removed /badge/.. related code

* Revert removing badge page

* Fixed Safari design issue

* Removed not-requried css property

* Trying to remove /badge/

* Updated profile badges

* Fixed userprofile badge

* Accessibility changes + removed failed tests

* Tests passed
2022-09-13 03:07:59 +05:30
Rajat Talesra
01513bae69
Remove mode banner (#18441) 2022-09-12 22:20:13 +05:30
Joshua Wehner
2b24167fba
Try fixing comment like count bugs (#18438)
* Try fixing comment like count bugs

* Tests for the CommentCreator
2022-09-12 10:12:46 +02:00
thejwuscript
fea90d2e84
Fix inconsistent published date of Article and Comment (#18412)
* Revise system specs for viewing a comment

* Add system specs for viewing comment date

* Add conditional to SetTimeZone middleware

* Revise comment_date partial

* Refactor viewing a comment system specs

* Add more system specs for viewing a comment

* Fix format of comment date with short year

* Fix edited comment date

* Fix comment date when posting new comments
2022-09-09 14:12:15 -06:00
Mac Siri
0e43c915d9
Silence parser warnings (#18429) 2022-09-09 11:28:43 -04:00
Josh Puetz
abbb4d2015
Feed experiment for 09-07-2022 (#18437) 2022-09-09 08:17:00 -05:00
Joshua Wehner
892ad01264
Restrict Reactions API to admins (#18424)
* Restrict Reactions API to admins

* Also update API docs spec

* Removed unneeded pundit_user
2022-09-08 17:56:42 +02:00
depfu[bot]
154f154006
[ruby] Update all development Bundler dependencies (2022-09-05) (#18422)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2022-09-08 11:48:07 -04:00