maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
2236 commits 1 branch 0 tags 1.6 GiB
Commit graph

1552 commits

Author SHA1 Message Date
briwa
b35fc23a82 refactor(svgs): remove empty group tags (#3002) 
* refactor(svgs): remove empty group tags

* fix(spec): update liquid tag twitter spec
 2019-05-31 08:54:31 -04:00
Anna Buianova
a7332846df Validate on creating a reaction notification (#3010) 2019-05-31 07:30:17 -04:00
Curtis Maloney
8d50956f1a Optimise images (#2966) 2019-05-30 17:37:10 -04:00
Ali Spittel
5dd0341a0c refactor v2 editor guide (#3007) 2019-05-30 17:35:19 -04:00
Jess Lee
c3e2a0c5f1 Add missing instance var for /manage & Bust rails cache on comments (#3004) 2019-05-30 12:23:20 -04:00
cyrillefr
8c52d5c43f Move remove_each notifications method in own job (#2946) 2019-05-29 16:26:18 -04:00
rhymes
a99c072525 Guard bust_comment against nil commentable (#2991) 2019-05-29 14:03:20 -04:00
Anna Buianova
c510f1510c Fix a validation error when creating notifications #2525 (#2999) 
* Use activerecord-import upsert to deal with the race condition

* Return a more consistent result form Notifications::Reactions::Send
 2019-05-29 11:19:37 -04:00
briwa
4f31c6d07a fix(reading-list): even spacing for Save and Bookmark span (#3000) 2019-05-29 11:19:01 -04:00
rhymes
38aa45c8e3 Cleanup bodyPreview component (#2980) [ci skip] 2019-05-28 23:55:37 -04:00
rhymes
6a626e819d Refactor: fix issues raised by bullet (#2965) 
* Preload organization, not user

* Preload users only when needed

* Pre-load podcasts for podcast episodes in API

* Avoid eager loading error by loading rating votes separately

* Preload associations for moderation

* Preload user comments in trees

* Preload organization for non org dashboard and cleanup queries

* Optimize ArticleSuggester to only load N articles at need

* Remove eager loading and pass variables to partials for easier debug

* Reorganize tags validation code and ignore actsastaggableon eager loading issues

* Remove unused eager loading and bring up comments relation

* Preload podcasts when loading podcast episodes

* Fix views specs

* Make sure ArticleSuggester never returns duplicates

* Remove commented code

* Re-trigger build

* Move suggested articles back to view to respect fragment caching
 2019-05-28 17:32:53 -04:00
Ben Halpern
d2f296114a
Modify cache key for article sidebar cta (#2993) 2019-05-28 17:18:31 -04:00
Vince Blom
bfc961b3f3 Codepen Links with Underscore Usernames (#2985) 
- updates codepen liquid tag regex to allow underscores
- adds test to ensure an underscore in the username field of the link
  is considered valid
 2019-05-28 16:32:34 -04:00
Ben Halpern
e1d537c016
Fix css missing (#2992) 2019-05-28 15:24:56 -04:00
Kartikey Tanna
b16fa4f8cc Implemented ActiveJob for badge_achievements#send_email_notification (#2962) 
* Implemented ActiveJob for badge_achievements#send_email_notification

* Sending email only if record not nil

As per the review
 2019-05-27 09:44:38 -04:00
Mac Siri
6d1638ed68 Unskip all skipped specs (#2941) 
* Change all login_as to sign_in

* Unskip comment spec

* Create new specs

* Turn on Webdriver caching

* Set logger for Omniauth in test

* Update editor system spec

* Fix editor approval file

* Update video_controller

* Update TagAdjustmentUpdateService's spec

* Update users api spec

* Update stories_index_spec

* Remove redundant spec file

* Remove residual code

* Change ClassifiedListing spec

* Update NotificationsIndex spec
 2019-05-25 11:04:38 -04:00
Thomas Ghysels
732d0e4450 Use consistent colors for inline code, including night theme (#2947) 2019-05-24 12:53:20 -04:00
Ben Halpern
37fabd08b1
Fix some connect bugs with wrong url and remove some dead code (#2953) 2019-05-24 12:19:59 -04:00
Anna Buianova
d3f9050be7 Move updating twitch username to a separate action #2784 (#2866) 
* Move updating twitch username to a separate action #2784

* Fix the submit button on the integrations page

* Modify test according to the redirect
 2019-05-24 11:13:33 -04:00
Clara
48b9d16e6e Bug/markdown underscores in usernames (#2948) 
* Add method into MardownFixer and call in Comment

* Add test

* Escape all underscores in usernames and adapt tests

* Rework regex [WIP]

* Add new idea

* Clean up method and add correct tests
 2019-05-24 08:34:14 -04:00
Anna Buianova
a6091fe6c8 Moved notifying followers to a separate ActiveJob #1996 (#2935) 
* Moved notifying followers to a service + specs

* Created an ActiveJob for notifiable action notifications

* Call the job from the Notification#send_to_followers

* Refactor creating notifiable action notification

* Handle possible nil followers while sending notifiable action notification

* Use activerecord import to bulk-create notifications

* Set notified_at for the bulk-created notifications

* Move compact to the appropriate place
 2019-05-24 07:45:51 -04:00
Jess Lee
8765de85b4 Sort internal/listings by recently bumped listings (#2938) 2019-05-22 15:28:03 -04:00
Mohammadjavad Raadi
1a960cfb44 Fix TwitterTag's video control bug (#2869) 2019-05-22 13:32:37 -04:00
rhymes
3a45bfcc2d API docs: Adjust document and add syntax highlight [skip ci] (#2936) 
* Adjust document and add syntax highlight

* Add alt text to images
 2019-05-22 12:24:52 -04:00
Jess Lee
65e3cf605c Internal Listings View Enhancement (#2931) 
* wip

* add username to listings list view

* add pagination

* small style adjustment on edit page

* add has_many relationship to users and orgs

* add search by username or listing title
 2019-05-21 18:28:18 -04:00
Jess Lee
1678489a2b Internal Updates - Bust Cache for Listings and Add Note for Credits (#2908) 
* handle cache busting

* add required note when removing or adding credits

* only reindex if listing is published
 2019-05-21 17:25:37 -04:00
rhymes
9e14ef2afd Add a proper exception in case of XSS attempt (#2927) 
Fixes the generic error message with a proper one
 2019-05-21 17:20:39 -04:00
Ben Halpern
e3400a2dc2
Make home page listings minimizeable (#2928) 2019-05-21 17:17:28 -04:00
Ben Halpern
07597d307c
Fix bug to allow users to remove org from article (#2930) 2019-05-21 17:16:16 -04:00
Jess Lee
27bd5ed4e2 add guard to granting credits and add spec (#2926) 2019-05-21 17:14:51 -04:00
Faraz Patankar
e33c376789 use flexbox to align content in onboarding modal (#2910) 2019-05-21 15:41:13 -04:00
rhymes
09a99d93a3 Return errors instead of raising an exception on ArticleCreation (#2922) 2019-05-21 15:18:02 -04:00
rhymes
d517050973 Do not ask to unpublish a draft article (#2920) [ci skip] 2019-05-21 15:17:12 -04:00
rhymes
c2a3d46850 Remove trailing dot from API token message [ci skip] (#2918) 2019-05-21 15:09:27 -04:00
Jess Lee
21f595ea2c Update Slack Notifications (#2870) [ci skip] 2019-05-21 15:06:04 -04:00
Ben Halpern
80f42a544a
Add noopener to external target blank links (#2923) 
* Add noopener to external target blank links

* Add noopener to external target blank links properly

* Fix schema mistake
 2019-05-21 13:56:25 -04:00
Ben Halpern
97125dfd6a
Add PWA target blank functionality (#2921) 2019-05-21 13:15:36 -04:00
Ben Halpern
ae47e8db2c
Add API portal (#2915) 
* Add API portal

* Change title tag
 2019-05-21 12:46:52 -04:00
Monica Powell
d1357608ea improve contrast of badge-reward-message (#2909) 
* improve contrast of badge-reward-message

* update styling to work in multiple themes
 2019-05-21 12:43:41 -04:00
Ben Halpern
2aa01d44a2
Add listings to home page (#2912) 2019-05-21 10:21:49 -04:00
rhymes
5e94533f0b Articles API: fix update org and add datetimes (#2913) 
* Allow the article to be assigned to an org on update

* Add all the relevant datetimes, those available in the export

* Not all dates are always available
 2019-05-21 09:53:30 -04:00
Kartikey Tanna
03a122f0ce Implemented ActiveJob for RateLimitChecker Job (#2878) 
* Implemented ActiveJob for RateLimitChecker Job

* Changes as per the review

* Further changes as per the review
 2019-05-21 08:45:58 -04:00
rhymes
ff929fcf14 Some small performance improvements (#2876) 
* Improve a few idioms with their faster counterparts

* Remove unused routes and some dead code

* Add the option to use bullet in testing mode and move rack host redirect

* Go back to the classic fetch to make mocking work

* Reorder gems and fix code climate issue
 2019-05-20 18:53:31 -04:00
rhymes
85e33583c8 Fix organization article ownership code (#2904) 
* Fix organization article ownership code

* Query the DB in case of user change only if needed
 2019-05-20 18:50:04 -04:00
cyrillefr
abb4831a53 Move remove_all notifications method in own job (#2882) 
- that calls a service
    - spec for job + service
    - check actual integration spec
    - minor refactoring
 2019-05-20 13:54:39 -04:00
Ben Halpern
c08d140b36
Remove some dead code for very minor perf improvements and code quality (#2905) 2019-05-20 13:40:02 -04:00
Molly Struve
d65889b8a8 Add text explaining how to setup anchor links for blog posts (#2884) 2019-05-20 13:30:08 -04:00
Ben Halpern
ec900a3146
Add safe navigation within chatchannelmemberships and remove some console.logs (#2903) 2019-05-20 13:20:06 -04:00
Ben Halpern
70580d0265
[WIP] Connect misc improvements/debugs (#2880) 
* WIP Connect misc improvements/debugs

* Modify tests and update snapshots

* Change GitHub sidecar copy
 2019-05-20 10:08:51 -04:00
Jess Lee
b935fdd920 Limit number of cover image uploads (#2851) 2019-05-17 15:59:07 -04:00