The char "-" in regexp defaults a a separator for a range of character, for example: "a-z", Ruby is smart enough to understand "-_" is no range but it does emit a warning, by properly escaping the char "-" we ensure that no warning or issues can arise in the future.
* Improve Gist Link Regex
While working with the gist liquid tag, I noticed that valid gist links
were resulting in errors. After looking at `gist_tag.rb`, I noticed
that for a link to be considered valid the gist-id had to be exactly 32
characters which is not always true.
I changed the regex so links with a gist-id of at least one character and
at most 32 characters is considered valid. I decided to continue with
the 32 characters that had previously been used as the upper bound. I
also made a change so links with a github username that starts or ends
with hypens or contains consecutive hypens are considered invalid. The
aforementioned change was based on the validation message from the
create new GitHub account form.
* Change gist_link to gist_links in spec file for Gist tag
This commit adds timestamps to the comment and post notifications.
Instead of using `strftime` and ordinalizing the date I decided to use the
`time_ago_in_words` methods. I think that this looks better and is more
accurate when it comes to notifications recently received. The final say
is up to the main contributors though, if you would like me to change it
back let me know.
* just opening PR
* add comments-container id to comment-trees
- allows initializeCommentsPage() to attach event listeners to heart reaction buttons
- reactions are created now when clicked
- page still needs to properly render reactions in its "reacted" state and proper reaction count/tally
* reactions, counts, and reacted state are accurate
adds readinglist ids to comment container parent, initializeCommentsPage handles lists of ids now instead of just one id, /reactions?... get request is now synchronous to handle multiple ids
* catch styling for reading list comments
* make xmlhttprequest async
* Specs for FuctionCaller
* Fix accepting nil values from AWS lambda
* Specs for the black_box #2524
* Spec for BlackBox#comment_quality_score
* Remove vcr cassette usage from the CouponGenerator spec
* Removed clear fix div
* Removed floating properties
* Added Flexbox properties to parent container
* Added media queries for screens smaller than 426px and adjusting styles accordingly
* Stretched and centered `upload a video` & `sort` select. Tested on Chrome and Firefox.
* Adjust `sort` select box's font-family according to other elements.
* Initial classified listings work
* More work on tags
* Additional work finalizing stripe and getting the listings page along
* Finalize-ish listings 🤞
* Apply theme color to sidebar widget links
This commit updates the sidebar widget links to apply the appropriate
theme color. This will prevent the links from being hard to read due to
a low contrast in night theme.
* Leave fallback for browsers that dont support css variables
