Kushal Niroula
ae9a10fb4d
Fix post title going out of the box ( #4392 )
2019-10-16 16:35:09 -04:00
Reece Dunham
3bd1b8ac27
Fix some strange wordings on the pro dashboard ( #4461 ) [ci skip]
2019-10-16 16:22:47 -04:00
RakChamp25
00f6f45334
Refactor readingList.jsx ( #4388 ) [ci skip]
2019-10-16 10:40:01 -04:00
Araslanov Evgeny
02a75b6efa
Remove unused methods _without_delay ( #4366 ) [ci skip]
2019-10-16 10:35:49 -04:00
Phong Truong
89af535146
Make follow button vertically-centered ( #4403 ) [ci skip]
2019-10-16 10:33:22 -04:00
Yash Dave
d307ce7469
Fix JavaScript Console errors in /Comments sub-page of any article ( #4446 )
...
* Fix JavaScript Console errors in /Comments sub-page of any article
- Make use of `document.body.contains()` to check if the element is present before trying to Add or Remove Event listeners or assign attribute values to the same.
* Implement recommendations for changes
- Switch String.match() to Regex.test() in order to have consistent Boolean return.
- Switch if(document.body.contains(element)) to if(element) as no need to check if the element is in visible context, only whether present or not.
* Implement recommendations for changes
- Switch String.match() to Regex.test() in order to have consistent Boolean return for isIOSDevice().
- Switch if(document.body.contains(element)) to if(element) as no need to check if the element is in visible context, only whether present or not.
2019-10-16 09:06:28 -04:00
rhymes
9c76663e1a
Fix broken error interface in Article creation API ( #4458 )
2019-10-16 09:02:26 -04:00
Anna Anks Nowak
ee8ae66e47
Add views count for authenticated users articles [ #4250 ] ( #4393 )
...
* Add views count for authenticated users articles [#4250 ]
* Bump API version to 0.5.6 [#4250 ]
2019-10-15 21:39:17 -04:00
Akshay Arora
9b5f57db0e
Fixed Leave organization not working ( #4387 ) ( #4420 )
...
* Fixed Leave organization not working
* Added named route for users_leave_org
2019-10-15 18:04:16 -04:00
Gabe Dunn
1c1a2e44fb
update muteUnmute to use ternaries instead of if/else to avoid duplicated code ( #4442 )
2019-10-15 17:12:27 -04:00
Bolarinwa Balogun
a6b51888c5
Improve error message in Api::V0:ArticlesController#create ( #4417 )
2019-10-15 16:49:26 -04:00
Karin Hendrikse
0ff237cf20
Add specs for errors, mainimage, and notice ( #4453 ) [ci skip]
2019-10-15 16:46:25 -04:00
Araslanov Evgeny
7de692156c
Add ChatChannels::IndexingJob ( #4317 ) [ci skip]
2019-10-15 16:13:10 -04:00
Emilia Muresan
daff71321f
Fix lints in app/javascript/src/components/ ( #4261 ) [ci skip]
2019-10-15 16:11:18 -04:00
Jacob Herrington
7152f07867
Remove unused import and unused props ( #4452 )
2019-10-15 14:12:40 -04:00
Dmitrii Pashutskii
ea4d1fee63
remove a space and refactor conditions ( #4437 )
...
* remove a space and refactor conditions
* fix the condition to present check
2019-10-15 11:24:19 -04:00
Karin Hendrikse
0575648407
Fix lints for sidebarwidget and sidebaruser ( #4418 ) [ci skip]
2019-10-14 14:43:26 -04:00
Hoang Vo
293ba5231b
Fix eslint issues in app/javascript/listings ( #4253 )
...
* Fix some eslint and a11y issues
* Add a11y fixed to snapshot
* Fix missing whitespace that cause test fail
* Fix code duplicate
* Config eslint to allows the label as a sibling
* Use 'error' instead of 2 in eslintrc
* Correct propTypes in SingleListing
* Add missing id prop for select
* Add space between two functions
* onKeyPress only register Enter
* Allow space key also to activate action
* Use a common function for three event handlers
2019-10-14 14:23:20 -04:00
Dmitrii Pashutskii
ab17afc247
Fix display style and extra spaces in internal's articles ( #4364 ) [ci skip]
...
Change display to flex and adjust code to remove the extra characters
2019-10-14 13:55:32 -04:00
José Chaves Neto
3161ab3214
Fix 'use strict' lints ( #4414 ) [ci skip]
2019-10-14 13:46:15 -04:00
Ben Halpern
9299f9500d
Update feed to have popular post stick around less ( #4413 )
2019-10-14 12:34:11 -04:00
Jacob Herrington
742d50f524
Remove unused onboarding files ( #4254 )
...
* Remove commented code
* Format onboarding SCSS
* Remove old onboarding files
* Remove tests for deleted React components
* Remove outdated onboarding stories
2019-10-14 09:35:37 -04:00
aRtoo
296ebeba6b
- created a shared partial logo_design file ( #4347 )
...
- moved text, bg and logo from profile.html.erb to logo_design.html.erb
- used logo_design to org_admin
2019-10-14 09:17:02 -04:00
Josh Bran
5e32dcd9db
Update constants.rb ( #4394 )
2019-10-14 09:15:09 -04:00
Karin Hendrikse
7ab10e709a
Test: add test for ItemListItem and ItemListItemArchiveButton ( #4391 )
2019-10-14 08:54:07 -04:00
Luke Inglis
cb87cfd36e
Resolve linting issue in app/assets/javascript/sendFetch.js ( #4363 )
2019-10-14 08:46:27 -04:00
RakChamp25
e690348824
Refactor: moreConfig.jsx ( #4352 )
...
* Refactor: moreConfig.jsx
* Revamp Changes
* Revamp TextField Proptypes
* Fix Text Field and revamp changes
* Removed trailing spaces
2019-10-14 08:44:45 -04:00
Andrew Bone
b0bf4aecb9
Centre with flex rather than padding ( #4368 )
...
Rather than centring the preview with padding (which may not always be correct) move to flex to calculate for you.
2019-10-14 08:44:15 -04:00
Jack Harner
7eb57dac89
Add Z-Index to Editor Image Upload Container ( #4376 )
...
Reply actions container has a z-index of 5, and extends over the upload button
and uploaded input.
2019-10-14 08:43:11 -04:00
Alessandro Diogo Brückheimer
c8b6c9c095
Prepend non-url paths with https://dev.to ( #4306 )
2019-10-11 12:34:42 -04:00
Jess Lee
8433f4ea03
Add todayilearned as a flare tag ( #4370 ) [ci skip]
2019-10-11 10:18:45 -04:00
Jeremy Schuurmans
ddabcb9d38
remove unused variable and querySelector method ( #4359 )
2019-10-11 09:28:57 -04:00
Luke Jones
dfed6de2da
Add post as an alias to the link liquid tag ( #4353 )
...
* link_tag alias + test added
* fixed the failing test and added change to editor guide
2019-10-11 08:46:02 -04:00
samuel-glitch
ea64c42d3a
Remove unused import ( #4362 )
2019-10-11 08:43:50 -04:00
Ben Halpern
0a60faec8c
Add tag rules to article v2 editor ( #4339 )
...
* Add tag rules to article v2 editor
* Add bottom phrase to tag dropdown
* Remove console logs
* Remove empty space in css
* Remove commented code and clean up css
* Add type='button' for a11y
2019-10-10 20:19:12 -04:00
rhymes
e461f0d799
Routine rubocop fixes after gem update ( #4309 )
...
* Regenerate rubocop todo
* Fix outstanding problems
* Fix Style/FormatStringToken
* Final update to rubocop todo file
* Set RSpec/ExampleLength to max 10 and regenerate todo file
2019-10-10 17:27:01 -04:00
Nick Taylor
78ccefdc84
Fix image upload button in comment form ( #3086 ) [ci skip]
2019-10-10 17:08:06 -04:00
Huynh Tan
63dbfe79fe
Add a proper error message for Link Liquid Tag ( #4341 )
2019-10-10 15:44:20 -04:00
Michael Kohl
fddb06f053
Refactor classified_listings.rb ( #4351 ) [ci skip]
2019-10-10 14:03:11 -04:00
RakChamp25
e00e7c3412
Refactor : BodyPreview.JSX ( #4348 )
2019-10-10 13:21:53 -04:00
Jeremy Schuurmans
96eb1a070a
Fix ESLint errors in initializeBodyData.js ( #4267 )
...
* fix use global form of use strict error
* fix errors involving functions being used before being defined
* fix undefined function and == errors
* fix redeclared variable name error
* use arrow functions to fix unnamed function warnings
* specify global function at top of file instead of disabling line in eslint, change meta variable name
2019-10-10 13:17:16 -04:00
Juliette de Rancourt
d8e04a0a09
Remove duplication in users_controller.rb ( #4337 )
...
* Remove duplication
* Naming
2019-10-10 10:48:23 -04:00
negue
043b7da8de
Remove white background in chat ( #4182 ) [ci skip]
2019-10-09 16:53:20 -04:00
Leonid Trofymchuk
5e347a6f94
Simplify key codes expression in Tags component ( #4248 )
...
* Simplifying this key codes expression in Tags component
* Refactor KeyboardEvent keyCode to key
* Simplify cyrillic letter regexp
* Wrap condition in 2 lines
2019-10-09 16:50:48 -04:00
Yash Dave
e7c4310211
Fix eslint issues in initializeSettings.js ( #4329 )
...
- eslint configuration moved comments to a seperate line
in pre commit hook allowing the eslint-disable-line to
not work correctly.
- switched to eslint-disable-next-line to fix the same
2019-10-09 16:05:07 -04:00
Yash Dave
d125d94cbb
Fix lint in initializeCommentPreview.js ( #4320 ) [ci skip]
2019-10-09 14:35:37 -04:00
Yash Dave
350e43e62b
Fix lint in initializeCommentDate.js ( #4319 ) [ci skip]
2019-10-09 14:33:52 -04:00
Michel
7d530cf002
Fix invalid anchored links due to "//" prefix. ( #4340 )
2019-10-09 13:57:58 -04:00
rhymes
e579b03af1
Add an alt text and some type="button" attributes ( #4331 )
...
* Add alt text to rainbow dev logo
* Add type=button to buttons
2019-10-09 13:16:02 -04:00
Sagar Choudhary
1aa0d95de3
Refactor: initializeDashboardSort.js ( #4313 )
...
* Refactor: initializeDashboardSort.js
* change: onchange method to native js eventListener
2019-10-09 10:32:27 -04:00