docbrown/app
Yash Dave d307ce7469 Fix JavaScript Console errors in /Comments sub-page of any article (#4446)
* Fix JavaScript Console errors in /Comments sub-page of any article

- Make use of `document.body.contains()` to check if the element is present before trying to Add or Remove Event listeners or assign attribute values to the same.

* Implement recommendations for changes

- Switch String.match() to Regex.test() in order to have consistent Boolean return.
- Switch if(document.body.contains(element)) to if(element) as no need to check if the element is in visible context, only whether present or not.

* Implement recommendations for changes

- Switch String.match() to Regex.test() in order to have consistent Boolean return for isIOSDevice().
- Switch if(document.body.contains(element)) to if(element) as no need to check if the element is in visible context, only whether present or not.
2019-10-16 09:06:28 -04:00
..
assets Fix JavaScript Console errors in /Comments sub-page of any article (#4446) 2019-10-16 09:06:28 -04:00
black_box Update feed to have popular post stick around less (#4413) 2019-10-14 12:34:11 -04:00
controllers Fix broken error interface in Article creation API (#4458) 2019-10-16 09:02:26 -04:00
dashboards Pro: memberships (#3461) 2019-09-24 10:38:54 -07:00
decorators Feat: #3498 Display episode's published_at (#4272) 2019-10-08 17:06:46 -04:00
errors Pro: memberships (#3461) 2019-09-24 10:38:54 -07:00
fields Enables Rails cops (#2186) 2019-03-25 09:25:55 -04:00
helpers Comment Social Preview (#4260) 2019-10-07 10:03:03 -04:00
javascript Add specs for errors, mainimage, and notice (#4453) [ci skip] 2019-10-15 16:46:25 -04:00
jobs Add ChatChannels::IndexingJob (#4317) [ci skip] 2019-10-15 16:13:10 -04:00
labor Add todayilearned as a flare tag (#4370) [ci skip] 2019-10-11 10:18:45 -04:00
lib Update constants.rb (#4394) 2019-10-14 09:15:09 -04:00
liquid_tags Add post as an alias to the link liquid tag (#4353) 2019-10-11 08:46:02 -04:00
mailers Pro: memberships (#3461) 2019-09-24 10:38:54 -07:00
models Add ChatChannels::IndexingJob (#4317) [ci skip] 2019-10-15 16:13:10 -04:00
observers Add comment markdown to warned_user_ping (#3750) 2019-08-22 22:04:45 -04:00
policies Add mod_roundrobin_notifications to user_policy.rb (#4226) [ci skip] 2019-10-08 13:52:20 -04:00
sanitizers Add support for mark element in markdown (#2089) 2019-03-18 17:10:58 -04:00
serializers/webhook Use a sortable unique ID for the event_id (#3972) 2019-09-09 10:15:12 -04:00
services Fix invalid body_markdown in article with video (#4258) [ci skip] 2019-10-08 15:41:44 -04:00
uploaders Set max file size limit for profile images (#3313) 2019-06-28 12:06:25 -04:00
view_objects Dispatch events to the webhook endpoints #3715 (#3872) 2019-09-07 13:17:45 -04:00
views Add views count for authenticated users articles [#4250] (#4393) 2019-10-15 21:39:17 -04:00