Commit graph

867 commits

Author SHA1 Message Date
rhymes
ae8a58fec2
[deploy] Decouple GitHub authentication from fetching GitHub issues (#7660)
* Improve error handling

* Add tests for Github::Client

* Add GithubIssue validation

* Refactor GithubIssue and fix bug with pull requests

* Improve tests

* Fix PR API URL generation

* Improve logic and get rid of the issue fragment

* Fix disappeared avatar

* Improve rendering

* Activate client side caching using Redis

* Remove unnecessary file

* Add RemoveGithubIssues data update script

* Fix comma

* Forgot to disable the approvals verify text

* Apply PR feedback
2020-05-04 16:17:16 -04:00
ludwiczakpawel
2ad5403045
Boxes coloring fix (#7656)
* boxes fix

* fix
2020-05-04 08:42:11 -04:00
Fernando Valverde
8f567524f7
Adds an extra check for Android Native app for playing podcasts (#7651) 2020-05-01 15:04:26 -04:00
Fernando Valverde
96c27ecdc6
[deploy] Android native audio feature support (#7554)
* First commit Android Bridge for Podcasts

* Working Android Bridge controls

* Adds Android metadata message & cleans up a couple longs functions

* Brings back use strict

* Cleans up a bit the conditional for either ios/android native players
2020-05-01 13:09:05 -04:00
ludwiczakpawel
7e88ad1a7d
Selects & Ghost Fields (#7607)
* ghost forms

* syntax error

* typo
2020-05-01 14:14:14 +02:00
Ben Halpern
0e1e4f89e4
[deploy] Fix jumping content in obboarding (#7601) 2020-04-30 11:57:00 -04:00
Mac Siri
e77f7854d5
[deploy] Improve style for tab navigation in FollowUsers (#7598) 2020-04-29 16:53:24 -04:00
Karthikeyan Dhanapal
57a4495420
Difference in code highlight depending on url #5041 (#7103)
* Adding background color for code preview in the comment and resolving the rubocop errors

* addiing background color for code within pre tag

* Removing extra space around code tag

* Removing % from the padding-top

* Removing mistakenly added datetime field to schema

* changing schema to match with master branch
2020-04-29 21:15:04 +02:00
Andy Zhao
dae409f1a9
Remove stats from /mod (#7581) 2020-04-28 18:03:08 -04:00
Mac Siri
1ea34b59ec
[deploy] Fix 'Suggested people' small viewport issue (#7575) 2020-04-28 15:34:20 -04:00
Ben Halpern
8f2c32249c
[deploy] Fix podcast pagination client/API mismatch (#7375)
* Fix podcast pagination API

* Adjust css for podcast header

* Adjust test

* Adjust test
2020-04-28 10:07:36 -04:00
rhymes
178a049262
Add SVG optimizer (#7542) 2020-04-28 08:28:25 -04:00
Rafi
28ec80c847
[deploy] Fixing youtube icon (#7559) 2020-04-28 11:28:18 +02:00
Julianna Tetreault
94a24f2c75
Remove cover image background styling from article-show.css (#7448)
* Removes dead code for background and background-size
* Crosses fingers that nothing breaks after style removal
2020-04-27 14:49:48 -06:00
Mac Siri
f4000a1809
[deploy] Render onboarding on small screens correctly (#7548) 2020-04-27 16:16:33 -04:00
Vaidehi Joshi
54519dbf4e
Minor tweaks to onboarding UI (#7546) [deploy]
* Use accent-color in onboarding progress stepper

This looks much prettier with the default DEV theme when viewing onboarding.
Closes https://github.com/thepracticaldev/dev.to/issues/7545.

* Align onboarding checkboxes in their parent element

Use `display: flex`.
Closes https://github.com/thepracticaldev/dev.to/issues/7544.
2020-04-27 12:38:48 -07:00
Rafi
bdcfba7d70
[deploy] Saving youtube url (#7516)
* Saving youtube url

* Fixing description in the spec

* Optimizing youtube logo svg

* Fixing indentation of form
2020-04-27 14:14:07 -04:00
Andy Zhao
fded16b8dc
[deploy] Add a more helpful msg for response templates (#7543) 2020-04-27 13:28:28 -04:00
Lisa Sy
9de59c4107
Update sidebar filter menu on Notifications (#7394) 2020-04-27 12:17:20 -04:00
rhymes
2d26318cf9
[deploy] Replace (black|white)list with more inclusive language (#7459)
* Replace isBlacklisted

* Update fastly.rake task

* More renames

* Rename Faslty config file

* More changes

* Replace isForbiddenFromPreloading with isNotPreloadable

* Skip problematic test

* Re-enable
2020-04-27 18:00:12 +02:00
rhymes
1c3b619583
[deploy] Fix settings billing section and other profile improvements (#7525)
* Truncate displayed username length to max length

* Better error notice

* Fix broken billing Stripe functionality

* Display server side credits purchasing errors

* Be explicit in the name of the partial

* Full name
2020-04-27 16:59:03 +02:00
rhymes
d87c3dbb18
[deploy] Improve comment posting error handling (#7519)
* Improve comment posting error handling

* Incorporate PR suggestions
2020-04-27 16:54:59 +02:00
Ben Halpern
9070174138
[deploy] Fix chatchannel pagination in connect (#7520) 2020-04-26 19:45:36 -04:00
Ben Halpern
7a6e7301a1
[deploy] Small update to /connect design (#7510)
* Initial work

* Full screen mode adjustments

* Update snapshots
2020-04-26 13:26:49 -04:00
Molly Struve
4ab202ab0a
[deploy] Execute Reading List searches in Elasticsearch (#7440)
* Execute Reading List searches in Elasticsearch

* add additional readinglist front tests
2020-04-24 10:30:17 -04:00
Mac Siri
57ae315c31
[deploy] Generalize Onboarding's task-card image (#7452)
* Generalize Onboarding's task-card image

* Rename SiteConfig's onboarding_taskcard_sticker

* Add & reorganize #config_params

* Update Internal::Config's view

* Add spec
2020-04-24 10:24:50 -04:00
Vaidehi Joshi
e19eb60d1f
Add skip/continue functionality to onboarding navigation (#7488) [deploy]
* Dynamically render forward text in Navigation component

* Render either "Skip for now" or "Continue" on the FollowTags, ProfileForm, and FollowUsers components.
* Refactor the ProfileForm component to dynamically change the button text based on the form's state.

* Render specific button text for last onboarding slide

* Fix back arrow styles for accessibility

Also set an explicit width on the containing button around the svg.

* Use min-width to specify back-button size
2020-04-23 16:30:48 -07:00
Vaidehi Joshi
046ec2eaee
Use back button svg icon in onboarding slides (#7455) [deploy] 2020-04-22 16:54:46 -07:00
Vaidehi Joshi
5f67f7b2e3
Add a progress stepper to onboarding flow (#7450) [deploy] 2020-04-22 13:59:43 -07:00
Mac Siri
a181a3af3a
[deploy] Remove Onboarding's ClosingSlide (#7443) 2020-04-22 14:08:10 -04:00
ludwiczakpawel
16560d9ef1
Settings style updates: Crayons! (#7393)
* .

* .

* .

* snapshot

* whoops

* halifax

* tests

* little fixes

* little fixes

* test? i guess..

* .

* minor fixes

* Update schema.rb

* Use shared logo_design in new org partial

* little fix

* Fix org spec

* decrayonsifying rich-selector

* if statement

Co-authored-by: rhymes <rhymesete@gmail.com>
2020-04-22 19:18:19 +02:00
Maja Komel
4499e5eb6e
[deploy] Add Wikipedia liquid tag (#7193) 2020-04-22 17:54:56 +02:00
Mac Siri
4edf1c5ada
[deploy] Create onboarding task card (#7369) 2020-04-22 11:46:49 -04:00
Sujith
b37bb942ec
[deploy] Chat search icon color fix (#7430)
Added svg color fill property for search icon
2020-04-22 12:06:24 +02:00
ludwiczakpawel
b9149ad779
Snackbars Improvements (#7412)
* fix stascking

* updated buttons

* adjustments
2020-04-21 18:31:12 -04:00
Fernando Valverde
5dc0ebbb04
Copy to clipboard fixes including support for Android Native Bridge (#7382)
* Adds Clipboard Async API & makes use of Android Native Bridge interface for write post image copy to clipboard

* Checks for clipboard api support before trying to use it

* Adds support for comment dropdown copy link

* Adds AndroidBridge to globals definition
2020-04-21 10:36:49 -04:00
Ridhwana
a2f1a0049f
Removal of morrrre hardcoded dev.to links (#7390)
* feat: remove 90% of hardcoded dev.to links now

* chore: update tests

* chore: implement suggested changes

* chore: update url

* chore: update to use URL helper
2020-04-21 11:50:18 +02:00
Julianna Tetreault
21cd5a3f72
[deploy] Replace Cover Image <div> Tags With <img> Tags (#7396)
* Replace cover image div tag with img tag in articles/show
  * Make cover images more semantic with img tag and src
  * Keep img styling for now

* Replace divs with inline img in _main_stories_feed.html.erb
  * Remove div in favor img tag to make more semantic
  * Add extra line at file end in _main_stories_feed.html.erb
  * Reword img alt text in articles/show.html.erb

* Remove unnecessary styling for cover images from stylesheets
  * Remove background image styling for main feed article
  * Remove background image styling for article show page
  * Adjust padding for main feed article
  * Adjust padding for article show page
  * Add 100% width to main feed article

* Adjust styling for article show pages
  * Add height to article show CSS
  * Adjust article show padding to be 0
  * Revert div to img change in _main_stories_feed.html.erb
  * Revert styling changes for articles.scss

* Add original styling back to article-show.scss
  * Add original styling for article show pages back
  * Hopefully avoid conflicts due to caching by keeping code

* Adjust team delightful TODO to be more explicit and readily accessible

* Update app/assets/stylesheets/article-show.scss

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-04-20 18:01:08 -04:00
Andy Zhao
f5c94391b7
[deploy] Revert "[deploy] Revert "[deploy] Buttons (#7361)" (#7399)" (#7400)
This reverts commit 028121b39d.
2020-04-20 16:40:50 -04:00
Molly Struve
028121b39d
[deploy] Revert "[deploy] Buttons (#7361)" (#7399)
This reverts commit a20e76995c.
2020-04-20 15:57:38 -04:00
ludwiczakpawel
a20e76995c
[deploy] Buttons (#7361)
* cleanup

* more cleanups

* copy fix + groups

* more buttons

* we are good.

* little shadow update

* .

* doc update

* themes

* stories

* button with icon

* html stories

* button groups

* comment subscription component

* Update small-bell.svg

* tests

* Fix polish locale in snapshots

Co-authored-by: rhymes <rhymesete@gmail.com>
2020-04-20 14:35:49 -04:00
ludwiczakpawel
d585c981db
[deploy] fixing svg (#7380) 2020-04-19 15:42:30 +02:00
Ben Halpern
2171fe3255
[deploy] Add missing parentheses to video html (#7379) 2020-04-18 16:34:48 -04:00
Ben Halpern
3d4944ebae
[deploy] Add video duration to search results (#7377) 2020-04-18 15:16:38 -04:00
Ridhwana
6dbc838bae
[deploy] Update our mailers to be generalized (#7359)
* feat: make the from in the email to be dynamic

* feat: hardcoded mailer dev.to

* feat: oops hardcoded email addresses in the terms

* chore: remove some whitespace

* update editor guide

* feat: new reply email

* feat: new message mailer

* feat: new follower email

* feat: capitalize the button

* feat: rename the link

* feat: capitalize the button

* feat: generalize the urls

* feat: generalise the url

* feat: dynamic DEV

* feat: update the specs

* feat: DEV digest generalisation part 1

* fix: the method is accessed by tag_url and so the default parameter needs to be set at this level and not at self.tag

* fix: use the tag model instance instead of passing through just the tag name (so that we can use tag_url)

* chore: make code climate happy

* chore: more robocop

* feat: add a default url back for self.tag

* test: fix the feedback helper spec

* fix: spec to be general

* fix: oops :(

* refactor: user_settings_path

* chore: use code_of_conduct_path

* chore: robocop

* chore: use connect path

* chore; use the notifications symbol

* chore: misc path

* feat: simplify url

* feat/fix: change the order of the helpers and use user_url

* chore: user_url

* capitalise

* chore: update article path
2020-04-17 15:35:35 -04:00
Fernando Valverde
f2ee0378f9
[deploy] Decorator podcast episode metadata (#7303)
* Moves podcast episode metadata to decorator

* Updates the podcast episode metadata to use image_url

* Syntax tweaks, initializeMedia() fix for initialized audio & brought back use strict
2020-04-17 12:52:11 -06:00
Molly Struve
8340051649
[deploy] properly parse params for feed content searching (#7367) 2020-04-17 12:23:24 -05:00
Molly Struve
2c99424205
[deploy] Execute Feed Searches through Elasticsearch (Round 2) (#7231) 2020-04-17 08:38:07 -05:00
Ben Halpern
2d978696c4
[deploy] Small connect js fixes (#7350) 2020-04-16 20:06:32 -04:00
Andy Zhao
f5ec83653c
[deploy] Finalize and add response templates feature (#7068) 2020-04-16 15:53:29 -04:00