Commit graph

6236 commits

Author SHA1 Message Date
Ben Halpern
aab0685b93
Add sign in options button to modal (#9506) 2020-07-27 09:28:41 -04:00
Ben Halpern
cbcd59edb3
Add more sign in options button to home sidebar (#9496) 2020-07-27 15:14:44 +02:00
dependabot-preview[bot]
3e6e7a4d1e
Bump strong_migrations from 0.6.8 to 0.7.0 (#9525)
* Bump strong_migrations from 0.6.8 to 0.7.0

Bumps [strong_migrations](https://github.com/ankane/strong_migrations) from 0.6.8 to 0.7.0.
- [Release notes](https://github.com/ankane/strong_migrations/releases)
- [Changelog](https://github.com/ankane/strong_migrations/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ankane/strong_migrations/compare/v0.6.8...v0.7.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump strong_migrations from 0.6.8 to 0.7.0 (Update vendor/cache)

* Enable safety check on rollbacks as well

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: rhymes <rhymes@hey.com>
2020-07-27 11:10:18 +02:00
dependabot-preview[bot]
f6d091213e
Bump rubocop-performance from 1.7.0 to 1.7.1 (#9380)
* Bump rubocop-performance from 1.7.0 to 1.7.1

Bumps [rubocop-performance](https://github.com/rubocop-hq/rubocop-performance) from 1.7.0 to 1.7.1.
- [Release notes](https://github.com/rubocop-hq/rubocop-performance/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-performance/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-performance/compare/v1.7.0...v1.7.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump rubocop-performance from 1.7.0 to 1.7.1 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-27 10:03:11 +02:00
Michael Kohl
a80d3f9082
[deploy] Move from OpenStruct to Struct (#9429) 2020-07-27 14:31:48 +07:00
Christina
c493ad1d2a
Change link in Contributing Docs (#9530)
Replacing https://docs.dev.to/contributing/forem/ new forem docs link per issue #9505.
2020-07-27 10:06:59 +07:00
Christina
112d7bb48f
Update README.md (#9531)
Replacing links to https://docs.dev.to in the Getting Started section with links to the newer https://docs.forem.com/ instead
2020-07-27 09:59:54 +07:00
dependabot-preview[bot]
160035fa2d
[deploy] Bump rubocop-rails from 2.6.0 to 2.7.1 (#9526)
* Bump rubocop-rails from 2.6.0 to 2.7.1

Bumps [rubocop-rails](https://github.com/rubocop-hq/rubocop-rails) from 2.6.0 to 2.7.1.
- [Release notes](https://github.com/rubocop-hq/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-rails/compare/v2.6.0...v2.7.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump rubocop-rails from 2.6.0 to 2.7.1 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-26 17:54:04 -05:00
dependabot-preview[bot]
4102a09777
Bump oj from 3.10.7 to 3.10.8 (#9523)
* Bump oj from 3.10.7 to 3.10.8

Bumps [oj](https://github.com/ohler55/oj) from 3.10.7 to 3.10.8.
- [Release notes](https://github.com/ohler55/oj/releases)
- [Changelog](https://github.com/ohler55/oj/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ohler55/oj/compare/v3.10.7...v3.10.8)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump oj from 3.10.7 to 3.10.8 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-26 17:53:10 -05:00
Molly Struve
f84f88f9bf
Flaky Spec Fix:Remove let_it_be usage from Comment Model Spec (#9529) 2020-07-26 17:22:51 -05:00
Molly Struve
4f20555221
[deploy] Optimization:Change Multiple Small Table Column IDs to Bigints (#9513) 2020-07-26 16:16:13 -05:00
dependabot-preview[bot]
9f48982f6e
Bump bootsnap from 1.4.6 to 1.4.7 (#9520)
* Bump bootsnap from 1.4.6 to 1.4.7

Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.4.6 to 1.4.7.
- [Release notes](https://github.com/Shopify/bootsnap/releases)
- [Changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Shopify/bootsnap/compare/v1.4.6...v1.4.7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump bootsnap from 1.4.6 to 1.4.7 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-26 21:51:12 +02:00
dependabot-preview[bot]
4b4749c29a
Bump ddtrace from 0.37.0 to 0.38.0 (#9521)
* Bump ddtrace from 0.37.0 to 0.38.0

Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb) from 0.37.0 to 0.38.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases)
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md)
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v0.37.0...v0.38.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump ddtrace from 0.37.0 to 0.38.0 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-26 21:50:59 +02:00
dependabot-preview[bot]
d54ca3f7ee
Bump twilio-ruby from 5.39.1 to 5.39.2 (#9516)
* Bump twilio-ruby from 5.39.1 to 5.39.2

Bumps [twilio-ruby](https://github.com/twilio/twilio-ruby) from 5.39.1 to 5.39.2.
- [Release notes](https://github.com/twilio/twilio-ruby/releases)
- [Changelog](https://github.com/twilio/twilio-ruby/blob/master/CHANGES.md)
- [Commits](https://github.com/twilio/twilio-ruby/compare/5.39.1...5.39.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump twilio-ruby from 5.39.1 to 5.39.2 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-26 21:50:37 +02:00
dependabot-preview[bot]
f29f4b7840
[deploy] Bump mini_racer from 0.2.15 to 0.3.1 (#9518)
* Bump mini_racer from 0.2.15 to 0.3.1

Bumps [mini_racer](https://github.com/discourse/mini_racer) from 0.2.15 to 0.3.1.
- [Release notes](https://github.com/discourse/mini_racer/releases)
- [Changelog](https://github.com/rubyjs/mini_racer/blob/master/CHANGELOG)
- [Commits](https://github.com/discourse/mini_racer/compare/v0.2.15...v0.3.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump mini_racer from 0.2.15 to 0.3.1 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-26 12:46:22 -05:00
dependabot-preview[bot]
1b81c94d5c
Bump sidekiq from 6.1.0 to 6.1.1 (#9527)
* Bump sidekiq from 6.1.0 to 6.1.1

Bumps [sidekiq](https://github.com/mperham/sidekiq) from 6.1.0 to 6.1.1.
- [Release notes](https://github.com/mperham/sidekiq/releases)
- [Changelog](https://github.com/mperham/sidekiq/blob/master/Changes.md)
- [Commits](https://github.com/mperham/sidekiq/compare/v6.1.0...v6.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump sidekiq from 6.1.0 to 6.1.1 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-26 12:43:00 -05:00
dependabot-preview[bot]
fd3413baac
Bump blazer from 2.2.5 to 2.2.6 (#9517)
* Bump blazer from 2.2.5 to 2.2.6

Bumps [blazer](https://github.com/ankane/blazer) from 2.2.5 to 2.2.6.
- [Release notes](https://github.com/ankane/blazer/releases)
- [Changelog](https://github.com/ankane/blazer/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ankane/blazer/compare/v2.2.5...v2.2.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump blazer from 2.2.5 to 2.2.6 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-26 12:38:57 -05:00
Molly Struve
bc5e114ce9
Flaky Spec Fix:Remove let_it_be To Prevent Bad Database State Failing Specs (#9512) 2020-07-26 12:32:32 -05:00
Molly Struve
7167587de5
[deploy] Feature:Allow Log Level to be Set with ENV Variable (#9456) 2020-07-25 16:46:48 -05:00
Molly Struve
21b1afb076
[deploy] Optimization:Change Mentions, Notes, Podcasts, Roles Related Ids To Bigints (#9477) 2020-07-25 16:11:26 -05:00
Molly Struve
06fb3cff6b
[deploy] Optimization:Recreate Comments Index with Digest Hash (#9474) 2020-07-25 14:32:00 -05:00
rhymes
0b4ad49cf8
Rubocop: Enable and fix Style/OptionHash (#9430)
* Enable and fix Style/OptionHash

* Add 10 seconds default timeout to DB statements
2020-07-25 10:41:21 +02:00
Stu Finn
95be4c6308
Update api_v0.yml (#9495)
Updated description with Forem placeholder text
2020-07-24 16:33:18 -04:00
Jacob Herrington
b26919e79b
[deploy] Fix archived readinglist reactions affecting count (#9044)
* Fix archived readinglist reactions affecting count

The reading list count badge on the home page currently takes all
readinglist reactions into account, but we shouldn't be including those
that are marked "archived."

Secondarily this fixes a bug that affects only admin users: all
reactions created by admins were given the status "confirmed"
instead of the expected "valid" status.
2020-07-24 14:18:35 -05:00
Michael Kohl
96b0d7fa09
Make credit pricing configurable (#9326)
* Add credit prices to SiteConfig

* Add credit prices to /internal/config

* Fix spec and transform values on update
2020-07-24 12:03:13 -04:00
Molly Struve
cd22f395d3
[deploy] Optimization:Create message JSON once when Notifying Users (#9492) 2020-07-24 10:56:05 -05:00
Molly Struve
330009995d
[deploy] Optimization:Index Chat Channel Memberships Async on Message Creation (#9491) 2020-07-24 09:52:42 -05:00
Jacob Herrington
cd11ebefb9
Fix accessibility issues flagged by axe (#9452) 2020-07-24 10:21:28 -04:00
Jacob Herrington
a5b26b3425
Fix formatting (#9450) 2020-07-24 10:20:06 -04:00
Abenet Tamiru
eea93cc1d9
Add gitdocs as devDependency (#9463)
* Add gitdocs add a devDependency

* Update docs to use local gitdocs installation

* Apply suggestion

Co-authored-by: Nick Taylor <nick@iamdeveloper.com>

* Apply suggestion

Co-authored-by: Nick Taylor <nick@iamdeveloper.com>

* Fix other places where gitdocs is mentioned

* Revert to old Makefile

Co-authored-by: Nick Taylor <nick@iamdeveloper.com>
2020-07-24 13:48:36 +02:00
Michael Kohl
8425c847c3
Update CODEOWNERS and team names in TODO comments (#9460)
* Update CODEOWNERS

* Update teams in TODO comments

* Remove mentions of team cool
2020-07-24 12:17:20 +07:00
Michael Kohl
fdedaa83cf
[deploy] Validate password confirmation when updating password (#9458)
* Validate password confirmation when updating password

* Fix Authentication::Authenticator

* Add comment about Devise
2020-07-24 09:08:52 +07:00
Fernando Valverde
a9441add3d
[deploy] Redirect override (#9469) 2020-07-23 10:28:28 -04:00
Andy Zhao
9bdef4d4ae
[deploy] Update /ban for Connect (#9459)
* Rough MVP of /ban v2

* Make snackbar dismissable

* Make unban work

* Clean up response for happy and sad paths

* Fix tests

* Fix policy spec
2020-07-23 09:49:54 -04:00
narender2031
a0592ecfa1
[deploy] Fix bug remove searched membership (#9426)
* Feature 🚀 : Ability to delete messages in chat channels

- Sending message ID to frontend
- Deleting Message
- Use pusher to delete message realtime

* Minor Bug 🐞: Show message action only for current user

- User can delete or edit their own messages

* Test cases added

* Bug 🐞: Update message id for receiver

Message id was not sent to receiver by pusher

* Refactoring🛠: Message controller refactoring

* Test Cases📝 : Specs for Delete message added

* Feature 🚀 : Ability to edit messages

* Test Cases📝 : Specs for Edit message added

* Merge conflict resolved

* fix remove membership when search

Co-authored-by: Sarthak Sharma <7lovesharma7@gmail.com>
2020-07-23 08:09:44 -04:00
Sarthak Sharma
44b8d0894d
[deploy] 🐞Hotfix: Search toggle breaks in some cases (#9454)
* Feature 🚀 : Ability to delete messages in chat channels

- Sending message ID to frontend
- Deleting Message
- Use pusher to delete message realtime

* Minor Bug 🐞: Show message action only for current user

- User can delete or edit their own messages

* Test cases added

* Bug 🐞: Update message id for receiver

Message id was not sent to receiver by pusher

* Refactoring🛠: Message controller refactoring

* Test Cases📝 : Specs for Delete message added

* Feature 🚀 : Ability to edit messages

* Test Cases📝 : Specs for Edit message added

* Merge conflict resolved

* Fixing the serch toggle issue

Co-authored-by: Narender Singh <narender2031@gmail.com>
2020-07-22 16:27:35 -04:00
Sarthak Sharma
4cc89e2100
[deploy] 🐞Bugfix: Sidebar scroll issues when list is long (#9451)
* Feature 🚀 : Ability to delete messages in chat channels

- Sending message ID to frontend
- Deleting Message
- Use pusher to delete message realtime

* Minor Bug 🐞: Show message action only for current user

- User can delete or edit their own messages

* Test cases added

* Bug 🐞: Update message id for receiver

Message id was not sent to receiver by pusher

* Refactoring🛠: Message controller refactoring

* Test Cases📝 : Specs for Delete message added

* Feature 🚀 : Ability to edit messages

* Test Cases📝 : Specs for Edit message added

* Merge conflict resolved

* Fixing the scroll issue in sidebar

* Update schema.rb

Co-authored-by: Narender Singh <narender2031@gmail.com>
2020-07-22 13:10:00 -06:00
Sarthak Sharma
89c15fd9d7
[deploy] 🐞Bugfix: Redundant messages issue in connect (#9432)
* Feature 🚀 : Ability to delete messages in chat channels

- Sending message ID to frontend
- Deleting Message
- Use pusher to delete message realtime

* Minor Bug 🐞: Show message action only for current user

- User can delete or edit their own messages

* Test cases added

* Bug 🐞: Update message id for receiver

Message id was not sent to receiver by pusher

* Refactoring🛠: Message controller refactoring

* Test Cases📝 : Specs for Delete message added

* Feature 🚀 : Ability to edit messages

* Test Cases📝 : Specs for Edit message added

* Merge conflict resolved

* 🐞Bugfix: Redundant messages on connect channel.

* Changes requested

Co-authored-by: Narender Singh <narender2031@gmail.com>
2020-07-22 12:23:18 -04:00
Fernando Valverde
7eb27328bb
[deploy] Changes expiration of invitation links to 80h (#9449) 2020-07-22 12:22:32 -04:00
Emma Goto
f6ee0f20e2
[deploy] Make profile settings save button sticky when modified (#9378)
* Make profile settings save button sticky when modified

* Replace querySelector with class selector, add newlines to end of files

* Make profile settings save button sticky when modified

* Replace querySelector with class selector, add newlines to end of files

* Add rspec test for sticky footer

* Move visit method to before block
2020-07-22 17:45:43 +02:00
Molly Struve
91c6541f57
Bug Fix:Validate User Password Length is Between 8-100 characters (#9447) 2020-07-22 11:40:23 -04:00
Andy Zhao
32c413f182
[deploy] Default to adding users as members to a chat channel and not mods (#9446) 2020-07-22 10:51:44 -04:00
Ben Halpern
01827a7653
[deploy] Fix double render of home feed (#9438) 2020-07-22 10:49:32 -04:00
Takuma
3fd01c326d
Bug Fix: Article Posted Date and Author Card Posted Date do not match (#9272)
* Refactor: move has_long_markdown from view to helper, and change it from variable to method

* Fix: Article Posted Date and Author Card Posted Date do not match #8789

* Add test case for Article Posted Date and Author Card Posted Date do not match #8789

* Use our custom URL helper module instead of manually constructing URL

* Move long_markdown? from ArticlesHelper to ArticleDecorator

* Change method name from has_long_markdown? to long_markdown?

* Add test suites for long_markdown? method to ArticleDecorator spec

* Use << over +=

* Fix typo

* Remove unnecessary cache
2020-07-22 16:34:55 +02:00
rhymes
88f0a0e58a
Rubocop: re-activate Style/RegexpLiteral and fix violations (#9418)
* Rubocop: re-activate Style/RegexpLiteral and fix violations

* Add 10 seconds default timeout to DB statements
2020-07-22 16:28:27 +02:00
Molly Struve
b6cc3ebb9a
[deploy] Optimization:Change Podcast and Episode PKs to Bigints (#9423) 2020-07-22 09:15:10 -05:00
Veggier
126367fa4a
Ability for admins to remove user from internal chat channels (#9235)
* change ui

* admins can remove users from internal chat channels

* rename destroy to remove_user

* change syntax

* add a single user

* remove a single user --debug

* remove a single user --debug

* remove a single user

* remove a single user

* remove a single user

* remove a single user

* add test for remove single user from internal chat_channel

* test

* sytax change

* add delete user for channel test

* add more test case for the remove user from chat channel

* change to single test case
2020-07-22 09:43:38 -04:00
Andy Zhao
046dcb8c9e
[deploy] Update slideshare embed code length limit (#9441)
* Make regex check 12 to 14 chars

* Add additional valid key to test
2020-07-22 09:42:54 -04:00
narender2031
0cfc593150
[deploy] 🚀 Feature: Chat channel request manager (#9305)
* Feature 🚀 : Ability to delete messages in chat channels

- Sending message ID to frontend
- Deleting Message
- Use pusher to delete message realtime

* Minor Bug 🐞: Show message action only for current user

- User can delete or edit their own messages

* Test cases added

* Bug 🐞: Update message id for receiver

Message id was not sent to receiver by pusher

* Refactoring🛠: Message controller refactoring

* Test Cases📝 : Specs for Delete message added

* Feature 🚀 : Ability to edit messages

* Test Cases📝 : Specs for Edit message added

* Merge conflict resolved

* request manager info API

* 👨🏼‍🎨 Design added for requestCenter

* integrate request manager with API

* remove unused argument

* fix request manager card UI

* fix request card UI

* add request manager button

* handle no invitaion UI

* fix badge UI

* add request specs

* add jest specs

* remove the presenter

* fix code climate issues

* fix queries

* fix runbocop issues

* fix PR suggestions

* remove empty lines

Co-authored-by: Sarthak Sharma <7lovesharma7@gmail.com>
2020-07-22 09:12:09 -04:00
Zach Attas
cc0231de77
Unflake system user_settings_response_templates_spec.rb (#8845) 2020-07-22 08:04:28 -05:00