maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
11589 commits 1 branch 0 tags 1.6 GiB
Commit graph

11589 commits

This branch
This branch
All branches
Author SHA1 Message Date
yheuhtozr
aa7e5d45fc
i18n keys update for new profile decorator (#17684) 2022-05-18 10:51:06 -04:00
Ridhwana
8975adf35f
feat: link to the contributing guide on developers.forem.com (#17703) 2022-05-18 16:13:14 +02:00
Takuya N
c3c33aa9cd
Show friendly error message on API fetch failure on stats (#17570) 
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
 2022-05-18 16:12:42 +02:00
Suzanne Aitchison
c37bbd77e5
Member index phase 2 - mock filters modal (#17578) 
* mock filters popover

* fix for safari

* add missing label
 2022-05-17 15:25:21 +01:00
dependabot[bot]
256ba5e8f5
Bump focus-trap from 6.9.1 to 6.9.2 (#17694) 
Bumps [focus-trap](https://github.com/focus-trap/focus-trap) from 6.9.1 to 6.9.2.
- [Release notes](https://github.com/focus-trap/focus-trap/releases)
- [Changelog](https://github.com/focus-trap/focus-trap/blob/master/CHANGELOG.md)
- [Commits](https://github.com/focus-trap/focus-trap/compare/v6.9.1...v6.9.2)

---
updated-dependencies:
- dependency-name: focus-trap
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-05-17 09:50:17 -04:00
dependabot[bot]
67973a4912
Bump @testing-library/user-event from 14.1.1 to 14.2.0 (#17693) 
Bumps [@testing-library/user-event](https://github.com/testing-library/user-event) from 14.1.1 to 14.2.0.
- [Release notes](https://github.com/testing-library/user-event/releases)
- [Changelog](https://github.com/testing-library/user-event/blob/main/CHANGELOG.md)
- [Commits](https://github.com/testing-library/user-event/compare/v14.1.1...v14.2)

---
updated-dependencies:
- dependency-name: "@testing-library/user-event"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-05-17 07:53:33 -04:00
dependabot[bot]
96fd8a6dd7
Bump core-js from 3.22.4 to 3.22.5 (#17692) 
Bumps [core-js](https://github.com/zloirock/core-js) from 3.22.4 to 3.22.5.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/compare/v3.22.4...v3.22.5)

---
updated-dependencies:
- dependency-name: core-js
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-05-17 07:53:13 -04:00
dependabot[bot]
dba5c2a6c2
Bump faker from 2.20.0 to 2.21.0 (#17695) 
Bumps [faker](https://github.com/faker-ruby/faker) from 2.20.0 to 2.21.0.
- [Release notes](https://github.com/faker-ruby/faker/releases)
- [Changelog](https://github.com/faker-ruby/faker/blob/master/CHANGELOG.md)
- [Commits](https://github.com/faker-ruby/faker/compare/v2.20.0...v2.21.0)

---
updated-dependencies:
- dependency-name: faker
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-05-17 07:50:27 -04:00
Jeremy Friesen
0c6b6b9e62
Ensuring that embed fallback renders URL (#17680) 
Prior to this commit, our fallback HREF was using only the URL's
domain (e.g. `guides.rubyonrails.org/routing.html`) instead of the
provided URL (e.g. `https://guides.rubyonrails.org/routing.html`).  This
resulted in the link resolving to
`<url-of-article>/guides.rubyonrails.org/routing.html`)

With this commit, we're using the given URL for the HREF.

An interesting side note, the Ruby on Rails guides includes an
`og:title` but not an `og:url` so we hit the fallback condition.  Could
we use the given URL if `og:url` does not exist?

Fixes forem/forem#17679
 2022-05-17 07:43:17 -04:00
Jeremy Friesen
127e3ac248
Adding page view goal for experiments (#17696) 
With comments, publishing articles, and reactions we had symmetry on two
goals:

- Create a _subject_ (e.g. Comment, Published Article, Reaction)
- Create four _subjects_ within a week.

For page views we only had "Create four _subjects_ within a week."  This
PR addes the "Create a _subject_".

To do this required adjusting some tests as they were too specific in
nature (looking at an expected count).

In addition, in consultation with Jennie, I've updated the experiment
order to better reflect some hierarchical importance.

**Rollback considerations:**

This also includes a feature flag that we can explicitly disable if we
overload the application with workers handling reaction goals.  Using
`FeatureFlag.accessible?(:field_test_event_single_create_pageview)`
returns `true` unless we explicitly disable this flag.

Related to forem/forem#17673
Related to forem/forem#17669
Closes forem/forem#17691
 2022-05-16 15:07:42 -04:00
dependabot[bot]
ad7ad333bf
Bump validate_url from 1.0.13 to 1.0.15 (#17674) 
Bumps [validate_url](https://github.com/perfectline/validates_url) from 1.0.13 to 1.0.15.
- [Release notes](https://github.com/perfectline/validates_url/releases)
- [Changelog](https://github.com/perfectline/validates_url/blob/master/CHANGELOG.md)
- [Commits](https://github.com/perfectline/validates_url/commits)

---
updated-dependencies:
- dependency-name: validate_url
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-05-16 15:00:43 -04:00
Fernando Valverde
8759439cd9
Fix spec calc that checks date filter expectation (#17690) 
* Fix spec calc that checks date filter expectation

* Long line reformat
 2022-05-16 12:43:18 -06:00
Jeremy Friesen
8a4e1ebeba
Adding more goals to feed experiments (#17673) 
This commit adds three new feed experiment goals:

* user publishes four posts within a week
* user reacts with a "heart", "unicorn", or "reading list" to an article
* user reacts with a "heart", "unicorn", or "reading list" to an article
  four times in a week

In addition it adds it to the existing experiment.  Adding it to the
existing experiment is acceptable because:

1. We can ignore the results
2. The experiments are structured such that these new goals could be met
   with prior data.
3. Both variants are playing by the same rules, so the results relative
   to each other are valid.

**There is a nuanced assumption in how we handle reactions:**

This implementation does not count by unique article reactions. However,
most folks will ❤️ , 🦄 , and 🔖 in one swoop; thus
those 3 reactions are all grouped into happening on one day.

Further, it's a reflection of the person taking an action after reading
a post, not how much action on that particular post.

**Rollback considerations:**

This also includes a feature flag that we can explicitly disable if we
overload the application with workers handling reaction goals.  Using
`FeatureFlag.accessible?(:field_test_event_for_reactions)` returns
`true` unless we explicitly disable this flag.

Closes forem/forem#17669
 2022-05-13 13:22:06 -04:00
dependabot[bot]
ba3e619c55
Bump vault from 0.16.0 to 0.17.0 (#17664) 
Bumps [vault](https://github.com/hashicorp/vault-ruby) from 0.16.0 to 0.17.0.
- [Release notes](https://github.com/hashicorp/vault-ruby/releases)
- [Changelog](https://github.com/hashicorp/vault-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/hashicorp/vault-ruby/compare/v0.16.0...v0.17.0)

---
updated-dependencies:
- dependency-name: vault
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-05-13 11:22:33 -04:00
dependabot[bot]
1f0f13d411
Bump blazer from 2.6.2 to 2.6.3 (#17663) 
Bumps [blazer](https://github.com/ankane/blazer) from 2.6.2 to 2.6.3.
- [Release notes](https://github.com/ankane/blazer/releases)
- [Changelog](https://github.com/ankane/blazer/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ankane/blazer/compare/v2.6.2...v2.6.3)

---
updated-dependencies:
- dependency-name: blazer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-05-12 21:48:42 -04:00
dependabot[bot]
ea6f6b365c
Bump rubocop from 1.29.0 to 1.29.1 (#17661) 
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.29.0 to 1.29.1.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop/compare/v1.29.0...v1.29.1)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-05-12 21:48:26 -04:00
Mac Siri
215bf4abe6
Update datadog.rb to include env scope (#17667) 2022-05-12 18:13:20 -04:00
Mac Siri
fc188a0759
Simplify ddtrace configuration (#17665) 2022-05-12 15:19:47 -04:00
Arit Amana
e2c06429fd
complete implementation; specs pending (#17630) 2022-05-12 13:52:48 -04:00
Mac Siri
8d39d22d9e
Revert "Bump ddtrace from 0.54.2 to 1.0.0 (#17560)" (#17643) 
This reverts commit eeed96cf9c.
 2022-05-12 09:28:50 -04:00
Arit Amana
a75ef4e1b2
Fix styling on Follow Button in User Info Panel (post view) (#17642) 
* fix

* nudge Travis
 2022-05-12 08:03:41 -04:00
Jeremy Friesen
ca7228084a
Ensuring we don't render call to action when unauthorized (#17640) 
Prior to this commit, if the Forem limitted article creation only to
admins, when a new user would sign-up their call to action was to
"Create a Post".  If that new user clicked on the button, they would get
an action unauthorized error.

With this commit, the call to action for Creating a Post is hidden to
that user.

The `users/onboardings/_task_card.html.erb` is rendered as part of the
home page.  The home page, due to our [EdgeCacheSafetyCheck][1], does not
allow us to access attributes of the current user (e.g. are they an
admin); which means we can't add a `if policy(Article).create` to the
HTML erb.  We must instead use the [`application_policy_content_tag`][2]
as well as the [AsyncInfo][3] to help inform the
[applyApplicationPolicyToggles.js pack][4] of the conditional rendering.

Closes forem/forem#17638
Related to forem/forem-internal-eng#347

[1]:8160089f3d/app/controllers/concerns/edge_cache_safety_check.rb
[2]:8160089f3d/app/helpers/application_helper.rb (L390)
[3]:8160089f3d/app/models/async_info.rb (L52-L61)
[4]:8160089f3d/app/javascript/packs/applyApplicationPolicyToggles.js
 2022-05-11 15:26:24 -04:00
Fernando Valverde
8160089f3d
Remove Community Wellness badge feature flag (#17623) 
* Remove feature flag

* Remove tracking spec

* Add rollout date restriction logic + specs
 2022-05-11 12:08:40 -06:00
yheuhtozr
ee42894990
restore i18n lib.constants.settings.campaign.url (#17637) 2022-05-11 16:02:52 +01:00
Jeremy Friesen
bcfbd523d4
Moving from user.trusted tests to policy tests (#17619) 
The [`ArticlePolicy#moderate?`][1] method answers the questions around article
moderation.

At present this change does not introduce any significant changes (aside
from the JS logic loop).  The next "step" is to adjust the
`ArticlePolicy#moderate?` method to test if the user has a moderator
role.

Further, we'd need to see what is available on the action panel.

Related to forem/forem#17606

[1]:5ac3216a5a/app/policies/article_policy.rb (L160-L174)
 2022-05-11 08:18:13 -04:00
Jeremy Friesen
f4d4889a07
Replacing a potentially expensive query (#17605) 
Prior to this commit, if we didn't have an instance of `Article` we
likely had the class `Article`; we would then run a potentially VERY
expensive query (`SELECT user_id FROM articles;`) to provide an
answer; namely if all of the articles are written by the same user then
yes this user is the author.

With this commit, when you're authorizing the `Article` class, let's
just say "Nope, this user isn't the author".

Closes forem/forem#17604
 2022-05-11 08:17:51 -04:00
yheuhtozr
d6c15a3fc6
I18nize Constants::Settings (#17086) 
* app/lib i18n (no callers)

* tidy key names

* callers deconstantified

* delete ja.yml

* update locale keys and calls

* remove ja.yml

* Revert "remove ja.yml"

This reverts commit 6a6881e274b58424ece0411c887c862124a2ca87.

* fix conflicts

* remove ja.yml

* Update general.rb
 2022-05-11 09:58:37 +01:00
Jeremy Friesen
dd5ea4ffe9
Passing --passWithNoTests to jest linter (#17635) 
Related to forem/forem#17612
Related to forem/forem#17634

Looking at the following error, I *think* this might address the
observed issue.

```shell
✖ jest --findRelatedTests:
No tests found, exiting with code 1
Run with `--passWithNoTests` to exit with code 0
Make sure Jest's configuration does not exclude this directory.
To set up Jest, make sure a package.json file exists.
Jest Documentation: https://jestjs.io/docs/configuration
```
 2022-05-10 23:48:26 -04:00
Arit Amana
41acd673d0
Make Follow Buttons in User, Org and Tag Embeds "secondary" (#17602) 
* complete implementation

* Make PR review changes
 2022-05-10 16:37:39 -04:00
Jeremy Friesen
d499a3727c
Ensuring only privileged users may give certain reactions (#17632) 
There are 2 things going on in this pull request:

1. Reducing duplication of knowledge, by favoring constants found in
   Reaction.
2. Creating and enforcing the policies regarding the different
   categories of reactions.

I chose to conflate these two as I was working on developing the
ReactionPolicy's finder method.

Closes forem/forem-internal-eng#454
Related to forem/forem#17628
 2022-05-10 16:13:23 -04:00
dependabot[bot]
0a738f731f
Bump fog-aws from 3.13.0 to 3.14.0 (#17631) 
Bumps [fog-aws](https://github.com/fog/fog-aws) from 3.13.0 to 3.14.0.
- [Release notes](https://github.com/fog/fog-aws/releases)
- [Changelog](https://github.com/fog/fog-aws/blob/master/CHANGELOG.md)
- [Commits](https://github.com/fog/fog-aws/compare/v3.13.0...v3.14.0)

---
updated-dependencies:
- dependency-name: fog-aws
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-05-10 16:05:30 -04:00
dependabot[bot]
8ae5ee1d20
Bump ransack from 3.1.0 to 3.2.0 (#17629) 
Bumps [ransack](https://github.com/activerecord-hackery/ransack) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/activerecord-hackery/ransack/releases)
- [Changelog](https://github.com/activerecord-hackery/ransack/blob/main/CHANGELOG.md)
- [Commits](https://github.com/activerecord-hackery/ransack/compare/v3.1.0...v3.2.0)

---
updated-dependencies:
- dependency-name: ransack
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-05-10 13:03:25 -06:00
Takuya N
e3a30eeb31
Replace forem/forem instead of thepracticaldev/dev.to (#17625) 
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
 2022-05-10 06:56:58 -06:00
dependabot[bot]
839d1aac5c
Bump @honeybadger-io/js from 3.2.9 to 4.0.1 (#17611) 
Bumps [@honeybadger-io/js](https://github.com/honeybadger-io/honeybadger-js) from 3.2.9 to 4.0.1.
- [Release notes](https://github.com/honeybadger-io/honeybadger-js/releases)
- [Changelog](https://github.com/honeybadger-io/honeybadger-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/honeybadger-io/honeybadger-js/compare/v3.2.9...v4.0.1)

---
updated-dependencies:
- dependency-name: "@honeybadger-io/js"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-05-10 07:28:28 -04:00
dependabot[bot]
c2af21e730
Bump jest from 27.5.1 to 28.1.0 (#17612) 
* Bump jest from 27.5.1 to 28.1.0

Bumps [jest](https://github.com/facebook/jest/tree/HEAD/packages/jest) from 27.5.1 to 28.1.0.
- [Release notes](https://github.com/facebook/jest/releases)
- [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/jest/commits/v28.1.0/packages/jest)

---
updated-dependencies:
- dependency-name: jest
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* resolve upgrade errors

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
 2022-05-10 07:27:36 -04:00
Takuya N
05fcdfcb2e
Replace forem/forem instead of thepracticaldev/dev.to (#17626) 
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
 2022-05-10 07:26:50 -04:00
dependabot[bot]
203d06a9ce
Bump focus-trap from 6.9.0 to 6.9.1 (#17608) 
Bumps [focus-trap](https://github.com/focus-trap/focus-trap) from 6.9.0 to 6.9.1.
- [Release notes](https://github.com/focus-trap/focus-trap/releases)
- [Changelog](https://github.com/focus-trap/focus-trap/blob/master/CHANGELOG.md)
- [Commits](https://github.com/focus-trap/focus-trap/compare/v6.9.0...v6.9.1)

---
updated-dependencies:
- dependency-name: focus-trap
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-05-10 10:54:21 +01:00
dependabot[bot]
0397870924
Bump preact from 10.7.1 to 10.7.2 (#17622) 
Bumps [preact](https://github.com/preactjs/preact) from 10.7.1 to 10.7.2.
- [Release notes](https://github.com/preactjs/preact/releases)
- [Commits](https://github.com/preactjs/preact/compare/10.7.1...10.7.2)

---
updated-dependencies:
- dependency-name: preact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-05-10 09:50:01 +01:00
dependabot[bot]
6b20e97b22
Bump @rails/ujs from 7.0.2 to 7.0.3 (#17621) 
Bumps [@rails/ujs](https://github.com/rails/rails) from 7.0.2 to 7.0.3.
- [Release notes](https://github.com/rails/rails/releases)
- [Commits](https://github.com/rails/rails/compare/v7.0.2...v7.0.3)

---
updated-dependencies:
- dependency-name: "@rails/ujs"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-05-10 09:45:57 +01:00
Fernando Valverde
bf4d34fe9c
Wellness badge query+service refactor (#17592) 
* Query +service slight refactor

* 33 week comment
 2022-05-09 16:44:50 -06:00
dependabot[bot]
6d6287d93f
Bump babel-jest from 28.0.3 to 28.1.0 (#17609) 
Bumps [babel-jest](https://github.com/facebook/jest/tree/HEAD/packages/babel-jest) from 28.0.3 to 28.1.0.
- [Release notes](https://github.com/facebook/jest/releases)
- [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/jest/commits/v28.1.0/packages/babel-jest)

---
updated-dependencies:
- dependency-name: babel-jest
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-05-09 17:28:06 -04:00
dependabot[bot]
030f5d7482
Bump eslint from 8.14.0 to 8.15.0 (#17620) 
Bumps [eslint](https://github.com/eslint/eslint) from 8.14.0 to 8.15.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v8.14.0...v8.15.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-05-09 16:58:02 -04:00
dependabot[bot]
5789e5feaf
Bump husky from 7.0.4 to 8.0.1 (#17618) 
Bumps [husky](https://github.com/typicode/husky) from 7.0.4 to 8.0.1.
- [Release notes](https://github.com/typicode/husky/releases)
- [Commits](https://github.com/typicode/husky/compare/v7.0.4...v8.0.1)

---
updated-dependencies:
- dependency-name: husky
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-05-09 14:15:41 -06:00
dependabot[bot]
5ac3216a5a
Bump blazer from 2.6.1 to 2.6.2 (#17614) 
Bumps [blazer](https://github.com/ankane/blazer) from 2.6.1 to 2.6.2.
- [Release notes](https://github.com/ankane/blazer/releases)
- [Changelog](https://github.com/ankane/blazer/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ankane/blazer/compare/v2.6.1...v2.6.2)

---
updated-dependencies:
- dependency-name: blazer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-05-09 13:42:59 -06:00
dependabot[bot]
c433a24649
Bump cypress from 9.6.0 to 9.6.1 (#17607) 
Bumps [cypress](https://github.com/cypress-io/cypress) from 9.6.0 to 9.6.1.
- [Release notes](https://github.com/cypress-io/cypress/releases)
- [Changelog](https://github.com/cypress-io/cypress/blob/develop/.releaserc.base.js)
- [Commits](https://github.com/cypress-io/cypress/compare/v9.6.0...v9.6.1)

---
updated-dependencies:
- dependency-name: cypress
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-05-09 15:05:10 -04:00
dependabot[bot]
6c64a76c0c
Bump metainspector from 5.12.0 to 5.12.1 (#17613) 
Bumps [metainspector](https://github.com/metainspector/metainspector) from 5.12.0 to 5.12.1.
- [Release notes](https://github.com/metainspector/metainspector/releases)
- [Changelog](https://github.com/metainspector/metainspector/blob/master/CHANGELOG.md)
- [Commits](https://github.com/metainspector/metainspector/compare/v5.12.0...v5.12.1)

---
updated-dependencies:
- dependency-name: metainspector
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-05-09 15:04:44 -04:00
dependabot[bot]
cc37c68477
Bump nokogiri from 1.13.5 to 1.13.6 (#17615) 
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.5 to 1.13.6.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/v1.13.6/CHANGELOG.md)
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.13.5...v1.13.6)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-05-09 14:46:35 -04:00
dependabot[bot]
dc1bcbb676
Bump i18n-tasks from 1.0.9 to 1.0.10 (#17616) 
Bumps [i18n-tasks](https://github.com/glebm/i18n-tasks) from 1.0.9 to 1.0.10.
- [Release notes](https://github.com/glebm/i18n-tasks/releases)
- [Changelog](https://github.com/glebm/i18n-tasks/blob/main/CHANGES.md)
- [Commits](https://github.com/glebm/i18n-tasks/compare/v1.0.9...v1.0.10)

---
updated-dependencies:
- dependency-name: i18n-tasks
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-05-09 12:36:05 -06:00
dependabot[bot]
a78062d53b
Bump capybara from 3.36.0 to 3.37.1 (#17610) 
Bumps [capybara](https://github.com/teamcapybara/capybara) from 3.36.0 to 3.37.1.
- [Release notes](https://github.com/teamcapybara/capybara/releases)
- [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md)
- [Commits](https://github.com/teamcapybara/capybara/compare/3.36.0...3.37.1)

---
updated-dependencies:
- dependency-name: capybara
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-05-09 12:24:49 -06:00
Jeremy Friesen
43a9c5f2f0
Fixing variant query specs (#17597) 
* Fixing variant query specs

As I was working on adding a new variant, I discovered that not all of
our variants were being tested.  This had to do with a faulty assumption
regarding the scoping of the `variant` local variable.

The change ensures that we declare a subject once for each defined
variant within their own `describe` block.  Without that `describe`
block, you end up repurposing the same subject.

I found this because I made a deliberate error in the upcoming variant
and checked the tests.  They passed.

Related to forem/forem#17584

* Update spec/services/articles/feeds/variant_query_spec.rb

Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>

* Update spec/services/articles/feeds/variant_query_spec.rb

Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>

Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>
 2022-05-09 13:20:34 -04:00