Anna Buianova
20e242af0d
Rubocop fixes ( #20254 )
...
* Fixed redundant alls for rubocop
* Fixed rubocop violations in spec/requests
* Fixed rubocop violations in spec/models
* Fixed Performance/MapMethodChain
* Fixed rubocop violations in spec/requests
* Revert changes to FastlyConfig::Update spec
2023-10-18 17:24:28 -04:00
Anna Buianova
7d053471f8
Rubocop fixes in spec/requests ( #18946 )
...
* Rubocop fixes in spec/requests
* Fixed spec/requests/api/v0/articles_spec.rb
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2023-01-12 19:10:16 +03:00
rhymes
cf9f6094cd
Have specs run without Redis and refactor ConsumerApp and Device ( #13647 )
...
* Add fakeredis gem
* Mock Pusher::PushNotifications in specs
* Remove Redis from Travis
* Add Android tests to ConsumerApp specs
* Use mock for push notification tests and refactor ConsumerApp and Device code
* Fix remaining broken specs
* Use symbols
* Cleanup rpush helpers
* Pusher::PushNotifications is no more
* Use human friendly platform in Admin::ConsumerApps index page
2021-05-07 08:03:16 +02:00
Ridhwana
3a4da2dd5a
RFC 50: Remove hardcoded paths and use path_helpers instead (in the specs) ( #13549 )
...
* feat: update the paths in the spec files
* feat: update hardcoded paths with path helpers
* chore: update hardcoded paths to path helpers
* chore: hardcode describe blocks
* chore: oops
* feat: update some more hardcoded to use link_to's
* fix broken tests
* chore: admin_articles path
* chore: oops remove rails helper
* feat: add starting /
* chore: more pre slashes
* chore: add pre slashes
* chore: some small typos
* fix: oops
2021-04-28 21:32:51 +02:00
Fernando Valverde
e602d50d32
Push Notification multi app support ( #13304 )
...
* PushNotificationTarget model + /admin/push_notifications (index)
* Admin panel CRUD + request tests
* Migrate Redis backed Rpush model responsibilities into PushNotificationTarget
* Fix failing specs
* Fix conflicts + clean up test by using constant reference
* Removed unused policy
* policy + services + misc feedback
* PushNotificationTarget refactored to AppIntegration
* Review feedback
* Some small cleanup
* Refactor AppIntegration -> ConsumerApp
* Fixing specs
* Trigger Travis
* More naming refactor changes
* Refactor services into queries
* Revert to where(...).first, fix typo and tests
* Apply suggestions from code review
Co-authored-by: rhymes <rhymes@hey.com>
* PR review feedback - create_or_find_by, validations, renaming + more tests
* Fix aria-label text
* Remove unnecessary individual index - composite index will do
Co-authored-by: rhymes <rhymes@hey.com>
2021-04-21 17:13:01 -06:00
