maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
13227 commits 1 branch 0 tags 1.6 GiB
Commit graph

3228 commits

Author SHA1 Message Date
Philip How
751e9d70d2
Show ⚠️ icon on /admin when an article is not indexed on search engines (#20713) 
* Add in icon when an article is not indexed on admin

* tests

* rubocop

* rubocop
 2024-03-05 21:34:20 +00:00
Gabriel Quaresma
02459941a5
Profile bio does not recognize line breaks (#20572) 
Co-authored-by: Mac Siri <mac@forem.com>
 2024-03-04 20:37:16 +00:00
Ben Halpern
f2968baadb
Add optional client-side dismissal SKU for closable billboards (#20716) 
* Add optional client-side dismissal SKU for closable billboards

* Safe nav
 2024-03-01 16:13:19 -05:00
Anna Buianova
288c9ed31f
Fix articles counts based on display rules (#20669) 
* Comment counts for signed in users

* Adjust comments count for articles

* Fixed counts for signed out users, added specs for Comments::Count

* Fixed counts for signed out and added specs for Comments::Count

* Removed debug info from the view

* Removed separate count for signed out users

* Remove irrelevant specs

* Remove unused scope
 2024-03-01 07:54:15 -05:00
Philip How
fe213a81fa
Add Following Tags and Reconfigure Sidebar in Mod Center (#20694) 
* reconfigure mod left sidebar, adding following tags

* add localization
 2024-03-01 07:35:54 -05:00
Ben Halpern
78f9bec3e7
Allow admin to declare whether to include the badge description in message (#20684) 
* Allow admin to declare whether to include the badge description in badge achievement message

* Update spec/services/badges/award_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Add proper acceptance to tests

* Tweak tests

* Switch to kwargs

* Clean up test acceptance

* Change interface

* Update spec/requests/admin/badge_achievements_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update app/services/badges/award.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Adjust interface

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
 2024-02-28 11:02:58 -05:00
Ben Halpern
585bea212d
Remove non-contextual content from signed-out version of page (#20686) 2024-02-27 15:15:05 -05:00
Ben Halpern
f88784cc35
Add configuration for admins to specify compliant email strategies (#20663) 
* Add configuration for admins to specify compliant email strategies

* Add keys for test
 2024-02-21 08:27:26 -08:00
Ben Halpern
17d81b6cb1
[Hotfix] Fix cache key (#20658) 
* Fix cache key

* Small style tweak
 2024-02-19 19:24:36 -08:00
Ben Halpern
caa7b5a63a
[Hot fix] Fix style bugs with registration page (#20656) 
* Fix style bugs with registration page

* Small additonal style tweak

* Final style tweak
 2024-02-19 18:48:50 -08:00
Ben Halpern
6ef9a83252
Make mobile runtime banner optional (#20637) 
* Remove runtime banner

* Show/hide runtime banner setting

* Update app/views/layouts/application.html.erb

* Update app/views/layouts/application.html.erb

* Update app/views/layouts/application.html.erb
 2024-02-16 10:45:41 -08:00
Anna Buianova
d0f3fb6fff
Optimize and test comments cache after score change (#20640) 
* Add specs for caching article comments, use cache_key_with_version

* Optimize cache busting for spammer comments, reorganized related specs
 2024-02-16 14:53:11 +00:00
Ben Halpern
205aee8c78
Add billboard for bottom of page with allowance to delay until after reading is finished. (#20616) 
* Add delayed behavior

* Add special behavior to billboards

* Fix order for test

* Test clicking outside element when close event is present

* Update app/javascript/packs/billboardAfterRenderActions.js
 2024-02-13 11:56:32 -05:00
Anna Buianova
e5064b418f
Hide super low score comments if they are child comments (#20612) 2024-02-09 16:24:13 +00:00
Ben Halpern
2f9769a89d
Add new sidebar billboard locations and remove legacy campaign area (#20562) 
* Add new sidebar billboard locations

* Remove some specs

* Remove campaign tests

* Adjust tag-allowed billboards

* Fix up targeting functionality

* Fix sidebar third render
 2024-02-08 16:55:48 +00:00
Anna Buianova
07ffb2e3be
Removed spammers from followers list (#20603) 
* Remove spam and suspended users from followers list (api and dashboards)

* Fixed the api followers endpoint

* Fixed issue with follower_ids query
 2024-02-08 13:57:15 +00:00
Anna Buianova
7125a62db0
Changed logic for hiding and displaying low-quality marker for comments based on their score (#20581) 
* Specs for revised comments thresholds

* Changed thresholds for low quality comments

* Added specs for comments page

* Fixed /comments and related specs

* Reorganized code for comments trees

* Specs for podcasts episodes comments

* Refactored Comments::Tree

* Refactored Comments::Tree + added specs

* Made build_sort_query private
 2024-02-05 09:27:24 -05:00
Philip How
15bac7afbc
Add safe-navigation for note author (#20571) 2024-01-30 15:18:59 -05:00
Ben Halpern
ee29318126
Add a/b test for which comments to show in feed (#20332) 
* Add a/b test for which comments to show in feed

* Adjust figure

* Started at

* Move scope placement around

* Add tests for different comments_variants passed

* Fix typo
 2024-01-29 12:18:50 -05:00
Anna Buianova
58bd07d729
Render 404 when root comment has low score and no children (#20560) 2024-01-26 17:21:18 +00:00
Mac Siri
afa73e06e3
Replace Webpacker with Esbuild (#20470) 
* Migrate to esbuild WIP

* Add exclude

* Remove redundant file

* Move file

* Move to javascript_include_tag

* Lint fix

* WIP

* WIP

* Add watch mode to esbuild WIP

* Get jest working

* Remove babel

* Revert "Remove babel"

This reverts commit 6da35260aa19d6f97f586deb66c0ecaf48433b73.

* More WIP

* Got image to load

* WIP

* Resolve audit

* Lint fix

* WIP

* Fix jest spec

* [CI] Remove asset-restore for test build stage

* Production compliant

* Temp disable sourcemap

* Update glob

* Add esbuild helper to stimulus

* Import fragment

* Temp disable coverage to see failing tests

* Fix broken spec

* Address lint

* Set proper es6 target

* Use esbuild for everything

* wait what

* Revert "Set proper es6 target"

This reverts commit 98f5278093421baa8ffe2ca580845b01c1a1eadf.

* Revert "Use esbuild for everything"

This reverts commit 0ac46738f07ffcb6af095ccb1ffa5e439b7fefa3.

* Replace uglifier with terser

* New compiled assets version

* Remvoe honeybadger-io/webpack

* Remove cypress coverage checks for now

* Update jsconfig.json

* Update docker-compose

* Remove public/packs-test from ci cache
 2024-01-25 20:29:21 +00:00
Philip How
d615fcef56
Add new members filter to mod center (#20542) 
* fix jest

* Update safe_params_list.vcl

---------

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
 2024-01-23 16:07:45 -05:00
Anna Buianova
321540ec08
Hide low quality comments from an article page (#20541) 
* Hide low-score (< -50) comments for signed in users on article page

* Use low quality threshold

* Show deleted message for low-quality for signed-in users + hide if no children

* Remove irrelevant changes

* Skip view test for low-quality

* Removed irrelevant (yet) tests

* Fixed low score threshold in specs descriptions
 2024-01-23 20:33:12 +00:00
Philip How
b593ecd323
Change 🧐 to 🚩 (#20537) 
* inital pass

* icon title

* fix locale issues failing tests
 2024-01-22 15:53:25 +00:00
Philip How
c11160d2f7
switch class for mod icon in top bar (#20540) 2024-01-19 09:33:54 -05:00
Ben Halpern
16ff57c2ff
Add HTML customization to admin (#20531) 
* Add HTML customization to admin

* Update spec/requests/stories_index_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
 2024-01-17 12:12:22 +00:00
Ben Halpern
ae2371d9a4
Add configuration for admins to determine whether to show cookie banner (#20517) 
* Cookie banner admin config (wip)

* GA4 consent mode based on cookie acceptance

* Fix i18n

* Merge upstream

* Adjust heading
 2024-01-15 18:22:17 +00:00
Philip How
33fd9836be
Add CSS as pages template option (#20512) 
* add css as pages option

* don't forget schema

* fix test

* add api support
 2024-01-12 15:35:38 +00:00
Ben Halpern
f4081b2e24
Functionality to allow admins to add a cookie consent notice (part 2) (#20488) 
* Initial work on base cookie modal

* Update app/assets/stylesheets/components/modals.scss
 2024-01-04 16:20:03 -05:00
Anna Buianova
473594f192
Match spam role with existing suspended actions (#20477) 
* Started matching spam and suspended roles

* Match spam and suspended roles in most cases

* Fixed check_suspended for unauthenticated users
 2023-12-27 20:12:50 +00:00
Anna Buianova
d327fbe73d
Remove unused user status span (#20468) 2023-12-22 10:53:32 +00:00
Philip How
199a88a254
fix notes typo + correctly add event listener to correct buttons (#20459) 2023-12-18 15:07:30 +00:00
Anna Buianova
adfd76feb6
Consider spam role in the user_status method (#20449) 
* Add spam role to user_status method

* Take spam role into account in user status indicator

* Return passed statuses
 2023-12-13 16:56:27 +00:00
Philip How
2ff439da80
Improve abuse reports UX (#20433) 
* change to buttons + updates to styles

* add expand/collapse all and increase number of displayed entries

* fix a11y

* fix show route + order vomits by users first

---------

Co-authored-by: Mac Siri <mac@forem.com>
 2023-12-13 15:31:09 +00:00
Philip How
25e0ebc1ac
admin filter feedback category (#20418) 2023-12-05 16:34:51 +00:00
Ben Halpern
9eaff67318
Update styling and refine features for analytics page (#20410) 
* Update styling and refine features for analytics page

* Remove follower reference from js

* Update html

* Adjust test
 2023-11-30 16:07:16 -05:00
Ben Halpern
88769c6a3c
Only render comment sorting for signed-in users (#20398) 2023-11-28 10:54:06 -05:00
Anna Buianova
df0b134ec4
Added followers count to /api/users/me endpoint (#20378) 
* Added followers_count to /api/users/me

* Updated the api user docs

* Rubocop fixes fro swagger_helper

* Added me jbuilder view for api/v0
 2023-11-22 20:22:06 +00:00
Ben Halpern
e545148fd5
Add active discussions to sidebar (#20372) 
* Add active discussions to sidebar

* Move featured tags to before signin-guard

* Move featured tags back to view

* Fix test
 2023-11-21 11:10:10 -05:00
Anna Buianova
3e27e9c986
Added user badge_ids to the api (#20365) 2023-11-17 17:01:55 +00:00
Peter Frank
1cea64c7f7
Update report_abuse.en.html.erb (#20362) 
Closes https://github.com/forem/forem/issues/20361
 2023-11-17 13:35:13 +00:00
Ben Halpern
eccd5fd9e3
Add custom_display_label to billboards and update API (#20355) 
* Add a/b test for which comments to show in feed

* Adjust figure

* Started at

* Add custom_display_label to billboards and update API

* Add custom_display_label to billboards and update API
 2023-11-15 09:57:39 -05:00
Ben Halpern
e7fc1bb0ce
Add article id and geolocation info to billboard events (#20329) 
* Add article id and geolocation info to billboard events

* Confirm destroyed in rollup
 2023-11-09 12:43:23 -05:00
Ben Halpern
a4a1de964d
Move features along in deprecation status ✂️ (#20315) 
* Move features along in deprecation status

* Remove unnecessary tests
 2023-11-07 09:50:08 -05:00
Ben Halpern
b0cb5540c0
Add new render mode and template options for billboards (#20282) 
* Add new render and template modes for billboards

* Add new fields to /admin

* Adjust test

* Adjust markup in form

* Add tests for script execution

* Add two script test

* Adjust scripts

* Adjust scripts

* Add new test

* Add new explicit tests

* Move JS functionaity around
 2023-10-30 14:56:09 -04:00
ktmouk
8963e185f8
Fix username combobox tries to load all users (#20227) 
* Fix username combobox tries to load all users

* Add the limit param to the users_query

* Add a comment
 2023-10-25 15:53:53 -04:00
Daniel M Brasil
212ddf0265
Fix: prevent users from changing the author when a post is part of a post series (#20259) 
* disable authors and co-authors selectors for series posts

* add translations

* fix constrant issues

* add alternative text for icon

---------

Co-authored-by: Mac Siri <mac@forem.com>
 2023-10-25 17:39:58 +03:00
Christine Belzie
4337161508
docs: making updates to Editor Guide (#20258) 
* feat: add mention

* fix: made some adjustments

* fix: revise bullet point

* fix: update another bullet point

---------

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
 2023-10-24 14:19:30 -04:00
Anna Buianova
5ac786c9a1
Add email to the users api (#20241) 
* Add email to the users api if display_public_email_on_profile is set to true

* Fixed selected user fields in the api

* A separate partial for user data with email (for the api)
 2023-10-13 16:27:21 +03:00
Gabriel Quaresma
344dfb7f77
Indicate required fields on podcasts/new (#20223) 2023-10-11 12:17:05 -04:00