maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
12499 commits 1 branch 0 tags 1.6 GiB
Commit graph

12499 commits

This branch
This branch
All branches
Author SHA1 Message Date
Joshua Wehner
a20cf3e02b
Unique cross-model-slug check is likely misconfigured (#19263) 
* Page unique_cross_model_slug seems misconfigured

* Update validator test

* More verbose invalid attribute message

* Try dynamic model/attribute registration

* Rubocop

* Use the cross-model-slug existence check

* Register with the dynamic cross-model-slug checker

* Cleanup

* Add missing keys to fr

* Update format regex

* Adjust validation: always presence, unique if changed

* Tests can create reserved-word pages when they need to

* Slugs can be mixed case?

* Case-sensitive is better, actually

* Refactor to use CrossModel check

* Refactor, rename for clarity

* Refactor, avoid mocking oneself

* Refactor, injectable everything

* Add reservedword check to extracted exists? checker

* Move to concerns

* Without dynamic registration

* extend when needed

* Cleanup comments, remove registration references

---------

Co-authored-by: Goran <gorang.pub@gmail.com>
 2023-04-07 17:04:45 +02:00
Grayson Adkins
f019085d1e
Add Uffizzi acknowledgement (#19301) 
Co-authored-by: Rajat Talesra <rajat@forem.com>
 2023-04-07 20:33:20 +05:30
Anna Buianova
eb52b91f75
Ensure rendering parity on DisplayAd, Comment, & Article (#19091) 2023-04-07 09:30:17 -04:00
Mac Siri
0813a0a322
Resolves false-positive UnsafeRedirectError (#19297) 2023-04-07 09:17:56 -04:00
fille du chaos
6a80f51e02
docs: Add filleduchaos to core contributors list (#19298) 2023-04-06 17:36:04 +01:00
Mac Siri
f88a861125
Keep rubocop's usage consistent (#19293) 2023-04-06 07:53:59 -04:00
depfu[bot]
a24cb4079c
[ruby] Update inline_svg: 1.8.0 → 1.9.0 (minor) (#19294) 
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
 2023-04-05 17:15:44 -04:00
Robert Chang
704eb4f5df
Update FeedbackMessagesController#create feedback-response-sent-at cache key (#19287) 2023-04-05 13:05:12 -04:00
Mai Irie
3775f2b06c
PR Template cleanup (#19277) 
* PR Template cleanup

Removed some sections we've been using less often to streamline the PR review process.
 2023-04-05 11:58:57 -04:00
Joshua Wehner
d3f8e127fa
Add an article exclusion list to Billboards (#19280) 
* Add exclude_article_ids int array

* Add specs, normalize inputs better

* Add to form & controller

* Add exclude_article_ids to DisplayAd API

* Use exclude_article_ids in query

* Rubocop

* Comment typo

* Tweak rspec example length config

* Arguments all the way down

* Typo

* Update spec/requests/api/v1/docs/display_ads_spec.rb

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>

* Update spec/requests/api/v1/docs/display_ads_spec.rb

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>

* Swagger schema for Display Ad

---------

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
 2023-04-05 09:10:22 -04:00
yheuhtozr
a6030022f6
[CP] fix multiple reaction icons joined by commas (#19288) 2023-04-04 22:34:18 +05:30
depfu[bot]
b412daa3ea
[ruby] Update all development Bundler dependencies (2023-04-03) (#19291) 
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Mac Siri <mac@forem.com>
 2023-04-03 17:31:30 -04:00
Mac Siri
e3b6e5b08d
[CI] Make CodeCov less noisy (#19286) 2023-04-03 15:56:20 -04:00
Joshua Wehner
ca89fbcec3
Clear trusted cache in rolify callback (#19275) 2023-04-03 14:45:00 +02:00
Joshua Wehner
197b7f7128
Update FilteredAdQuery to better support community ads (#19281) 
* Update FilteredAdQuery to better support community ads

* Maybe organization_id could be blank?

* Try an explanatory comment for filter ordering

* Update app/queries/display_ads/filtered_ads_query.rb

Co-authored-by: Anna Buianova <lightallloy@gmail.com>

* Rubocop

* Tidy up type matching logic

---------

Co-authored-by: Anna Buianova <lightallloy@gmail.com>
 2023-04-03 14:44:35 +02:00
Rajat Talesra
2346d22fe9
a11y-ize reaction drawer (#19273) 2023-03-31 11:00:45 -04:00
Ridhwana
16f678cebd
feat: move the initializer to a pack file (#19279) 2023-03-31 15:33:41 +02:00
Josh Klar
408bb14283
readme: Add klardotsh to core contributors list. (#19278) 
Co-authored-by: Josh Klar <jklar@forem.com>
 2023-03-30 17:07:09 -07:00
Omar Ferreiro
8b6e67ff9b
Remove the <br> tags in 404.html (#19236) 
Co-authored-by: IcarusTheFly <IcarusTheFly@users.noreply.github.com>
Co-authored-by: Lawrence <lawrence@forem.com>
Co-authored-by: Rajat Talesra <rajat@forem.com>
 2023-03-30 13:23:38 -04:00
Mac Siri
f368a4ce7f
Fix broken cypress code coverage (#19282) 2023-03-30 12:36:12 -04:00
Mac Siri
64c10957e3
Update CODEOWNERS (#19276) 2023-03-29 17:20:41 -04:00
Mac Siri
88108b3037
Implement code coverage for Cypress (#19250) 2023-03-29 15:37:50 -04:00
Joshua Wehner
47cf1d14a8
Allow codepen retries in UnifiedEmbed(#19271) 2023-03-29 15:05:30 -04:00
Lawrence
e4e1f4d96d
report abuse dropdown link (#19247) 
* report abuse dropdown link

* Update app/controllers/pages_controller.rb

* Update app/views/shared/_display_ad.html.erb

* remove billboard url check

---------
 2023-03-28 14:02:31 -05:00
Ridhwana
42b392906b
Migrate initializeUserProfilePage to webpack (#19241) 2023-03-28 12:20:49 -04:00
Mac Siri
37c961e40d
Fix broken buildkite pipeline. (#19272) 2023-03-28 11:14:51 -04:00
James Wu
a9948a41e3
Fix like icon in sidebar (#19266) 2023-03-28 12:17:10 +05:30
Goran
0b4a3601a8
Refactor User#temp_username (#19252) 
* Refactor User#temp_username

* Remove Authentication::Providers dependency from Users::UsernameGenerator

* Adds brief description and yard docs
 2023-03-27 16:21:00 +03:00
Ridhwana
15bb2e5a8b
Tweaks to display ad styling (#19262) 2023-03-24 12:49:27 -04:00
Mac Siri
1e1064de0b
Undo changes to Sprockets::UglifierWithSourceMapsCompressor (#19261) 2023-03-24 12:48:59 -04:00
Anna Buianova
784afdf41e
Routine rubocop fixes (#19254) 
* Rubocop fixes

* Rubocop fixes

* Fixed rubocop violation

* Fixed policies rubocop violations

* More rubocop fixes
 2023-03-24 14:37:44 +03:00
Rajat Talesra
54eb412593
Add user status from profiles to the report section (#19240) 2023-03-23 15:47:41 -04:00
Ridhwana
c285cf8f9e
Promotional Flair for external Billboard (#19216) 
* Users can only opt-out of external ads

* Move random sampling out of FilteredAdsQuery

* Refactor filtered_ads_query_spec

* Add test for new permit_adjacent setting

* Rubocop

* Use permit_adjacent_sponsors on article sidebar and post-comments

* Remove, unused

* Update copy

* type_matched -> type_of_ads

* Remove non-applicable test

* feat: update the bullet safe list and add eager loading with organizations

* feat: add an indicator round for promoted

* feat: update the css

* feat: add il8n

* fix: styling changes

---------

Co-authored-by: Joshua Wehner <joshua@forem.com>
 2023-03-23 18:37:04 +02:00
depfu[bot]
81201c0284
[js] Update all Yarn dependencies (2023-03-20) (#19239) 
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Mac Siri <mac@forem.com>
Co-authored-by: Lawrence <lawrence@forem.com>
 2023-03-23 10:53:14 -04:00
Thomas Bnt
f9a3baca44
I18n: populate config/locales with French (#17487) 
Co-authored-by: Joshua Wehner <joshua.wehner@gmail.com>
Co-authored-by: Mac Siri <mac@forem.com>
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
 2023-03-23 10:06:38 -04:00
depfu[bot]
853e2dbc22
[ruby] Update pghero: 3.2.0 → 3.3.1 (minor) (#19256) 
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
 2023-03-23 09:42:22 -04:00
yheuhtozr
87c5526c30
Allow BIDI non-deprecated marks in title (#19177) 2023-03-23 09:41:57 -04:00
Joshua Wehner
b812ca5955
(Really) Enable multiple reactions on #index (#19202) 2023-03-22 10:20:00 -04:00
depfu[bot]
5b437af792
Update sidekiq-cron to version 1.10.0 (#19245) 
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
 2023-03-21 22:39:04 +05:30
Mac Siri
b7f00706bd
[CI] Adjust cancel-in-progress concurrency (#19244) 
* [CI] Adjust cancel-in-progress concurrency

* Revert "[CI] Lock setup-ruby to v1.144.0 (#19243)"

This reverts commit 44a3527983.
 2023-03-21 10:05:31 -04:00
Mac Siri
842e6880b8
Routine rubocop fix on /spec (#19217) 
* Softrun rubocop

* Hardrun rubocop (-A)

* Change a rubocop rule

* Add missing cops

* Undo & redo rubocop -A
 2023-03-21 09:55:26 -04:00
depfu[bot]
ce6f30b9de
[ruby] Update strong_migrations: 1.4.3 → 1.4.4 (patch) (#19238) 
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
 2023-03-20 17:48:36 -04:00
Mac Siri
44a3527983
[CI] Lock setup-ruby to v1.144.0 (#19243) 2023-03-20 11:17:18 -04:00
Joshua Wehner
8086ef68ac
Fix bullet issue with includes commentable (#19145) 
* Fix bullet issue with includes commentable

* Flatten view logic

* Restore user comment section logic (but bullet-friendly)

* Try fixing podcast_episode -> podcast

* Add test that would have caught the logic bug

* View specs need describe to specific the path

* Remove unnecessary _comments argument

* Ooops, missed saving this
 2023-03-20 16:08:03 +01:00
Mac Siri
047a68cc66
[CI] Add concurrency & remove slack alert (#19237) 
* Remove CI's slack report

* Add concurrency to per branch

* Dynamic cancel-in-progress
 2023-03-20 08:59:14 -04:00
depfu[bot]
7d2d71de68
[ruby] Update devise: 4.8.1 → 4.9.0 (minor) (#19173) 
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Lawrence <lawrence@forem.com>
 2023-03-17 13:55:49 -04:00
James Wu
78bb52a627
Fix text color contrast on social previews (#19163) 2023-03-17 13:37:19 -04:00
Mac Siri
bfe797f44d
Create cleanup-cache.yml (#19232) 2023-03-17 12:18:51 -04:00
depfu[bot]
108caee0d5
[ruby] Update ancestry: 4.2.0 → 4.3.0 (minor) (#19233) 
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
 2023-03-17 10:36:33 -04:00
depfu[bot]
d452f5a683
[js] Update all Yarn dependencies (2023-03-15) (#19230) 
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
 2023-03-17 07:46:31 -04:00