Jamie Gaskins
9db13cbc4c
Run user setting DUS per-user via Sidekiq ( #13848 )
...
* Run user setting DUS per-user via Sidekiq
Doing it as a single query trips the query timeout beyond a certain
quantity of users.
* Run DataUpdateScripts::MigrateRelevantFieldsFromUsersToUsersNotificationSettings asynchronously
2021-05-25 14:25:45 -04:00
Lisa Sy
e925d95f71
Rename WRITE A POST to CREATE POST ( #13855 )
...
* Rename WRITE A POST to CREATE POST
* Revert schema line removal
2021-05-25 10:30:30 -07:00
Ineza Bonté Grévy
802a557399
Update api docs to include list of events for creating webhooks ( #13849 )
2021-05-25 10:03:06 -05:00
Jacob Herrington
4c81e3b29b
Highlight "Posts" tab by default in search ( #13847 )
...
The default behavior of search is to search articles, so when no
"class_name" is specified in the search query, it makes sense to
highlight posts.
2021-05-25 09:57:52 -05:00
dependabot[bot]
be6a050d3c
Bump sass from 1.32.13 to 1.34.0 ( #13842 )
...
Bumps [sass](https://github.com/sass/dart-sass ) from 1.32.13 to 1.34.0.
- [Release notes](https://github.com/sass/dart-sass/releases )
- [Changelog](https://github.com/sass/dart-sass/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sass/dart-sass/compare/1.32.13...1.34.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-25 15:37:31 +02:00
rhymes
bd0e121d88
Remove IBM openapi-validator ( #13837 )
...
* Fix IBM openapi-validator configuration file
* Remove ibm-openapi-validator
2021-05-25 14:35:32 +02:00
Andrew Bone
61cd4b3e14
🚑 Quick fix prevent grammarly from running on chromium based browsers ( #13820 )
2021-05-25 06:54:32 -04:00
rhymes
7fe02c8383
Fix Invalid category error in seeds file ( #13838 )
2021-05-25 09:10:26 +02:00
Daniel Uber
a1c27cc47d
Update docker-compose.yml file to permit login ( #13792 )
...
There was an issue seen with the HTTP Origin header not matching (the
error unhelpfully reported localhost:3000 did not match
localhost:3000).
Change the APP_DOMAIN internally to localhost:3000 (which is what the
user will in fact use, not rails), and since that breaks the http
requests from the db seed and sidekiq containers, allow them to only
check for a tcp connection instead of expecting a 200
response (sending requests to the disallowed host `rails` triggered a
403).
Related to discussion in https://github.com/forem/forem/issues/4955
2021-05-24 20:03:36 -05:00
Thomas Step
d8cc793afe
Show correct number in series truncation. ( #13799 )
...
* Change math in collection to represent the correct number of hidden posts.
* Add test for correction truncation text.
* Add aggregate_failures tag to collections spec
Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>
Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>
2021-05-24 15:47:06 -06:00
Jacob Herrington
d87537ab29
[15 minute fix] Fix accessibility concerns in settings UI ( #13813 )
...
* Fix accessibility concerns in settings UI
* Update nav aria-labels
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Add hidden labels for color selectors
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-05-24 14:50:24 -05:00
Andy Zhao
864a9195a9
[15-min-fix] Add option for triple tildes for fenced codeblocks ( #13810 )
...
* Add option for triple tildes for fenced codeblocks
Note that this doesn't account for all triple backticks in fenced codeblocks situations.
* Add commented out but failing test case for the future?
* Add tests from QA instructions
2021-05-24 14:19:04 -04:00
dependabot[bot]
0b80d92d66
Bump eslint-plugin-import from 2.23.2 to 2.23.3 ( #13833 )
...
Bumps [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import ) from 2.23.2 to 2.23.3.
- [Release notes](https://github.com/benmosher/eslint-plugin-import/releases )
- [Changelog](https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md )
- [Commits](https://github.com/benmosher/eslint-plugin-import/compare/v2.23.2...v2.23.3 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-24 12:56:26 -05:00
Ridhwana
bf02be9df8
Data Migration Script for users_settings and users_notification_settings ( #13390 )
...
* schema file undelete description
* feat: v1 of the script
* Flesh out remaining enums under their categories
* complete UsersSettings data update script
* complete DUS for relevant attributes in users and profiles tables
* complete DUS for users_notification_settings
* alphabetize user_settings sql file
* safeguard against null values for "null: false" settings
* Set up actual UsersSettings DUS and specs files
* fix broken DUS script
* complete specs for UsersSetting DUS
* Address QA of specs
* complete specs for users_notification_settings DUS
* fix the typos (thanks Julianna!)
* add missing attribute "email_membership_newsletter"
Co-authored-by: Arit Amana <msarit@gmail.com>
2021-05-24 13:54:58 -04:00
Chien-Wei Huang (Michael)
a4c06d3207
Extract tag stories to tag articles controller ( #13457 )
2021-05-24 13:44:43 -04:00
dependabot[bot]
343a3a8a8a
Bump rpush from 5.4.0 to 6.0.0 ( #13835 )
...
Bumps [rpush](https://github.com/rpush/rpush ) from 5.4.0 to 6.0.0.
- [Release notes](https://github.com/rpush/rpush/releases )
- [Changelog](https://github.com/rpush/rpush/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rpush/rpush/compare/v5.4.0...v6.0.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-24 09:47:54 -06:00
dependabot[bot]
d83a3d474c
Bump puma from 5.3.1 to 5.3.2 ( #13836 )
...
Bumps [puma](https://github.com/puma/puma ) from 5.3.1 to 5.3.2.
- [Release notes](https://github.com/puma/puma/releases )
- [Changelog](https://github.com/puma/puma/blob/master/History.md )
- [Commits](https://github.com/puma/puma/compare/v5.3.1...v5.3.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-24 16:11:02 +02:00
dependabot[bot]
671cd7cbce
Bump jsdom from 16.5.3 to 16.6.0 ( #13840 )
...
Bumps [jsdom](https://github.com/jsdom/jsdom ) from 16.5.3 to 16.6.0.
- [Release notes](https://github.com/jsdom/jsdom/releases )
- [Changelog](https://github.com/jsdom/jsdom/blob/master/Changelog.md )
- [Commits](https://github.com/jsdom/jsdom/compare/16.5.3...16.6.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-24 15:23:28 +02:00
dependabot[bot]
efb5ba52c7
Bump css-loader from 5.2.4 to 5.2.5 ( #13841 )
...
Bumps [css-loader](https://github.com/webpack-contrib/css-loader ) from 5.2.4 to 5.2.5.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases )
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v5.2.4...v5.2.5 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-24 15:23:11 +02:00
dependabot[bot]
92e03fb8f4
Bump eslint from 7.26.0 to 7.27.0 ( #13832 )
...
Bumps [eslint](https://github.com/eslint/eslint ) from 7.26.0 to 7.27.0.
- [Release notes](https://github.com/eslint/eslint/releases )
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md )
- [Commits](https://github.com/eslint/eslint/compare/v7.26.0...v7.27.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-24 13:07:39 +01:00
dependabot[bot]
84c1ac94ca
Bump @rails/webpacker from 5.3.0 to 5.4.0 ( #13834 )
...
Bumps [@rails/webpacker](https://github.com/rails/webpacker ) from 5.3.0 to 5.4.0.
- [Release notes](https://github.com/rails/webpacker/releases )
- [Changelog](https://github.com/rails/webpacker/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rails/webpacker/compare/v5.3.0...v5.4.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-24 13:05:17 +01:00
dependabot[bot]
e3e6eb81ab
Bump @babel/plugin-transform-react-jsx from 7.13.12 to 7.14.3 ( #13831 )
...
Bumps [@babel/plugin-transform-react-jsx](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-transform-react-jsx ) from 7.13.12 to 7.14.3.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.14.3/packages/babel-plugin-transform-react-jsx )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-24 13:02:37 +01:00
rhymes
967c655573
Admin DataUpdateScripts: fix Re-run button label ( #13825 )
2021-05-21 17:35:09 +02:00
rhymes
cfff766d37
[Hotfix] Fix DataUpdateScripts::RemoveSiteConfigScripts script ( #13824 )
2021-05-21 16:34:21 +02:00
Michael Kohl
6dfabd578f
Rename SiteConfig to Settings::General ( #13573 )
...
* Rename SiteConfig
* More renaming
* Update spec
* Update mandatory settings mapping
* More renaming
* e2e test fixes
* You have a rename, and you have a rename
* Spec fix
* More changes
* Temporarily disable specs
* After-merge update
* Undo rename for migration
* undo rename of DUS
* Fix DUS
* Fix merge problem
* Remove redundant DUS
* Fix specs
* Remove unused code
* Change wrong class name
* More cleanup
* Re-add missing values to constant
* Fix constant
* Fix spec
* Remove obsolete fields
* Add accidentally removed field
* Update spec
* Move methods from Settings::General to ForemInstance
* Remove unneeded model
* Change mentions of 'site config'
2021-05-21 14:45:37 +02:00
Jamie Gaskins
b3e5533142
Move print-hidden to a class attribute ( #13821 )
2021-05-20 14:15:48 -04:00
Jacob Herrington
d195270383
Remove DEV specific placeholder text ( #13812 )
...
The input had some placeholder text about "helping beginners with CSS,"
which seems particularly DEV-oriented.
While removing that text I also realized we don't support multi-line
formatting in the place that this is rendered, so the example shouldn't
be a bulleted list.
2021-05-20 11:13:05 -05:00
rhymes
70e0e9b83a
[15 min fix] Fix some autoloading deprecation warnings ( #13793 )
...
* Fix autoloading for RateLimitChecker
* Fix autoloading for ForemStatsClient
* Fix autoloading for middlewares
* Move things to their proper place
* Move middleware usage to the proper place
* Re-add rest-client in datadog driver correctly
* Already required in config/initializers/middlewares.rb
* Bring that back
* Fix Honeybadger spec
2021-05-20 18:10:25 +02:00
Fernando Valverde
5832d146de
Add error handling to clipboard promise - post editor ( #13798 )
...
* Adds error handling to clipboard promise - post editor
* Adds a reload when rendering the Editor to get missing navigator.clipboard
* Remove reload logic from Post Editor
* Adds Honeybadger notify on error handling
2021-05-20 09:46:37 -06:00
dependabot[bot]
873506dd7a
Bump omniauth-apple from 1.0.1 to 1.0.2 ( #13818 )
...
Bumps [omniauth-apple](https://github.com/nhosoya/omniauth-apple ) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/nhosoya/omniauth-apple/releases )
- [Changelog](https://github.com/nhosoya/omniauth-apple/blob/master/CHANGELOG.md )
- [Commits](https://github.com/nhosoya/omniauth-apple/compare/v1.0.1...v1.0.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-20 08:16:19 -06:00
dependabot[bot]
6196eb3c77
Bump stripe from 5.32.1 to 5.33.0 ( #13817 )
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 5.32.1 to 5.33.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v5.32.1...v5.33.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-20 08:05:33 -06:00
Karel De Smet
f9e307a4bd
#13759 : hide content in print mode ( #13794 )
...
* Hide certain article elements on print
* Fix class statement
2021-05-20 10:10:46 +02:00
dependabot[bot]
8606abfbcc
Bump nokogiri from 1.11.4 to 1.11.5 ( #13816 )
...
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri ) from 1.11.4 to 1.11.5.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases )
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.11.4...v1.11.5 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-20 09:00:13 +02:00
Suzanne Aitchison
1ec07d3fe2
Fix UI showing "Following" after unfollowing a user ( #13757 )
...
* manually delete cache key on unfollow
* add cypress test
* move deletecached into own service
* rename and tidy up
* Update cypress/integration/profileFlows/followUser.spec.js
Co-authored-by: Jacob Herrington <jacobherringtondeveloper@gmail.com>
Co-authored-by: Jacob Herrington <jacobherringtondeveloper@gmail.com>
2021-05-19 17:40:38 +01:00
Andrew Bone
ba5e55ae44
Update rbenv-doctor location in docs ( #13803 )
...
* Update with best practices
* Remove useCallback
* Update app/javascript/shared/components/useKeyboardShortcuts.js
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Fill out JSDoc
* Follow Prettier rules
* Resolve conflict
* 📝 Update rbenv-doctor location
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-05-19 08:59:22 -06:00
rhymes
a798bd2f7d
[15 min fix] Fallback to the image URL if Cloudinary/Imgproxy are not configured ( #13767 )
...
* Fallback to the image URL if neither Cloudinary nor Imgproxy are configured
* Fix specs
* Cloudinary api_secret is required
* Update spec/models/message_spec.rb
Co-authored-by: Michael Kohl <citizen428@dev.to>
Co-authored-by: Michael Kohl <citizen428@dev.to>
2021-05-19 15:03:20 +02:00
dependabot[bot]
f39b76b865
Bump webpacker from 5.3.0 to 5.4.0 ( #13801 )
...
Bumps [webpacker](https://github.com/rails/webpacker ) from 5.3.0 to 5.4.0.
- [Release notes](https://github.com/rails/webpacker/releases )
- [Changelog](https://github.com/rails/webpacker/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rails/webpacker/compare/v5.3.0...v5.4.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-19 08:38:28 -04:00
dependabot[bot]
1a0604b3e8
Bump sidekiq-unique-jobs from 7.0.10 to 7.0.11 ( #13800 )
...
Bumps [sidekiq-unique-jobs](https://github.com/mhenrixon/sidekiq-unique-jobs ) from 7.0.10 to 7.0.11.
- [Release notes](https://github.com/mhenrixon/sidekiq-unique-jobs/releases )
- [Changelog](https://github.com/mhenrixon/sidekiq-unique-jobs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/mhenrixon/sidekiq-unique-jobs/compare/v7.0.10...v7.0.11 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-19 08:38:02 -04:00
dependabot[bot]
ff244a31ef
Bump rubocop from 1.14.0 to 1.15.0 ( #13791 )
...
* Bump rubocop from 1.14.0 to 1.15.0
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.14.0 to 1.15.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.14.0...v1.15.0 )
Signed-off-by: dependabot[bot] <support@github.com>
* Enable Style/TopLevelMethodDefinition and fix outstanding violations
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rhymes <github@rhymes.dev>
2021-05-18 15:41:14 +02:00
Michael Kohl
b7ff9aadd1
Clean up SiteConfig ( #13738 )
...
* Remove obsolete SiteConfig values
* Remove DUS
* fixup! Remove obsolete SiteConfig values
* fixup! Remove obsolete SiteConfig values
* Add DUS for removing SiteConfig values
* Fix specs
* Fix specs
* Clean up more DUS
* Update DUS
* Fix remaining spec
* Remove leftover spec
* Fix more specs
* Fix spec
* Remove deprecated spec
* Rearrange specs
* Temporarily disable specs
2021-05-18 09:38:31 +07:00
Michael Kohl
5e05f0fd92
✂✂✂ Remove shop_url from SiteConfig ✂✂✂ ( #13773 )
...
* Remove shop_url from SiteConfig
* Add data update script
2021-05-18 09:03:05 +07:00
dependabot[bot]
c5883e68bf
Bump webpack-bundle-analyzer from 4.4.1 to 4.4.2 ( #13787 )
...
* Bump webpack-bundle-analyzer from 4.4.1 to 4.4.2
Bumps [webpack-bundle-analyzer](https://github.com/webpack-contrib/webpack-bundle-analyzer ) from 4.4.1 to 4.4.2.
- [Release notes](https://github.com/webpack-contrib/webpack-bundle-analyzer/releases )
- [Changelog](https://github.com/webpack-contrib/webpack-bundle-analyzer/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack-contrib/webpack-bundle-analyzer/compare/v4.4.1...v4.4.2 )
Signed-off-by: dependabot[bot] <support@github.com>
* Trigger Travis manually
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rhymes <github@rhymes.dev>
2021-05-17 10:57:09 -06:00
Joe Avila
51969518f5
Change const to var in user_subscription_tag ( #13694 )
2021-05-17 11:40:07 -04:00
dependabot[bot]
e4ecfd2b9e
Bump @babel/core from 7.14.0 to 7.14.2 ( #13788 )
...
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core ) from 7.14.0 to 7.14.2.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.14.2/packages/babel-core )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-17 09:36:24 -06:00
dependabot[bot]
dd6194b5a9
Bump canvas from 2.7.0 to 2.8.0 ( #13783 )
...
Bumps [canvas](https://github.com/Automattic/node-canvas ) from 2.7.0 to 2.8.0.
- [Release notes](https://github.com/Automattic/node-canvas/releases )
- [Changelog](https://github.com/Automattic/node-canvas/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Automattic/node-canvas/compare/v2.7.0...v2.8.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-17 09:12:20 -06:00
Alex
1a0351c2b0
Remove no-op Search::IndexWorker ( #13632 )
2021-05-17 10:17:58 -04:00
Mac Siri
c22128e0ab
Add .yarnclean ( #13770 )
2021-05-17 10:15:25 -04:00
Michael Kohl
8ff86f6107
Remove mentions of creators.forem.com ( #13774 )
2021-05-17 09:49:36 -04:00
dependabot[bot]
8cedf00f6d
Bump @testing-library/user-event from 13.1.8 to 13.1.9 ( #13784 )
2021-05-17 09:48:50 -04:00
dependabot[bot]
7e3512dcad
Bump eslint-plugin-import from 2.22.1 to 2.23.2 ( #13785 )
2021-05-17 09:47:41 -04:00
