Michael Kohl
9c2d33bda0
Check Connect feature flag in more places ( #14795 )
2021-09-23 09:02:27 -05:00
Angel Barros
bb8b32bdf2
Zappat0n/add rate limit model everywhere 11500 ( #14609 )
...
* Create showModalAfterError function
* Show modal when comments rate limit is reached
* Show modal when article reaction rate limit is reached
* Show modal when follow user rate limit is reached
* Show form error when listing creation rate limit is reached
* Show form error when feedback messages rate limit is reached
* Rename functions for listings rate limit checks
* Show modal when notifications reaction rate limit is reached
* Show modal when picture upload rate limit reached
* Show modal for reactable objects when rate limit reached
* Add and modify tests
* empty commit
* Match modal messages to tests
* Fix error updating Modals
Co-authored-by: Dan Uber <dan@forem.com>
2021-09-23 10:49:19 +01:00
dependabot[bot]
48e327dae0
Bump field_test from 0.4.1 to 0.5.0 ( #14792 )
...
Bumps [field_test](https://github.com/ankane/field_test ) from 0.4.1 to 0.5.0.
- [Release notes](https://github.com/ankane/field_test/releases )
- [Changelog](https://github.com/ankane/field_test/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ankane/field_test/compare/v0.4.1...v0.5.0 )
---
updated-dependencies:
- dependency-name: field_test
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-23 10:25:22 +07:00
dependabot[bot]
926d2d41ca
Bump rubocop-rspec from 2.4.0 to 2.5.0 ( #14793 )
...
Bumps [rubocop-rspec](https://github.com/rubocop/rubocop-rspec ) from 2.4.0 to 2.5.0.
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases )
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rspec/compare/v2.4.0...v2.5.0 )
---
updated-dependencies:
- dependency-name: rubocop-rspec
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-22 14:04:24 -05:00
Keshav Biswa
086813afd4
Accessible names for follow buttons ( #14687 )
...
* added aria-pressed value to all follow_buttons
* added check to remove aria pressed attribute and added cypress tests
* removed unfollow aria-label setting and cypress test fixes
* fixed cypress failing tests
* failing cypress test fix
* added steps to check correct states are loaded when page refreshed
* refreshed alias after page reload
2021-09-22 10:34:34 +07:00
Daniel Uber
1746366c9b
Record cassette to import feed from rss for two users ( #14788 )
...
Needs to fetch the rss feed 4 times (once for each user's setting
validation, once for each users import job).
2021-09-21 15:44:15 -05:00
Josh Puetz
7f88e4a722
Add mutable flag to APNS notifcation payload ( #14777 )
2021-09-21 15:37:43 -05:00
Nick Taylor
5fa87246df
Made GitHub CLI install permanent in Gitpod ( #14787 )
2021-09-21 15:27:39 -04:00
dependabot[bot]
910343ff85
Bump gibbon from 3.4.1 to 3.4.2 ( #14786 )
...
Bumps [gibbon](https://github.com/amro/gibbon ) from 3.4.1 to 3.4.2.
- [Release notes](https://github.com/amro/gibbon/releases )
- [Changelog](https://github.com/amro/gibbon/blob/master/CHANGELOG.md )
- [Commits](https://github.com/amro/gibbon/compare/v3.4.1...v3.4.2 )
---
updated-dependencies:
- dependency-name: gibbon
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-21 12:35:02 -06:00
Ridhwana
9d16aa0166
chcek if the element exists before calling onclick on it ( #14785 )
2021-09-21 18:34:49 +02:00
Daniel Uber
3e5d399d82
Ensure seeded listings are valid ( #14784 )
...
This matches the same change made to the db/seeds.rb file at
https://github.com/forem/forem/blob/main/db/seeds.rb#L515
Since there's a validation that Listings are only 12 lines or
shorter, and no technical limit on the length of
`Faker::Markdown.random`'s output, take the first 10 lines only.
2021-09-21 10:31:54 -05:00
Spencer
234156de7d
Fix organization's admin unable to view an article's stats ( #14767 )
...
* update stats action in article_policy
* add rspec test
2021-09-21 16:05:34 +01:00
dependabot[bot]
aef9196a84
Bump puma from 5.4.0 to 5.5.0 ( #14781 )
...
Bumps [puma](https://github.com/puma/puma ) from 5.4.0 to 5.5.0.
- [Release notes](https://github.com/puma/puma/releases )
- [Changelog](https://github.com/puma/puma/blob/master/History.md )
- [Commits](https://github.com/puma/puma/compare/v5.4.0...v5.5.0 )
---
updated-dependencies:
- dependency-name: puma
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-21 08:34:08 -06:00
Nick Taylor
009665ce2a
Gitpod improvements for initial load and persisting gems in container ( #14764 )
2021-09-21 10:32:22 -04:00
Michael Kohl
9f0dfa3181
Add internal top tags API ( #14752 )
...
* Add internal top tags API
* Add rules_html to tag API
* Move tags autocomplete to custom route
* Simplify spec
* Change route from autocomplete to suggest
2021-09-21 15:24:53 +01:00
dependabot[bot]
b4c21ead05
Bump blazer from 2.4.5 to 2.4.6 ( #14780 )
...
Bumps [blazer](https://github.com/ankane/blazer ) from 2.4.5 to 2.4.6.
- [Release notes](https://github.com/ankane/blazer/releases )
- [Changelog](https://github.com/ankane/blazer/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ankane/blazer/compare/v2.4.5...v2.4.6 )
---
updated-dependencies:
- dependency-name: blazer
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-21 07:24:45 -06:00
dependabot[bot]
b7c270dd7f
Bump eslint-plugin-cypress from 2.11.3 to 2.12.1 ( #14775 )
...
Bumps [eslint-plugin-cypress](https://github.com/cypress-io/eslint-plugin-cypress ) from 2.11.3 to 2.12.1.
- [Release notes](https://github.com/cypress-io/eslint-plugin-cypress/releases )
- [Commits](https://github.com/cypress-io/eslint-plugin-cypress/compare/v2.11.3...v2.12.1 )
---
updated-dependencies:
- dependency-name: eslint-plugin-cypress
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-21 06:53:07 -06:00
dependabot[bot]
75b4a460a9
Bump prettier from 2.4.0 to 2.4.1 ( #14771 )
...
Bumps [prettier](https://github.com/prettier/prettier ) from 2.4.0 to 2.4.1.
- [Release notes](https://github.com/prettier/prettier/releases )
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md )
- [Commits](https://github.com/prettier/prettier/compare/2.4.0...2.4.1 )
---
updated-dependencies:
- dependency-name: prettier
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-21 06:52:49 -06:00
Suzanne Aitchison
b7d63a6e8d
workaround getComputedStyle issues in all jest tests ( #14737 )
2021-09-21 10:52:54 +01:00
Suzanne Aitchison
634ec98f11
fix error adding removing tags from article mod tools ( #14769 )
2021-09-21 10:52:37 +01:00
dependabot[bot]
56f772d95d
Bump cypress from 8.4.0 to 8.4.1 ( #14779 )
...
Bumps [cypress](https://github.com/cypress-io/cypress ) from 8.4.0 to 8.4.1.
- [Release notes](https://github.com/cypress-io/cypress/releases )
- [Changelog](https://github.com/cypress-io/cypress/blob/develop/.releaserc.base.js )
- [Commits](https://github.com/cypress-io/cypress/compare/v8.4.0...v8.4.1 )
---
updated-dependencies:
- dependency-name: cypress
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-21 11:07:04 +07:00
dependabot[bot]
a2747aeb1e
Bump bootsnap from 1.9.0 to 1.9.1 ( #14776 )
...
Bumps [bootsnap](https://github.com/Shopify/bootsnap ) from 1.9.0 to 1.9.1.
- [Release notes](https://github.com/Shopify/bootsnap/releases )
- [Changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Shopify/bootsnap/compare/v1.9.0...v1.9.1 )
---
updated-dependencies:
- dependency-name: bootsnap
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-21 11:06:19 +07:00
dependabot[bot]
0e6fdcfba6
Bump rouge from 3.26.0 to 3.26.1 ( #14774 )
...
Bumps [rouge](https://github.com/rouge-ruby/rouge ) from 3.26.0 to 3.26.1.
- [Release notes](https://github.com/rouge-ruby/rouge/releases )
- [Changelog](https://github.com/rouge-ruby/rouge/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rouge-ruby/rouge/compare/v3.26.0...v3.26.1 )
---
updated-dependencies:
- dependency-name: rouge
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-21 10:38:35 +07:00
dependabot[bot]
eda94046d6
Bump svgo from 2.6.0 to 2.6.1 ( #14778 )
...
Bumps [svgo](https://github.com/svg/svgo ) from 2.6.0 to 2.6.1.
- [Release notes](https://github.com/svg/svgo/releases )
- [Changelog](https://github.com/svg/svgo/blob/master/CHANGELOG-old.md )
- [Commits](https://github.com/svg/svgo/compare/v2.6.0...v2.6.1 )
---
updated-dependencies:
- dependency-name: svgo
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-20 16:44:04 -06:00
dependabot[bot]
60e2790cd7
Bump storybook-addon-jsx from 7.3.13 to 7.3.14 ( #14770 )
...
Bumps [storybook-addon-jsx](https://github.com/storybookjs/addon-jsx ) from 7.3.13 to 7.3.14.
- [Release notes](https://github.com/storybookjs/addon-jsx/releases )
- [Changelog](https://github.com/storybookjs/addon-jsx/blob/master/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/addon-jsx/compare/v7.3.13...v7.3.14 )
---
updated-dependencies:
- dependency-name: storybook-addon-jsx
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-20 13:19:07 -06:00
dependabot[bot]
5098d27fb3
Bump jest from 27.2.0 to 27.2.1 ( #14772 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-20 15:09:14 -04:00
dependabot[bot]
36d7de9d1a
Bump parallel from 1.20.1 to 1.21.0 ( #14724 )
...
Bumps [parallel](https://github.com/grosser/parallel ) from 1.20.1 to 1.21.0.
- [Release notes](https://github.com/grosser/parallel/releases )
- [Commits](https://github.com/grosser/parallel/compare/v1.20.1...v1.21.0 )
---
updated-dependencies:
- dependency-name: parallel
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-20 12:13:29 -06:00
dependabot[bot]
d23048006e
Bump cypress-rails from 0.5.2 to 0.5.3 ( #14762 )
...
Bumps [cypress-rails](https://github.com/testdouble/cypress-rails ) from 0.5.2 to 0.5.3.
- [Release notes](https://github.com/testdouble/cypress-rails/releases )
- [Changelog](https://github.com/testdouble/cypress-rails/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testdouble/cypress-rails/compare/v0.5.2...v0.5.3 )
---
updated-dependencies:
- dependency-name: cypress-rails
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-20 11:49:11 -06:00
ludwiczakpawel
987c48771c
padding fix ( #14766 )
2021-09-20 17:45:18 +02:00
Michael Kohl
75d1025023
No longer allow Connect messaging for listings ( #14741 )
2021-09-20 06:20:13 -04:00
dependabot[bot]
01aff342bf
Bump bootsnap from 1.8.1 to 1.9.0 ( #14761 )
...
Bumps [bootsnap](https://github.com/Shopify/bootsnap ) from 1.8.1 to 1.9.0.
- [Release notes](https://github.com/Shopify/bootsnap/releases )
- [Changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Shopify/bootsnap/compare/v1.8.1...v1.9.0 )
---
updated-dependencies:
- dependency-name: bootsnap
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-20 11:13:57 +07:00
Nick Taylor
b83706ab0b
Added GitHub CLI to Gitpod. ( #14763 )
2021-09-17 15:18:21 -04:00
dependabot[bot]
537132875e
Bump oj from 3.13.6 to 3.13.7 ( #14760 )
...
Bumps [oj](https://github.com/ohler55/oj ) from 3.13.6 to 3.13.7.
- [Release notes](https://github.com/ohler55/oj/releases )
- [Changelog](https://github.com/ohler55/oj/blob/develop/CHANGELOG.md )
- [Commits](https://github.com/ohler55/oj/compare/v3.13.6...v3.13.7 )
---
updated-dependencies:
- dependency-name: oj
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-17 12:28:25 -06:00
Andy Zhao
e1606bcb0c
Move pin post to admin ✂️ ( #14739 )
...
* Update pin post button to be an admin articles button instead
* Rename file since we don't pin posts on show page
* Don't use instant click for admin link
* Update tests to visit the article from the start
2021-09-17 14:25:39 -04:00
dependabot[bot]
7a1f6246ee
Bump liquid from 5.0.1 to 5.1.0 ( #14746 )
...
Bumps [liquid](https://github.com/Shopify/liquid ) from 5.0.1 to 5.1.0.
- [Release notes](https://github.com/Shopify/liquid/releases )
- [Changelog](https://github.com/Shopify/liquid/blob/master/History.md )
- [Commits](https://github.com/Shopify/liquid/compare/v5.0.1...v5.1.0 )
---
updated-dependencies:
- dependency-name: liquid
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-17 08:54:03 -06:00
ludwiczakpawel
e7af2bfc86
Little frontend refactor ( #14755 )
...
* profile dropdown update
* dropdown fixes
* preview cards fix
2021-09-17 16:23:51 +02:00
Daniel Uber
57561b1815
Check required inputs for apple authentication ( #14750 )
...
All providers except apple use a common key/secret form partial, but
the apple authentication section uses client_id, key_id, pem, and
team_id.
Assuming all four of these are required, when the enabled provider
name is 'apple', check for those values. For other providers (github,
facebook, etc) only check secret and key as before.
2021-09-17 07:39:53 -05:00
ludwiczakpawel
abd252315a
Style updates ( #14736 )
...
* style fixes
* remove nav headline
* fixes
* spec
* specs again
* specs... geeeeeeez
2021-09-17 08:47:45 +02:00
dependabot[bot]
0644f4e191
Bump blazer from 2.4.3 to 2.4.5 ( #14747 )
...
Bumps [blazer](https://github.com/ankane/blazer ) from 2.4.3 to 2.4.5.
- [Release notes](https://github.com/ankane/blazer/releases )
- [Changelog](https://github.com/ankane/blazer/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ankane/blazer/compare/v2.4.3...v2.4.5 )
---
updated-dependencies:
- dependency-name: blazer
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-17 10:24:33 +07:00
Michael Kohl
c7ba9d81db
Clean up feed-related code ( #14707 )
...
* Start cleaning up feed code
* Move published_articles_by_tag to service
* Add timeframe and latest feed services
* fixup! Move published_articles_by_tag to service
* Move constant to correct location
* Fix spec
2021-09-17 09:23:32 +07:00
ludwiczakpawel
0b547bf8cd
Tabs ( #14738 )
...
* sliding tabs
* Add aria-label to the navigation
This supports the cypress tests, as well as retaining existing accessibility features.
* Adapt feedNavigation cypress test to handle new navigation layout
Before looking for week, month, year, or infinity top feeds, select
"Top" and wait for the page refresh.
* increasing tappable area + making foucs outline visible
Co-authored-by: Dan Uber <dan@forem.com>
2021-09-16 21:42:55 +02:00
Daniel Uber
7147ae4053
Use a textarea for apple_pem in admin ( #14744 )
...
* Since we're pasting a multi-line key, use a textarea for apple_pem
* Update app/views/admin/settings/forms/authentication/_apple_auth_provider_settings.html.erb
set style on pem input to show expected input size.
Co-authored-by: Fernando Valverde <fernando@visualcosita.com>
Co-authored-by: Fernando Valverde <fernando@visualcosita.com>
2021-09-16 12:56:57 -05:00
Ridhwana
69b4c6c5e3
Fix Forem Ownership Field ( #14730 )
...
* fix: mistakenly renamed forem_owner_secret to owner_secret
* chore: revert change from merge
* refactor: use the Forem Instance model
* extra .
2021-09-16 06:56:59 -04:00
dependabot[bot]
0c164b9648
Bump webpacker from 5.4.2 to 5.4.3 ( #14740 )
...
Bumps [webpacker](https://github.com/rails/webpacker ) from 5.4.2 to 5.4.3.
- [Release notes](https://github.com/rails/webpacker/releases )
- [Changelog](https://github.com/rails/webpacker/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rails/webpacker/compare/v5.4.2...v5.4.3 )
---
updated-dependencies:
- dependency-name: webpacker
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-16 10:12:09 +07:00
Arit Amana
aa5f18b234
Admin Save Confirmation - Removing Badge Achievements ( #14684 )
...
* schema file undelete description
* update with main
* update with origin
* update
* create controller; hook up to badge_achievements
* almost done with implementation
* push up what I have
* complete implementation; generalize snackbar usage
* start writing tests
* add confirmation text entry step to test
* Fix delete via JS
* implement danger notice for errors
* complete cypress test
* create ErrorAlert CustomEvent and implement
* fix failing badge_achievements spec
* start applying PR review changes
* hook up Preact Modal
* fix cypress tests
* remove old comment
Co-authored-by: Nick Taylor <nick@forem.com>
* consolidate messaging functions
Co-authored-by: Michael Kohl <citizen428@forem.com>
Co-authored-by: Nick Taylor <nick@forem.com>
2021-09-15 21:25:01 -04:00
dependabot[bot]
ae90186ad7
Bump svgo from 2.5.0 to 2.6.0 ( #14717 )
...
Bumps [svgo](https://github.com/svg/svgo ) from 2.5.0 to 2.6.0.
- [Release notes](https://github.com/svg/svgo/releases )
- [Changelog](https://github.com/svg/svgo/blob/master/CHANGELOG-old.md )
- [Commits](https://github.com/svg/svgo/compare/v2.5.0...v2.6.0 )
---
updated-dependencies:
- dependency-name: svgo
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-15 13:09:17 -06:00
ludwiczakpawel
f1c8de4024
Shortcut for "Following tags" ( #14708 )
...
* following tags shortcut
* rails helper
2021-09-15 20:54:18 +02:00
Alex
a024efcc45
Add display_in_directory setting ( #14733 )
...
* Add display_in_directory setting
* Remove setting from constants
* Update spec to use change
2021-09-15 13:34:31 -04:00
Mac Siri
94d2261d42
Remove #sanitize_and_decode ( #14727 )
2021-09-15 11:05:06 -04:00
Daniel Uber
14e95e6713
Ensure ActiveRecord::Base has descendants before checking triggers ( #14732 )
...
HairTrigger uses the ActiveRecord::Base.descendants to find triggers
in the db (from `models`). WithModel (used in the Settings::Base spec)
clears this during its descendants cleanup, causing this test to
ocassionally fail.
Before checking hairtrigger, if AR::Base descendents is empty, add
ApplicationRecord (there's an assumption here that all of our
application models inherit from application record - this may or may
not be true if we use engine generated models that do not follow this
convention and need to validate triggers there.
2021-09-15 09:29:44 -05:00
