We have decided enable indented-code-block because it is an expected
markdown feature. The trade-off here is that backticks will cause
rendering issues in codeblock.
* Refactor raise_error(specific_error) expectation
The full RSpec warining is
```
WARNING: Using `expect { }.not_to raise_error(SpecificErrorClass)` risks false positives,
since literally any other error would cause the expectation to pass,
including those raised by Ruby (e.g. NoMethodError, NameError and ArgumentError),
meaning the code you are intending to test may not even get reached.
Instead consider using `expect { }.not_to raise_error` or `expect { }.to raise_error(DifferentSpecificErrorClass)`.
```
* Refactor jsitor tests to test behaviour
As pointed out by @rhymes, the previous tests were not
testing actual behaviour. This is an attempt at improving the tests.
* Redo JSitor
- can now accept full url with params
- added more test
- redo jsitor guide
* Jsitor redo guide
- moved below JSFiddle
- add more instructions
* Refactor JSitor liquid tag
- Change the iframe size to 400
- can accept ID with or without params
- added ID_REGEX to check for id
- add more information on error
- added more test
- test for id with invalid link
- test for id with params
- test for id without params
* Refactor
- simplified regex, removed unnecessary groupings
- changed method name from link_valid? to validate_link
- changed error message
* Request change
- Added specific error message
- changed jsitor to JSitor
- changed JSITOR_URL constant to URL_REGEXP
- added space between URL_REGEXP and initialize method
* created jsitor liquid tag
- created a jsitor_tag.rb for jsitor liquid core
- created partial (_jsitor.html.erb) for jsitor liquid tag
* created test for jsitor liquid tag
- created spec for jsitor liquid tag
- generated jsitor_liquid_tag.approved.html
* added suggestion change
- removed regex
- change the full link to embeddable id
- removed dead code(methods) due to change logic
- removed checking of link since embeddable id will be parse as string
- removed parts of the test
- change the guide explanation
* Added lazy loading on iframe
* Add Stack Exchange Liquid tag
* Add Stack Exchange/Overflow tag
* Convert to integers
* Add better error handling
* Make all links open in new tab
* Adjust names and refactor a bit
* Use key for every API call
* Add new lines to end of svg files
* Add better error handling
* Fix edge case where input is not numeric
* Finalize Stackexhange tag design and functionality
* Fix css typo
* Update snapshots
* Fix snapshot back
* Create jsfiddle_tag.rb
Add liquid tag for jsfiddle
* Create jsfiddle_tag-spec.rb
Add liquid tag for jsfiddle
* Update _editor_guide_text.html.erb
Add liquid tag for jsfiddle
* Updates for rubocop
* Edit boilerplate
Change some of the boiler plate code.
* rubocop compliance
* Fixed name
Fixed file name
* Fixed boiler plate
Changed codepen to jsfiddle
* Update guide text
Change the Guide Text to be jsfiddle specific.
Co-Authored-By: Link2Twenty <AndrewB05@gmail.com>
* Fixed typo in spec
Co-Authored-By: Link2Twenty <AndrewB05@gmail.com>
* Update Valid Link
* Update jsfiddle_tag.rb
* Add Approved html
* Remove double slash
* Revert change
* Fix XSS error
* Remove extra line
* Remove extra slash
* Remove extra slash
* Make DRY
* rubocop compliance
* Change test logic
* Revert test to Approvals
* Fix HTML approved
* feat(markdown): add anchors for headers
* Fix markdown anchors impl and spec
* Fixes tests for markdown anchors
* Use name for anchors instead of IDs
* Fix approval file
* Remove emojis in links and hyphenate only spaces
* Remove stream and add new notification views
* Actually remove Stream
* Move followers query to async method
* Remove unused tests and fix query
* Try using without delay instead
* Add without delay and escape HTML
* Make all tests pending for now
* Add liquid tag for Soundcloud
Adds a liquid tag for soundcloud links. Currently does not support customizing autplay, display for comments, or color.
* Strip HTML from Soundcloud tag input
We want to prevent potential XSS exploits, so we sanitize all link input
* Add Soundcloud tag documentation to editor guide
* refactor github tag class
* fix github issue tag spec
* reduce github issue title text on mobile
* pull readme
* octokit wip
* Render repo with Octokit and change error handling
* start syling for github tag
* add styling for github readme tag
* Take darker of user colors
* Andy pushing WIP
* truncates and adds styling for readme
* fix relative image links
* use regex instead of URI join for relative image links
* Fix failing test and approvals
* Lint and clean up github issue styles
* Use heredoc HTML for easier formatting
* Add better error handling for 404 github issues
* Use custom sanitizer for markdown render
* Refactor unless to ternary
* Rename file and tighten up sanitization
* Fix codepen and instagram tag styling