Commit graph

38 commits

Author SHA1 Message Date
Mai Irie
9332ef7123
Reduce Codecov's patch target to 60% (#20095)
* Reduce Codecov's patch target to 50%

* Update codecov.yml

After internal discussion, settled on 60% as the floor for the baseline.

* Code Cov note in PR template
2023-09-15 13:31:22 -04:00
Mai Irie
282afaa6a2
Update PR template to include a11y checklist (#19538) 2023-05-26 12:37:48 -04:00
Ridhwana
0771a5cd2e
Load post_comments billboard asynchronously (#19285)
* feat: add a route to the async_info for display ads

* feat: load the billboard asyncronously

* feat: move the methods to the display_ads controller

* feat: handle params better

* feat: cache control headers

* feat: test fastly caching headers on display ads

* fix: surrogate key test

* feat: use safe navigation operator to handle cases where there is no article id

* fix: article id present then find the article

* feat: add a response test

* Fragment caching

* feat: update the article decorator

* feat: update cache keys for fragment

* feat: remove an empty line

* feat: add article id

* feat: bust cache

* feat: setup dropdown for billboard

* chore: add chunk to same line

* feat: add to safe params for caching

* Update app/controllers/display_ads_controller.rb

Co-authored-by: Joshua Wehner <joshua@forem.com>

* feat: remove the cache deletion

* feat: update the routes to follow a new scope

* feat: update the cache params

---------

Co-authored-by: Joshua Wehner <joshua@forem.com>
2023-04-12 18:15:15 +02:00
Mai Irie
3775f2b06c
PR Template cleanup (#19277)
* PR Template cleanup

Removed some sections we've been using less often to streamline the PR review process.
2023-04-05 11:58:57 -04:00
Kirtan Soni
debdf1f804
updated dead link and added an example gif (#17756)
* updated dead link and added an example gif 

replaced CONTRIBUTING.md#create-a-pull-request with the current one.

* Update PULL_REQUEST_TEMPLATE.md

resolved the change previously made

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>

Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>
2022-06-02 15:30:46 +02:00
Suzanne Aitchison
f36d27a233
remove task boxes (#16626) 2022-02-17 18:13:04 -05:00
Jeremy Friesen
ddd9b2bb12
Adding docs regarding auto-linking PR to issue (#16584)
* Adding docs regarding auto-linking PR to issue

* Apply suggestions from code review

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2022-02-16 08:09:33 -05:00
Ridhwana
69b4c6c5e3
Fix Forem Ownership Field (#14730)
* fix: mistakenly renamed forem_owner_secret to owner_secret

* chore: revert change from merge

* refactor: use the Forem Instance model

* extra .
2021-09-16 06:56:59 -04:00
Christina
82b27d9d61
Update Forem core team only section (#14725)
* Update Forem core team only section

Adding additional clarification for how the team can communicate that they worked on the Admin area so Community Success can update the appropriate docs.

* Updated PR with Michael T's suggestions

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>

Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>
2021-09-13 15:38:56 -06:00
Andy Zhao
3b81172c56
Remove docs from repo ✂✂✂ (#14579)
* Remove docs ✂✂✂✂

* Remove all references to docs and gitdocs

* Update docs.forem.com to developers.forem.com

* Remove .gitdocs_build/

* Update yarn.lock
2021-08-23 17:23:42 -04:00
Jamie Gaskins
f0edbcef90
Add support for versioned releases (#13750)
* Add release scripts

* Use `delete` over `gsub` with an empty string

Co-authored-by: Michael Kohl <citizen428@dev.to>

* wip

* wip

* Include stable release-channel branches in builds

* Add changelog stub

* Include the union of changes to the changelog

* Add things

* Add stuff

* Remove test changelog content

* Fix String#delete call

Extraneous `.` made Ruby parse it as a range

* Fix suggested release command

* Use backticks to denote a command to run

* Add debugging output to script

* Build more appropriate containers for stable

This includes tags

* Check if branch *starts with* release channel name

* Cache tag builds from production tag

* Skip trying to build containers for untagged pushes

* Clear out stubbed changelog

* Update PR template to incorporate CHANGELOG.md

* Run Rubocop on release scripts

This excludes some linter rules that only make sense in code that is
running as part of the Rails app. For example, we can't rely on
`ActiveSupport::TimeWithZone` because these scripts don't load Rails,
and we define top-level methods because they're scripts rather than
complex applications.

Co-authored-by: Michael Kohl <citizen428@dev.to>
2021-07-28 10:10:33 -04:00
Andy Zhao
0eaea33710
Replace admin guide links (#13967)
* Replace admin guide links

* Add missing /docs/

* Add proper links
2021-06-23 15:01:01 -04:00
Michael Kohl
cbb385bf6d
Update test section (#13972) 2021-06-14 18:58:27 +07:00
Josh Puetz
9fe7be190b
Switch references to Forem master branch to main (#12325) 2021-04-16 11:51:06 -05:00
Suzanne Aitchison
65f558e4f2
add some notes re manual testing in pr template and docs (#13414) 2021-04-15 15:03:06 +01:00
Vaidehi Joshi
e94f2f4e31
Update PR template with communicating changes section (#12603)
* Update PR template with communicating changes section

* Combine communicating changes with updating docs section

* Add forem core team only tag to communicating changes

* Specify team over teams
2021-02-10 11:56:56 -08:00
Suzanne Aitchison
00222790fd
Add Storybook as an option for PR documentation (#12573) 2021-02-08 14:21:43 +00:00
Joe Doss
58b7906fe6
GitHub workflow for /ci trigger (#11794)
* GitHub workflow for /ci trigger

Add in GitHub workflow for adding the `ci` label to the PR and running Buildkite
pipeline(s).

The `ci` label will allow the PR to be built on push without havinvg to continuously
issue the `/ci` trigger from a Forem team member.

```
build.pull_request.repository.fork != true || build.pull_request.labels includes "ci"
```

Also using the `/ci` trigger will run the initial pipeline builds too.

* Fix YAML formatting and typos.

* Add note to PR template.

* Conditionally add a comment to a new PR when it originates from a third-party
fork with a note about having to wait for manual approval for our CI to run on
their PR.

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: Michael Kohl <citizen428@dev.to>

* Update .github/workflows/pr.yml

Co-authored-by: Michael Kohl <citizen428@dev.to>

* Adjust if statement to include OWNERS and do startsWith instead of contains.

Co-authored-by: Michael Kohl <citizen428@dev.to>
2020-12-08 08:32:47 -06:00
Sarthak Sharma
6dee5edd0e
🚀 Ability to allow tag moderators to create chat channels (#9741)
* Feature 🚀 : Ability to delete messages in chat channels

- Sending message ID to frontend
- Deleting Message
- Use pusher to delete message realtime

* Minor Bug 🐞: Show message action only for current user

- User can delete or edit their own messages

* Test cases added

* Bug 🐞: Update message id for receiver

Message id was not sent to receiver by pusher

* Refactoring🛠: Message controller refactoring

* Test Cases📝 : Specs for Delete message added

* Feature 🚀 : Ability to edit messages

* Test Cases📝 : Specs for Edit message added

* Merge conflict resolved

* UI completed for Create Channel

* API for create channel & invitations

* 🚀 Combining Backend and Frontend

* Test cases added

* UI completed for Create Channel

* API for create channel & invitations

* 🚀 Combining Backend and Frontend

* Test cases added

* fix suggestions

* add test cases

* replace mod_relations_admin to tag_moderator

* fix test cases

* refactor and fix code climate issues

* Update app/controllers/chat_channel_memberships_controller.rb

Co-authored-by: Michael Kohl <me@citizen428.net>

* fix suggestions

* renaming the methods

* Update app/javascript/chat/chat.jsx

Co-authored-by: Nick Taylor <nick@iamdeveloper.com>

* Update app/javascript/chat/components/createChatModal.jsx

Co-authored-by: Nick Taylor <nick@iamdeveloper.com>

* add jsDoc and add validation

* add PR suggestions

* renmae the file name to  PascalCase

* add styled component

* refactor channel button component

* fix specs

* fix code smell issues

* fix file name issue

* handle error message

* add jsDoc

* Update app/controllers/chat_channels_controller.rb

Co-authored-by: Michael Kohl <me@citizen428.net>

* refactor chat_channel_helpers

* update old hash to new hash

* Update app/javascript/chat/components/ChannelButton.jsx

Co-authored-by: Nick Taylor <nick@iamdeveloper.com>

* Update app/views/chat_channels/index.html.erb

Co-authored-by: Michael Kohl <me@citizen428.net>

* fix syntax error

* Update app/views/chat_channels/index.html.erb

Co-authored-by: Nick Taylor <nick@iamdeveloper.com>

* Policies changed

* The Disable Button issue 🐞

* Fixing Disabled button Issue 🐞

* New group doesn't show up 🐞

Co-authored-by: Narender Singh <narender2031@gmail.com>
Co-authored-by: Michael Kohl <me@citizen428.net>
Co-authored-by: Nick Taylor <nick@iamdeveloper.com>
2020-12-08 13:10:36 +07:00
Lisa Sy
ea00c808bd
Storybook: Add DocsPage and test out static content (#11397)
* Update naming of guidelines section and improve Introduction page

* Add Docs

* Add docs

* Install Docs add-on

- Rename top-level folders and sort manually
- Add MDX static pages

* Updated all Storybook addons to 6.1.3 except for notes as it's currently 5.3.21

* Fixed naming of section for the select component.

* Updated yarn.lock file.

* Added missing dependency @storybook/addon-docs

Co-authored-by: Nick Taylor <nick@dev.to>
2020-12-02 09:56:38 -08:00
Marcy Sutton
89e0ea79bb
Update PR template to prompt for accessibility (#11407)
* Add accessibility section to PR template

* Add accessibility section to Forem docs

* Incorporate PR review feedback
2020-11-18 11:52:57 -05:00
Peter Frank
cbde504e91
Add admin guide to "added to docs?" section of PR template (#11366)
I'm linking to the GitBook generated version (https://forem.gitbook.io/forem-admin-guide/) and not the GitHub repo (https://github.com/forem/forem-admin-guide) but I could see the opposite being better.  Open to suggestions.
2020-11-11 11:33:31 -05:00
Vaidehi Joshi
bbc55e2e7b
Update PR template's "has tests?" section (#11088)
* Update PR template to help prompt us all to think a bit deeper about whether testing a code change is actually possible/doable/necessary before checking “no” in the template.

* Standardize around capitalization in PR template checkboxes
2020-10-26 10:12:04 -07:00
Nick Taylor
ae32687164
Update repository links in PR template (#9760)
* Updated PR template links to https://github.com/forem/forem/...

* Changed DEV to Forem in the wording in the template.
2020-08-12 18:08:56 -04:00
Nick Taylor
1faa7c723f
Updated docs.dev.to to docs.forem.com (#9666) 2020-08-07 11:24:53 -04:00
Vaidehi Joshi
2b6510f4ea
Add QA instructions to pull request template (#8412) 2020-06-11 10:49:39 -07:00
Ridhwana
0373965435
Implement sentence construction changes on PR template (#7588)
* chore: update PR template

* chore: change language

* chore: revert change after triggering build
2020-04-29 09:39:13 -04:00
Nick Taylor
3311023163
Linked to CoC and Contrib guide, plus explicit message about small PRs. (#7569)
* Linked to CoC and Contrib guide, plus explicit message about small PRs.

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-Authored-By: Vaidehi Joshi <vaidehi.sj@gmail.com>

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-Authored-By: Vaidehi Joshi <vaidehi.sj@gmail.com>

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-Authored-By: Vaidehi Joshi <vaidehi.sj@gmail.com>

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-Authored-By: Vaidehi Joshi <vaidehi.sj@gmail.com>

* Made changes based on PR comments.

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2020-04-28 15:37:29 -04:00
rhymes
f14b5f93fe
Update README and contributing guide (#6074)
* Update readme

* Update contributing guide

* Update prepare PR guides to mention draft PRs
2020-02-17 11:53:49 -05:00
Michael Kohl
3f08572306
Update PR template (#5979)
Now questions tests and post-deployment tasks
2020-02-11 18:34:11 -05:00
Jacob Herrington
373140d3d1 Add documentation for PR expectations [ci skip] (#5106)
This change ideally reminds contributors to take steps that make code
review easier on DEV maintainers.
2020-01-09 09:05:26 -05:00
Molly Struve
8f08ad2e99 add optimization option to PR template (#5097) 2019-12-13 08:24:27 -05:00
rhymes
aa54ab541d Add force push notice to the PR template (#3671) [ci skip] 2019-08-09 14:23:46 -04:00
rhymes
83db6b8015 Add notes about force pushing and PR reviews (#3666) 2019-08-09 12:43:40 -03:00
Arit Amana
5c245bdb4e Better alignment of "Select" and "Remove" buttons with Repo Titles in "Integrations" (#836)
* Syncing with Upstream master

* Dev Env Keys - Algolia and Github

* Pull from upstream master

* Remove commented code
2018-10-05 17:37:50 -04:00
Frederik Creemers
5cb8201dd8 Update PULL_REQUEST_TEMPLATE.md (#791) [ci skip]
On macOS, and probably on other operating systems, double clicking a word, selects it. The OS sees underscores as word characters, which isn't the case for hyphens, so that this_word is seen as one word, whereas this-word isn't. Replacing the dashes with underscores makes these placeholders easier to select and replace.
2018-10-02 12:13:32 -04:00
Mac Siri
7447c38d20
Update PULL_REQUEST_TEMPLATE.md 2018-08-16 17:03:41 -04:00
Andy Zhao
40f4997199 Update README/Docs (#670)
* Rename and add addl postgres setup

* Update ToC for docs/readme

* Add links + enrich license FAQ page (#671)

- Added brief "intro" section at the top
- Added back in links that were lost in copy/paste over

* Nick/task/update front end docs [skip ci]

* Clarify that each step is an or

* issue/pr templates

* Remove broken redirect from netlify

* Attempt to add redirects for Netlify

* Try to fix redirects for Netlify

* Added more redirects for netlify

* Fix redirects to use splat keyword

* Testing placeholder instead of splat

* add product roadmap

* Change doc contribution instructions

* Add notice at bottom
2018-08-08 12:40:20 -04:00