Update PR template's "has tests?" section (#11088)
* Update PR template to help prompt us all to think a bit deeper about whether testing a code change is actually possible/doable/necessary before checking “no” in the template. * Standardize around capitalization in PR template checkboxes
This commit is contained in:
parent
dbfed77f37
commit
bbc55e2e7b
1 changed files with 7 additions and 6 deletions
13
.github/PULL_REQUEST_TEMPLATE.md
vendored
13
.github/PULL_REQUEST_TEMPLATE.md
vendored
|
|
@ -33,15 +33,16 @@ as any relevant images for UI changes._
|
|||
|
||||
## Added tests?
|
||||
|
||||
- [ ] yes
|
||||
- [ ] no, because they aren't needed
|
||||
- [ ] no, because I need help
|
||||
- [ ] Yes
|
||||
- [ ] No, and this is why: _please replace this line with details on why tests
|
||||
have not been included_
|
||||
- [ ] I need help with writing tests
|
||||
|
||||
## Added to documentation?
|
||||
|
||||
- [ ] docs.forem.com
|
||||
- [ ] readme
|
||||
- [ ] no documentation needed
|
||||
- [ ] Docs.forem.com
|
||||
- [ ] README
|
||||
- [ ] No documentation needed
|
||||
|
||||
## [optional] Are there any post deployment tasks we need to perform?
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue