From bbc55e2e7bd60943220a4b144751d96f2774b39f Mon Sep 17 00:00:00 2001 From: Vaidehi Joshi Date: Mon, 26 Oct 2020 10:12:04 -0700 Subject: [PATCH] Update PR template's "has tests?" section (#11088) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Update PR template to help prompt us all to think a bit deeper about whether testing a code change is actually possible/doable/necessary before checking “no” in the template. * Standardize around capitalization in PR template checkboxes --- .github/PULL_REQUEST_TEMPLATE.md | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 44062e78c..c98f5ffb7 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -33,15 +33,16 @@ as any relevant images for UI changes._ ## Added tests? -- [ ] yes -- [ ] no, because they aren't needed -- [ ] no, because I need help +- [ ] Yes +- [ ] No, and this is why: _please replace this line with details on why tests + have not been included_ +- [ ] I need help with writing tests ## Added to documentation? -- [ ] docs.forem.com -- [ ] readme -- [ ] no documentation needed +- [ ] Docs.forem.com +- [ ] README +- [ ] No documentation needed ## [optional] Are there any post deployment tasks we need to perform?