Commit graph

8132 commits

Author SHA1 Message Date
Michael Kohl
807efcfdd2
Ignore feed_admin_publish_permission column (#12482) 2021-02-02 13:34:36 +07:00
Katie Davis
c917f916f9
override disabled for comment like usecase (#12517) 2021-02-01 14:19:27 -05:00
dependabot[bot]
551fc75978
Bump eslint from 7.18.0 to 7.19.0 (#12508)
Bumps [eslint](https://github.com/eslint/eslint) from 7.18.0 to 7.19.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v7.18.0...v7.19.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-02-01 12:42:08 -06:00
dependabot[bot]
1452eac8a4
Bump webmock from 3.11.1 to 3.11.2 (#12510)
Bumps [webmock](https://github.com/bblimke/webmock) from 3.11.1 to 3.11.2.
- [Release notes](https://github.com/bblimke/webmock/releases)
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md)
- [Commits](https://github.com/bblimke/webmock/compare/v3.11.1...v3.11.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-02-01 12:41:51 -06:00
dependabot[bot]
efb9ba2f02
Bump start-server-and-test from 1.11.7 to 1.12.0 (#12509)
Bumps [start-server-and-test](https://github.com/bahmutov/start-server-and-test) from 1.11.7 to 1.12.0.
- [Release notes](https://github.com/bahmutov/start-server-and-test/releases)
- [Commits](https://github.com/bahmutov/start-server-and-test/compare/v1.11.7...v1.12.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-02-01 12:11:00 -06:00
dependabot[bot]
fb609703ca
Bump redoc-cli from 0.10.2 to 0.10.3 (#12507)
Bumps [redoc-cli](https://github.com/Redocly/redoc) from 0.10.2 to 0.10.3.
- [Release notes](https://github.com/Redocly/redoc/releases)
- [Changelog](https://github.com/Redocly/redoc/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Redocly/redoc/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-02-01 12:10:47 -06:00
dependabot[bot]
1393845b41
Bump rubocop from 1.8.1 to 1.9.1 (#12506)
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 1.8.1 to 1.9.1.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v1.8.1...v1.9.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-02-01 12:10:05 -06:00
dependabot[bot]
2a779d02d1
Bump database_cleaner-active_record from 1.8.0 to 2.0.0 (#12504)
Bumps [database_cleaner-active_record](https://github.com/DatabaseCleaner/database_cleaner-active_record) from 1.8.0 to 2.0.0.
- [Release notes](https://github.com/DatabaseCleaner/database_cleaner-active_record/releases)
- [Commits](https://github.com/DatabaseCleaner/database_cleaner-active_record/compare/v1.8.0...v2.0.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-02-01 13:09:36 -05:00
dependabot[bot]
9b50ebdb60
Bump capybara from 3.35.1 to 3.35.3 (#12505)
Bumps [capybara](https://github.com/teamcapybara/capybara) from 3.35.1 to 3.35.3.
- [Release notes](https://github.com/teamcapybara/capybara/releases)
- [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md)
- [Commits](https://github.com/teamcapybara/capybara/compare/3.35.1...3.35.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-02-01 18:42:55 +01:00
rhymes
304b8f0e13
Add Message to the postgres.db_table_size dataset on Datadog (#12516) 2021-02-01 12:41:12 -05:00
Molly Struve
5a9235ed81
Remove Hacktoberfest Badge Rake Task (#12495) 2021-02-01 09:59:29 -06:00
Molly Struve
265c4d72c1
Optimization: Set ForemInstance.deployed_at Locally to Better Mirror Production (#12500) 2021-02-01 07:43:23 -06:00
Molly Struve
336eaae64c
Optimization:Add Index to collection_id on Articles (#12496) 2021-02-01 07:03:08 -06:00
Molly Struve
82585464b9
Bug Fix:ForemInstance.deployed_at is a String, not a datetime (#12498) 2021-01-31 14:57:48 -06:00
Molly Struve
113d195051
Bug Fix:Bust Bottom Shell Content on Admin Config Update (#12497) 2021-01-31 13:31:44 -06:00
Andrea Martz
0c0e28dd35
Add missing aria label for campaign close button (#12489) 2021-01-29 17:51:18 -05:00
Mac Siri
8e7cd6a699
Remove last DatadogStatsClient (#12490)
Co-authored-by: Zhao-Andy <17884966+Zhao-Andy@users.noreply.github.com>
2021-01-29 16:11:51 -05:00
Andy Zhao
52abffd4ea
Verify link is available and wait for JS before testing (#12492)
* Remove unused variables

* Use find to ensure JS updates link and then test
2021-01-29 15:42:08 -05:00
Katie Davis
6a660776fa
fix check to remove class from null element (#12488) 2021-01-29 14:10:07 -05:00
dependabot[bot]
9a92945609
Bump @testing-library/user-event from 12.6.0 to 12.6.2 (#12478)
Bumps [@testing-library/user-event](https://github.com/testing-library/user-event) from 12.6.0 to 12.6.2.
- [Release notes](https://github.com/testing-library/user-event/releases)
- [Changelog](https://github.com/testing-library/user-event/blob/master/CHANGELOG.md)
- [Commits](https://github.com/testing-library/user-event/compare/v12.6.0...v12.6.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-29 17:47:43 +01:00
Henry Boisdequin
ccdc5fbfa7
Fix spelling (#12484) 2021-01-29 17:31:11 +01:00
dependabot[bot]
38bf1ad2df
Bump storext from 3.1.0 to 3.3.0 (#12477)
Bumps [storext](https://github.com/g5/storext) from 3.1.0 to 3.3.0.
- [Release notes](https://github.com/g5/storext/releases)
- [Changelog](https://github.com/G5/storext/blob/master/CHANGELOG.md)
- [Commits](https://github.com/g5/storext/compare/v3.1.0...v3.3.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-29 09:50:25 -06:00
Mateusz Hajder
fcc443e1d8
Update GitDocs link (#12485)
The project is already archived, the site on Netlify is down.
2021-01-29 16:20:30 +01:00
Vaidehi Joshi
561c9f74fa
Remove feature request issue template (#12476) 2021-01-29 16:18:46 +01:00
Nick Taylor
a7da74b993
Cleaning Test Runs for End to End (E2E) Tests (#12143)
* Added custom seed task

* Added a test for the initial login for the intial admin of a forem instance.

* Renamed admin login seed data file.

* Pulled functions out of main Cypress plugin file and import them now.

* Added some comments.

* Added a comment about Cypress tasks requiring a return value to be considered successful.

* Moved admin_login_setup seed file to spec folder.

* Made change requests in regards to rake task.

* Fixed reference to SiteConfig

* Created the seeder class to be shared for all seed files.

* Added a missing param to function comment.

* Fixed seeder require in e2e test seed file.

* Fixed seeder require in seeds.rb. Why is Rails.root required?

* Added an environment guard for not being production in the e2e seed task.

* Made seeder require relative.

* Trying something for the Elastic Search issue in CI.

* Revert "Trying something for the Elastic Search issue in CI."

This reverts commit 7cb2a963c8ac1f9242c612a1b9fe8ff814605df6.

* Search indices are now removed via bundle exec rake search:destroy

* Now rake search:destroy is used in the Cypress task for resetting data as well.

* Moved Seeder class to app/lib

* Added cypress-rails

* Got two flows working with db rollbacks.

* Trimmed down the e2e dataset for now.

* Added a custom Cypress command to encompass test setup.

* removed unused e2e rake task

* added some user login/password e2e tests.

* Added a note about Cypress not cleaning cookies, so we do for the moment.

* Removed code no longer required.

* Removed comment in test that is no longer pertinent to the test suite.

* Removed data cleaning plugins as cypress rails gem handles it now.

* Added @citizen428's recommendation got raising an error if trying to seed production.

* Temporarily have paralleziation of e2e tests disabled to figure out cypres-rails/knapsack pro integration.

* Doh! Forgot a semi-colon in the Travis config.

* Added a comment about not integrating cypress-rails/knapsack pro right now.

* Removed knapsack pro npm package for now as we aren't using it.

* Reworded comment about cypress-rails/kanpsackpro.

* Removed seeding for tags to follow for onboarding in e2e seed data.

* Made pree2e script e2e:setup so it only runs explicitly when needed.

* Renamed bin/e2e to bin/e2e-ci.

* Created a new script for local e2e testing.

* Removed RAILS_ENV as it's in the e2e-ci script already.

* Fixed an auto corrected command.

* Fixed wording in e2e script prompt.

* Removed bundle exec rake data_updates:run that I had added. Doesn't appear to be necessary.

* Added missing new lines.

* Renamed e2e seed file and only use that one now. THere are no others.

* Some script cleanup.

* Added a check for the E2E environment so as to not pollute system tests.

* Now e2e test server cleanup occurs when the server shuts down.

* Put puts as this is really just for testing.

* Put environment variable in the proper place for runnning bundle exec.

* Added a check to only run for E2E tests.

* Some bash script formatting.

* Removed copy paste irrelevant comments.

* Updated e2e server shutdown message.

* Now a data-testid attribute is used for finding the user account errors panel.

* Made test selectors ignore casing of text.

* Removed prod paranoia check in e2e seed file.

* Refactored spec to use new cy.loginUser(user) command.

* Update app/lib/seeder.rb

Co-authored-by: Michael Kohl <citizen428@dev.to>

* Fixed flakiness that @aitchiss was experiencing.

* Rubocop fix.

* Due to a Cypress issue, fixing cookie clearing with another tweak.

* Bumped the wait time to 500ms if cookies don't clear.

* Added a 'bundle check' to the bin/e2e script as suggested by @katiedavis.

* Removed some white space

Co-authored-by: Michael Kohl <citizen428@dev.to>
2021-01-29 13:34:01 +01:00
Vaidehi Joshi
154b185f2d
Remove extra asterisks in contributing guide (#12474) 2021-01-29 06:41:29 -05:00
Vaidehi Joshi
5907ff6b2d
Update /contact page with links to filing bug reports + forem.dev (#12475) 2021-01-29 06:40:24 -05:00
dependabot[bot]
5636e48c92
Bump ddtrace from 0.44.0 to 0.45.0 (#12460)
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb) from 0.44.0 to 0.45.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases)
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md)
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v0.44.0...v0.45.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-29 10:30:52 +01:00
Vaidehi Joshi
afb2369bf4
Update Contributing guide to reflect new processes (#12472)
* Update Contributing guide to reflect new processes

* what is pluralization anyways

Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>

Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>
2021-01-28 15:05:03 -08:00
Mac Siri
e4eefb3db5
[Travis] Remove node_modules from cache (#12467) 2021-01-28 16:21:03 -05:00
dependabot[bot]
e81b562a11
Bump twilio-ruby from 5.46.0 to 5.46.1 (#12469)
Bumps [twilio-ruby](https://github.com/twilio/twilio-ruby) from 5.46.0 to 5.46.1.
- [Release notes](https://github.com/twilio/twilio-ruby/releases)
- [Changelog](https://github.com/twilio/twilio-ruby/blob/main/CHANGES.md)
- [Commits](https://github.com/twilio/twilio-ruby/compare/5.46.0...5.46.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-28 15:27:56 -05:00
Mac Siri
5d86877e02
Limit user.touch usage in RepoSyncWorker (#12458) 2021-01-28 12:35:58 -05:00
Katie Davis
9d4b6c36ea
updates article form to have warning modal (#12430) 2021-01-28 11:32:28 -05:00
dependabot[bot]
f1288f8f2f
Bump oj from 3.11.1 to 3.11.2 (#12465)
Bumps [oj](https://github.com/ohler55/oj) from 3.11.1 to 3.11.2.
- [Release notes](https://github.com/ohler55/oj/releases)
- [Changelog](https://github.com/ohler55/oj/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ohler55/oj/compare/v3.11.1...v3.11.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-28 10:02:24 -06:00
dependabot[bot]
6a87cac999
Bump jbuilder from 2.11.1 to 2.11.2 (#12464)
Bumps [jbuilder](https://github.com/rails/jbuilder) from 2.11.1 to 2.11.2.
- [Release notes](https://github.com/rails/jbuilder/releases)
- [Changelog](https://github.com/rails/jbuilder/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rails/jbuilder/compare/v2.11.1...v2.11.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-28 10:01:42 -06:00
dependabot[bot]
931aac916c
Bump bootsnap from 1.5.1 to 1.6.0 (#12463)
Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.5.1 to 1.6.0.
- [Release notes](https://github.com/Shopify/bootsnap/releases)
- [Changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Shopify/bootsnap/compare/v1.5.1...v1.6.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-28 10:01:16 -06:00
dependabot[bot]
a9591dc861
Bump ibm-openapi-validator from 0.34.0 to 0.34.1 (#12462)
Bumps [ibm-openapi-validator](https://github.com/IBM/openapi-validator) from 0.34.0 to 0.34.1.
- [Release notes](https://github.com/IBM/openapi-validator/releases)
- [Changelog](https://github.com/IBM/openapi-validator/blob/master/CHANGELOG.md)
- [Commits](https://github.com/IBM/openapi-validator/compare/v0.34.0...v0.34.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-28 09:59:35 -06:00
dependabot[bot]
867123fec2
Bump puma from 5.1.1 to 5.2.0 (#12461)
Bumps [puma](https://github.com/puma/puma) from 5.1.1 to 5.2.0.
- [Release notes](https://github.com/puma/puma/releases)
- [Changelog](https://github.com/puma/puma/blob/master/History.md)
- [Commits](https://github.com/puma/puma/compare/v5.1.1...v5.2.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-28 09:59:04 -06:00
Rafi
335957edd5
Adding focus trap to trap focus within the modal (#12366)
* Adding focus trap to focus trap in the modal

* Adding yarn lock

* Removing Fragment

* Fixing focus trap casing

* Adding waitFor
2021-01-28 10:18:21 +01:00
Michael Kohl
12a8fbddb5
Add flash message for email confirmation (#12450)
* Add flash message for email confirmation

* Fix spec
2021-01-28 09:32:04 +07:00
Joe Doss
e46b537e91
Add nodejs to the production container since we have removed mini_racer from the (#12457)
Gemfile.
2021-01-27 16:36:30 -06:00
dependabot[bot]
18fc9c597b
Bump ibm-openapi-validator from 0.33.2 to 0.34.0 (#12449)
Bumps [ibm-openapi-validator](https://github.com/IBM/openapi-validator) from 0.33.2 to 0.34.0.
- [Release notes](https://github.com/IBM/openapi-validator/releases)
- [Changelog](https://github.com/IBM/openapi-validator/blob/master/CHANGELOG.md)
- [Commits](https://github.com/IBM/openapi-validator/compare/v0.33.2...v0.34.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-27 15:19:52 -05:00
Kirk Haines
ed74f2f245
Abstract DatadogStatsClient to ForemStatsClient (#12304)
* This change abstracts the DatadogStatsClient into a ForemStatsClient.
The purpose of this abstraction is to set the foundation for a subsequent PR that will allow one to use New Relic for recording Forem stats, instead of Datadog, if there is a New Relic configuration found.
This specific change creates an abstraction layer that can be built upon, without changing any actual default behavior. All specs still pass.

* Use delegate instead of explicit methods.

* Delegate instead of explicit methods.

* Fix the error.

* Refactor according to the suggestions in the comments.

* Ooops.  Stats work better when all of the code is committed.

* Removing the alias of count to increment since that was done in error.
2021-01-27 11:25:44 -05:00
Arit Amana
23f3386f3f
Don't display '0 reactions' on article feed (#12425)
* Implement for Feed Card only

* update snapshot

* write tests

* Implement changes in other article-feed-card views

* modify failing spec

* Address code review comments
2021-01-27 11:13:10 -05:00
dependabot[bot]
8340207728
Bump brakeman from 4.10.1 to 5.0.0 (#12446)
Bumps [brakeman](https://github.com/presidentbeef/brakeman) from 4.10.1 to 5.0.0.
- [Release notes](https://github.com/presidentbeef/brakeman/releases)
- [Changelog](https://github.com/presidentbeef/brakeman/blob/main/CHANGES.md)
- [Commits](https://github.com/presidentbeef/brakeman/compare/v4.10.1...v5.0.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-27 16:35:07 +01:00
dependabot[bot]
e9ff57c14c
Bump preact from 10.5.11 to 10.5.12 (#12447)
Bumps [preact](https://github.com/preactjs/preact) from 10.5.11 to 10.5.12.
- [Release notes](https://github.com/preactjs/preact/releases)
- [Commits](https://github.com/preactjs/preact/compare/10.5.11...10.5.12)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-27 16:34:32 +01:00
dependabot[bot]
1ae878086f
Bump twilio-video from 2.10.0 to 2.11.0 (#12448)
Bumps [twilio-video](https://github.com/twilio/twilio-video.js) from 2.10.0 to 2.11.0.
- [Release notes](https://github.com/twilio/twilio-video.js/releases)
- [Changelog](https://github.com/twilio/twilio-video.js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/twilio/twilio-video.js/compare/2.10.0...2.11.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-27 16:34:03 +01:00
Fernando Valverde
e6883ea63b
Explicitly adds the unique jobs middleware (#12441) 2021-01-27 08:16:55 -06:00
Mac Siri
b76e6839cf
Add a 4th node to Travis (#12442) 2021-01-27 08:48:15 -05:00
Marcy Sutton
f072730f0f
Header navigation dropdown accessibility (#11509)
* Improve keyboard a11y of header menu dropdown

This commit also includes some cleanup of unnecessary functions that seemed to degrade performance.

Closes https://github.com/forem/forem/issues/1154

* Add temporary focus style on navigation-button

* Put menu items in a list

* Adjust menu button based on VoiceOver testing

* Refactor menu logic to be reusable/work on touch

* Preserve admin link visibility

* Focus on first item on menu open

* Clean up some HTML and CSS

* Apply suggestions from code review

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* Ensure menu hides on click outside

* Rename toggle function and adjust formatting

* Update nav button focus style

* Clean up padding on header avatar focus style

* Make button show focus state for keyboard only

Using .focus-visible:focus targets keyboard focus and eliminates a flash of the blue border on click before focus is moved to the child item (which also has no focus style on mouse click)

* Update app/views/layouts/_top_bar.html.erb

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* Add some defensive programming

* Removed initializeTouchDevice from base.js.erb

* navigation-butt ID is now member-menu-button

* Moved all the logic from initializeTouchDevice.js into a pack file/utilities.

* committing re-ordered schema after setup

* add tests for initializeTouchDevice

* remove some unneeded html setup

* make sure menu doesn't close if user tabs back from sign out

* Revert "committing re-ordered schema after setup"

This reverts commit a41a1c861cca3b97d8a7b8a99268b8afaae9f028.

* optimized code

* small tweaks, only show outline when focused

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
Co-authored-by: rhymes <rhymes@hey.com>
Co-authored-by: Nick Taylor <nick@dev.to>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-01-27 09:39:17 +00:00