maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
3021 commits 1 branch 0 tags 1.6 GiB
Commit graph

3021 commits

This branch
This branch
All branches
Author SHA1 Message Date
Nick Taylor
78ccefdc84 Fix image upload button in comment form (#3086) [ci skip] 2019-10-10 17:08:06 -04:00
Huynh Tan
63dbfe79fe Add a proper error message for Link Liquid Tag (#4341) 2019-10-10 15:44:20 -04:00
Michael Kohl
fddb06f053 Refactor classified_listings.rb (#4351) [ci skip] 2019-10-10 14:03:11 -04:00
RakChamp25
e00e7c3412 Refactor : BodyPreview.JSX (#4348) 2019-10-10 13:21:53 -04:00
Jeremy Schuurmans
96eb1a070a Fix ESLint errors in initializeBodyData.js (#4267) 
* fix use global form of use strict error

* fix errors involving functions being used before being defined

* fix undefined function and == errors

* fix redeclared variable name error

* use arrow functions to fix unnamed function warnings

* specify global function at top of file instead of disabling line in eslint, change meta variable name
 2019-10-10 13:17:16 -04:00
Nick Taylor
cc7a3f692a VS Code Settings Update / Frontend Debug Documentation (#4346) 
* Added Edge debug configuration for VS Code.

* Added frontend debug documentation.

* Some copy updates.

* Added the debugging docs to the TOC.
 2019-10-10 13:10:03 -04:00
Juliette de Rancourt
d8e04a0a09 Remove duplication in users_controller.rb (#4337) 
* Remove duplication

* Naming
 2019-10-10 10:48:23 -04:00
Joshua Tzucker
b61db22dc5 [DOC] Update PostgreSQL docs (#4345) [ci skip] 2019-10-10 10:28:17 -04:00
negue
043b7da8de Remove white background in chat (#4182) [ci skip] 2019-10-09 16:53:20 -04:00
Leonid Trofymchuk
5e347a6f94 Simplify key codes expression in Tags component (#4248) 
* Simplifying this key codes expression in Tags component

* Refactor KeyboardEvent keyCode to key

* Simplify cyrillic letter regexp

* Wrap condition in 2 lines
 2019-10-09 16:50:48 -04:00
Austen Madden
ae22dc93a9 Fix broken job specs (#4281) 
* Fix broken job specs

Many job specs were putting their assertions inside a block provided to
ActiveJob's perform_now. Unfortunately, this syntax does not error and
simply ignores the provided block.

The tests were therefore not executing their assertions. As a result
many of them were actually broken to begin with. Many used incorrect
stubbing, were trying to stub instances of models that wouldn't actually
be returned by ActiveRecord queries, etc.

This commit fixes the syntax and does it's best to fix the tests. Many
of these assertions/spec could use more TLC, but this work at least gets
them passing/executing.

* Avoid time comparison precision issues

* Implement review feedback

Adds negative test cases for when record is not found/nil. Also some
formatting changes as I was paying more attention to the rubocop setup
now.

* Add without article context to job spec

* Remove unused lets
 2019-10-09 16:05:32 -04:00
Yash Dave
e7c4310211 Fix eslint issues in initializeSettings.js (#4329) 
- eslint configuration moved comments to a seperate line
  in pre commit hook allowing the eslint-disable-line to
  not work correctly.
- switched to eslint-disable-next-line to fix the same
 2019-10-09 16:05:07 -04:00
Yash Dave
d125d94cbb Fix lint in initializeCommentPreview.js (#4320) [ci skip] 2019-10-09 14:35:37 -04:00
Yash Dave
350e43e62b Fix lint in initializeCommentDate.js (#4319) [ci skip] 2019-10-09 14:33:52 -04:00
Michel
7d530cf002 Fix invalid anchored links due to "//" prefix. (#4340) 2019-10-09 13:57:58 -04:00
rhymes
e579b03af1 Add an alt text and some type="button" attributes (#4331) 
* Add alt text to rainbow dev logo

* Add type=button to buttons
 2019-10-09 13:16:02 -04:00
rhymes
54047f2292 Use a bigger sample for badges titles (#4334) 2019-10-09 13:13:26 -04:00
Sagar Choudhary
1aa0d95de3 Refactor: initializeDashboardSort.js (#4313) 
* Refactor: initializeDashboardSort.js

* change: onchange method to native js eventListener
 2019-10-09 10:32:27 -04:00
Yash Dave
fd1b003334 Refactor/fix initializeCommentDropdown.js (#4318) 
* Fix eslint issues in initializeCommentDropdown.js
- file was already compliant, just needed to add
  'use strict'.

* remove unnecessary eslint rule
 2019-10-09 08:19:08 -04:00
Ben Halpern
3db3f6fdc2
Fix gotchas with color preview and some style adjustments and add documentation (#4322) 2019-10-08 21:32:31 -04:00
Nick Taylor
f7f3380267 Add app/assets/javascripts/lib to eslintignore (#4323) [ci skip] 2019-10-08 18:38:59 -04:00
Andrew Brown
fd5c338659 Allow combining tags together in a search query (#2322) 2019-10-08 18:34:55 -04:00
Arun Kumar Mohan
08f397b36b Delete messages without instantiating ActiveRecord objects (#4183) 2019-10-08 17:29:38 -04:00
Duc Nguyen
2ebe70039a Feat: #3498 Display episode's published_at (#4272) 
* feat: #3498 Display episode's published_at

* feat: #3498 Move methods to decorator

* feat: #3498 Add check if published_at present

* feat: #3498 Add testcase for showing published_at

* Fix build failure #3498

https://travis-ci.com/thepracticaldev/dev.to/builds/130734935

* feat: #3498 Fix testcase failed on Travis 130738295

* feat: #3498 Address comments on PR #4272

* feat: #3498 Delete unused

* feat: #3498 Refactor the use of decorate
 2019-10-08 17:06:46 -04:00
Araslanov Evgeny
14796a9b84 Fix how white space is detected in frontmatter (#4265) 2019-10-08 16:53:10 -04:00
Araslanov Evgeny
60d8a07276 Fix invalid body_markdown in article with video (#4258) [ci skip] 2019-10-08 15:41:44 -04:00
Saurabh Daware
81e3f65965 Add preview for color changes in profile edit (#4212) 2019-10-08 14:52:07 -04:00
Akshay Mahajan
1cf125cb4f Add mod_roundrobin_notifications to user_policy.rb (#4226) [ci skip] 2019-10-08 13:52:20 -04:00
aRtoo
bec5b79120 Fix Github Liquid Tag alignment in notifications page (#4270) [ci skip] 2019-10-08 13:43:26 -04:00
Mac Siri
56bdf6f846
Create scoped policy for internal/comment (#4311) 2019-10-08 12:33:59 -04:00
Sagar Choudhary
a8b61bf781 Refactor: initializeCreditsPage.js (#4312) [ci skip] 2019-10-08 12:33:28 -04:00
dependabot-preview[bot]
57942feb2c Bump sass-rails from 5.1.0 to 6.0.0 (#4288) [ci skip] 
Bumps [sass-rails](https://github.com/rails/sass-rails) from 5.1.0 to 6.0.0.
- [Release notes](https://github.com/rails/sass-rails/releases)
- [Commits](https://github.com/rails/sass-rails/compare/v5.1.0...v6.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2019-10-08 11:47:53 -04:00
Glenn Carremans
179c3150dd [PWA] Add purpose tag to 192x192 (#4220) [ci skip] 2019-10-08 11:31:35 -04:00
Ben Halpern
c0faa20c90
Add more info to architecture (#4233) 
* Add more info to architecture

* Fix various typos and improve clarity in docs
 2019-10-08 11:29:44 -04:00
Victoria Fluharty
e111951ceb fixes bug in tag search feature (#4222) 
* fixes bug in tag search feature
now allows user to type in full name of tag and it does not disappear
makes other changes to pass eslint failing tests
moves methods around according to eslint tests
makes use of prevState callback method due to eslint tests

* updates handleKeyDown method
removes complex logical expression comparison from !== to !=
changes made due to failing task in pull request

* removes commented out code that I added to test code
updates logic to fix searchResults
removes .filter()

* adds comments to fixed code for clarification
 2019-10-08 09:40:53 -04:00
dependabot-preview[bot]
5511e9da63 Bump recaptcha from 5.1.0 to 5.1.1 (#4292) 
Bumps [recaptcha](https://github.com/ambethia/recaptcha) from 5.1.0 to 5.1.1.
- [Release notes](https://github.com/ambethia/recaptcha/releases)
- [Changelog](https://github.com/ambethia/recaptcha/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ambethia/recaptcha/compare/v5.1.0...v5.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2019-10-08 09:10:09 -04:00
Yash Dave
49fbf280c3 Refactor initializeArticleReactions.js (#4303) 
* Refactor initializeArticleReactions.js
- Refactors file according to eslint rules
- Add showModal and sendHapticMessage to globals
  in eslintrc.js
- Shorten initializeArticleReactions() by distributing
  parts of it into jumpToComments() and requestReactionCounts()
- requestReactionCounts() makes an ajax request to get the
  reaction counts
- jumpToComments() jumps to comments element directly if the
  element jump-to-comments is present

* Fix reactionOnClick function to work correctly
- Move sendHapticMessage and showModal global declaration to file
- name function on reaction button on click as addReactionOnClick
  which then calls reactToArticle()
 2019-10-08 08:41:43 -04:00
Karin Hendrikse
a9adeee11f [SPEC] Add tests for sidebarUser component (#4301) [ci skip] 2019-10-07 16:01:59 -04:00
dependabot-preview[bot]
e6b1d6d882 Bump rubocop from 0.74.0 to 0.75.0 (#4287) 
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.74.0 to 0.75.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.74.0...v0.75.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2019-10-07 15:44:43 -04:00
dependabot-preview[bot]
37a12d4bb2 Bump eslint-plugin-react from 7.14.3 to 7.16.0 (#4294) [ci skip] 
Bumps [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from 7.14.3 to 7.16.0.
- [Release notes](https://github.com/yannickcr/eslint-plugin-react/releases)
- [Changelog](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yannickcr/eslint-plugin-react/compare/v7.14.3...v7.16.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2019-10-07 15:38:29 -04:00
dependabot-preview[bot]
3b383cb325 Bump stackprof from 0.2.12 to 0.2.13 (#4291) [ci skip] 
Bumps [stackprof](https://github.com/tmm1/stackprof) from 0.2.12 to 0.2.13.
- [Release notes](https://github.com/tmm1/stackprof/releases)
- [Changelog](https://github.com/tmm1/stackprof/blob/master/CHANGELOG.md)
- [Commits](https://github.com/tmm1/stackprof/compare/v0.2.12...v0.2.13)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2019-10-07 15:25:53 -04:00
dependabot-preview[bot]
21b77dca6d Bump google-api-client from 0.31.0 to 0.32.1 (#4289) [ci skip] 
Bumps [google-api-client](https://github.com/google/google-api-ruby-client) from 0.31.0 to 0.32.1.
- [Release notes](https://github.com/google/google-api-ruby-client/releases)
- [Changelog](https://github.com/googleapis/google-api-ruby-client/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/google-api-ruby-client/compare/0.31.0...0.32.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2019-10-07 15:14:15 -04:00
dependabot-preview[bot]
b6416f986f Bump faker from 2.4.0 to 2.5.0 (#4285) [ci skip] 
Bumps [faker](https://github.com/faker-ruby/faker) from 2.4.0 to 2.5.0.
- [Release notes](https://github.com/faker-ruby/faker/releases)
- [Changelog](https://github.com/faker-ruby/faker/blob/master/CHANGELOG.md)
- [Commits](https://github.com/faker-ruby/faker/compare/v2.4.0...v2.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2019-10-07 15:13:18 -04:00
dependabot-preview[bot]
d63718e521 Bump lint-staged from 9.4.0 to 9.4.1 (#4295) [ci skip] 
Bumps [lint-staged](https://github.com/okonet/lint-staged) from 9.4.0 to 9.4.1.
- [Release notes](https://github.com/okonet/lint-staged/releases)
- [Commits](https://github.com/okonet/lint-staged/compare/v9.4.0...v9.4.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2019-10-07 15:11:54 -04:00
dependabot-preview[bot]
236ce736fe Bump eslint-config-prettier from 6.3.0 to 6.4.0 (#4297) [ci skip] 
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 6.3.0 to 6.4.0.
- [Release notes](https://github.com/prettier/eslint-config-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-config-prettier/blob/master/CHANGELOG.md)
- [Commits](https://github.com/prettier/eslint-config-prettier/compare/v6.3.0...v6.4.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2019-10-07 15:10:43 -04:00
dependabot-preview[bot]
522f734f2f Bump husky from 3.0.7 to 3.0.8 (#4299) [ci skip] 
Bumps [husky](https://github.com/typicode/husky) from 3.0.7 to 3.0.8.
- [Release notes](https://github.com/typicode/husky/releases)
- [Changelog](https://github.com/typicode/husky/blob/master/CHANGELOG.md)
- [Commits](https://github.com/typicode/husky/compare/v3.0.7...v3.0.8)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2019-10-07 15:10:05 -04:00
dependabot-preview[bot]
2008f5c404 Bump rubocop-performance from 1.4.1 to 1.5.0 (#4286) [ci skip] 
Bumps [rubocop-performance](https://github.com/rubocop-hq/rubocop-performance) from 1.4.1 to 1.5.0.
- [Release notes](https://github.com/rubocop-hq/rubocop-performance/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-performance/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-performance/compare/v1.4.1...v1.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2019-10-07 15:06:01 -04:00
Mac Siri
db351b1d53 Update CODEOWNERS [ci skip] 2019-10-07 15:03:03 -04:00
Abbas
dce1b8d2da Update badge index's css (#4278) [ci skip] 2019-10-07 13:59:33 -04:00
Yehuda Neufeld
b5b98c3a37 added print styles to hide header & footer (#4249) 2019-10-07 12:57:36 -04:00