Commit graph

7543 commits

Author SHA1 Message Date
Nick Taylor
779551916a
Fix frontend test setup file (#11623) 2020-11-25 15:27:06 -05:00
Marcy Sutton
c345ff95f7
Start a11y testing checklist in Forem docs (#11614) 2020-11-25 14:22:50 -05:00
Thomas Bnt
3d8049697a
Edited URLs settings/ux to settings/customization (#11618) 2020-11-25 12:29:12 -05:00
rhymes
ba91a3e9e7
Restore fieldsets in Settings/Customization (#11617) 2020-11-25 17:42:27 +01:00
Ben Halpern
a98665fdde
Use content-visibility: auto for small render performance boost (#11560)
* Use content-visibility: auto for small render performance boost

* Remove all but footer
2020-11-25 11:36:36 -05:00
Ben Halpern
a229cfa174
Preserve internal navigation indicator on redirect (#11476)
* Preserve internal navigation indicator on redirect

* Fix test

* Refactor for cleaner reusability

* Add docs
2020-11-25 11:04:19 -05:00
rhymes
369d6e2206
Fix Settings/Customization page (#11615) 2020-11-25 16:47:38 +01:00
Michael Kohl
82108ea8b5
Remove app/labor/random_gif.rb (#11611) 2020-11-25 14:58:32 +00:00
Arit Amana
845e00797b
[EOY 2020] Replace "ban" with "suspend" in Admin (#11581)
* Implement changes

* display "Suspended" if user role.name is banned

* Correct equality symbol

Co-authored-by: Michael Kohl <me@citizen428.net>

Co-authored-by: Michael Kohl <me@citizen428.net>
2020-11-25 09:15:07 -05:00
Spencer
de3d62bc40
API: Endpoint to get an organization's users (#11514)
* add tests

* add route

* add users action to organizations controller

* add jbuilder file

* update api docs

* add recource routes

* make updates to organizations controller

* remove org_users from api docs

* update spec

* add users show jbuilder

* bug fix for user show
2020-11-25 12:50:57 +01:00
Ben Halpern
d5546d6d6b
Don't do serviceworker asset caching in development (#11605) 2020-11-24 19:48:48 -05:00
Molly Struve
dc7d9d5843
Refactor/Optimization:Use more_comments_minimal_weight_randomized_at_end for Signed In Feed (#11604) 2020-11-24 15:36:55 -06:00
Lisa Sy
fc4f6e3b1c
Improve information architecture of Settings (#11347)
* WIP Rename categories and make consistency card titles

* Add rest of sections to Extensions page

* icons

* Reshuffle Integrations and remove unnecessary Integrations tab in controller

* Update rspec tests

* Fix specs

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
Co-authored-by: rhymes <rhymes@hey.com>
2020-11-24 12:26:06 -08:00
Molly Struve
c3b0103eb1
Bug Fix:Remove Score Filter From Tag Mod Index (#11599) 2020-11-24 14:18:14 -06:00
Nick Taylor
ddb70e2900
Batched updated Storybook packages as Storybook is currently broken. (#11598) 2020-11-24 14:58:51 -05:00
rhymes
1741e52e83
Add missing features to new feed importer (#11501)
* Add explanatory comment to how RssReaderFetchUserWorker works

* Add Feeds::ImportWorker worker

* Enable Feeds::Import for single user feed fetching behind a feature flag

* Add Feeds::ValidateUrl service

* Add feature flag to user's validate feed URL feature

* Remove todo notices

* Add feature flag to fetch_all_rss task

* Add feature flag to RssReaderWorker

* Bring back short-circuit for Articles::RssReaderWorker
2020-11-24 18:11:13 +01:00
Mac Siri
5ef6106045
Update JS dependencies with yarn upgrade (#11589) 2020-11-24 11:17:25 -05:00
rhymes
d49c00aa84
Fix email messages link in admin's user page (#11595) 2020-11-24 16:35:14 +01:00
Jacob Herrington
e2f33a37b7
Restore some context in comment (#11587)
rhymes mentioned that this context might be useful regarding this comment.

I removed some of this info in https://github.com/forem/forem/pull/11480, so this commit adds that context along with a link that rhymes shared with me.
2020-11-24 16:08:41 +01:00
dependabot-preview[bot]
c29bff5955
Bump @testing-library/jest-dom from 5.11.5 to 5.11.6 (#11429)
Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) from 5.11.5 to 5.11.6.
- [Release notes](https://github.com/testing-library/jest-dom/releases)
- [Changelog](https://github.com/testing-library/jest-dom/blob/master/CHANGELOG.md)
- [Commits](https://github.com/testing-library/jest-dom/compare/v5.11.5...v5.11.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-24 09:56:55 -05:00
Julianna Tetreault
2dff7c2877
Rewords Public checkbox warning message in SiteConfig (#11580) 2020-11-24 09:52:43 -05:00
Mac Siri
c4fdeeb944
Make Images::Optimizer nil-safe (#11584) 2020-11-24 09:39:34 -05:00
Oskar Janusz
397f426b87
Add Github environments keys to .env_sample file (#11591) 2020-11-24 15:05:17 +01:00
dependabot-preview[bot]
c17ccb4a76
Bump @storybook/addon-knobs from 6.1.2 to 6.1.4 (#11593)
Bumps [@storybook/addon-knobs](https://github.com/storybookjs/storybook/tree/HEAD/addons/knobs) from 6.1.2 to 6.1.4.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.1.4/addons/knobs)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-24 15:04:59 +01:00
Ben Halpern
575449b890
Include core assets in serviceworker cache (#11559) 2020-11-24 08:58:06 -05:00
dependabot-preview[bot]
e063605600
Bump @storybook/addon-links from 6.0.28 to 6.1.3 (#11573)
Bumps [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/addons/links) from 6.0.28 to 6.1.3.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.1.3/addons/links)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-24 09:55:29 +01:00
Michael Kohl
2fd724d191
Update empty reading list copy (#11565)
* Change wording

* Add icon

* Update app/javascript/readingList/readingList.jsx

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
2020-11-24 09:40:04 +07:00
Nick Taylor
bf7780cd2c
Ran prettier on *.js, *.jsx and *.md files. (#11586) 2020-11-23 20:45:50 -05:00
Joe Doss
44569605d2
Fix container composes w/r/t multistage container builds (#11531)
* Use premade development image.

* Use prebuilt container for podman-compose too!

* Fix bundle bundle_finished path.

* Fix docker-compose to work with the Multistage Containerfile

Add root user for Forem containers, fix bundle_finished path and make
webpacker wait for the bundle to finish.

Switch Redis to redis:6.0.9-alpine

* Remove build steps and fix bundle path.

* Merge dev entrypoint into the main one.

* Use merged entrypoint.sh, remove old entrypoint directives, and fix a dockerize bug.

* Make sure unset BUNDLE_WITHOUT and remove without in bundle config.

* Unset BUNDLE_WITHOUT="development:test" as a global ENV.

Also ensure that we remove the without directives for development and testing.
This will make sure that the right gems are installed for each environment.

Removed some unneeded COPYs and remove a commented out RUN.

* Fix ENTRYPOINT on development and testing containers.

* Fix entrypoint and command on rails container.

* Ignore bundle_finished file.

* Fix REDIS_ env vars and adjust podman-compose file.

* Change bundle_finished path and update Yarn docker-compose command.
2020-11-23 15:15:21 -06:00
Nick Taylor
8c22bbd17b
filterXSS is now set up in testSetup.js (#11579) 2020-11-23 14:08:13 -05:00
dependabot-preview[bot]
bf6a48fe5a
Bump @storybook/addon-a11y from 6.0.27 to 6.1.3 (#11571)
Bumps [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/addons/a11y) from 6.0.27 to 6.1.3.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.1.3/addons/a11y)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 12:35:29 -05:00
Ben Halpern
7aca8ac337
Add comment about canonical url (#11574) 2020-11-23 11:35:30 -05:00
dependabot-preview[bot]
f860ca8e14
Bump @storybook/addon-storysource from 6.0.28 to 6.1.2 (#11547)
Bumps [@storybook/addon-storysource](https://github.com/storybookjs/storybook/tree/HEAD/addons/storysource) from 6.0.28 to 6.1.2.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.1.2/addons/storysource)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 17:09:52 +01:00
dependabot-preview[bot]
5bef72ad3d
Bump @storybook/addon-knobs from 6.0.28 to 6.1.2 (#11543)
Bumps [@storybook/addon-knobs](https://github.com/storybookjs/storybook/tree/HEAD/addons/knobs) from 6.0.28 to 6.1.2.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.1.2/addons/knobs)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 10:50:40 -05:00
dependabot-preview[bot]
306105b6d9
Bump @storybook/addon-storyshots from 6.0.28 to 6.1.2 (#11549)
Bumps [@storybook/addon-storyshots](https://github.com/storybookjs/storybook/tree/HEAD/addons/storyshots/storyshots-core) from 6.0.28 to 6.1.2.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.1.2/addons/storyshots/storyshots-core)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 10:50:15 -05:00
Molly Struve
abbc29dafe
Bug Fix:User >= when filtering by SiteConfig.home_feed_minimum_score (#11567) 2020-11-23 09:13:03 -06:00
dependabot-preview[bot]
392d3ef5c6
Bump elasticsearch from 7.9.0 to 7.10.0 (#11554)
* Bump elasticsearch from 7.9.0 to 7.10.0

Bumps [elasticsearch](https://github.com/elastic/elasticsearch-ruby) from 7.9.0 to 7.10.0.
- [Release notes](https://github.com/elastic/elasticsearch-ruby/releases)
- [Changelog](https://github.com/elastic/elasticsearch-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/elastic/elasticsearch-ruby/compare/v7.9.0...v7.10.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump elasticsearch from 7.9.0 to 7.10.0 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 09:46:47 -05:00
Michael Kohl
894b1b94c7
Remove UnreadNotificationsEmailer (#11561) 2020-11-23 14:15:07 +00:00
dependabot-preview[bot]
fc1e7442ee
Bump feedjira from 3.1.1 to 3.1.2 (#11552)
* Bump feedjira from 3.1.1 to 3.1.2

Bumps [feedjira](https://github.com/feedjira/feedjira) from 3.1.1 to 3.1.2.
- [Release notes](https://github.com/feedjira/feedjira/releases)
- [Changelog](https://github.com/feedjira/feedjira/blob/master/CHANGELOG.md)
- [Commits](https://github.com/feedjira/feedjira/compare/v3.1.1...v3.1.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump feedjira from 3.1.1 to 3.1.2 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 07:45:35 -06:00
dependabot-preview[bot]
cc4a17992a
Bump devise_invitable from 2.0.2 to 2.0.3 (#11553)
* Bump devise_invitable from 2.0.2 to 2.0.3

Bumps [devise_invitable](https://github.com/scambra/devise_invitable) from 2.0.2 to 2.0.3.
- [Release notes](https://github.com/scambra/devise_invitable/releases)
- [Changelog](https://github.com/scambra/devise_invitable/blob/master/CHANGELOG.md)
- [Commits](https://github.com/scambra/devise_invitable/compare/v2.0.2...v2.0.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump devise_invitable from 2.0.2 to 2.0.3 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 13:57:36 +01:00
dependabot-preview[bot]
be8828e72c
Bump ddtrace from 0.42.0 to 0.43.0 (#11538)
* Bump ddtrace from 0.42.0 to 0.43.0

Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb) from 0.42.0 to 0.43.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases)
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md)
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v0.42.0...v0.43.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump ddtrace from 0.42.0 to 0.43.0 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 13:17:34 +01:00
Rafi
f88bf5a0b1
Fixing overflow of comment button (#11562) 2020-11-23 12:17:30 +01:00
dependabot-preview[bot]
04aefdf06c
Bump blazer from 2.2.8 to 2.3.0 (#11548)
* Bump blazer from 2.2.8 to 2.3.0

Bumps [blazer](https://github.com/ankane/blazer) from 2.2.8 to 2.3.0.
- [Release notes](https://github.com/ankane/blazer/releases)
- [Changelog](https://github.com/ankane/blazer/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ankane/blazer/compare/v2.2.8...v2.3.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump blazer from 2.2.8 to 2.3.0 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 12:16:10 +01:00
dependabot-preview[bot]
9ba251fccb
Bump @babel/plugin-transform-react-jsx from 7.12.5 to 7.12.7 (#11537)
Bumps [@babel/plugin-transform-react-jsx](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-transform-react-jsx) from 7.12.5 to 7.12.7.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.12.7/packages/babel-plugin-transform-react-jsx)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 05:59:49 -05:00
dependabot-preview[bot]
6f8511466e
Bump rubocop-performance from 1.8.1 to 1.9.0 (#11546)
* Bump rubocop-performance from 1.8.1 to 1.9.0

Bumps [rubocop-performance](https://github.com/rubocop-hq/rubocop-performance) from 1.8.1 to 1.9.0.
- [Release notes](https://github.com/rubocop-hq/rubocop-performance/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-performance/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-performance/compare/v1.8.1...v1.9.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump rubocop-performance from 1.8.1 to 1.9.0 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 10:31:37 +01:00
dependabot-preview[bot]
fc744eea1e
Bump knapsack_pro from 2.8.0 to 2.9.0 (#11544)
* Bump knapsack_pro from 2.8.0 to 2.9.0

Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby) from 2.8.0 to 2.9.0.
- [Release notes](https://github.com/KnapsackPro/knapsack_pro-ruby/releases)
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v2.8.0...v2.9.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump knapsack_pro from 2.8.0 to 2.9.0 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 10:16:12 +01:00
Oskar Janusz
39daa21add
Update Copy for Orgs Call-to-action Box (#11534) 2020-11-23 10:15:34 +01:00
dependabot-preview[bot]
f1b00f2376
Bump counter_culture from 2.6.2 to 2.7.0 (#11541)
* Bump counter_culture from 2.6.2 to 2.7.0

Bumps [counter_culture](https://github.com/magnusvk/counter_culture) from 2.6.2 to 2.7.0.
- [Release notes](https://github.com/magnusvk/counter_culture/releases)
- [Changelog](https://github.com/magnusvk/counter_culture/blob/master/CHANGELOG.md)
- [Commits](https://github.com/magnusvk/counter_culture/compare/v2.6.2...v2.7.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump counter_culture from 2.6.2 to 2.7.0 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 10:05:27 +01:00
dependabot-preview[bot]
9fe452fdb5
Bump prettier from 2.1.2 to 2.2.0 (#11545)
Bumps [prettier](https://github.com/prettier/prettier) from 2.1.2 to 2.2.0.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/master/CHANGELOG.md)
- [Commits](https://github.com/prettier/prettier/compare/2.1.2...2.2.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 10:04:23 +01:00
dependabot-preview[bot]
8cceb1aaec
Bump eslint from 7.11.0 to 7.14.0 (#11542)
Bumps [eslint](https://github.com/eslint/eslint) from 7.11.0 to 7.14.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v7.11.0...v7.14.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 10:02:06 +01:00