maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
3687 commits 1 branch 0 tags 1.6 GiB
Commit graph

3687 commits

This branch
This branch
All branches
Author SHA1 Message Date
Nick Schwaderer
74da1ffc59 No longer hide reactions and follows after 24 hours (#5314) 
* No longer hide reactions and follows after 24 hours
* Removes unused scope without_past_aggregations

Co-authored-by: Molly Struve <mollylbs@gmail.com>
 2020-01-09 11:49:55 -05:00
rhymes
7dd2ae9fe0 Remove notifiable access from articles and comments notifications (#5415) [deploy] 
* Add created_at to comment notification data

* Remove notifiable usage from notifications partials

* Fix typo
 2020-01-09 10:19:45 -05:00
Jacob Herrington
41c3164553 Skip negative reactions for unpublished content (#5392) [deploy] 
If content is unpublished it shouldn't be immediately necessary for
negative reactions to be acted on.

There is a higher touch solution here, but I'm not sure it's warranted.
 2020-01-09 10:06:45 -05:00
Mukesh Chaudhary
48edaab5bc Migrate new reaction job 5305 (#5401) 
* Add New Reaction Worker

* Add Specs for the New Reaction Worker

* Update Worker Calls in Notification Model

* Update Notification Model Specs

* Fix Code Climate Issues

* Fix notification specs to remove instance variable and complex logic

* Fix Worker Spec

* Fix Review Comments

* Undo Job Specs

Co-authored-by: Mukesh Chaudhary <45253983+mukeshchdy@users.noreply.github.com>
 2020-01-09 09:51:56 -05:00
Mehdi Vasigh
29a734b698 fix totalCount getting an array instead of a number (#5359) 2020-01-09 09:47:55 -05:00
Jacob Herrington
373140d3d1 Add documentation for PR expectations [ci skip] (#5106) 
This change ideally reminds contributors to take steps that make code
review easier on DEV maintainers.
 2020-01-09 09:05:26 -05:00
Molly Struve
86e138662a
remove persist audit job and do it inline (#5355) [deploy] 2020-01-09 08:49:22 -05:00
Asha Balasubramaniam
91663231cc Remove delayed job that calculates comment score (#5412) [deploy] 
Get rid of the delayed job and corresponding spec. Follow up to https://github.com/thepracticaldev/dev.to/pull/5382
 2020-01-09 08:25:03 -05:00
rhymes
d2e96007c7 Fix (some) n+1/eager loading issues (#5294) [deploy] 
* Remove mock from specs to test the actual Suggester

* Fix articles API top articles n+1

* Fix n+1 in articles API with state parameter

* Remove eager loading for organization dashboard

* Eager load notifiables in notifications only when needed

* Algolia does not like this
 2020-01-08 18:48:24 -05:00
Michael Kohl
8006de06ea Add 'overflow-y: scroll' to .user-metadata-details (#4803) 
Users with too much/too long profile information where overflowing the section which
made some of their information inaccessible.
 2020-01-08 18:05:52 -05:00
Alain Mauri
5055121361 Remove Chat Channels Index Job (#5409) [deploy] 2020-01-08 16:33:40 -05:00
Pablo Ifrán
f5d3593d4f Change the way that id_code was created (#5348) [deploy] 
The column id_code was created with a job in an after create callback,
that was replaced by an inline creation of the attribute
 2020-01-08 16:21:39 -05:00
Anna Buianova
e09e46ec99 Creating podcasts by users (#3730) [deploy] 
* Create podcast as a user [WIP]

* Sample css for podcast form

* Nicer podcasts suggesting form

* Validate podcast feed_url

* Validate podcast main_color_hex

* Fix podcasts specs

* Fix form appearance

* Placeholder for podcast main_color_hex

* Provide a link to suggest a podcast

* Add a checkbox and a role for when a podcast is added by an owner

* Prettier checkbox in the podcasts form

* Added creator to podcasts

* Set the podcast creator

* Fix the /pod spec

* Added creator information to the internal podcast page

* Added cta class to the podcasts submit button

* Global notice when a podcast was suggested

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
 2020-01-08 16:14:25 -05:00
rhymes
482a77a375 Restore default email from SiteConfig for mailers (#5399) [deploy] 
* Restore default email from SiteConfig for mailers

* Fix broken email preview
 2020-01-08 16:09:32 -05:00
gverger
b7bb006d70 Fix ProMembership Time flaky test (#5402) 
After traveling back in time, it can be the case that between the call
to the service and the moment we check the current time, we moved on to
the next second.

Using Timecop.freeze takes care of that.
 2020-01-08 16:06:10 -05:00
Maykon Menezes
a9cb13c3f6 moving org bust cache job to sidekiq (#5406) [deploy] 2020-01-08 15:03:40 -05:00
Cadu Ribeiro
00a97b2051 Migrate Users/FollowJob to Sidekiq (#5403) 2020-01-08 15:03:18 -05:00
Molly Struve
7c939dc2c5
Remove TouchFollowerJob and do user update inline (#5391) [deploy] 2020-01-08 14:12:04 -05:00
Asha Balasubramaniam
1003f71c8f Migrate delayed job that calculates comment score to sidekiq (#5382) 2020-01-08 14:11:31 -05:00
rhymes
fec196ffe3 Add wait_for_javascript to flaky system tests (#5405) 2020-01-08 13:47:08 -05:00
Molly Struve
9dc1f51a79
Update Heroku Release to Migrate and Load App (#5404) [deploy] 2020-01-08 13:43:00 -05:00
Molly Struve
64ca1e7638
Set type for user_selects_looking_for_work_spec to system (#5390) 2020-01-08 12:16:33 -05:00
rhymes
102e1a6b9c Routine rubocop fixes (#5386) 2020-01-08 09:05:12 -05:00
Jacob Herrington
82bc17d667
Fix erblint errors (#5395) 
This is a workaround that I found in another repository:

dbd7af822b

I'm not sure if anyone else is seeing these errors, but locally the
pre-commit hooks fail every time I create a commit that touches an erb
file.
 2020-01-07 18:53:27 -06:00
Molly Struve
8a630b1896 Set default email in application mailer using ENV variable (#5394) [deploy] 
* Set default email in application mailer using ENV variable

* remove readonly

* replace siteconfig with ENV variable for more mailers
 2020-01-07 19:10:46 -05:00
mstruve
21e64bfb46 Make default email Siteconfig read only 2020-01-07 18:50:00 -05:00
Molly Struve
d039a61177 Remove SiteConfig From Org Validation (#5393) [deploy] 
* Make default_site_email readonly so Rails can load first

* Change Org validation message and remove readonly so configs can be updated

* Change Org validation message and remove readonly so configs can be updated TRY 2
 2020-01-07 18:04:13 -05:00
Michael Kohl
728a05c476 Move from env variables to SiteConfig (#5385) [deploy] 
* Move from env variables to SiteConfig

Related to #5384

This PR only deals with the first remaining part outlined in the issue, starting to use existing SiteConfig keys instead of the env variables.

* Restore Envfile to original version for now
 2020-01-07 16:36:24 -05:00
Molly Struve
6b23e327aa
Track Queue sizes and latency for Sidekiq (#5352) [deploy] 2020-01-07 11:57:13 -05:00
Molly Struve
aa7b76d9a2
Limit ALL Upload file sizes to 25 MB (#5356) [deploy] 2020-01-07 11:20:40 -05:00
Cadu Ribeiro
4d7d3edb2d Remove Articles/BustMultipleCachesJob (#5388) 
This is a follow up from #5309.
This commit removes the Articles/BustMultipleCachesJob after we migrated
it to Sidekiq.
 2020-01-07 11:20:06 -05:00
Jacob Herrington
44403eba89 Fix suggested tweets UI (#5380) 
* Remove console log

* Update suggest tweets layout

These changes reflect a specific request from Michael to fix the layout
of suggested tweets, including the expected border animation that occurs
on form submits for articles

* Add labels for suggested tweets
 2020-01-07 11:00:48 -05:00
serena
252027ad9c use new_badge_achievement_worker instead of active job (#5358) [deploy] 2020-01-07 08:16:17 -05:00
Jacob Herrington
73dccaaea6 Fix internal/reports email form (#5383) [deploy] 
The UI refactor broke this query selector.
 2020-01-06 18:53:56 -05:00
dependabot-preview[bot]
389cb12372 Bump octokit from 4.14.0 to 4.15.0 (#5364) [deploy] 2020-01-06 16:27:08 -05:00
dependabot-preview[bot]
1c2a0816f6 Bump codemirror from 5.50.0 to 5.50.2 (#5363) 2020-01-06 16:23:12 -05:00
dependabot-preview[bot]
4ee7d7e60a Bump faker from 2.9.0 to 2.10.0 (#5366) 2020-01-06 16:07:54 -05:00
Molly Struve
d5b3a10061 Handle Missing article_id When Loading additional_content_boxes (#5376) 2020-01-06 15:56:49 -05:00
Molly Struve
a572a96921
Remove comments user_touch job and do it inline when comment is created (#5378) [deploy] 2020-01-06 15:52:59 -05:00
Molly Struve
bc8c177966
Record db table sizes in datadog where we can use them to generate relevant alerts (#5377) 2020-01-06 15:52:47 -05:00
Molly Struve
bc2dbd8e7f
Move Events::BustCacheJob to Sidekiq and rename (#5379) 2020-01-06 15:51:46 -05:00
dependabot-preview[bot]
3188b37762 Bump pg from 1.1.4 to 1.2.1 (#5369) 2020-01-06 14:50:41 -05:00
Lucas Hiago
6ff43ffcbe Refactor method in user_decorator.rb (#5360) [deploy] 
* Refactor method in user_decorator.rb

* Add a constant for white text color
 2020-01-06 14:21:29 -05:00
dependabot-preview[bot]
091fbbc6d7 Bump google-api-client from 0.36.3 to 0.36.4 (#5367) 
Bumps [google-api-client](https://github.com/google/google-api-ruby-client) from 0.36.3 to 0.36.4.
- [Release notes](https://github.com/google/google-api-ruby-client/releases)
- [Changelog](https://github.com/googleapis/google-api-ruby-client/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/google-api-ruby-client/compare/0.36.3...0.36.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-01-06 14:20:39 -05:00
Cadu Ribeiro
93514e73df Migrate Articles/BustMultipleCachesJob to Sidekiq (#5309) [deploy] 
Related to: #5305

In order to move all the jobs to Sidekiq, this commit creates a new
Articles/BustMultipleCachesWorker using Sidekiq based on the
Articles/BustMultipleCachesJob (this one is not removed until we know
that any job on this one will be performed).
 2020-01-06 13:42:34 -05:00
dependabot-preview[bot]
d5621bc7d4 Bump rubocop from 0.78.0 to 0.79.0 (#5365) 
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.78.0 to 0.79.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.78.0...v0.79.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-01-06 13:15:52 -05:00
dependabot-preview[bot]
1c915062fd Bump capybara from 3.29.0 to 3.30.0 (#5370) 
Bumps [capybara](https://github.com/teamcapybara/capybara) from 3.29.0 to 3.30.0.
- [Release notes](https://github.com/teamcapybara/capybara/releases)
- [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md)
- [Commits](https://github.com/teamcapybara/capybara/compare/3.29.0...3.30.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-01-06 13:15:33 -05:00
dependabot-preview[bot]
82d37efce0 Bump yard from 0.9.20 to 0.9.23 (#5371) 
Bumps [yard](https://github.com/lsegal/yard) from 0.9.20 to 0.9.23.
- [Release notes](https://github.com/lsegal/yard/releases)
- [Changelog](https://github.com/lsegal/yard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/lsegal/yard/compare/v0.9.20...v0.9.23)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-01-06 13:15:14 -05:00
dependabot-preview[bot]
120d14c40b Bump stackprof from 0.2.13 to 0.2.15 (#5372) 
Bumps [stackprof](https://github.com/tmm1/stackprof) from 0.2.13 to 0.2.15.
- [Release notes](https://github.com/tmm1/stackprof/releases)
- [Changelog](https://github.com/tmm1/stackprof/blob/master/CHANGELOG.md)
- [Commits](https://github.com/tmm1/stackprof/compare/v0.2.13...v0.2.15)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-01-06 13:15:01 -05:00
Molly Struve
1966c449ed
scope error message correctly for InvalidAuthenticityToken error (#5375) [deploy] 2020-01-06 11:45:28 -05:00