Commit graph

428 commits

Author SHA1 Message Date
Ben Halpern
71c94b6546
Fix boosted posts and add spec (#521) 2018-06-28 17:22:02 -04:00
Mac Siri
6bae46fbbf Remove escaping of user_params (#500)
* Remove the need to escape user_params

* Fix lint

* Permit password and password_confirmation

* Fix lint
2018-06-28 15:56:24 -04:00
Ben Halpern
799aa16378
Fix /live for workshop (#516) 2018-06-28 14:28:24 -04:00
Tiffany Wismer
414d259c0d Fixed errors in last pull request (#502) 2018-06-28 12:11:04 -04:00
Ben Halpern
7e9280390c
Add /survey and modified several page titles (droped the the) (#515)
* Add /survey and modified several page titles (droped the the)

* Add emojis to page title
2018-06-28 11:07:42 -04:00
Edem Attikese
0ad8cd9eab Edem/improvements/pundit coverage (#498)
* added organization policy + spec

* user specs for is_org_admin?

* added authroize to organization controller

* admin policy + specs

* deleted enforce admin due to pundit policy redundancy

* applied admin policy to entire admin namespace

* refactoring analytics controller WIP - wanna test codeship

* Add protection against reactions to unpublished articles (#473)

* Add chat channel policy and spec (#474)

* Add comment policy and specs (#475)

* Fix edge case with apostrophes

* Add comment policy and specs

* Add login for deleting comment spec

* Change test to raise pundit error instead of 404

* Clean up comment destroy request specs

* Remove redundant raise

* Whitelist columns on to_json call (#477)

* Add pundit policy for several controllers (#476)

* Add pundit policy for several controllers

* Adjust video spec

* Fix tag request specs

* Add proper twilio tokens request specs

* Remove puts statements

* Add a couple basic request specs (#478)

* Add a few tests and fix user tag color bug (#482)

* Refactor handle_tag_index in stories_controller (#481)

* Modify valid_request_origin? (#483)

* Add misc specs and remove banned attribute from user model (#484)

*  Fix missing Cloudinary tags and misc specs (#486)

* removing current_user_is_admin? to use .is_admin? method

* added missing org policy routes

* Add comment for all public controllers

* Fix edge case for test

* Authorize mod controller and add specs

* Refactor methods via inheritance and use only super_admin role

* Create policy method for analytics via article_policy and refactor

* Capitalize all buttons in dashboard page

* Fix org tests and remove old admin test

* Use only happy path for analytics

* Fix tests to use Pundit error

* Update org_policy spec
2018-06-28 09:38:20 -04:00
Ben Halpern
441a1ba8b8
Make channels list scroll to top on change (#514) 2018-06-27 22:30:38 -04:00
Ben Halpern
51ddc2f4fa
Track query across filters (#513) 2018-06-27 22:21:18 -04:00
Ben Halpern
62fc45865c
Add sticky activechannel during filtering (#511) 2018-06-27 21:46:58 -04:00
Ben Halpern
5842b73d6c
Add filters (#510) 2018-06-27 21:25:25 -04:00
Ben Halpern
d67bd4c13e
Add connect filters (#509) 2018-06-27 21:19:04 -04:00
Ben Halpern
258a6ea74f
Add filter buttons to /connect (#508) 2018-06-27 21:14:06 -04:00
Ben Halpern
b8d2c0033e
Get /connect pagination working (for real in prod I hope) (#507) 2018-06-27 18:47:06 -04:00
Ben Halpern
aaba866b87
Modify /connect to try to get pagination working in prod (#505) 2018-06-27 17:51:38 -04:00
Ben Halpern
a89433596b
Small /connect adjustment (#504) 2018-06-27 16:24:35 -04:00
Ben Halpern
5194c9828c
Add proper pagination and fix small issues with /connect (#503)
* Add proper pagination and fix small issues with /connect
2018-06-27 16:06:15 -04:00
Mac Siri
76132e6650 Update .rubocop.yml (#499) 2018-06-27 09:54:09 -04:00
Meghan
e27a0d2578 stop scrollbar from appearing on profiles with long names (#488)
should fix #335
2018-06-26 15:20:24 -04:00
Yechiel Kalmenson
f7a826cc17 open links in chats in new tabs (#492) 2018-06-26 14:40:05 -04:00
Andy Zhao
cd9f6d9ada [Done] Add BDEFGI Policies and Specs (#487)
* Add comment for public controllers

* Add block policy and specs

* Add policy for authorizing dashboard

* Add follow policy and specs

* Refactor a tiny bit

* Prevent banned users from following anything

* Add a note for email sub controller about auth

* Add image upload policies

* Add policy for github repos

* Fix typo and use correct github repo variable

* Fix image uploader and use regular params

* Add authenticate_user before action back in

* Rename test

* Update slack bot message formatting and fix reported URL
2018-06-26 09:23:07 -04:00
Ben Halpern
75d3a79c12
Add search_keywords record and associated functionality (#494)
* Add search_keywords record and associated functionality

* Fix test and add badge rewarder method
2018-06-25 11:58:07 -04:00
Nick Taylor
7d64ae8d09 Added documentation for the front-end. (#491) 2018-06-24 18:32:45 -04:00
Mac Siri
dd5a22dc80 Create UserPolicy (#480)
* Fix lint

* Create User#settings_tab_list

* Remove UsersController#finish_signup

* Remove UsersController#index

* Create UserPolicy WIP

* Replace UsersController's spec with request spec

* Fix broken specs

* Fix broken specs

* Remove comment

* Upgrade UserPolicy

* Fix specs
2018-06-22 20:40:08 -04:00
Ben Halpern
5a59b4c8a9
Fix missing Cloudinary tags and misc specs (#486) 2018-06-22 16:29:17 -04:00
Ben Halpern
0755a07713
Add misc specs and remove banned attribute from user model (#484) 2018-06-22 16:06:04 -04:00
Ben Halpern
b44a3eecc2
Modify valid_request_origin? (#483) 2018-06-22 13:38:19 -04:00
Tiffany Wismer
7f0f2328c0 Refactor handle_tag_index in stories_controller (#481) 2018-06-22 10:40:11 -04:00
Ben Halpern
03e4f6531f
Add a few tests and fix user tag color bug (#482) 2018-06-22 10:22:53 -04:00
Ben Halpern
13a92d17cb
Add a couple basic request specs (#478) 2018-06-21 18:35:34 -04:00
Ben Halpern
c60268b76f
Add pundit policy for several controllers (#476)
* Add pundit policy for several controllers

* Adjust video spec

* Fix tag request specs

* Add proper twilio tokens request specs

* Remove puts statements
2018-06-21 18:26:35 -04:00
Ben Halpern
2b4749bf11
Whitelist columns on to_json call (#477) 2018-06-21 17:43:56 -04:00
Andy Zhao
0785720908 Add comment policy and specs (#475)
* Fix edge case with apostrophes

* Add comment policy and specs

* Add login for deleting comment spec

* Change test to raise pundit error instead of 404

* Clean up comment destroy request specs

* Remove redundant raise
2018-06-21 17:20:34 -04:00
Ben Halpern
8b53f68574
Add chat channel policy and spec (#474) 2018-06-21 16:58:21 -04:00
Ben Halpern
1127b2e61b
Add protection against reactions to unpublished articles (#473) 2018-06-21 15:44:04 -04:00
Mac Siri
ff36271108 Improve ArticlesController's authorization (#466)
* Fix lint

* Add pundit-matchers gem

* Strengthen ArticlePolicy & create spec

* Change ApplicationPolicy to a closed system

* Globally handle pundit's NotAuthorizedError

* Fix lint

* Adjust /new's authorization
2018-06-21 14:18:32 -04:00
Yechiel Kalmenson
c121dd63d3 Yechiel/feature/add route for shop (#468)
* add test for /shop route

* route /shop to shop.dev.to
2018-06-21 13:14:13 -04:00
Ben Halpern
45ad83455a
Add after-initialize checker to add routes to reserved words (#471) 2018-06-21 12:24:47 -04:00
Ben Halpern
aed3c81e8d
Fix canonical url on tag page (#464)
* Fix canonical url on tag page

* Fix canonical url on tag page
2018-06-21 11:06:37 -04:00
Andy Zhao
691ad2e771 Fix tests for live (#465) 2018-06-20 18:45:12 -04:00
Andy Zhao
e2184d2ff0 Tests for /live and minor style adjustments (#462)
* Add spec for badges show page

* Test live feature and minor styling changes
2018-06-20 18:29:31 -04:00
Ben Halpern
6f1efb0342
Adjust style for live channel (#463) 2018-06-20 18:16:56 -04:00
Andy Zhao
263a74bcb6 Add more request specs (#460)
* Remove email blank onboarding redirect

* Add authorization specs for video upload

* Add registration spec

* Remove skip before actions for signup complete

* Use new param for abuse reports

* Remove else because it never runs

* Add more dashboard request specs

* Use let with no bang in case there are errors
2018-06-20 17:46:23 -04:00
Ben Halpern
0941b2e4fb
Add some tests around model validations (#459)
* Modify sample_application.yml and write test

* Add ahrefs verification

* Add some tests around model validations

* Indent an end

* Add a few tests

* Add tests and reserved words

* Fix live articles spec typo

* Modify ga_events_controller
2018-06-20 17:14:08 -04:00
Jess Lee
3440d0529a add missing file (#458) 2018-06-20 15:00:57 -04:00
Yechiel Kalmenson
23ee1004be fix grammar in the chat screen (#457) 2018-06-20 10:23:09 -04:00
Ben Halpern
3a623993d4
Modify sample_application.yml and write test (#456)
* Modify sample_application.yml and write test

* Add ahrefs verification
2018-06-19 19:06:22 -04:00
Mac Siri
d31e1b0594 Remove Sendbird (#421)
* Remove Sendbird

* Remove more remnant of sendbird

* Remove puts
2018-06-19 17:51:10 -04:00
Andy Zhao
ecbb9d4ab1 [Done] New Reporting System MVP (#408)
* Move validations from controller to model

* Add new columns to feedback message model

* Use polymorphic notes relationship

* MVP of ticketing system

* Use new URL for reported_url param

* Add missing files

* Add validations and tests for feedback_messages

* Clean up some html

* Update create spec and add update spec

* Add mail tests and lint

* Add link to user profile
2018-06-19 16:41:31 -04:00
Mac Siri
ec264bf802 Clean up spec outputs (#450)
* Improve BadgeAchievementSpec

* Create specs for PushNotificationSubscription

* Clean-up specs for VideoStatesController

* Refactor spec
2018-06-19 16:27:15 -04:00
Andy Zhao
74266db0d9 Add name length validation (#453) 2018-06-19 16:22:02 -04:00