Commit graph

6168 commits

Author SHA1 Message Date
rhymes
6cd64c4071
Rubocop: enable and fix Style/Send and Style/Next (#9366)
* Enable and fix Style/Send

* Enable and fix Style/Next

* Fix private cookies send

* Fix merging indentation issues
2020-07-20 16:28:00 +02:00
dependabot-preview[bot]
c5cf8fa82a
Bump jest-axe from 3.4.0 to 3.5.0 (#9383)
Bumps [jest-axe](https://github.com/nickcolley/jest-axe) from 3.4.0 to 3.5.0.
- [Release notes](https://github.com/nickcolley/jest-axe/releases)
- [Changelog](https://github.com/nickcolley/jest-axe/blob/main/CHANGELOG.md)
- [Commits](https://github.com/nickcolley/jest-axe/compare/v3.4.0...v3.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-20 10:27:49 -04:00
dependabot-preview[bot]
b309ab3be7
Bump eslint from 7.4.0 to 7.5.0 (#9387)
Bumps [eslint](https://github.com/eslint/eslint) from 7.4.0 to 7.5.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v7.4.0...v7.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-20 10:27:09 -04:00
Michael Kohl
f28deb9e71
Add regex to check for possible XSS attempts (#9400)
* Fix ruby linting issues

* Added test for uncovered branch

* Fixed typo

* Address PR comments

Co-authored-by: Brian Mayo <ioprotium@gmail.com>
2020-07-20 16:09:26 +02:00
Molly Struve
d9beec9419
[deploy] Optimization:Change Primary Keys on Mentions and Notes to Bigint (#9393) 2020-07-20 09:04:18 -05:00
Molly Struve
10788a5016
Flaky Spec Fix:Clear Elasticsearch FeedContent to avoid trying to load missing images (#9402) 2020-07-20 09:01:42 -05:00
Michael Kohl
a4dadfb728
Standardize ActiveRecord order clauses (#9395)
* Change simple order clauses

* Change nested order clauses
2020-07-20 10:00:51 -04:00
dependabot-preview[bot]
cd1327096c
Bump knapsack_pro from 2.0.0 to 2.1.1 (#9384)
* Bump knapsack_pro from 2.0.0 to 2.1.1

Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby) from 2.0.0 to 2.1.1.
- [Release notes](https://github.com/KnapsackPro/knapsack_pro-ruby/releases)
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v2.0.0...v2.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump knapsack_pro from 2.0.0 to 2.1.1 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-20 08:52:04 -05:00
Piyush Suthar
e8b32c0e51
[deploy] Changed the Typo at "A Published article by path" (#9396) 2020-07-20 09:08:52 -04:00
Jacob Herrington
cc6a79ad57
[deploy] Fix tag input patterns (#9363)
* Fix tag input patterns

* Trigger build

* Increase JS test coverage for CI
2020-07-20 08:06:36 -05:00
Michael Kohl
8dd4a85fba
Introduce domain model for campaigns (#9300)
* Introduce domain model for campaigns

* Move main_tag method to decorator

* Add options argument to decorator method

* Change more code to use Campaign domain model

* active? -> show_in_sidebar? and fix spec

* Switch back to leading dots after merge
2020-07-20 09:04:53 -04:00
Ridhwana
4359d5b09a
[deploy] Site Config: Get Started Section and Show Required Fields (#9289)
* chore: spike

* fix: update doesnt get to symbol

* spelling

* chore: some suggestions

* chore: change name

* chore: content tag and safe join

* chore: keep this open for now

* chore: code climate

* more code climate stuff

* chore: remove commas

* fix: tests

* feat: update the descriptions and placeholders

* chore: update all the variables

* chore: update lines

* feat: update ""

* chore: length line

* feat: content_tag

* chore: disable rubocop:disable Rails/OutputSafety

* feat: collapse the get started section if everything is filled out

* chore: comment

* some cleanup

* codeclimate :(
2020-07-20 08:20:15 -04:00
Sarthak Sharma
3addb64326
[deploy] 🚀 Feature: Chat channel membership manager component (#8945)
* Feature 🚀 : Ability to delete messages in chat channels

- Sending message ID to frontend
- Deleting Message
- Use pusher to delete message realtime

* Minor Bug 🐞: Show message action only for current user

- User can delete or edit their own messages

* Test cases added

* Bug 🐞: Update message id for receiver

Message id was not sent to receiver by pusher

* Refactoring🛠: Message controller refactoring

* Test Cases📝 : Specs for Delete message added

* Feature 🚀 : Ability to edit messages

* Test Cases📝 : Specs for Edit message added

* Merge conflict resolved

* fix video content issue

* add UI for membership management

* add api to update memberahip role

* add methods for manage membership

* Add integration test cases

* add emoji for admin

* Open member profile in sidecar only

* 🐞 Problem with direct channel sidecar

* 🐞 Few other UI enhancements

* fix mod typo

* add limit upto 4 for display active memberships

* fix UI issues

* fix action ui for membership

* fix sidebar redirection issue

* fix svg buttons

* add test cases

* fixed broken spec

* fix PR suggestions

* remove not used code

* fix typo

* fix PR suggestion

* fix typos

* add invitation url expiry

* fix specs

* fix PR suggestions

* removed unused gem

* remove presenter format

* handle invitation link expiry with redis

* fix PR suggestions

* user can view non-discoverable channel invitation link

* fix typos

* remove commented code

* add spacing

* PR suggestions

* remove class from button

* replace componentDidMount with commen function

* remove action button for single membership

* add chat message on update role

* add spece between lines

Co-authored-by: Narender Singh <narender2031@gmail.com>
Co-authored-by: Fernando Valverde <fdov88@gmail.com>
2020-07-20 08:08:31 -04:00
dependabot-preview[bot]
803d482f90
Bump test-prof from 0.11.3 to 0.12.0 (#9386)
* Bump test-prof from 0.11.3 to 0.12.0

Bumps [test-prof](https://github.com/palkan/test-prof) from 0.11.3 to 0.12.0.
- [Release notes](https://github.com/palkan/test-prof/releases)
- [Changelog](https://github.com/palkan/test-prof/blob/master/CHANGELOG.md)
- [Commits](https://github.com/palkan/test-prof/compare/v0.11.3...v0.12.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump test-prof from 0.11.3 to 0.12.0 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-20 09:53:55 +02:00
Molly Struve
914e8b80a8
[deploy] Optimization:Change Broadcast and GithubIssue PKs to Bigint (#9372) 2020-07-19 17:41:37 -05:00
dependabot-preview[bot]
f5fe706ce7
[deploy] Bump @testing-library/jest-dom from 5.11.0 to 5.11.1 (#9381)
Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) from 5.11.0 to 5.11.1.
- [Release notes](https://github.com/testing-library/jest-dom/releases)
- [Changelog](https://github.com/testing-library/jest-dom/blob/master/CHANGELOG.md)
- [Commits](https://github.com/testing-library/jest-dom/compare/v5.11.0...v5.11.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-19 18:29:55 -04:00
dependabot-preview[bot]
ee22a35658
Bump preact from 10.4.5 to 10.4.6 (#9388)
Bumps [preact](https://github.com/preactjs/preact) from 10.4.5 to 10.4.6.
- [Release notes](https://github.com/preactjs/preact/releases)
- [Commits](https://github.com/preactjs/preact/compare/10.4.5...10.4.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-19 16:39:16 -04:00
dependabot-preview[bot]
2636d600a2
Bump rouge from 3.20.0 to 3.21.0 (#9382)
* Bump rouge from 3.20.0 to 3.21.0

Bumps [rouge](https://github.com/rouge-ruby/rouge) from 3.20.0 to 3.21.0.
- [Release notes](https://github.com/rouge-ruby/rouge/releases)
- [Changelog](https://github.com/rouge-ruby/rouge/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rouge-ruby/rouge/compare/v3.20.0...v3.21.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump rouge from 3.20.0 to 3.21.0 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-19 16:36:56 -04:00
Molly Struve
129b60772c
[deploy] Refactor:Drop Blocks Table (#9373) 2020-07-17 16:29:05 -05:00
Molly Struve
62d43a1ce7
[deploy] Refactor: Remove Block Model and All Related Code (#9370) 2020-07-17 15:32:39 -05:00
benhalpern
b564592a4e Fix test typo 2020-07-17 13:38:47 -04:00
Cain Watson
6853e103ae
Fix reading list rendering multiple times (#9364) 2020-07-17 07:53:43 -04:00
Josh Puetz
73a3bcc68a
Attempt to turn off Flipper UI CSRF protections (#9360) [deploy]
* Turn off flipper ui CSRF

* Turn off CSRF protection in Flipper UI
2020-07-16 21:56:11 -05:00
shelby spees
a6c4f0b884
[deploy] Update NoiseCancellingSampler to make it more self-documenting (#9359) 2020-07-16 15:06:49 -05:00
benhalpern
dcf3af7cff Fix test copy 2020-07-16 15:16:18 -04:00
Molly Struve
397c9ed2bf
[deploy] Bug Fix: Refresh Hypershield after db:prepare if Enabled (#9353) 2020-07-16 13:50:22 -05:00
Josh Puetz
e9cafe5de6
Add logging to Flipper UI (#9355) [deploy] 2020-07-16 11:47:54 -05:00
Jacob Herrington
9e08ae6f1f
[deploy] Restrict tags input regex (#9172) 2020-07-16 12:28:03 -04:00
rhymes
696c712883
Rubocop: routine fixes (#9345)
* rubocop -A

* Fix Style/HashLikeCase

* regenerated todo file
2020-07-16 18:18:13 +02:00
Mac Siri
7ceb5550a2
Remove codeql-analysis.yml (#9354) 2020-07-16 12:15:38 -04:00
rhymes
995f9f8679
Create Listings in seed file (#9351) 2020-07-16 12:08:11 -04:00
narender2031
2a5f5053b7
[deploy] Fix non channel details visible (#9252)
* Feature 🚀 : Ability to delete messages in chat channels

- Sending message ID to frontend
- Deleting Message
- Use pusher to delete message realtime

* Minor Bug 🐞: Show message action only for current user

- User can delete or edit their own messages

* Test cases added

* Bug 🐞: Update message id for receiver

Message id was not sent to receiver by pusher

* Refactoring🛠: Message controller refactoring

* Test Cases📝 : Specs for Delete message added

* Feature 🚀 : Ability to edit messages

* Test Cases📝 : Specs for Edit message added

* Merge conflict resolved

* fix pending invitation issue

* non active member blocked to open channel details

* add specs for bug fix

Co-authored-by: Sarthak Sharma <7lovesharma7@gmail.com>
2020-07-16 09:28:28 -06:00
Pavel Tkachenko
9e94b80741
[deploy] Add local_date helper to handle dates with respect of user timezone (#9285)
* Add local_date helper to handle dates with respect of user timezone

* Fix date timezone bug for articles/show

* Fix date_helper to meet system specs requirements
2020-07-16 08:45:44 -06:00
Mazen Touati
ed3d8901b2
Update Readme (#9333)
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-07-16 10:26:25 -04:00
benhalpern
a18e5912e9 Remove extra space 2020-07-16 10:22:49 -04:00
benhalpern
b611a9847a Enable public or private forem config 2020-07-16 09:58:00 -04:00
rhymes
f1ec04a0c9
Rubocop: move dot in multi-line calls to leading position (#9262) 2020-07-16 15:51:11 +02:00
Alex
204fb51f14
[deploy] Remove path redirects (#9350)
* Remove path_redirect menu item

* Remove path_redirects_controller

* Remove path_redirect routes

* Remove PathRedirect model

* Remove internal views

* Remove path_redirects from seed file

* Remove PathRedirect factory

* Remove specs

* Migration to drop table and update schema
2020-07-16 09:35:42 -04:00
Sarthak Sharma
6ee16d77a1
🐞Hotfix: In small screen user is not able to access sidecar (#9325)
Co-authored-by: Narender Singh <narender2031@gmail.com>
2020-07-16 08:58:55 -04:00
Olawale Oyeyipo
c990f5d7d8
Fixed broken link, replaces file links with permalinks (#9334)
Co-authored-by: rhymes <rhymesete@gmail.com>
2020-07-16 07:41:07 -05:00
benhalpern
98242dc68b Initial work 2020-07-16 06:59:20 -04:00
Christina
73187e82ba
Add missing words in README (#9341)
Adding in missing word `write` to the forem/README.md file.
2020-07-16 09:49:16 +02:00
Olawale Oyeyipo
246660f120
Fixes javascript folder typo in webpacker documentation (#9329) 2020-07-16 09:35:00 +02:00
Josh Puetz
9ce75250ff
Attempt to fix Flipper-UI (#9320) [deploy]
* Upgrade redis-store, attempt to fix flipper ui

* Remove explicit Gemfile require for redis-store, use URL.url

* Re-add use of URL 🤦
2020-07-15 22:13:40 -05:00
Andy Zhao
3b73038919
Update more Forem to DEV language (#9337)
* Update more Forem to DEV language

* Update readme with more Forem language

* Use Forem favicon, thanks @atsmith813!
2020-07-15 18:01:34 -04:00
Arit Amana
a78ccf2310
[deploy] [ModCenter] Fix "FlagUser" Modal functionality (#8995)
* Make FlagUserModal show up on click

* Explain extra div

* Make sure "Vomit All" reaction fires accurately

* Make test-file comment clearer

* Fix bug when 2 articles are open and the FlagUser modal does not open for the first article

* Still working it out ...

* Tests broken; need help

* Get rid of debugging alerts

* Fixed broken tests for <SingleArticle />

* Write tests for ModerationArticles component

* Complete tests for ModerationArticles component

* Employ safer Preact testing techniques

* Query all articles using "data-testid"

* Revert changes

* Got it working with portals for non-iframe implementation.

* wip tests

* Got mod tools flag user modal wprking on article page again.

* Added some documentation the code.

* Now confirm is disabled until you select an item in the flag user modal.

* Revert "wip tests"

This reverts commit fb7a0825039fd377cad04d9dedad9d1146b03978.

* test prep

* Fixed broken test.

* Refactored to use useRef hook.

* Rename a variable

* remove unnecessary comments

Co-authored-by: Nick Taylor <nick@dev.to>
2020-07-15 13:54:52 -04:00
dependabot-preview[bot]
e11f4f321a
Bump rubocop-rspec from 1.41.0 to 1.42.0 (#9313) 2020-07-15 13:32:33 -04:00
Andy Zhao
955bdcb2bc
Update docs with Forem instead of dev.to (#9316)
* Rename all GitHub links from thepracticaldev/dev.to to forem/forem

* Use new site name

* Rename to Forem

* Rename more dev.to to forem

* Remove unnecessary redirects

* Rename DEV to Forem

* Use Forem instead of DEV for branding

* Use Forem instead of DEV for licensing

* Use seedling instead of DEV logo
2020-07-15 13:29:11 -04:00
Lisa Sy
7475716662
Make small CSS improvements to mod center (#9315) [deploy]
* Update mod center layout & color fixes

* Update SVG for external link

* - Update external link svg to use
- Remove scrollbar in actions menu
- Move action panel styling from `articles.scss` to `moderators.scss`

* Delete schema.rb

* Add back schema file

* SiteConfig view refactoring (#9286)

* Clean up payment pointer in top shell

* Simplify handling of social media icons

* Also guard against empty strings

* Only traverse hash once

* Adds a default value to the shell version cache response in case it returns undefined (#9250)

* [deploy] 🐞 Hotfix Real time chat was broken  (#9293)

* Feature 🚀 : Ability to delete messages in chat channels

- Sending message ID to frontend
- Deleting Message
- Use pusher to delete message realtime

* Minor Bug 🐞: Show message action only for current user

- User can delete or edit their own messages

* Test cases added

* Bug 🐞: Update message id for receiver

Message id was not sent to receiver by pusher

* Refactoring🛠: Message controller refactoring

* Test Cases📝 : Specs for Delete message added

* Feature 🚀 : Ability to edit messages

* Test Cases📝 : Specs for Edit message added

* Merge conflict resolved

* 🐞Hotfix: Findinder error in chat

Co-authored-by: Narender Singh <narender2031@gmail.com>

* Bump jsdom from 16.2.2 to 16.3.0 (#9279)

* Fix TypeError: userData is null in blockButton.js (#9299)

Should fix https://app.honeybadger.io/fault/67192/ed6f6b392b5bd791d6dc04732f125123.

* Fix TypeError: userData is null in initializeOnboardingTaskCard.js (#9298) [deploy]

* Fix TypeError: userData is null in initializeOnboardingTaskCard.js

Should fix https://app.honeybadger.io/fault/67192/65045742fda3390a067960f53a894e87.

* Combine return statements in initializeOnboardingTaskCard

* Fix TypeError: null is not an object in initializeArticleReactions.js (#9297) [deploy]

* Fix TypeError: null is not an object in initializeArticleReactions.js

Should fix https://app.honeybadger.io/fault/67192/6f9b4fdf475e2229c968fa26d785b90f

* Return 0 rather than undefined if reactionEl doesn't exist

* Routine Rubocop fixes (#9302)

* rubocop -A

* rubocop --auto-gen-config

* Fix sorting in Bundler/OrderedGems to consider punctuation

* Rubocop: activate Layout/ClassStructure (#9304)

* change Label Follow Weight Scale for Tags in Dashboard (#9247)

* [deploy] Remove codeql analysis for right now (#9308)

* Update Readme Headline (#9309)

* [deploy] Fix TypeError: Cannot set property 'innerHTML' of null (#9306)

Should fix https://app.honeybadger.io/fault/67192/f79e24dfb4e4364da09dda6380e9d2ff.

* Add /forem redirect (#9317)

* [deploy] Make sidebar sponsor headline configurable (#9251)

* Make sidebar sponsor headline configurable

* Fix spec

* Fix spec typo

* Create profile image generator (#8695)

* Create profile image generator

* Update spec/services/users/profile_image_generator_spec.rb

Co-authored-by: Mac Siri <krairit.siri@gmail.com>

* Remove difficult cloudinary dependency

Co-authored-by: Mac Siri <krairit.siri@gmail.com>

Co-authored-by: Michael Kohl <citizen428@gmail.com>
Co-authored-by: Fernando Valverde <fdov88@gmail.com>
Co-authored-by: Sarthak Sharma <7lovesharma7@gmail.com>
Co-authored-by: Narender Singh <narender2031@gmail.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
Co-authored-by: rhymes <rhymesete@gmail.com>
Co-authored-by: Veggier <47649859+Veggier@users.noreply.github.com>
Co-authored-by: Molly Struve <mollylbs@gmail.com>
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
Co-authored-by: Jacob Herrington <jacobherringtondeveloper@gmail.com>
Co-authored-by: Mac Siri <krairit.siri@gmail.com>
2020-07-15 09:54:19 -07:00
dependabot-preview[bot]
f312ed9432
Bump rubocop from 0.87.1 to 0.88.0 (#9311) 2020-07-15 12:26:01 -04:00