Commit graph

3547 commits

Author SHA1 Message Date
rhymes
689fb6efb6
Routine rubocop fixes (#8137)
* Update gems

* rubocop -a

* rubocop --auto-gen-config
2020-05-29 11:56:52 +02:00
rhymes
5e3f645d29
Fix WikipediaTag tag regexp (#8139) 2020-05-29 10:59:12 +02:00
Jacob Herrington
79bc4929e6
Remove unclear comment (#8138)
This is probably pedantic, but I believe this comment is unclear. There
is also a typo removed by this commit.
2020-05-28 12:53:04 -05:00
Ridhwana
1a40e10df8
Update the tag moderation email (#8048)
* feat: update the tag mod text

* feat: channel slug

* feat: updates

* feat: update text

* chore: change
2020-05-28 17:46:41 +02:00
Molly Struve
07f8964007
[deploy] Tweak How We Track Ambiguous Routes to Make them Easier to Track (#8112) 2020-05-28 10:34:39 -05:00
Nick Taylor
530b13e8c7
made all frontend unit tests uniform by preffering it(...) over test(...) (#8113) 2020-05-28 17:18:15 +02:00
Molly Struve
8a4c2c1cb4
[deploy] Add App, Database, and Search Health Check Endpoints (#8071) 2020-05-28 08:33:31 -05:00
Molly Struve
0edca1fe2c
[deploy] Track How Often We Hit Ambiguous Routes (#8098) 2020-05-28 07:56:00 -05:00
rhymes
eb355a6d4c
Fix broken tag filters in listings (#8086) 2020-05-28 10:24:50 +02:00
krishna kakade
29269cd589
--base-50: changed to #fff unreadble text in ten X hacker theme (#8001)
--base-50: changed to #fff unreadable text in ten X hacker theme  light-dark text making eye strain their that's why i changed to white it looks i tested in firefox and another bug in this theme is in case of mail 
  and usernames CSS properties are overriding please and that text is getting black out there Ex:-Hidden
2020-05-27 15:54:55 -04:00
Vaidehi Joshi
5baecfdd61
Remove type onboarding from broadcast form options (#8087) [deploy] 2020-05-27 12:49:23 -07:00
Nick Taylor
c83cad6fb6
Sorting Storybook stories (#8058)
* Added story sorting to Storybook.

* Added design system guidelines.

* Made Base in Storybook tree 2nd in the tree view.

* Now Components are 3rd in the treeview of Storybook.

* Now App Components are 4th in the treeview of Storybook.

* Froze node version to 12.16.0

* Revert "Froze node version to 12.16.0"

This reverts commit 093b119c7d7ca05ecb4e1c0234b24bcf8e7b10a4.
2020-05-27 13:10:16 -04:00
Nick Taylor
26c66b34d2
Fixed configuration to build Storybook on Netlify. (#8088) 2020-05-27 12:44:30 -04:00
Ben Halpern
9a489adc12
[deploy] Fix cloudinary helper (#6701)
Co-authored-by: Molly Struve <mollylbs@gmail.com>
2020-05-27 11:05:30 -05:00
Fernando Valverde
bf740ac5d8
[deploy] Podcast Player native bridge calls refactor to use message based communication (#8054)
* Podcast native bridge calls now message based

* Resets current time to 0 when initializing
2020-05-27 11:14:31 -04:00
Julianna Tetreault
6cf177c3e4
Add download_app Welcome Notification (#8067)
* Add download_broadcast to generator.rb
  * Adds memoized download_broadcast method
  * Adds send_download_notification method
  * Adds send_download_notification to call method

* Add download_app to broadcasts.rb and seeds.rb
  * Adds download_app broadcast info and copy to factory
  * Adds download_app copy to seeds

* Add specs around #send_download_app_notification in generator_spec.rb

* Fix quotes around copy

* Remove extra space within copy
2020-05-27 08:14:47 -06:00
Michael Kohl
7f75f99560
[deploy] Rename classified listings (#7910)
* Change models and related files

* Update controllers and specs

* More renaming

* Seek and destroy, I mean search and replace

* Round up the stragglers

* Ground control to Major Travis...

* More fixes

* PR feedback

* Various fixes

* Rename view

* Fix list query builder

* Unify request specs

* Fix some API spec errors

* Fix remaining API specs

* Make spec conform to API

* Fix leftover problems

* Fix JS tests

* Fix column name in select

* Fix API specs

* Fix search specs

* Paging Mr. Travis
2020-05-27 13:35:09 +00:00
rhymes
ce28c0b5e5
[deploy] Remove ERB pre-processing from pure JS files and cleanup (#8030) 2020-05-27 08:25:39 -05:00
ludwiczakpawel
975ddc61c4
Home Feed Tabs - Crayonsified (#7976)
* flare tag line height

* .

* new tabs on home

* instantclick

* Some JS cleanup for mobile view select event handler.

* eslint cleanup

* select arrow color

* quotes

* quotes

* .

* .

* omg

* .

* finally

* focus visible

Co-authored-by: Nick Taylor <nick@iamdeveloper.com>
2020-05-27 14:48:18 +02:00
rhymes
acb35afe03
Add unique indexes - part 4 (#8059)
* Rubocop unique index cop needs a static list of columns

* Add unique index on organizations secret

* Add unique index on chat_channel_memberships chat_channel_id

* Add unique index to chat_channel slug

* Add unique index to badge_achievements badge_id
2020-05-27 09:29:20 +02:00
Ben Halpern
e39f5b04d1
[deploy] Render recently updated search preambled to sidebar (#8060)
* Render recently updated search preambled to sidebar

* Refactor

* Fix typo

* Mess with test
2020-05-26 18:34:27 -04:00
Josh Puetz
1a1b5b544e
Add Feature Flags support to DEV (#7996)
* Create tables for Flipper gem

* Enable Flipper gem

* Remove concurrent ruby from Gemfile

* Add Flipper UI

* Codeland landing page

* Remove codeland controller and sample page

* Remove oops

* Rename Flipper-UI endpoint

* Wrap Flipper in a FeatureFlag module

* [deploy] Lock node to 12.16 (#8057)

Co-authored-by: Mac Siri <krairit.siri@gmail.com>
2020-05-26 15:26:33 -05:00
rhymes
0976132425
[deploy] RSS feed: add article tags as categories (#8046) 2020-05-26 15:51:33 -04:00
Ben Halpern
cd18d2f436
[deploy] Add alternate comment-oriented feed algos (#8042) 2020-05-26 13:23:03 -04:00
Andy Zhao
c42fd3461e
[deploy] Rename positive_reactions_count to public_reactions_count in logic (#7926)
* Rename positive_reactions_count to public_reactions_count

* Add positive reactions count back in so we can remove it

* Use public_category method for reactions

* Add positive_reactions_count in case any old caches rely on it

* Add positive_rxn_count to account for API endpoints

* Remove unused method

* One more spot...

* Add method back in because of caches

* Update specs to match new functionality

* Fix typo

* Remove unused methods
2020-05-26 12:36:28 -04:00
rhymes
7db40b2117
[deploy] Add unique indexes - part 3 (#8050) 2020-05-26 08:34:53 -05:00
rhymes
867a268a62
Fix blockquote styling in comments previews and notifications (#8052)
* Add quote styling to comment preview

* Add quote styling in notification comment
2020-05-26 15:17:20 +02:00
Mac Siri
9c58ebc61e
[deploy] Apply HTML encoder to FeedContent's query (#7985)
* Use .textContent to apply Search Snippets

* Improve var name

* Apply HTML encoder to FeedContent's query

* Add spec

* Expand FeedContent specs

* Actually let's not use approval
2020-05-25 13:06:35 -04:00
Rohit Sharma
1f56c44e53
feat(styling): add focus state/outline for crayons-btn class (#8051)
Remove "outline: none" from the crayons-btn CSS class, allowing better accessibility for users navigating with the keyboard. Remove :enabled from the .focus:enabled selector in buttons.scss as it appears to be preventing the focus from being applied.

Co-authored-by: Rohit Sharma <rohitsharma@Rohits-MacBook-Pro.local>
2020-05-25 13:04:29 -04:00
Ben Halpern
cde008c0a9
Add current state to nav bar links properly (#8045) 2020-05-25 12:00:21 -04:00
Molly Struve
61cda701c5
Track Article IDs for Controller Requests (#8038) 2020-05-25 11:59:34 -04:00
rhymes
6a0b675974
Fix load more listings button colors (#8049) 2020-05-25 15:01:07 +02:00
benhalpern
cca7729198 Add page view tracking to comment permalinks 2020-05-23 14:08:28 -04:00
Ben Halpern
a53de929fe
[deploy] Remove sidebar variant from CTA (#8040)
* Remove sidebar variant from CTA

* Remove unneeded tests

* Modify algo *just a bit*
2020-05-23 13:35:43 -04:00
Alex
84e9d769e8
[deploy] Fix tag removal case sensitivity for mods (#8024)
* Fix removal of tags/tag_list validation

* Remove tags regardless of case

* Refactor removing tags to be more readable

* Add guard for when tags aren't found to remove

* Refactor more logic
2020-05-22 15:44:10 -04:00
Thomas Bnt
a7807eb606
Checkmark stackbit at integration (#8026)
* Changing width to checkmark of Stackbit in integration page

* Adding margin-left on img green checkmark of Stackbit to 2px

* Update app/views/users/_integrations.html.erb

Co-authored-by: rhymes <rhymesete@gmail.com>

Co-authored-by: rhymes <rhymesete@gmail.com>
2020-05-22 18:15:29 +02:00
Mac Siri
58f2143f42
Improve RssReader::Assembler's path correction (#7984) 2020-05-22 11:03:28 -04:00
Ben Halpern
6a2b6aa914
[deploy] Quick fix for podcast liquid tag in comments (#8025) 2020-05-21 21:52:13 -04:00
Ben Halpern
1aaf91c37c
[deploy] Add config for whether campaign posts require approval (#7961)
* Add config for whether campaign posts require approval

* Fix logic
2020-05-21 21:00:11 -04:00
rhymes
174dd9359d
[deploy] Add missing unique indexes - part 2 (#8002) 2020-05-21 14:15:49 -05:00
Ben Halpern
b51d56159a
[deploy] Implement web-monetization/payment pointer (#6345)
* WIP payment pointer

* Add payment pointer config

* Add proper siteconfig var to view

* Finalize

* Fix typo

Co-authored-by: Andy Zhao <17884966+Zhao-Andy@users.noreply.github.com>
2020-05-21 12:10:02 -04:00
ludwiczakpawel
35eb4f1f72
Overflow issue in Settings on mobile (#7999)
* flare tag line height

* .

* .
2020-05-21 11:47:18 -04:00
Dana Scheider
c59db25387
[deploy] Gracefully handle missing linked users from comments (#7941) 2020-05-21 09:07:51 -05:00
Anna Buianova
5fcc44677e
Display existing sponsorships even when an org doesn't have enough credits (#7978) 2020-05-21 13:10:39 +03:00
Dmitry Maksyoma
eb85a91a9d
Refactor Mentions::CreateAll (#7880)
* Refactor Mentions::CreateAll

* Update app/services/mentions/create_all.rb

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>

* Refactor for readability

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2020-05-21 12:08:36 +02:00
Molly Struve
76da5a7a66
Remove ProMembership Models (#7989) 2020-05-21 12:04:41 +02:00
Molly Struve
374f030d12
Cache Article IDs Rather than ActiveRecord Objects (#7990) 2020-05-20 18:51:33 -04:00
rhymes
fa22f346e4
Add merveilles.town to list of Mastodon instances (#7983) 2020-05-20 17:48:46 -04:00
Julianna Tetreault
97c46cfbf8
Refactor User-Specific JSON-LD in the Stories::Controller (#7731)
* Refactor user_same_as_json_ld method to be more readable

* Refactor user JSON-LD to be less verbose in Stories::Controller
  * Removes set_user_same_as_json_ld method
  * Removes set_user_profile_json_ld method
  * Adds user_works_for and user_disambiguating_description
  * Adds inline logic to the data structure
  * Simplifies user_same_as method

* Add documentation around specific data properties

* Add .reject to user_json_ld to remove key, value if value blank
  * Checks for blank values and rejects key,value if blank
  * Accounts for JSON-LD preference for no key,value if blank

* Add reject and compact to worksFor in Stories::Controller
  * Ensures any nil/empty values for worksFor are removed
  * Cleans up existing code within Stories::Controller

* Add test for values that eval to true when .blank? is called
  * Adds test to check that empty key/values are not included
  * Adds test to check that nil key/values are not included
  * Refactors variables to be inline in user_show_spec
  * Refactors existing code in user_show_spec

* Add reject for blank values to user_same_as in Stories::Contrroller
  * Adds a check for email_public to email

* Fix typo within comment in Stories::Controller

* Add ternary operation to email in Stories::Controller
2020-05-20 14:40:34 -06:00
Molly Struve
58ff5d44ba
[deploy] Add back ProMembership AR class (#7987) 2020-05-20 13:15:22 -05:00