maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Cache Article IDs Rather than ActiveRecord Objects (#7990)

Browse source
This commit is contained in:
Molly Struve 2020-05-20 17:51:33 -05:00 • committed by GitHub
parent fa22f346e4
commit 374f030d12
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
app/services/suggester/articles/classic.rb
View file

@ -7,14 +7,16 @@ module Suggester
def initialize(input = nil, options = {})
@input = input
@not_ids = options[:not_ids]
@not_ids = options[:not_ids] || []
end
def get(num = 1)
articles = if rand(8) == 1
random_high_quality_articles(num)
else
qualifying_articles(random_supported_tag_names).where.not(id: not_ids).compact.sample(num)
qualifying_ids = qualifying_articles(random_supported_tag_names)
lookup_ids = qualifying_ids - not_ids
Article.where(id: lookup_ids).limit(num)
end
articles = random_high_quality_articles(num) if articles.empty?
articles
@ -22,14 +24,14 @@ module Suggester
def qualifying_articles(tag_names)
tag_name = tag_names.sample
Rails.cache.fetch("classic-article-for-tag-#{tag_name}}", expires_in: 90.minutes) do
Rails.cache.fetch("classic-article-ids-for-tag-#{tag_name}", expires_in: 90.minutes) do
Article.published.cached_tagged_with(tag_name).
includes(:user).
limited_column_select.
where(featured: true).
where("positive_reactions_count > ?", MIN_REACTION_COUNT).
where("published_at > ?", 10.months.ago).
order(Arel.sql("RANDOM()"))
order(Arel.sql("RANDOM()")).pluck(:id)
end
end