Commit graph

940 commits

Author SHA1 Message Date
rhymes
9b2886979a ActiveRecord count optimizations (#5478) [deploy]
* Do not load messages in memory, just to count them
* Add Model.estimated_count
* Use Model.estimated_count in task record_db_table_counts
* Use size and estimated_count
* Use table_name so that .estimated_count works with all models
* Add comment to explain the .load.size + .each pattern
2020-01-14 12:03:38 -05:00
Michael Kohl
dba7e6ca60 Move Twitch webhook registration from ActiveJob to Sidekiq (#5414) 2020-01-14 11:55:35 -05:00
Michael Kohl
92b5f113be Return 429 Too Many Requests instead of raising (#5504) 2020-01-14 11:53:33 -05:00
rhymes
241c39344e Destroy messages if chat channels are destroyed (#5498) 2020-01-14 09:46:40 -06:00
Anna Buianova
05884acd19 Fixed rubocop issues (#5506) 2020-01-14 09:45:26 -06:00
serena
6e9539415e Move welcome notification job to worker for Sidekiq (#5465) [deploy] 2020-01-13 13:28:23 -06:00
Alain Mauri
faa696444b Add Mentions::CreateAllWorker for Sidekiq (#5463) 2020-01-13 13:23:30 -06:00
Asha Balasubramaniam
61acfcd4c9 Remove Comments::SendEmailNotificationJob to send email notification on comment creation (#5446)
Follow up to https://github.com/thepracticaldev/dev.to/pull/5427
2020-01-13 13:19:48 -06:00
Lucas Hiago
1ed6aca54a Change Webhook::DestroyJob to Wehook::DestroyWorker and move to sidekiq (#5424) [deploy] 2020-01-13 12:38:10 -06:00
Anna Buianova
851508f628 Fix a bug when user tries to delete an account while not having an email (#5486)
* Ask user to add email when deleting [WIP]

* Ask to provide an email before requesting account deletion

* Additional checks to make sure that user won't be deleted w/o an email

* Revert changes on confirm destroy view
2020-01-13 08:34:37 -05:00
Asha Balasubramaniam
e5960810cc Migrate Comments::SendEmailNotificationJob to Sidekiq (#5427)
* Add sidekiq version of the corresponding delayed job
* Switch the invocation of the delayed job from `after_create` to
`after_create_commit` to avoid the race condition where the worker can
be executed before the comment is persisted. Added covering spec
for this change.
2020-01-10 13:59:12 -06:00
Pablo Ifrán
bac4b7fac4 Move Users::ResaveArticlesJob to Sidekiq (#5398)
Change Resave Articles job to worker, and add missing specs on the user
model when changing the trigger attributes
2020-01-10 13:56:39 -06:00
Ben Halpern
f78b89e763
Add suggested tags to SiteConfig (#5426) [deploy]
* Initial base work

* Add suggested tags config

* Downcase suggested tag input
2020-01-10 12:33:37 -05:00
Maykon Menezes
cf4dc80250 Move Podcast Episode Bust Cache Job to Sidekiq (#5416) [deploy] 2020-01-10 10:08:59 -06:00
serena
00fd2f4518 Remove Unused NewBadgeAchievementJob (#5437) 2020-01-10 10:07:36 -06:00
Mukesh Chaudhary
d479a77aab Remove New Reaction Job and Spec (#5422) [deploy] 2020-01-10 08:44:23 -06:00
Jenna Pederson
5c9302f5f1 Migrate subscribe to mailchimp newsletter job to sidekiq worker (#5423)
* Start migrating job to sidekiq worker
* Only check for badge jobs queued to sidekiq
2020-01-10 08:43:13 -06:00
Alain Mauri
c013079359 Move Classified Listing Cache Buster to Sidekiq (#5408) [deploy]
* Created the worker to bust cache for classified listings
* Created the related tests
* Removed the old job
2020-01-09 17:23:23 -05:00
Lucas Hiago
a86371e772 Remove TouchJob and do it Inline (#5410) 2020-01-09 17:22:09 -05:00
rhymes
7dd2ae9fe0 Remove notifiable access from articles and comments notifications (#5415) [deploy]
* Add created_at to comment notification data

* Remove notifiable usage from notifications partials

* Fix typo
2020-01-09 10:19:45 -05:00
Mukesh Chaudhary
48edaab5bc Migrate new reaction job 5305 (#5401)
* Add New Reaction Worker

* Add Specs for the New Reaction Worker

* Update Worker Calls in Notification Model

* Update Notification Model Specs

* Fix Code Climate Issues

* Fix notification specs to remove instance variable and complex logic

* Fix Worker Spec

* Fix Review Comments

* Undo Job Specs

Co-authored-by: Mukesh Chaudhary <45253983+mukeshchdy@users.noreply.github.com>
2020-01-09 09:51:56 -05:00
Molly Struve
86e138662a
remove persist audit job and do it inline (#5355) [deploy] 2020-01-09 08:49:22 -05:00
Asha Balasubramaniam
91663231cc Remove delayed job that calculates comment score (#5412) [deploy]
Get rid of the delayed job and corresponding spec. Follow up to https://github.com/thepracticaldev/dev.to/pull/5382
2020-01-09 08:25:03 -05:00
rhymes
d2e96007c7 Fix (some) n+1/eager loading issues (#5294) [deploy]
* Remove mock from specs to test the actual Suggester

* Fix articles API top articles n+1

* Fix n+1 in articles API with state parameter

* Remove eager loading for organization dashboard

* Eager load notifiables in notifications only when needed

* Algolia does not like this
2020-01-08 18:48:24 -05:00
Alain Mauri
5055121361 Remove Chat Channels Index Job (#5409) [deploy] 2020-01-08 16:33:40 -05:00
Pablo Ifrán
f5d3593d4f Change the way that id_code was created (#5348) [deploy]
The column id_code was created with a job in an after create callback,
that was replaced by an inline creation of the attribute
2020-01-08 16:21:39 -05:00
Anna Buianova
e09e46ec99 Creating podcasts by users (#3730) [deploy]
* Create podcast as a user [WIP]

* Sample css for podcast form

* Nicer podcasts suggesting form

* Validate podcast feed_url

* Validate podcast main_color_hex

* Fix podcasts specs

* Fix form appearance

* Placeholder for podcast main_color_hex

* Provide a link to suggest a podcast

* Add a checkbox and a role for when a podcast is added by an owner

* Prettier checkbox in the podcasts form

* Added creator to podcasts

* Set the podcast creator

* Fix the /pod spec

* Added creator information to the internal podcast page

* Added cta class to the podcasts submit button

* Global notice when a podcast was suggested

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-01-08 16:14:25 -05:00
rhymes
482a77a375 Restore default email from SiteConfig for mailers (#5399) [deploy]
* Restore default email from SiteConfig for mailers

* Fix broken email preview
2020-01-08 16:09:32 -05:00
gverger
b7bb006d70 Fix ProMembership Time flaky test (#5402)
After traveling back in time, it can be the case that between the call
to the service and the moment we check the current time, we moved on to
the next second.

Using Timecop.freeze takes care of that.
2020-01-08 16:06:10 -05:00
Maykon Menezes
a9cb13c3f6 moving org bust cache job to sidekiq (#5406) [deploy] 2020-01-08 15:03:40 -05:00
Cadu Ribeiro
00a97b2051 Migrate Users/FollowJob to Sidekiq (#5403) 2020-01-08 15:03:18 -05:00
Molly Struve
7c939dc2c5
Remove TouchFollowerJob and do user update inline (#5391) [deploy] 2020-01-08 14:12:04 -05:00
Asha Balasubramaniam
1003f71c8f Migrate delayed job that calculates comment score to sidekiq (#5382) 2020-01-08 14:11:31 -05:00
rhymes
fec196ffe3 Add wait_for_javascript to flaky system tests (#5405) 2020-01-08 13:47:08 -05:00
Molly Struve
64ca1e7638
Set type for user_selects_looking_for_work_spec to system (#5390) 2020-01-08 12:16:33 -05:00
Michael Kohl
728a05c476 Move from env variables to SiteConfig (#5385) [deploy]
* Move from env variables to SiteConfig

Related to #5384

This PR only deals with the first remaining part outlined in the issue, starting to use existing SiteConfig keys instead of the env variables.

* Restore Envfile to original version for now
2020-01-07 16:36:24 -05:00
Molly Struve
6b23e327aa
Track Queue sizes and latency for Sidekiq (#5352) [deploy] 2020-01-07 11:57:13 -05:00
Cadu Ribeiro
4d7d3edb2d Remove Articles/BustMultipleCachesJob (#5388)
This is a follow up from #5309.
This commit removes the Articles/BustMultipleCachesJob after we migrated
it to Sidekiq.
2020-01-07 11:20:06 -05:00
serena
252027ad9c use new_badge_achievement_worker instead of active job (#5358) [deploy] 2020-01-07 08:16:17 -05:00
Molly Struve
d5b3a10061 Handle Missing article_id When Loading additional_content_boxes (#5376) 2020-01-06 15:56:49 -05:00
Molly Struve
a572a96921
Remove comments user_touch job and do it inline when comment is created (#5378) [deploy] 2020-01-06 15:52:59 -05:00
Molly Struve
bc2dbd8e7f
Move Events::BustCacheJob to Sidekiq and rename (#5379) 2020-01-06 15:51:46 -05:00
Cadu Ribeiro
93514e73df Migrate Articles/BustMultipleCachesJob to Sidekiq (#5309) [deploy]
Related to: #5305

In order to move all the jobs to Sidekiq, this commit creates a new
Articles/BustMultipleCachesWorker using Sidekiq based on the
Articles/BustMultipleCachesJob (this one is not removed until we know
that any job on this one will be performed).
2020-01-06 13:42:34 -05:00
Lud
d39aa6537f removes job moved to worker: follows send email notification (#5357) 2020-01-06 08:11:54 -05:00
rhymes
97d188264f Add worker: option to sidekiq_enqueued_jobs to return also jobs by worker (#5334) 2020-01-03 14:54:44 -05:00
Molly Struve
5f5dd528e1 Remove unused UpdateAnalyticsJob code (#5335) [deploy] 2020-01-03 14:22:39 -05:00
serena
caa1738b16 delete unused mention job, update spec with helper (#5349) [deploy] 2020-01-03 14:08:47 -05:00
Pablo Ifrán
5e9376e955 Remove old create first reaction job (#5347) [deploy]
This job was replaced by the worker with the same name as the suffix
Worker instead of Job, it was kept to run the existing jobs before it
can be fully removed
2020-01-03 12:40:48 -05:00
Edward Tam
cb98b3b510 pages bust cache job sidekiq refactor (#5338) [deploy]
* Refactored Pages::BustCacheJob to Pages::BustCacheWorker
* Removed Pages::BustCacheJob and specs
Co-authored-by: Edward Tam <edward6882990@gmail.com>
2020-01-02 15:16:09 -05:00
Lud
df042d6b0b Refactors ActiveJob to SidekiqWorker: Follows::SendEmailNotificationWorker (#5322) [deploy]
* Refactors ActiveJob to SidekiqWorker: Follows::SendEmailNotificationWorker
* improves naming of User#receives_follower_email_notifications?
* adjust expect count for spec SendEmailNotificationWorker
2020-01-02 13:35:09 -05:00