Commit graph

87 commits

Author SHA1 Message Date
Joe Doss
5edff0182f
Update buildkite.yml (#11820)
Admin merging to disable the conditional for a quick test. TravisCI tests do not need to run for this PR.
2020-12-08 18:31:20 -06:00
Joe Doss
a8b9e9ab95
Add debug to actions. (#11819) 2020-12-08 18:12:06 -06:00
Joe Doss
4504ac15ec
GitHub Action bug fixes (#11816)
* Update if statement w/r/t github.event.issue.pull_request conditional and update
cirrus-actions/rebase to 1.4.

* Fix running the PR comment workflow so it only runs if

github.event.pull_request.head.repo.full_name != github.repository

How neat!
2020-12-08 16:54:28 -06:00
Joe Doss
bb849bf319
Try to fix GitHub Action conditionals again... (#11807) 2020-12-08 10:38:09 -06:00
John Losito
c55dacf598
Check github actions weekly with dependabot (#11779)
* Check github actions weekly with dependabot

* Update dependabot.yml
2020-12-08 11:36:25 -05:00
Joe Doss
71ad902315
Fix YAML so it is actually valid GitHub Action YAMLs. (#11801) 2020-12-08 09:48:49 -06:00
Joe Doss
08447cfea2
Update buildkite.yml (#11799) 2020-12-08 09:02:09 -06:00
Joe Doss
58b7906fe6
GitHub workflow for /ci trigger (#11794)
* GitHub workflow for /ci trigger

Add in GitHub workflow for adding the `ci` label to the PR and running Buildkite
pipeline(s).

The `ci` label will allow the PR to be built on push without havinvg to continuously
issue the `/ci` trigger from a Forem team member.

```
build.pull_request.repository.fork != true || build.pull_request.labels includes "ci"
```

Also using the `/ci` trigger will run the initial pipeline builds too.

* Fix YAML formatting and typos.

* Add note to PR template.

* Conditionally add a comment to a new PR when it originates from a third-party
fork with a note about having to wait for manual approval for our CI to run on
their PR.

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: Michael Kohl <citizen428@dev.to>

* Update .github/workflows/pr.yml

Co-authored-by: Michael Kohl <citizen428@dev.to>

* Adjust if statement to include OWNERS and do startsWith instead of contains.

Co-authored-by: Michael Kohl <citizen428@dev.to>
2020-12-08 08:32:47 -06:00
Sarthak Sharma
6dee5edd0e
🚀 Ability to allow tag moderators to create chat channels (#9741)
* Feature 🚀 : Ability to delete messages in chat channels

- Sending message ID to frontend
- Deleting Message
- Use pusher to delete message realtime

* Minor Bug 🐞: Show message action only for current user

- User can delete or edit their own messages

* Test cases added

* Bug 🐞: Update message id for receiver

Message id was not sent to receiver by pusher

* Refactoring🛠: Message controller refactoring

* Test Cases📝 : Specs for Delete message added

* Feature 🚀 : Ability to edit messages

* Test Cases📝 : Specs for Edit message added

* Merge conflict resolved

* UI completed for Create Channel

* API for create channel & invitations

* 🚀 Combining Backend and Frontend

* Test cases added

* UI completed for Create Channel

* API for create channel & invitations

* 🚀 Combining Backend and Frontend

* Test cases added

* fix suggestions

* add test cases

* replace mod_relations_admin to tag_moderator

* fix test cases

* refactor and fix code climate issues

* Update app/controllers/chat_channel_memberships_controller.rb

Co-authored-by: Michael Kohl <me@citizen428.net>

* fix suggestions

* renaming the methods

* Update app/javascript/chat/chat.jsx

Co-authored-by: Nick Taylor <nick@iamdeveloper.com>

* Update app/javascript/chat/components/createChatModal.jsx

Co-authored-by: Nick Taylor <nick@iamdeveloper.com>

* add jsDoc and add validation

* add PR suggestions

* renmae the file name to  PascalCase

* add styled component

* refactor channel button component

* fix specs

* fix code smell issues

* fix file name issue

* handle error message

* add jsDoc

* Update app/controllers/chat_channels_controller.rb

Co-authored-by: Michael Kohl <me@citizen428.net>

* refactor chat_channel_helpers

* update old hash to new hash

* Update app/javascript/chat/components/ChannelButton.jsx

Co-authored-by: Nick Taylor <nick@iamdeveloper.com>

* Update app/views/chat_channels/index.html.erb

Co-authored-by: Michael Kohl <me@citizen428.net>

* fix syntax error

* Update app/views/chat_channels/index.html.erb

Co-authored-by: Nick Taylor <nick@iamdeveloper.com>

* Policies changed

* The Disable Button issue 🐞

* Fixing Disabled button Issue 🐞

* New group doesn't show up 🐞

Co-authored-by: Narender Singh <narender2031@gmail.com>
Co-authored-by: Michael Kohl <me@citizen428.net>
Co-authored-by: Nick Taylor <nick@iamdeveloper.com>
2020-12-08 13:10:36 +07:00
Lisa Sy
ea00c808bd
Storybook: Add DocsPage and test out static content (#11397)
* Update naming of guidelines section and improve Introduction page

* Add Docs

* Add docs

* Install Docs add-on

- Rename top-level folders and sort manually
- Add MDX static pages

* Updated all Storybook addons to 6.1.3 except for notes as it's currently 5.3.21

* Fixed naming of section for the select component.

* Updated yarn.lock file.

* Added missing dependency @storybook/addon-docs

Co-authored-by: Nick Taylor <nick@dev.to>
2020-12-02 09:56:38 -08:00
Joe Doss
1d4685219d
Multistage container builds (#11468)
* WIP multi-stage container build.

* Move to a multistage build process in the Containerfile.

* Enable testing container

* Finalize the multistage build script and Containerfile. Ooof!

I got blocked for a bit with this bugger:

Step 27/32 : COPY --from=builder --chown=${APP_USER}:${APP_USER} ${APP_HOME} ${APP_HOME}
failed to copy files: failed to copy directory: Error processing tar file(exit status 1): Container ID 100999 cannot be mapped to a host ID

but https://github.com/phusion/passenger-docker/issues/235#issuecomment-636318827

was a good shove in the right direction!

* Fix bugs on container build script.

* Adjust compose files to use multistage builds.

* Add in Buildkite pipeline for building containers.

* Update CODEOWNERS to claim ownership over things that Systems Eng cares about
2020-11-19 10:03:35 -06:00
Marcy Sutton
89e0ea79bb
Update PR template to prompt for accessibility (#11407)
* Add accessibility section to PR template

* Add accessibility section to Forem docs

* Incorporate PR review feedback
2020-11-18 11:52:57 -05:00
Peter Frank
cbde504e91
Add admin guide to "added to docs?" section of PR template (#11366)
I'm linking to the GitBook generated version (https://forem.gitbook.io/forem-admin-guide/) and not the GitHub repo (https://github.com/forem/forem-admin-guide) but I could see the opposite being better.  Open to suggestions.
2020-11-11 11:33:31 -05:00
Michael Kohl
32e461c66b
Update to Ruby 2.7.2 (#10594)
* Update to Ruby 2.7.2

* Update remaining files

* Remove VERBOSE from development.rb and test.rb

* Update Ruby version for dependabot and docs

* Readd accidentally removed code
2020-11-05 16:11:09 +01:00
Vaidehi Joshi
bbc55e2e7b
Update PR template's "has tests?" section (#11088)
* Update PR template to help prompt us all to think a bit deeper about whether testing a code change is actually possible/doable/necessary before checking “no” in the template.

* Standardize around capitalization in PR template checkboxes
2020-10-26 10:12:04 -07:00
rhymes
aa39a1f801
Update CODEOWNERS to remove old teams (#10538) 2020-10-02 12:20:29 -04:00
Mac Siri
df245e7e84
Create codeql-analysis.yml (#10276) 2020-09-11 09:46:45 +02:00
Nick Taylor
ae32687164
Update repository links in PR template (#9760)
* Updated PR template links to https://github.com/forem/forem/...

* Changed DEV to Forem in the wording in the template.
2020-08-12 18:08:56 -04:00
ludwiczakpawel
d5e13f5ba7
Github's bug report template (#9736)
* flare tag line height

* .

* dropdown fix + actions bar fix

* actions bar on mob

* .
2020-08-11 09:25:52 -04:00
Josh Puetz
7d4a7cc883
[deploy] Change lingering /internal paths to /admin (#9673)
* Change lingering `/internal` paths to `/admin`

* Fix multiline test expectation
2020-08-07 19:52:39 -04:00
Nick Taylor
1faa7c723f
Updated docs.dev.to to docs.forem.com (#9666) 2020-08-07 11:24:53 -04:00
Alberto Pérez de Rada Fiol
8b882dd512
Add workflow automating maintainers' comment on new issues (#9488)
* Add workflow automating maintainers' comment on new issues

* Add steps

* Convert steps to a list
2020-07-29 14:17:47 +02:00
Yash Dave
c9ff792497
fix actions/checkout to v2 for rebase workflow (#9515) 2020-07-28 10:34:35 -05:00
Michael Kohl
8425c847c3
Update CODEOWNERS and team names in TODO comments (#9460)
* Update CODEOWNERS

* Update teams in TODO comments

* Remove mentions of team cool
2020-07-24 12:17:20 +07:00
Mac Siri
7ceb5550a2
Remove codeql-analysis.yml (#9354) 2020-07-16 12:15:38 -04:00
Molly Struve
e2d58f862c
[deploy] Remove codeql analysis for right now (#9308) 2020-07-14 12:37:45 -05:00
rhymes
b42a843b78
Add Github CodeQL code scanner for JavaScript (#9217)
GitHub released a code analysis engine that scans the code for potential issues called CodeQL.

Among the list of supported languages we only use JavaScript
2020-07-09 14:16:48 -04:00
Jacob Herrington
9285abcd5e
Remove first interaction workflow (#9112)
This workflow is currently not function as expected. I'm not sure why it
would not be more clearly documented, but there doesn't seem to be a way
that this would actually work to leave a comment on a first time
contributor's PR (given that the contributor is using a fork)...

Relevant discussions:
https://github.com/actions/first-interaction/issues/10
https://github.community/t/github-actions-are-severely-limited-on-prs/18179#M9249
2020-07-05 18:14:10 -04:00
Jacob Herrington
0b973c9d82
Allow organization owners to use the Automatic Rebase workflow (#9090)
* Allow org owners to kick off automatic rebase

I suspect without this change PBJ couldn't kick off the automatic rebase
workflow.

This also includes a tweak to our method for determining if this is a
comment on a PR. I personally think this method is more explicit and
therefore readable.

* Add explanatory comment to rebase workflow

This might help someone determine what the workflow does at a glance, it
also documents a slightly unexpected caveat: The workflow can't be
triggered if your organization membership is private.

* Trigger Travis

Co-authored-by: rhymes <rhymesete@gmail.com>
2020-07-03 10:49:40 -05:00
Jacob Herrington
10bb220e1d
Add a workflow to greet new contributors (#9096) 2020-07-03 09:44:41 -05:00
Awasum Yannick
f298f8c41f
Enable Automatic Rebase: Fix #8927 (#9018)
* Enable Automatic Rebase: Fix #8927

* Update rebase.yml to use startsWith

Use startsWith() instead of contains() in Github Action so as to prevent accidental Rebase of PRs.
2020-07-02 12:42:21 +02:00
dependabot-preview[bot]
92c72ab2c5
[deploy] Bump twilio-ruby from 5.37.0 to 5.38.0 (#8968) 2020-06-29 09:39:41 -05:00
Molly Struve
ff1686c70e
Update SRE files in CODEOWNERS (#8857) 2020-06-23 10:07:53 -05:00
Vaidehi Joshi
2b6510f4ea
Add QA instructions to pull request template (#8412) 2020-06-11 10:49:39 -07:00
Joe Doss
284b6ee1e1
Update dependabot.yml (#8143) 2020-05-28 13:45:47 -05:00
Joe Doss
a913103e7d
Update dependabot.yml (#8140) 2020-05-28 12:30:26 -05:00
Joe Doss
a607cbbf41
Update vendor/cache After Dependabot (#8135)
* Create dependabot.yml with 

bundle config cache_all_platforms true
bundle config set cache_all true

so we cache gems in the workflow.
2020-05-28 12:15:43 -05:00
Ridhwana
0373965435
Implement sentence construction changes on PR template (#7588)
* chore: update PR template

* chore: change language

* chore: revert change after triggering build
2020-04-29 09:39:13 -04:00
Nick Taylor
3311023163
Linked to CoC and Contrib guide, plus explicit message about small PRs. (#7569)
* Linked to CoC and Contrib guide, plus explicit message about small PRs.

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-Authored-By: Vaidehi Joshi <vaidehi.sj@gmail.com>

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-Authored-By: Vaidehi Joshi <vaidehi.sj@gmail.com>

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-Authored-By: Vaidehi Joshi <vaidehi.sj@gmail.com>

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-Authored-By: Vaidehi Joshi <vaidehi.sj@gmail.com>

* Made changes based on PR comments.

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2020-04-28 15:37:29 -04:00
rhymes
fd75f70c06
Add Nick to codeowners for JS deps (#6890) 2020-03-26 18:39:17 +01:00
Ben Halpern
ec98a4f271
Remove Greetings workflows (#6453) 2020-03-04 13:37:31 -05:00
Ridhwana
dee8d39fe7
Ridhwana/Remove shecoded (Please do NOT merge as yet) (#6357) [deploy]
* chore: remove she coded route

* chore: remove the shecoded page

* chore: remove some assets

* chore: remove shecoded pages controller action
2020-03-02 10:20:42 -05:00
Mac Siri
2c6fc937cd
Create greeter (#4727)
* [WIP] Create greeter

* Update greeter
2020-02-18 13:31:00 -05:00
rhymes
f14b5f93fe
Update README and contributing guide (#6074)
* Update readme

* Update contributing guide

* Update prepare PR guides to mention draft PRs
2020-02-17 11:53:49 -05:00
Mac Siri
02fc46a3e9
Delete weekly-digest.yml (#6062) 2020-02-14 16:13:52 -05:00
Molly Struve
0bfbd9bb1f
Set Up Framework For Running Data Update Scripts (#6025) [deploy] 2020-02-13 10:48:23 -05:00
Vaidehi Joshi
ee5aa1ff1a
Add more paths for team delightful in CODEOWNERS file (#6050) 2020-02-12 14:38:59 -08:00
Michael Kohl
3f08572306
Update PR template (#5979)
Now questions tests and post-deployment tasks
2020-02-11 18:34:11 -05:00
rhymes
bc876465fc
Assign teams to files and directories (#6020) 2020-02-11 12:04:01 -05:00
Jacob Herrington
06326a7b33
Update codeowners for Team snackCase (#5714)
This way Andy and I will both receive notications. Andy was taking
priority over me on some of these files.
2020-01-24 16:58:19 -06:00