Commit graph

3305 commits

Author SHA1 Message Date
Julianna Tetreault
94a24f2c75
Remove cover image background styling from article-show.css (#7448)
* Removes dead code for background and background-size
* Crosses fingers that nothing breaks after style removal
2020-04-27 14:49:48 -06:00
Mac Siri
f4000a1809
[deploy] Render onboarding on small screens correctly (#7548) 2020-04-27 16:16:33 -04:00
Molly Struve
8eb4612166
[deploy] fix podcast episode comment rendering and write a spec for it (#7547) 2020-04-27 14:56:03 -05:00
Vaidehi Joshi
54519dbf4e
Minor tweaks to onboarding UI (#7546) [deploy]
* Use accent-color in onboarding progress stepper

This looks much prettier with the default DEV theme when viewing onboarding.
Closes https://github.com/thepracticaldev/dev.to/issues/7545.

* Align onboarding checkboxes in their parent element

Use `display: flex`.
Closes https://github.com/thepracticaldev/dev.to/issues/7544.
2020-04-27 12:38:48 -07:00
Rafi
bdcfba7d70
[deploy] Saving youtube url (#7516)
* Saving youtube url

* Fixing description in the spec

* Optimizing youtube logo svg

* Fixing indentation of form
2020-04-27 14:14:07 -04:00
Andy Zhao
fded16b8dc
[deploy] Add a more helpful msg for response templates (#7543) 2020-04-27 13:28:28 -04:00
Alex
6bbe4e0533
[deploy] Change CarrierWave error code (#7539) 2020-04-27 13:27:04 -04:00
Michael Wilde
dfd8b0bf86
[deploy] Fixed "Join the Welcome thread" spelling err (#7538)
Was "welcome thead" now is "welcome thread".  I noticed the spelling error show up as I recently just joined dev.to
2020-04-27 18:24:40 +02:00
Lisa Sy
9de59c4107
Update sidebar filter menu on Notifications (#7394) 2020-04-27 12:17:20 -04:00
rhymes
2d26318cf9
[deploy] Replace (black|white)list with more inclusive language (#7459)
* Replace isBlacklisted

* Update fastly.rake task

* More renames

* Rename Faslty config file

* More changes

* Replace isForbiddenFromPreloading with isNotPreloadable

* Skip problematic test

* Re-enable
2020-04-27 18:00:12 +02:00
Andy Zhao
ae4ba673c4
[deploy] Show reactable username for reactable_type == User (#7527)
* Show reactable username for reactable_type == User

* Add test for GET /internal/reports vomit reaction on user
2020-04-27 11:27:45 -04:00
Molly Struve
527c98fa01
[deploy] remove no longer used index! and check for main_image method in view (#7526) 2020-04-27 10:16:49 -05:00
rhymes
1c3b619583
[deploy] Fix settings billing section and other profile improvements (#7525)
* Truncate displayed username length to max length

* Better error notice

* Fix broken billing Stripe functionality

* Display server side credits purchasing errors

* Be explicit in the name of the partial

* Full name
2020-04-27 16:59:03 +02:00
rhymes
d87c3dbb18
[deploy] Improve comment posting error handling (#7519)
* Improve comment posting error handling

* Incorporate PR suggestions
2020-04-27 16:54:59 +02:00
Ridhwana
b9a8d87e95
[deploy] Refactor to create a helper for the mailer links (#7502)
* refactor: set the email_from to use in teh defaults

* chore: remove some new lines

* feat: add a mail link helper that can be used in the views

* feat: returns the default if it doesn't understand the parameter

* feat: Quick replacement of links

* feat: allow subject to be passed through

* chore: update all hrefs

* chore: remove rel attribute

* chore: mail link

* update spec

* chore: space

* chore: update some whitespaces and emails

* style

* chore: PR mail_link to email_link and the comment

* feat: PR suggestions for encoding

* feat: use mail_to
2020-04-27 09:18:16 -04:00
rhymes
9d1ad76a21
Fix reading list pagination (#7518) 2020-04-27 09:17:50 -04:00
Ben Halpern
3d985319dd
[deploy] Fix notice in accepting invites (#7522) 2020-04-26 21:40:51 -04:00
Ben Halpern
921b2e73b6
Line up params properly in Bufferizer (#7521) 2020-04-26 20:51:57 -04:00
Ben Halpern
9070174138
[deploy] Fix chatchannel pagination in connect (#7520) 2020-04-26 19:45:36 -04:00
Ben Halpern
d447d0cadf
[deploy] Update design and functionality of internal/articles (#7517)
* Update design and functionality of internal/articles

* Fix spec

* Update specs

* Fiddle with test

* Fix request spec
2020-04-26 18:27:09 -04:00
Ben Halpern
7a6e7301a1
[deploy] Small update to /connect design (#7510)
* Initial work

* Full screen mode adjustments

* Update snapshots
2020-04-26 13:26:49 -04:00
Sujith
28d24854c6
Modal not closing while choosing tag filter (#7497)
* modal not closing while choosing tag filter

Modal did not close upon choosing the filter tag.

* improved if condition  referring codeclimate

refactored if condition by declaring a static array list for checking target id exist in the array list

* removed unwanted function

Removing a function added by me
2020-04-26 12:55:34 +02:00
Lucas Hiago
d989b9d842
Add style for images on email to turn them responsiveness (#7247)
* Change property for max-width to turn more responsive

* Change css property for images to turn more responsive in mention email
2020-04-26 12:33:16 +02:00
Molly Struve
a7e664fc9c
[deploy] Remove Algolia from User Model (#7454)
* Remove Algolia from User Model

* check banned on self for user

* fine have your redundant method

* remove a couple more unnecessary specs
2020-04-24 18:39:36 -04:00
Molly Struve
94f3a4b6fd
[deploy] Remove Algolia from Podcast Episodes (#7489) 2020-04-24 18:36:13 -04:00
Guilherme Vinicius Moreira
31c0b388e5
Refactor internal users index (#7457)
* Refactor internal users index

* Add table-hover to users table

* Add users query spec
2020-04-24 17:27:07 -04:00
rhymes
f5a6ff32cc
Finalize Slack messengers refactoring (#7484)
* Remove dead code

* Rename SlackBotPingWorker to Slack::Messengers::Worker

* Remove useless Slack mock

* Fix specs
2020-04-24 21:15:10 +02:00
Fernando Valverde
baac7997c3
[deploy] Send push to Android phones and use Pusher broadcasting (#6883) 2020-04-24 13:50:59 -04:00
rhymes
0186fd9aee
Add Retry-After for API rate limit errors and document limits in API spec (#7444)
* Add correct rate limit exception to Articles::Updater

* Send Retry-After with HTTP 429 back to the client

* Update API specs for error 429

* Test build

* Fix spec

* Add retry after to ImageUploadsController and fix specs

* Generalize a bit
2020-04-24 17:35:28 +02:00
Michael Kohl
f791e84f2d
Filter classified listings by published status for mods (#7432)
* Filter classified listings by published status for mods

* Change checkbox label, invert logic, respect checked status
2020-04-24 10:31:29 -04:00
Molly Struve
4ab202ab0a
[deploy] Execute Reading List searches in Elasticsearch (#7440)
* Execute Reading List searches in Elasticsearch

* add additional readinglist front tests
2020-04-24 10:30:17 -04:00
Mac Siri
57ae315c31
[deploy] Generalize Onboarding's task-card image (#7452)
* Generalize Onboarding's task-card image

* Rename SiteConfig's onboarding_taskcard_sticker

* Add & reorganize #config_params

* Update Internal::Config's view

* Add spec
2020-04-24 10:24:50 -04:00
Michael Kohl
02d23a0673
Refactor jbuilder (#7411)
* Refactor jbuilder for articles

* Refactor remaining jbuilder files

* Fix specs

* Remove content_truncated from response template JSON

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-04-24 12:49:12 +02:00
Vaidehi Joshi
e19eb60d1f
Add skip/continue functionality to onboarding navigation (#7488) [deploy]
* Dynamically render forward text in Navigation component

* Render either "Skip for now" or "Continue" on the FollowTags, ProfileForm, and FollowUsers components.
* Refactor the ProfileForm component to dynamically change the button text based on the form's state.

* Render specific button text for last onboarding slide

* Fix back arrow styles for accessibility

Also set an explicit width on the containing button around the svg.

* Use min-width to specify back-button size
2020-04-23 16:30:48 -07:00
Julianna Tetreault
2a74f6f811
Refactor SEO Optimized Images (#7494)
* Add seo_optimized_images method to article_json_ld
  * Add inline documentation for images in method
  * Add to stories_controller.rb with other JSON-LD

* Fix inconsistencies in stories_show_spec.rb tests
2020-04-23 19:26:29 -04:00
Alex
b6664456c0
[deploy] Validate filenames server-side (#7405) 2020-04-23 14:30:59 -05:00
Ben Halpern
4a28f90b29
[deploy] Fix height/width mismatch (#7485) 2020-04-23 13:38:10 -04:00
Molly Struve
7f98d7e54c
[deploy] Revert "Remove algolia from podcast episode model (#7453)" (#7481)
This reverts commit b29671cb7f.
2020-04-23 11:01:01 -05:00
rhymes
6d9ecb45e6
[deploy] Authentication refactoring: improve testing on OmniauthCallbacksController (#7439)
* Improve testing on OmniauthCallbacksController

* Remove removal of legacy cookie and added validation comments
2020-04-23 17:27:04 +02:00
Molly Struve
b29671cb7f
[deploy] Remove algolia from podcast episode model (#7453) 2020-04-23 10:21:37 -05:00
Julianna Tetreault
91e4cd26ed
Specify SEO-Optimized Width and Height for Cover Images (#7447)
* Specify SEO optimized width and height for cover images in articles JSON-LD
  * Specify 1:1 ratio for cover images in stories_controller.rb
  * Specify 4:3 ratio for cover images in stories_controller.rb
  * Specify 16:9 ratio for cover images in stories_controller.rb
  * Optimize images for SEO purposes by specifying width and height

* Change aspect ratio to be 1600x900 in stories_controller.rb
  * Makes aspect ratio for article cover images smaller in JSON-LD

* Add options to social_image_helper.rb
  * Adds options to article_social_image_url call
2020-04-23 08:30:28 -06:00
Anna Buianova
bc8df2bb57
Replaced hardcoded 'the practical dev' with the community name (#7460)
* Replaced hardcoded 'the practical dev' with the configurable community name
* Replaced url with url helper
2020-04-23 16:09:50 +03:00
Nick Taylor
d3171fb3c8
Created Snackbar components (#7415)
Created the Snackbar components.
2020-04-23 08:27:50 -04:00
Ridhwana
17fdc556ee
Generalization: Replace static dev emails with configurable ones. (#7438)
* feat: update the email addresses in the site config

* chore: update the default email address everywhere

* feat: update the template for the config

* chore: remove default_site_mail as an allowed parameter

* feat: change biz@dev.to to teh business email address and with a subject

* feat: update partners@dev.to to use SiteConfig.email_addresses[:business]

* feta: update to business email address

* feat: update members@dev.to to use the site config

* feat: update privacy email

* chore: Anna's suggestion to loop through object instead of keys
2020-04-23 11:26:58 +02:00
Michael Kohl
9df68f3920
Use new classified listing categories (#7250)
* Add ClassifiedListingCategoryModel

* Add data update script for classified listing categories

* Refactor and fix specs

* Resolve conflict

* Incorporate PR feedback
2020-04-23 10:06:58 +07:00
Vaidehi Joshi
046ec2eaee
Use back button svg icon in onboarding slides (#7455) [deploy] 2020-04-22 16:54:46 -07:00
Vaidehi Joshi
5f67f7b2e3
Add a progress stepper to onboarding flow (#7450) [deploy] 2020-04-22 13:59:43 -07:00
Julianna Tetreault
8b6566da6b
Allow Height and Width to be Specified in Options (#7417)
* Allow height and width to be specified in options in CloudCoverUrl

* Allow height and width to be specified in options in social_image.rb
  * Remove options from cloud_cover_url.rb in favor of social_image.rb

* Add double splat operator for height and width options in social_image.rb
  * Add double splat operator to options in application_helper.rb
  * Add options to call in article_serializer.rb

* Remove options from the CloudCOverUrl call in application_helper.rb

* Remove options from article_serializer.rb

* Add height and width variables to cl_image_path
  * Remove hardcoded height and width from social_image.rb

* Adjust width to be 500 rather than 420 in social_image.rb
2020-04-22 15:04:32 -04:00
Ben Halpern
f677e7f4f0
[deploy] Fix task card unstyled issue for rollout (#7449) 2020-04-22 14:24:38 -04:00
Mac Siri
a181a3af3a
[deploy] Remove Onboarding's ClosingSlide (#7443) 2020-04-22 14:08:10 -04:00