cyrillefr
4fd66372dc
Enable Layout/AlignParameters ( #2340 )
...
Check if the parameters on a multi-line method call or definition are aligned.
Resolves : #2021
2019-04-08 18:47:34 -04:00
rhymes
c99fb27451
Add published in the SQL query to retrieve article ( #2248 )
...
Since we're already asking the DB to retrieve an article, we can directly ask it to filter out published articles without checking at runtime.
2019-04-01 06:24:17 -04:00
Abraham Williams
9cb40e546b
Enables Rails cops ( #2186 )
...
* Enable Rails cops
* Fix Rails/DynamicFindBy
* Fix Rails/HttpStatus
* Fix Rails/Blank
* Fix Rails/RequestReferer
* Fix Rails/ActiveRecordAliases
* Fix Rails/FindBy
* Fix Rails/Presence
* Fix Rails/Delegate
* Fix Rails/Validation
* Fix Rails/PluralizationGrammar
* Fix Rails/Present
* Fix Rails/Output
* Fix Rails/Blank
* Fix Rails/FilePath
* Fix Rails/InverseOf
* Fix Rails/LexicallyScopedActionFilter
* Add Rails/OutputSafety to TODO
* Add Rails/HasManyOrHasOneDependent to TODO
* Add Rails/SkipsModelValidations to TODO
2019-03-25 09:25:55 -04:00
Keshav Biswa
8d57d45ecc
Rubocop Style cops enabled ( #2056 )
...
* Rubocop enabled style/alias
* Enabled Style/ArrayJoin Cop
* Enabled Style/Attr
* Enabled Case Equality
* Enabled CharacterLiteral
* Enabled ColonMethodCall Cop
* Enabled CommentAnnotation cop
* Enabled PreferredHashMethods Cop
* Enabled DoubleNegation Cop
* Enabled EachWithObject Cop
* Enabled EmptyLiteral Cop
* Enabled EvenOdd Cop
* Enabled IfWithSemicolon Cop
* Enabled Lambda and LambdaCall Cop
* Enabled LineEndConcatenation Cop
* Enabled ModuleFunction Cop;
* Enable NegatedIf and NegatedWhile Cop
* Enabled NilComparison Cop
* Enabled Not Cop
* Enabled NumericLiterals Cop
* Enabled OneLineConditional Cop
* Enabled PercentLiteralDelimiters Cop
* Excluded internal/users_controller from negated_if cop
* Reverted the double negation change from github_issue_tag and github_issue.rb"
* Enabled PerlBackrefs Cop
* Changed Regexp.last_match(1) to Regexp.last_match(0)
* Enabled proc cop
* Enabled RaiseArgs Cop
* Reverted Regexp.last_match(0) to Regexp.last_match(1)
* Enabled SelfAssignment Cop
* Enabled SingleLineMethods Cop
* Enabled SpecialGlobalVars Cop
* Enabled VariableInterpolation Cop
* Enabled WhenThen Cop
* Enabled WhileUntilModifier Cop
* Enabled WordArray Cop
* Enabled IfUnlessModifier Cop
* Enabled GuardClause Cop
2019-03-15 18:33:54 -04:00
James Turner
a9254eac40
Fix typo in surrogate key header ( #2013 )
2019-03-11 17:40:45 -04:00
Ben Halpern
a0d90874a9
Move org admin privilege check into controller ( #1642 )
2019-01-24 13:35:39 -05:00
Arun Kumar
80a23ba403
Fix rubocop offenses ( #1452 )
2019-01-03 09:23:38 -05:00
rhymes
6553f08d94
Rubocop cleanups ( #1415 )
...
* Update rubocop-todo.yml with new violations
* Fix Layout/EmptyLine* rules
* Fix Layout/Indentation* rules
* Fix remaining Layout/* rules
* Fix Lint/DuplicateMethods by removing unused accessor
* Fix Lint/IneffectiveAccessModifier
* Fix Lint/MissingCopEnableDirective
* Re-run rubocop auto gen config
* Fix Layout/RescueEnsureAlignment
* Fix Naming/* rules
* Fix some RSpec/* rules
* Fix typos
* Fix RSpec/LetBeforeExamples
* Series should only be an attr_writer, not an attr_accessor
* Fix RSpec/InstanceVariable
* Fix RSpec/InstanceVariable
* Fix RSpec/RepeatedDescription and RSpec/RepeatedExample
* Fix Style/ClassAndModuleChildren
* Fix Style/ConditionalAssignment
* Fix some Style/* rules
* Trigger Travis CI build because failing tests are not failing locally
* Revert "Fix Style/ClassAndModuleChildren"
This reverts commit 1686801d8a1516ba1894f79e24401a20dea65f99.
2019-01-02 11:20:02 -05:00
Ben Halpern
fc0175b18d
Refactor articles api controller ( #1409 )
...
* Refactor articles api controller
* Modify authorization logic in api
2018-12-27 16:47:04 -05:00
Maksim Litvinov
f2f889af77
Replace long string with array and join ( #795 )
2018-11-28 09:20:13 -05:00
Ben Halpern
1aa8e70a5b
Allow removal of collection element ( #1036 )
...
* Allow removal of collection element
* Update tests
2018-10-29 15:14:13 -04:00
Ben Halpern
359cc71b64
Add ability for users to publish series ( #1034 )
2018-10-29 13:04:42 -04:00
Ben Halpern
90861366df
Add additional config to v2 editor ( #980 )
...
* Add additional config to v2 editor
* Fix typo
2018-10-23 12:41:19 -04:00
Ben Halpern
ecb9645775
Make changes to editor ( #837 )
...
* Make changes to editor
* Make minor fixes and console log removals
* Fix test in article form
* Adjust rspec test
2018-10-05 16:03:06 -04:00
Kohei Sugi
91c3eef1e1
Fix Layout/EndAlignment lint ( #349 ) [skip ci]
2018-08-15 15:49:38 -04:00
rhymes
e588fa7ece
Code cleanups ( #659 )
...
* Initial automatic cleanup with rubocop
* Fix syntax error introduced by rubocop
* Cleanup seeds file
* Cleanup lib folder
* Exclude bin folder because it contains auto generated files
* Make Rubocop a little bit more chatty
* Block length should not include comments in the count
* Cleanup config folder
* Cleanup specs
* Updated Rubocop version and generated a todo file
* Fix broken ArticlesApi spec
* Fix tests
* Restored rubocop pre-commit hook
2018-08-07 11:00:13 -04:00
Mac Siri
0f3342bcec
[WIP] Implement non front-matter editor ( #415 )
...
* Create alternate editor
* Install linkstate (?)
Not sure how it disappear in the first place
* Run yarn install
* Modulize ArticleForm component
* Refactor
* Isolating css WIP
* Implement simplified frontmatter-less editor
* Modulize individual form element
* Ajust props names
* Transform json params to snakecase
* Remove codes
* Update /new, almost there for release
* Fix editor resize issues
* Change defaultvalue to value in article form tag element
* Modify html buttons in article form
2018-07-27 20:12:33 -07:00
Ben Halpern
fb20b8adf7
Add content sidecar for chat ( #413 )
...
* Rearchitect chat channel subscriptions
* Add browser push notifications (attempt)
* Add content sidecar for chat
* Add live code basics
* Add content features to chat
* Fix chat_channels test
2018-06-11 11:00:51 -04:00
Mac Siri
923e1acbda
Create Suggester service object ( #372 )
...
* Create Suggester::Article::Boosted
* Fix lint & Remove .compact
* Expand Suggester service-object WIP
* Create Suggester::Users
* Remove ClassicArticle
* Replace old refactored classes
* Move Suggester specs into appropriate folder
* Fix broken spec & Fix lint
* Fix lint
* Fix lint
* Fix broken code
2018-06-08 17:17:20 -04:00
Andy Zhao
4eb4ac55ce
Show only published articles for onboarding ( #337 )
2018-05-21 18:27:04 -04:00
Ben Halpern
f2101410ea
[WIP] Improve article boosting abilities and insights ( #237 )
...
* Update email subjects split test
* Create alternate editor
* Add proof of concept to emails
* Add utm for internal nav
* Add ability to boost in DEV Digest
* Adjust articles.scss
* Adjust article_form.scss
* Remove unnecessary files
* Remove files from PR
* Adjust boosted email settings
* Conditionally include organization in additional box
* Modify schema.rb
2018-05-02 12:24:54 -04:00
Ben Halpern
02cff623e4
Adjust non-tag state for onboarding suggestions ( #190 )
...
* Change onboarding limit
* Adjust non-tag state for onboarding suggestions
2018-04-06 08:35:05 -07:00
Ben Halpern
61c0a4cdaa
Change onboarding limit ( #186 )
2018-04-05 14:17:01 -07:00
Andy Zhao
deb63ab643
Add Save Articles Page to Onboarding ( #182 )
...
* Add MVP of onboarding articles
* Lint and fix unfollow all button bug
* Update onboarding tests
* Fix typo and adjust when saveAll request gets sent
* Set default to always save all articles
* Fix when request is sent for follows/saves
* Check for article length when for initial request
* Add a loading indicator for follows page
* Prevent multiple follow/save requests
* Update tests
* Add some hover and click effects
* Adjust onboarding test and suggested articles
2018-04-05 11:41:28 -07:00
Mac Siri
301c6080e3
Initial commit
2018-02-28 16:11:08 -05:00
