Commit graph

1785 commits

Author SHA1 Message Date
cyrillefr
4fd66372dc Enable Layout/AlignParameters (#2340)
Check if the parameters on a multi-line method call or definition are aligned.

Resolves: #2021
2019-04-08 18:47:34 -04:00
Andy Zhao
36a21cd0f2 Add tech admin role and allow tech admins to view /delayed_job (#2343)
* Add tech support role

* Add tech support permission method

* Enabled /delayed_job for tech support users

* Fix typo oops

* Add tests for tech support viewing /delayed_job

* Fix typo again...

* Rename tech role to tech admin
2019-04-08 18:00:59 -04:00
Ben Halpern
dfbea4c0bd
Fix social share text bugs (#2341) 2019-04-08 17:43:27 -04:00
Ben Halpern
bd95c6a8bf
Fix human language detection (#2338)
* Update language detection

* Modify feed to account for languages
2019-04-08 15:47:29 -04:00
dependabot[bot]
c406650197 Bump rails-assets-airbrake-js-client from 1.5.0 to 1.6.6 (#2330)
Bumps rails-assets-airbrake-js-client from 1.5.0 to 1.6.6.

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-08 13:07:58 -04:00
dependabot[bot]
65b3418b06 Bump autoprefixer-rails from 9.4.3 to 9.5.1 (#2332) [ci skip]
Bumps [autoprefixer-rails](https://github.com/ai/autoprefixer-rails) from 9.4.3 to 9.5.1.
- [Release notes](https://github.com/ai/autoprefixer-rails/releases)
- [Changelog](https://github.com/ai/autoprefixer-rails/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ai/autoprefixer-rails/compare/9.4.3...9.5.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-08 12:59:04 -04:00
dependabot[bot]
aea63bcaca Bump marked from 0.6.1 to 0.6.2 (#2328) [ci skip]
Bumps [marked](https://github.com/markedjs/marked) from 0.6.1 to 0.6.2.
- [Release notes](https://github.com/markedjs/marked/releases)
- [Commits](https://github.com/markedjs/marked/compare/v0.6.1...v0.6.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-08 12:55:29 -04:00
dependabot[bot]
885482a96a Bump jest-fetch-mock from 2.1.1 to 2.1.2 (#2326) [ci skip]
Bumps [jest-fetch-mock](https://github.com/jefflau/jest-fetch-mock) from 2.1.1 to 2.1.2.
- [Release notes](https://github.com/jefflau/jest-fetch-mock/releases)
- [Commits](https://github.com/jefflau/jest-fetch-mock/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-08 12:51:38 -04:00
dependabot[bot]
65bc1b02cc Bump devise from 4.6.1 to 4.6.2 (#2329) [ci skip]
Bumps [devise](https://github.com/plataformatec/devise) from 4.6.1 to 4.6.2.
- [Release notes](https://github.com/plataformatec/devise/releases)
- [Changelog](https://github.com/plataformatec/devise/blob/master/CHANGELOG.md)
- [Commits](https://github.com/plataformatec/devise/compare/v4.6.1...v4.6.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-08 12:50:31 -04:00
dependabot[bot]
d9c7a2f52f Bump twilio-video from 1.16.0 to 1.17.0 (#2327)
Bumps [twilio-video](https://github.com/twilio/twilio-video.js) from 1.16.0 to 1.17.0.
- [Release notes](https://github.com/twilio/twilio-video.js/releases)
- [Changelog](https://github.com/twilio/twilio-video.js/blob/1.17.0/CHANGELOG.md)
- [Commits](https://github.com/twilio/twilio-video.js/compare/1.16.0...1.17.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-08 11:35:21 -04:00
Anna Buianova
4ef7635ae0 Don't make additional SQL query on remembering user (#2335)
* Don't save when remembering user on sign in (WIP)

* Specs for AuthorizationService
2019-04-08 10:12:19 -04:00
Anna Buianova
f23235eab9 Improve rubocop config #2021 (#2324)
* Methods that skip validations are fine

* Fix gems order

* Enable layout cops that have no violations
2019-04-08 10:06:41 -04:00
Sidak Singh Aulakh
dbac5f6d19 Fixed fluid-comments in dark mode (#2246)
* Fixed fluid-comments

the inline fluid-comments in dark mode are now matching the syntax followed in the default theme.

* grey -> gray

* Added lighten function to fallback variable

Added lighten function to the fallback variable for anchor tags in fluid-comments
2019-04-07 17:12:49 -04:00
Jan Keromnes
6bc248e43b Automated DEV setup using Gitpod (#2321) 2019-04-07 17:08:30 -04:00
rhymes
3b4bda89df Upgrade Honeycomb gem, fix and improve RssReader tests (#2319)
* Switch from deprecated honeycomb-rails to honeycomb-beeline

* Improve error handling, tests and add refactoring

* Fix multiple fetching test and add one more

The test wasn't actually testing the correct behavior, because the class
by default force fetches. It worked because it wasn't reloading the user
from the database.

* Test that Honeycomb's client is doing its thing

* Use some defensive programming to avoid any possible problem during shutdown

* Fix typo

* Use the new API to add fields to the current measured event

* Use default instrumentation and add user info to event

* Replace user.email with user.username, less personal data around

* Use mocking instead of calling Honeycomb.init

* Freeze time before traveling

* Remove a flaky test dependent on rand
2019-04-07 15:27:53 -04:00
Perlat Kociaj
b4484ba06d integrations github repos hover and text color (#2302) 2019-04-07 15:25:41 -04:00
Ben Halpern
5f3fd96960
Modify social share button and functionality (#2316)
* Modify social share button and functionality

* Some nightmode changes tossed in

* Style adjustments and test snapshot fix
2019-04-06 14:49:52 -04:00
rhymes
a1787d0702 Fixed some Style/* rubocop violations (#2314)
* Fix Style/FormatString and Style/TrivialAccessors

* Fix Style/NegatedIf and Style/DoubleNegation

* Style/ClassAndModuleChildren is already enabled by default

* Fix Style/GlobalVars

* Group all style/ cops inside rubocop config file
2019-04-06 14:24:33 -04:00
Maxime Piard
8d67a06bd9 darken following weight input background for it to be readable (#2318) 2019-04-06 11:37:23 -04:00
Ben Halpern
42a5124fe4
Clean up videos page and add tests (#2315) 2019-04-05 16:05:50 -04:00
Jess Lee
175569fb97 "/videos" (#2291)
* set up video route

* add video index

* update styling

* fix mobile full width styling

* bust cache when new video is created

* add unlimited scrolling
2019-04-05 14:02:03 -04:00
Abraham Williams
b98565a931 Update rubocop to 0.67 (#2313) [ci skip] 2019-04-05 12:55:13 -04:00
Anna Buianova
1b9f2432f6 Conditional validations for user github_username and twitter_username #2061 (#2312)
* Conditional validation for usernames

* Allow nil, not blank for usernames
2019-04-05 11:35:26 -04:00
Ben Halpern
d7e2a07064
Finalize suggest-a-tweet functionality (#2310) 2019-04-04 19:23:03 -04:00
Ben Halpern
1552df98d2
Add ability for trusted users to suggest social copy for posts (#2306)
* Add ability for trusted users to suggest social copy for posts

* Fix schema

* Fix tests

* Fix test
2019-04-04 17:01:58 -04:00
rhymes
5e9867ec56 Simplify AnalyticsService code (#2308)
* Add basic tests for Analytics service

* User/Organization are always required

* Add some data to the test

* Use queries and date times

* Fix AnalyticsService interface in the controller

* s/HTTP_API_KEY/api-key

* Defend against nils and support datetime objects

* Update app/services/analytics_service.rb

Co-Authored-By: rhymes <rhymesete@gmail.com>

* Use SQL sum, not Rails sum

* Group average_read_time

* Use SQL, not Rails

* Use ISO date

* Fix specs
2019-04-04 16:07:57 -04:00
Mac Siri
fc39f24ee3 Migrate feature test to system test (#2301)
* Move all features to system

* Remove database_cleaner & apply use_transactional_fixtures

* Move rspec-retry to :test

* Update Capybara config

* Update rails_helper

* Fix user_visits_a_comments_page_spec.rb

* Fix lint
2019-04-04 12:15:10 -04:00
Andy Zhao
3e89796d9d Add API Analytics Endpoints (#2293)
* Add API endpoints for analytics

* Remove comment and spacing

* Use proper time formatting

* Refactor and clean up some logic

* Add pro and org member traits

* Use shared examples for analytics API spec

* Add analytics authorization specs

* Remove accidental include Pundit

* Raise not_authorized for invalid requests

* Make attributes and time methods private

* Add custom UnauthorizedError

* Raise and use rescue_from to handle 4xx requests

* Enforce date parameters to follow a specific format

* Use current user to allow same origin requests

* Use custom headers and not params for token auth

* Default to current user for same origin requests

* Use correct boolean for choosing user

* Update tests to use request headers and add stricter tests
2019-04-04 10:52:45 -04:00
Andy Zhao
7ade338002 Use nil instead of empty string w/ new db constraints (#2300) 2019-04-03 17:28:08 -04:00
Miguel Piedrafita
72dfcae674 Fix Blogcast styling issues (#2298) 2019-04-03 16:12:28 -04:00
Mac Siri
7147428821 Update Rails version on README [ci skip] 2019-04-03 14:15:17 -04:00
rhymes
3a53d5797e Upgrade Rails to 5.2.3 (#1408) 2019-04-03 13:08:59 -04:00
Anna Buianova
509c11e86f New comment notifications to Active Jobs #1996 (#2287)
* Send new comment notification service + specs

* Call new comment notification service from the model

* Return to non-bang notifications create

* An ActiveJob for the new comment notifications

* Call comments notification ActiveJob from Notification
2019-04-03 11:38:30 -04:00
Mohammadjavad Raadi
1fd637cd37 Fixes Upload Video Section Background Color in Night Mode Theme #2245 (#2296) 2019-04-03 09:58:16 -04:00
rhymes
dc2414c174 Add tests to PodcastEpisodesController (#2297)
* Add tests for existing API PodcastEpisodesController

* Generate only index route

There's no need to generate all routes if they are not implemented
2019-04-03 09:57:48 -04:00
Anna Buianova
1a0d4667c5 Unique twitter and github usernames #2061 (#2255)
* Set github and twitter usernames to nil if they are blank

* Verify github and twitter username in the Admin::UsersController (just in case)

* Add unique indexs on users twitter_username and github_username
2019-04-02 18:16:29 -04:00
Ben Halpern
5cc1109de4
Conditionally run feed validation (#2292) 2019-04-02 17:48:53 -04:00
Anna Buianova
d1db3abc35 Optimize sign in: User (#2237)
* Unique index on users email, conditional user unique validations

* Only uniqueness validations are conditional
2019-04-02 17:12:35 -04:00
Mohammadjavad Raadi
9f02062eb8 Fixes night mode issue #2244 (#2285)
* Patched article's comments/discussion styling according to night mode design (#2244)

* Fixed header title color

* Fixed article header background color and its border color

* Fixed "code of conduct" text and anchor link color

* Patched article's comments/discussion styling according to night mode design (#2244)

* Fixed "code of conduct" text and anchor link color

* Fixes night mode issue #2244
2019-04-02 16:08:26 -04:00
dependabot[bot]
0bc1b46535 Bump gibbon from 2.2.5 to 3.2.0 (#916)
Bumps [gibbon](https://github.com/amro/gibbon) from 2.2.5 to 3.2.0.
- [Release notes](https://github.com/amro/gibbon/releases)
- [Changelog](https://github.com/amro/gibbon/blob/master/CHANGELOG.md)
- [Commits](https://github.com/amro/gibbon/compare/v2.2.5...v3.2.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-02 13:24:42 -04:00
Ben Halpern
b0ad7f8c74
Some night theme code, other style adjustments, and extracted app name into ENV var (#2289)
* Style, theme adjustments, plus generalization work

* Modify login cta style on home page

* Modify text
2019-04-02 13:10:28 -04:00
Filip Defar
512c9ee8a0 Extract "followers" action from "show" in DashboardsController (#2270) 2019-04-01 18:43:44 -04:00
Ben Halpern
490645ea92
Add sponsors to sponsors page and add sponsor order field (#2284)
* Add sponsorship page

* Fix schema

* dev => DEV
2019-04-01 18:24:47 -04:00
Ben Halpern
c90be27677
Ignore unnecessary airbrake notices (#2283) 2019-04-01 17:40:50 -04:00
Ben Halpern
cc0e4b40dd
Allow orgs to be marked as sponsors (#2282)
* Allow orgs to be marked as sponsors

* Remove community sponsor condition
2019-04-01 16:41:25 -04:00
dependabot[bot]
9f4ab6d17a Bump twilio-ruby from 5.21.0 to 5.22.0 (#2254)
Bumps [twilio-ruby](https://github.com/twilio/twilio-ruby) from 5.21.0 to 5.22.0.
- [Release notes](https://github.com/twilio/twilio-ruby/releases)
- [Changelog](https://github.com/twilio/twilio-ruby/blob/master/CHANGES.md)
- [Commits](https://github.com/twilio/twilio-ruby/compare/5.21.0...5.22.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-01 16:38:42 -04:00
dependabot[bot]
d36f33f849 Bump recaptcha from 4.13.1 to 4.13.2 (#2253) [ci skip]
Bumps [recaptcha](https://github.com/ambethia/recaptcha) from 4.13.1 to 4.13.2.
- [Release notes](https://github.com/ambethia/recaptcha/releases)
- [Changelog](https://github.com/ambethia/recaptcha/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ambethia/recaptcha/compare/v4.13.1...v4.13.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-01 16:35:37 -04:00
dependabot[bot]
b8e567a350 Bump counter_culture from 2.1.2 to 2.1.4 (#2251) [ci skip]
Bumps [counter_culture](https://github.com/magnusvk/counter_culture) from 2.1.2 to 2.1.4.
- [Release notes](https://github.com/magnusvk/counter_culture/releases)
- [Changelog](https://github.com/magnusvk/counter_culture/blob/master/CHANGELOG.md)
- [Commits](https://github.com/magnusvk/counter_culture/compare/v2.1.2...v2.1.4)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-01 16:35:02 -04:00
dependabot[bot]
a903160d4a Bump shoulda-matchers from 4.0.0.rc1 to 4.0.1 (#2252) [ci skip]
Bumps [shoulda-matchers](https://github.com/thoughtbot/shoulda-matchers) from 4.0.0.rc1 to 4.0.1.
- [Release notes](https://github.com/thoughtbot/shoulda-matchers/releases)
- [Changelog](https://github.com/thoughtbot/shoulda-matchers/blob/master/NEWS.md)
- [Commits](https://github.com/thoughtbot/shoulda-matchers/compare/v4.0.0.rc1...v4.0.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-01 16:33:24 -04:00
dependabot[bot]
324d8fe6b1 Bump eslint from 5.15.3 to 5.16.0 (#2256) [ci skip]
Bumps [eslint](https://github.com/eslint/eslint) from 5.15.3 to 5.16.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v5.15.3...v5.16.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-01 16:32:45 -04:00