Commit graph

3569 commits

Author SHA1 Message Date
Dinesh
420b42e656 Added title attribute for Badges (#5201) 2019-12-27 10:40:29 -05:00
Molly Struve
2e661809b6 Introduce Sidekiq For Background Jobs (#5252)
* Introduce Sidekiq to the app and update RateLimitCheckerJob to use it

* fix rate limit checker spec with new sidekiq syntax

* add Sidekiq to tech stack overview

* Remove RateLimitChecker job change, add sidekiq web UI and testing support
2019-12-27 10:39:48 -05:00
rhymes
fa9acf2073 Fix deprecation for not_to raise_error (#5257) 2019-12-27 09:00:09 -06:00
rhymes
d1383ffdb6 Rename Metrics/LineLength to Layout/LineLength (#5255) 2019-12-27 08:58:35 -06:00
Molly Struve
1ac9a2d7bd
add index to created_at for notifications (#5251) [deploy] 2019-12-27 08:57:40 -06:00
Molly Struve
2415392da5
Return a 401 Response when Github creds are bad via the API (#5249) [deploy] 2019-12-26 14:51:36 -06:00
dependabot-preview[bot]
b5db5b19a9 Bump jest-fetch-mock from 2.1.2 to 3.0.0 (#5207) 2019-12-26 15:29:06 -05:00
Molly Struve
f86f93bc8a
Create rake Task to Destroy Old Notifications (#5180) [deploy] 2019-12-26 13:17:34 -06:00
dependabot-preview[bot]
d1cb715858 Bump codemirror from 5.49.2 to 5.50.0 (#5209) 2019-12-26 14:02:22 -05:00
dependabot-preview[bot]
eb8f0a005c Bump twilio-video from 1.20.0 to 2.0.0 (#5208) 2019-12-26 13:54:43 -05:00
dependabot-preview[bot]
9369b51364 [Security] Bump handlebars from 4.1.2 to 4.5.3 (#5250) [deploy] 2019-12-26 13:38:09 -05:00
Keith Bennett
3c980e7b83 Fix long line lints (#5062) 2019-12-26 13:24:24 -05:00
Molly Struve
faa4325c1f
Only Update page_views When They Are Valid (ie created) (#5195) [deploy] 2019-12-26 11:28:18 -06:00
dependabot-preview[bot]
0ca803ec4a Bump honeybadger from 4.5.2 to 4.5.4 (#5213) [deploy]
Bumps [honeybadger](https://github.com/honeybadger-io/honeybadger-ruby) from 4.5.2 to 4.5.4.
- [Release notes](https://github.com/honeybadger-io/honeybadger-ruby/releases)
- [Changelog](https://github.com/honeybadger-io/honeybadger-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/honeybadger-io/honeybadger-ruby/compare/v4.5.2...v4.5.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-26 11:59:00 -05:00
Anna Buianova
31d51999df Rubocop fixes (#5244) 2019-12-26 11:52:36 -05:00
dependabot-preview[bot]
d091b4c4fd Bump derailed_benchmarks from 1.4.2 to 1.4.3 (#5218)
Bumps [derailed_benchmarks](https://github.com/schneems/derailed_benchmarks) from 1.4.2 to 1.4.3.
- [Release notes](https://github.com/schneems/derailed_benchmarks/releases)
- [Changelog](https://github.com/schneems/derailed_benchmarks/blob/master/CHANGELOG.md)
- [Commits](https://github.com/schneems/derailed_benchmarks/compare/v1.4.2...v1.4.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-26 11:50:57 -05:00
Anna Buianova
7ef0d043e0 Handle a case when lambda client returns an empty result (#5248) 2019-12-26 11:50:34 -05:00
rhymes
76faceecbe Fix flaky Notifications::NewFollower::Send spec (#5236)
* Smarter follow detection

* Fix creation order

* Fix stop following use case and add comments
2019-12-26 11:49:18 -05:00
Molly Struve
fb17d0e079
fix title_with_timeframe to handle invalid timeframe and update rake task to not use return (#5241) [deploy] 2019-12-26 08:43:46 -06:00
rhymes
b0343d99c3 Refactor specs for Api::V0::FollowsController (#5239) 2019-12-24 13:14:39 -05:00
Anna Buianova
4cec45fcd3 Remove code related to vscode color customization (#5235) 2019-12-24 13:12:54 -05:00
Molly Struve
448adfdd23 Use ApiController for ChatChannels and return not_found error if channel cant be accessed by user (#5194) [deploy] 2019-12-24 13:12:29 -05:00
rhymes
2d6df70dea Return an empty result set instead of 404 in case users are not available. (#5238)
A common response in collection endpoint with REST APIs is to return an empty result set when the requested params end up in an empty result. The reason for this is that the resource itself exists (the collection always exists), it just is empty.

See https://github.com/thepracticaldev/dev.to/pull/5192
2019-12-24 13:08:10 -05:00
Molly Struve
9638e3da26
Group Honeybadger Rack::Timeout::RequestTimeoutExceptions (#5231) [deploy] 2019-12-23 19:34:08 -06:00
Ben Halpern
771fa5b782
Final fixes to /mod (#5234) [deploy] 2019-12-23 20:12:14 -05:00
Ben Halpern
c70042655f
Fix off by one for nth_published_by_author (#5233) [deploy] 2019-12-23 19:59:30 -05:00
Ben Halpern
4a1819f1e6
Fix off-by-one in nth_published_by_author (#5232) [deploy] 2019-12-23 19:38:20 -05:00
Molly Struve
36efb1b7bb Show count of users followed from API (#5229) [deploy] 2019-12-23 18:20:39 -05:00
Dan Silcox
e98d3cb7be Fix check for whether shell has changed (#5176)
Previously shell_top was being checked twice - now we check top + bottom :)
2019-12-23 18:19:50 -05:00
dependabot-preview[bot]
367f05695f Bump libhoney from 1.14.1 to 1.14.2 (#5217)
Bumps [libhoney](https://github.com/honeycombio/libhoney-rb) from 1.14.1 to 1.14.2.
- [Release notes](https://github.com/honeycombio/libhoney-rb/releases)
- [Commits](https://github.com/honeycombio/libhoney-rb/compare/v1.14.1...v1.14.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-23 18:18:10 -05:00
Ben Halpern
03c2404b13
Redo /mod for performance and usability (#5230) [deploy] 2019-12-23 18:10:25 -05:00
rhymes
d6a0ccb721 Routine Rubocop fixes (#5224) 2019-12-23 14:47:10 -05:00
dependabot-preview[bot]
ec16fc88e7 Bump twilio-ruby from 5.31.0 to 5.31.1 (#5215)
Bumps [twilio-ruby](https://github.com/twilio/twilio-ruby) from 5.31.0 to 5.31.1.
- [Release notes](https://github.com/twilio/twilio-ruby/releases)
- [Changelog](https://github.com/twilio/twilio-ruby/blob/master/CHANGES.md)
- [Commits](https://github.com/twilio/twilio-ruby/compare/5.31.0...5.31.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-23 13:48:07 -05:00
dependabot-preview[bot]
2898a1aa3f Bump faker from 2.8.1 to 2.9.0 (#5212)
Bumps [faker](https://github.com/faker-ruby/faker) from 2.8.1 to 2.9.0.
- [Release notes](https://github.com/faker-ruby/faker/releases)
- [Changelog](https://github.com/faker-ruby/faker/blob/master/CHANGELOG.md)
- [Commits](https://github.com/faker-ruby/faker/compare/v2.8.1...v2.9.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-23 13:43:31 -05:00
dependabot-preview[bot]
c74c60801b Bump rubocop-rspec from 1.37.0 to 1.37.1 (#5214)
Bumps [rubocop-rspec](https://github.com/rubocop-hq/rubocop-rspec) from 1.37.0 to 1.37.1.
- [Release notes](https://github.com/rubocop-hq/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-rspec/compare/v1.37.0...v1.37.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-23 13:34:52 -05:00
dependabot-preview[bot]
a7032b62f1 Bump google-api-client from 0.36.1 to 0.36.2 (#5211) [deploy]
Bumps [google-api-client](https://github.com/google/google-api-ruby-client) from 0.36.1 to 0.36.2.
- [Release notes](https://github.com/google/google-api-ruby-client/releases)
- [Changelog](https://github.com/googleapis/google-api-ruby-client/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/google-api-ruby-client/compare/0.36.1...0.36.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-23 12:23:44 -05:00
dependabot-preview[bot]
4cdad94c9c Bump dry-struct from 1.1.1 to 1.2.0 (#5210) 2019-12-23 12:22:59 -05:00
Mike Coutermarsh
3128c17fab Improve twitter card caching (#5206) [deploy]
* update test so it fails from badge randomness

* Better caching

This removes the randomness from the views. Which means the cache keys
won't get regenerated every request.

The badges will still be in random positions, but it will change per
user/article rather than every render.
2019-12-23 12:22:38 -05:00
dependabot-preview[bot]
ca71cb2c34 Bump rubocop from 0.77.0 to 0.78.0 (#5216) 2019-12-23 12:14:01 -05:00
Ben Halpern
737310f8ef
Add ability to open /new in connect sidecar (#5220) [deploy] 2019-12-23 09:11:02 -05:00
Sarthak Sharma
bb570a2d55 Bug Fix 🐞: Fixing missing edit and delete option (#5200)
* Feature 🚀 : Ability to delete messages in chat channels

- Sending message ID to frontend
- Deleting Message
- Use pusher to delete message realtime

* Minor Bug 🐞: Show message action only for current user

- User can delete or edit their own messages

* Test cases added

* Bug 🐞: Update message id for receiver

Message id was not sent to receiver by pusher

* Refactoring🛠: Message controller refactoring

* Test Cases📝 : Specs for Delete message added

* Feature 🚀 : Ability to edit messages

* Test Cases📝 : Specs for Edit message added

* Bug Fix 🐞:  Fixing missing edit and delete option
2019-12-23 08:20:15 -05:00
Ben Halpern
5812ecc383
Open /connect sidecar links in iframe (#5203) [deploy]
* Use iframe for connect sidecar

* Modify css of lefthand sidebar

* Add proper sidecar markup

* Update tests
2019-12-21 15:46:36 -05:00
Ben Halpern
cb3a0c462c
Separate chat channel unopened status from Algolia (#5198) [deploy] 2019-12-21 13:05:16 -05:00
Molly Struve
b1a71d0ac1 Ensure comment has a path when created for specs (#5197) 2019-12-20 17:23:59 -05:00
Ben Halpern
cd9805bc22 Fix tag badge task logic (#5189) [deploy] 2019-12-20 14:39:28 -05:00
Molly Struve
71fbad5387 Check user follow count after job is run (#5193) 2019-12-20 14:25:58 -05:00
Molly Struve
212a2a430d Return not_found response if we cant return users via the api (#5192) 2019-12-20 13:43:14 -05:00
Molly Struve
55b691c980
Ensure model properties in factories are unique (#5190) 2019-12-20 12:21:16 -06:00
Sarthak Sharma
b602b7b91f 🚀Feature/ability to edit messages (#5139) [deploy]
* Feature 🚀 : Ability to delete messages in chat channels

- Sending message ID to frontend
- Deleting Message
- Use pusher to delete message realtime

* Minor Bug 🐞: Show message action only for current user

- User can delete or edit their own messages

* Test cases added

* Bug 🐞: Update message id for receiver

Message id was not sent to receiver by pusher

* Refactoring🛠: Message controller refactoring

* Test Cases📝 : Specs for Delete message added

* Feature 🚀 : Ability to edit messages

* Test Cases📝 : Specs for Edit message added

* Refactoring🔩: Refactoring for edit messages

* Refactoring🔩: Refactoring:2 for edit messages

* Refactoring🔩: Refactoring:2 for edit messages

* Test Cases📝 : Test Cases for edit message added

* Minor Bug 🐞: Show message action only for current user

- User can delete or edit their own messages

* Test cases added

* Bug 🐞: Update message id for receiver

Message id was not sent to receiver by pusher

* Feature 🚀 : Ability to edit messages

* Test Cases📝 : Specs for Edit message added

* Refactoring🔩: Refactoring for edit messages

* Refactoring🔩: Refactoring:2 for edit messages

* Refactoring🔩: Refactoring:2 for edit messages

* Bug Fix 🐞: Added space between edited and timestamp

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2019-12-20 10:19:00 -05:00
Jared Harbison
07fd2281cd Implement GitPitchTag (#4942) 2019-12-19 19:59:15 -05:00