Commit graph

12482 commits

Author SHA1 Message Date
Josh Klar
408bb14283
readme: Add klardotsh to core contributors list. (#19278)
Co-authored-by: Josh Klar <jklar@forem.com>
2023-03-30 17:07:09 -07:00
Omar Ferreiro
8b6e67ff9b
Remove the <br> tags in 404.html (#19236)
Co-authored-by: IcarusTheFly <IcarusTheFly@users.noreply.github.com>
Co-authored-by: Lawrence <lawrence@forem.com>
Co-authored-by: Rajat Talesra <rajat@forem.com>
2023-03-30 13:23:38 -04:00
Mac Siri
f368a4ce7f
Fix broken cypress code coverage (#19282) 2023-03-30 12:36:12 -04:00
Mac Siri
64c10957e3
Update CODEOWNERS (#19276) 2023-03-29 17:20:41 -04:00
Mac Siri
88108b3037
Implement code coverage for Cypress (#19250) 2023-03-29 15:37:50 -04:00
Joshua Wehner
47cf1d14a8
Allow codepen retries in UnifiedEmbed(#19271) 2023-03-29 15:05:30 -04:00
Lawrence
e4e1f4d96d
report abuse dropdown link (#19247)
* report abuse dropdown link

* Update app/controllers/pages_controller.rb

* Update app/views/shared/_display_ad.html.erb

* remove billboard url check

---------
2023-03-28 14:02:31 -05:00
Ridhwana
42b392906b
Migrate initializeUserProfilePage to webpack (#19241) 2023-03-28 12:20:49 -04:00
Mac Siri
37c961e40d
Fix broken buildkite pipeline. (#19272) 2023-03-28 11:14:51 -04:00
James Wu
a9948a41e3
Fix like icon in sidebar (#19266) 2023-03-28 12:17:10 +05:30
Goran
0b4a3601a8
Refactor User#temp_username (#19252)
* Refactor User#temp_username

* Remove Authentication::Providers dependency from Users::UsernameGenerator

* Adds brief description and yard docs
2023-03-27 16:21:00 +03:00
Ridhwana
15bb2e5a8b
Tweaks to display ad styling (#19262) 2023-03-24 12:49:27 -04:00
Mac Siri
1e1064de0b
Undo changes to Sprockets::UglifierWithSourceMapsCompressor (#19261) 2023-03-24 12:48:59 -04:00
Anna Buianova
784afdf41e
Routine rubocop fixes (#19254)
* Rubocop fixes

* Rubocop fixes

* Fixed rubocop violation

* Fixed policies rubocop violations

* More rubocop fixes
2023-03-24 14:37:44 +03:00
Rajat Talesra
54eb412593
Add user status from profiles to the report section (#19240) 2023-03-23 15:47:41 -04:00
Ridhwana
c285cf8f9e
Promotional Flair for external Billboard (#19216)
* Users can only opt-out of external ads

* Move random sampling out of FilteredAdsQuery

* Refactor filtered_ads_query_spec

* Add test for new permit_adjacent setting

* Rubocop

* Use permit_adjacent_sponsors on article sidebar and post-comments

* Remove, unused

* Update copy

* type_matched -> type_of_ads

* Remove non-applicable test

* feat: update the bullet safe list and add eager loading with organizations

* feat: add an indicator round for promoted

* feat: update the css

* feat: add il8n

* fix: styling changes

---------

Co-authored-by: Joshua Wehner <joshua@forem.com>
2023-03-23 18:37:04 +02:00
depfu[bot]
81201c0284
[js] Update all Yarn dependencies (2023-03-20) (#19239)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Mac Siri <mac@forem.com>
Co-authored-by: Lawrence <lawrence@forem.com>
2023-03-23 10:53:14 -04:00
Thomas Bnt
f9a3baca44
I18n: populate config/locales with French (#17487)
Co-authored-by: Joshua Wehner <joshua.wehner@gmail.com>
Co-authored-by: Mac Siri <mac@forem.com>
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2023-03-23 10:06:38 -04:00
depfu[bot]
853e2dbc22
[ruby] Update pghero: 3.2.0 → 3.3.1 (minor) (#19256)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-03-23 09:42:22 -04:00
yheuhtozr
87c5526c30
Allow BIDI non-deprecated marks in title (#19177) 2023-03-23 09:41:57 -04:00
Joshua Wehner
b812ca5955
(Really) Enable multiple reactions on #index (#19202) 2023-03-22 10:20:00 -04:00
depfu[bot]
5b437af792
Update sidekiq-cron to version 1.10.0 (#19245)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-03-21 22:39:04 +05:30
Mac Siri
b7f00706bd
[CI] Adjust cancel-in-progress concurrency (#19244)
* [CI] Adjust cancel-in-progress concurrency

* Revert "[CI] Lock setup-ruby to v1.144.0 (#19243)"

This reverts commit 44a3527983.
2023-03-21 10:05:31 -04:00
Mac Siri
842e6880b8
Routine rubocop fix on /spec (#19217)
* Softrun rubocop

* Hardrun rubocop (-A)

* Change a rubocop rule

* Add missing cops

* Undo & redo rubocop -A
2023-03-21 09:55:26 -04:00
depfu[bot]
ce6f30b9de
[ruby] Update strong_migrations: 1.4.3 → 1.4.4 (patch) (#19238)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-03-20 17:48:36 -04:00
Mac Siri
44a3527983
[CI] Lock setup-ruby to v1.144.0 (#19243) 2023-03-20 11:17:18 -04:00
Joshua Wehner
8086ef68ac
Fix bullet issue with includes commentable (#19145)
* Fix bullet issue with includes commentable

* Flatten view logic

* Restore user comment section logic (but bullet-friendly)

* Try fixing podcast_episode -> podcast

* Add test that would have caught the logic bug

* View specs need describe to specific the path

* Remove unnecessary _comments argument

* Ooops, missed saving this
2023-03-20 16:08:03 +01:00
Mac Siri
047a68cc66
[CI] Add concurrency & remove slack alert (#19237)
* Remove CI's slack report

* Add concurrency to per branch

* Dynamic cancel-in-progress
2023-03-20 08:59:14 -04:00
depfu[bot]
7d2d71de68
[ruby] Update devise: 4.8.1 → 4.9.0 (minor) (#19173)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Lawrence <lawrence@forem.com>
2023-03-17 13:55:49 -04:00
James Wu
78bb52a627
Fix text color contrast on social previews (#19163) 2023-03-17 13:37:19 -04:00
Mac Siri
bfe797f44d
Create cleanup-cache.yml (#19232) 2023-03-17 12:18:51 -04:00
depfu[bot]
108caee0d5
[ruby] Update ancestry: 4.2.0 → 4.3.0 (minor) (#19233)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-03-17 10:36:33 -04:00
depfu[bot]
d452f5a683
[js] Update all Yarn dependencies (2023-03-15) (#19230)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-03-17 07:46:31 -04:00
Mac Siri
2e759c823d
Merge bundle-audit and rubocop into CI & add precompile step (#19228) 2023-03-16 15:34:38 -04:00
depfu[bot]
dc7ff6382c
[ruby] Update js-routes: 2.2.4 → 2.2.5 (patch) (#19229)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-03-16 13:09:32 -04:00
Joshua Wehner
230e77e5cd
Update FilteredAdsQuery and user settings for opting-out of Billboards (#19208)
* Users can only opt-out of external ads

* Move random sampling out of FilteredAdsQuery

* Refactor filtered_ads_query_spec

* Add test for new permit_adjacent setting

* Rubocop

* Use permit_adjacent_sponsors on article sidebar and post-comments

* Remove, unused

* Update copy

* type_matched -> type_of_ads

* Remove non-applicable test

---------

Co-authored-by: Ridhwana <ridhwana.khan16@gmail.com>
2023-03-16 15:23:02 +02:00
depfu[bot]
67b6fbcbd9
[js] Update all Yarn dependencies (2023-03-09) (#19213)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2023-03-15 15:47:21 -04:00
depfu[bot]
e0728cb8cc
[ruby] Update metainspector: 5.13.1 → 5.14.0 (minor) (#19203)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-03-15 14:22:40 -04:00
depfu[bot]
dd057b6023
🚨 [security] [ruby] Update rails: 7.0.4.2 → 7.0.4.3 (patch) (#19223)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-03-15 09:59:18 -04:00
Mac Siri
61bd41930d
Add build steps and expand CI node (#19220)
* Add build step

* Use retrieve cache instead for tests

* Add assets_precompile step

* Rename method

* Forgot ruby

* Typo

* Try exit early

* Speed up yarn_install

* Try again

* why

* Oops

* debug echo

* Move order

* Refine lookup process

* Synxtax error

* Remove redundant yarn install

* Separate Storybook

* Simplify

* Revert "Simplify"

This reverts commit 2e07724dcc4d08d03b9f50c41669f9ee94045002.

* Expand node counts

* Experimental bypass

* Remove verbose cypress install

* Revert "Remove verbose cypress install"

This reverts commit 5ace028feb91f44358a384bfaa8d3da1cdf68c07.

* Provide precompiled asset to RSpec

* lets try 10 nodes

* Only cache webpack

* Test speed with 8 node counts

* No need for assets precompile
2023-03-15 09:36:30 -04:00
yheuhtozr
b4fc687292
missing currencies, format controls and emoji (#19178)
Co-authored-by: Lawrence <lawrence@forem.com>
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2023-03-10 16:13:29 +02:00
Mac Siri
45f25647ef
Fix flaky notifications_spec (#19215) 2023-03-10 06:59:30 -05:00
Ben Halpern
22e8d802da
Billboard style tweaks (#19206)
* Billboard style tweaks

* Padding-right adjustment

* Padding adjustments
2023-03-09 13:51:42 -05:00
depfu[bot]
3aabdf0fe9
Update all development Bundler dependencies (2023-03-06) (#19201)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-03-09 18:03:20 +02:00
depfu[bot]
82a43aba6d
[js] Update all Yarn dependencies (2023-02-20) (#19161)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Mac Siri <mac@forem.com>
2023-03-09 09:15:59 -05:00
Joshua Wehner
276a53b5b4
Permit params needs update to allow saving mastodon (see 0baafea) (#19210) 2023-03-08 09:00:08 -08:00
depfu[bot]
ec2ce4d27a
Update rack to version 2.2.6.3 (#19209)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-03-07 14:24:18 -08:00
Joshua Wehner
0baafeabb9
Fix social media settings to enable mastodon (#19191) 2023-03-07 16:49:16 +01:00
Lawrence
cfad413ca1
Display Rules for In house and Community Billboards (#19189)
* init

* Update app/queries/display_ads/filtered_ads_query.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update app/queries/display_ads/filtered_ads_query.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* add display ad query and update caller

* set as keyword args and add org id to callers

* Update app/queries/display_ads/filtered_ads_query.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update app/queries/display_ads/filtered_ads_query.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update app/queries/display_ads/filtered_ads_query.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update app/views/articles/_sticky_nav.html.erb

Co-authored-by: Joshua Wehner <joshua@forem.com>

* Update app/views/articles/show.html.erb

Co-authored-by: Joshua Wehner <joshua@forem.com>

* Update app/queries/display_ads/filtered_ads_query.rb

Spacing

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update app/queries/display_ads/filtered_ads_query.rb

More spacing

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update app/queries/display_ads/filtered_ads_query.rb

Co-authored-by: Joshua Wehner <joshua@forem.com>

* Update app/queries/display_ads/filtered_ads_query.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix some broken specs

* add updated spec for billboard rules

* missing comma

* Update spec/queries/display_ads/filtered_ads_query_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* add placement in spec

* fix external spec

* cleanup

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Joshua Wehner <joshua@forem.com>
2023-03-06 14:15:14 -08:00
depfu[bot]
0fc6a455de
[ruby] Update ahoy_matey: 4.2.0 → 4.2.1 (patch) (#19194)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Lawrence <lawrence@forem.com>
2023-03-06 16:57:01 -05:00