Commit graph

3755 commits

Author SHA1 Message Date
Daniel M Brasil
406e3fec4d
Rremove de-indexing From Accounts With No Comments (#20660)
* remove de-indexing from accounts that have no comments

* add specs for Article#skip_indexing?
2024-02-21 10:54:02 +00:00
Ben Halpern
561bdb278c
Change value of signup in success score (#20647) 2024-02-18 10:30:59 -08:00
Anna Buianova
d0f3fb6fff
Optimize and test comments cache after score change (#20640)
* Add specs for caching article comments, use cache_key_with_version

* Optimize cache busting for spammer comments, reorganized related specs
2024-02-16 14:53:11 +00:00
Ben Halpern
8eb41eef8e
Record billboard signup conversions (#20629)
* Record billboard signup conversions

* Update app/models/billboard_event.rb

* Modify click tracking
2024-02-14 14:18:57 -05:00
Ben Halpern
205aee8c78
Add billboard for bottom of page with allowance to delay until after reading is finished. (#20616)
* Add delayed behavior

* Add special behavior to billboards

* Fix order for test

* Test clicking outside element when close event is present

* Update app/javascript/packs/billboardAfterRenderActions.js
2024-02-13 11:56:32 -05:00
Anna Buianova
fb09a75352
Update comment updated_at when changing score (#20622)
* Change comment updated_at when updating comment score

* Rubocop fixes
2024-02-13 13:17:24 +00:00
Mac Siri
248f0f55c0
Allow Slack::Messengers to be disabled (#20609) 2024-02-09 17:20:35 +00:00
Philip How
e2035e0c4a
update first post badge name (#20613) 2024-02-09 12:20:14 -05:00
Anna Buianova
e5064b418f
Hide super low score comments if they are child comments (#20612) 2024-02-09 16:24:13 +00:00
Ben Halpern
1b083f39a4
Ensure at least 0 score for new badge award (#20605) 2024-02-08 17:00:10 +00:00
Ben Halpern
2f9769a89d
Add new sidebar billboard locations and remove legacy campaign area (#20562)
* Add new sidebar billboard locations

* Remove some specs

* Remove campaign tests

* Adjust tag-allowed billboards

* Fix up targeting functionality

* Fix sidebar third render
2024-02-08 16:55:48 +00:00
Philip How
55f191a5ec
Automated First Post Badge (#20600)
* award first post logic, schedule, and tests

* award first post logic, schedule, and tests
2024-02-08 10:11:40 -05:00
Anna Buianova
07ffb2e3be
Removed spammers from followers list (#20603)
* Remove spam and suspended users from followers list (api and dashboards)

* Fixed the api followers endpoint

* Fixed issue with follower_ids query
2024-02-08 13:57:15 +00:00
Ben Halpern
2d9c87d9d3
Add ability to view specific billboard via params in any context if it is live (#20599)
* Fix AudienceSegmentRefreshAllWorker args issue

* Add ability to view specific billboard via params if it is live

* Fix lingering

* Refactor to clean up
2024-02-07 15:11:22 -05:00
Anna Buianova
b43cb38d40
Remove notifications related to spammer actions (after the role is assigned) (#20593) 2024-02-07 17:36:19 +00:00
Philip How
a900050fdc
Add Sendgrid Category to Digest Emails (#20595)
* add in header for digest emails

* add test
2024-02-06 19:02:10 +00:00
Ben Halpern
e26b27c7fa
New a/b test for Feb 5 (and add a variable too a hardcoded value) (#20588)
* Fix AudienceSegmentRefreshAllWorker args issue

* New a/b test for Feb 5 (and add a variable too a hardcoded value)
2024-02-05 15:46:03 +00:00
Anna Buianova
7125a62db0
Changed logic for hiding and displaying low-quality marker for comments based on their score (#20581)
* Specs for revised comments thresholds

* Changed thresholds for low quality comments

* Added specs for comments page

* Fixed /comments and related specs

* Reorganized code for comments trees

* Specs for podcasts episodes comments

* Refactored Comments::Tree

* Refactored Comments::Tree + added specs

* Made build_sort_query private
2024-02-05 09:27:24 -05:00
Ben Halpern
9b93b12f05
Fix AudienceSegmentRefreshAllWorker args issue (#20576)
* Fix AudienceSegmentRefreshAllWorker args issue

* Update test

* Fix

* Fix test

---------

Co-authored-by: Mac Siri <krairit.siri@gmail.com>
2024-01-31 13:48:13 -05:00
Ben Halpern
ee29318126
Add a/b test for which comments to show in feed (#20332)
* Add a/b test for which comments to show in feed

* Adjust figure

* Started at

* Move scope placement around

* Add tests for different comments_variants passed

* Fix typo
2024-01-29 12:18:50 -05:00
Anna Buianova
58bd07d729
Render 404 when root comment has low score and no children (#20560) 2024-01-26 17:21:18 +00:00
Anna Buianova
a4d9b4f0d1
Hide low score comments on user profile (#20556) 2024-01-25 16:06:50 +00:00
Ben Halpern
b763ba8544
Allow pages to have subdirectories (#20549)
* Allow pages to have subdirectories

* Add locale text
2024-01-24 16:09:29 -05:00
Anna Buianova
321540ec08
Hide low quality comments from an article page (#20541)
* Hide low-score (< -50) comments for signed in users on article page

* Use low quality threshold

* Show deleted message for low-quality for signed-in users + hide if no children

* Remove irrelevant changes

* Skip view test for low-quality

* Removed irrelevant (yet) tests

* Fixed low score threshold in specs descriptions
2024-01-23 20:33:12 +00:00
Ben Halpern
d86689f63d
Allow pages to render .txt requests (#20547)
* Allow pages to render .txt requests

* Adjust routes
2024-01-22 11:12:22 -05:00
Anna Buianova
947aaef7c1
Return 404 if user is a spammer (#20546) 2024-01-22 15:20:42 +00:00
Ben Halpern
aab0a19011
Allow configuration to conditionally prefer Cloudflare over Cloudinary (#20539)
* Allow configuration to conditionally prefer Cloudflare over Cloudinary

* Update app/services/images/optimizer.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix some lints

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-01-19 09:45:36 -05:00
Ben Halpern
66f3ae71b5
Adjust comment notification logic (#20534)
* Adjust comment notification logic

* Update spec/models/comment_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update spec/models/comment_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update spec/models/comment_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-01-17 12:22:50 -05:00
Philip How
fb855c97bd
Update badge awarding language (#20516)
* update badge language files

* update admin controller

* fix tests

* no actually fix the tests

* remove 'community' from notification

* fix spec

* fix interpolations
2024-01-17 09:26:19 -05:00
Ben Halpern
16ff57c2ff
Add HTML customization to admin (#20531)
* Add HTML customization to admin

* Update spec/requests/stories_index_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-01-17 12:12:22 +00:00
Ben Halpern
5c2723a04e
Update safe params and billboard cache config (#20530) 2024-01-16 12:13:29 -05:00
Anna Buianova
539844165f
Avoid sending follow notifications from spammers (#20526) 2024-01-15 16:50:21 +00:00
Anna Buianova
08d34d5d34
Don't show low scoring articles in timeframe feeds (#20525) 2024-01-15 14:14:32 +00:00
Anna Buianova
9c7476db62
Make articles from a user with spam role inaccessible (direct access) (#20515)
* Make articles inaccessible if their author has spam role

* Improve specs a bit for showing spammer articles
2024-01-12 15:36:44 +00:00
Philip How
33fd9836be
Add CSS as pages template option (#20512)
* add css as pages option

* don't forget schema

* fix test

* add api support
2024-01-12 15:35:38 +00:00
Ben Halpern
1c25171cc6
Do not vacate tags if parameter not passed via API (#20513) 2024-01-11 16:25:21 -05:00
Ben Halpern
b0e3a512bb
Delay and modify follow logic to remove spammers (#20505)
* Delay and modify follow logic to remove spammers

* Fix tests

* Change comment

* Update spec/models/notification_spec.rb

Co-authored-by: Anna Buianova <lightallloy@gmail.com>

* Update spec/models/notification_spec.rb

Co-authored-by: Anna Buianova <lightallloy@gmail.com>

---------

Co-authored-by: Anna Buianova <lightallloy@gmail.com>
2024-01-10 14:35:12 +00:00
Philip How
7d47ffef78
Remove calls to trigger round robin notifications (#20506)
* remove calls to trigger round robin notifications

* remove tests
2024-01-10 13:44:57 +00:00
Ben Halpern
8e532c848a
Nullify published_at if absurdly far in the future (#20504) 2024-01-08 16:57:38 +00:00
Ben Halpern
04d4b2340d
Add downstream score effects from spam role (#20498)
* Add downstream score effects from spam role

* Move async score calc down low

* Add tests

* Add stub

* Fix typo

* No need for guard

* No need for guard
2024-01-08 16:25:28 +00:00
Ben Halpern
108d753d68
Add articles clickbait_score as factor in final feed ordering (#20493)
* Add articles clickbait_score

* Add attributes

* Fix field test config
2024-01-05 09:37:53 -05:00
Ben Halpern
e376e2b887
Add cookie requirement option for billboards (#20486)
* Add cookie requirement for billboards

* Clean up tests

* Fix up tests

* Adjust tests

* Adjust tests
2024-01-03 16:33:08 +00:00
Anna Buianova
473594f192
Match spam role with existing suspended actions (#20477)
* Started matching spam and suspended roles

* Match spam and suspended roles in most cases

* Fixed check_suspended for unauthenticated users
2023-12-27 20:12:50 +00:00
Ben Halpern
f0673648c2
Add preferred_article_ids to billboards (#20437)
* Add preferred_article_ids to billboards

* Adjust query

* Refactor method

* Refactor method

* Fix input type

* Add feature flag
2023-12-18 19:20:56 +00:00
Philip How
78b42c5efd
Add trusted role via API (#20455)
* rubocop

* use has_trusted_role? in tests, not trusted? due to pesky caching issues

* swagger
2023-12-18 18:38:05 +00:00
Anna Buianova
adfd76feb6
Consider spam role in the user_status method (#20449)
* Add spam role to user_status method

* Take spam role into account in user status indicator

* Return passed statuses
2023-12-13 16:56:27 +00:00
Anna Buianova
81b042ee25
Give admins the ability to add spam role to users via the API (#20445) 2023-12-12 14:35:55 +00:00
Anna Buianova
e0ba90d60a
Allow to remove suspended role (#20439)
* Allow to remove suspended role

* Fixed the cypress spec for removing suspended role
2023-12-12 11:57:03 +00:00
Anna Buianova
1eeaa34e98
Added spam role (#20434)
* Added spam role

* Fixed role spec
2023-12-11 14:27:22 +00:00
Anna Buianova
4815661bad
Api search users by email (#20423) 2023-12-04 23:18:36 +00:00