Commit graph

4080 commits

Author SHA1 Message Date
Josh Puetz
38622317b7
Consolidate server side main article feed logic (#5953) [deploy]
* Consolidate `.decorate` calls

* Move Activerecord finders out of main stories feed partial

* Add back in decorates to sticky_articles partial

* Combine top and new articles returned from StoriesController

* Extract feed construction logic to a service

* Some PR tweaks (naming)

* Quick test fix
2020-02-12 08:43:20 -06:00
Michael Kohl
9ea9549e28
Fix spelling of Elastiscsearch in docs (#6033) 2020-02-12 09:28:28 -05:00
Michael Kohl
3f08572306
Update PR template (#5979)
Now questions tests and post-deployment tasks
2020-02-11 18:34:11 -05:00
Nick Taylor
56b7410983
Fix dev shop logos style (#6028) [deploy] 2020-02-11 18:23:45 -05:00
Molly Struve
a39c6a03b0
Remove extra period if name ends with it (#6029) [deploy] 2020-02-11 17:57:02 -05:00
Andy Zhao
0f9b52f800
Use post instead of get for CSRF (#6026) 2020-02-11 17:56:11 -05:00
rhymes
30554b84f0
Enable Gemfile to be installable from wherever (#6012) 2020-02-11 17:25:04 -05:00
rhymes
ac7785ea8d
Update doorkeeper initializer with new (disabled) features (#6011) 2020-02-11 16:04:52 -05:00
Maykon Menezes
cefa95b92d
fix response when article can't be found (#5999) 2020-02-11 15:23:44 -05:00
Ben Halpern
2add3ae300
Replace dev.to with ApplicationConfig in a few locations (#6008) [deploy]
* Replace dev.to with ApplicationConfig in a few locations

* Update app/labor/badge_rewarder.rb
2020-02-11 14:48:27 -05:00
rhymes
041ad23b6b
Upgrade omniauth-github to fix deprecation notice (#6022) [deploy] 2020-02-11 14:33:47 -05:00
Michael Kohl
050a2e2726
Implement Mailchimp unsubscribe webhook (#5804) [deploy] 2020-02-11 14:25:48 -05:00
Nick Taylor
0119918237
Homepage left side bar tags followed (#5918) [deploy]
* SASS formatting in action.

* Unnested .sidebar-nav-element in SASS

* Created the <TagsFollowed /> component.

* Mini refactor.

* Left side bar uses <TagsFollowed /> component now.

* Accomodating InstantClick

* Small refactor and added some comments.

* The homepage webpacker pack only needs to be loaded once.

* Added tests for the <TagsFollowed /> component.

* Modified the receive InstantClick callback as per their docs.

* Reverted the data-no-instant on he homepage bundle. It seems to cause issues in certain scenarios.

* Just some tweaks to <TagsFollowed /> component.

* Removed CSS for general img tag in context of sidebar as it does not appear to be used.

* Fixed copy paste error from JSX to HTML.

* Fixed <img /> styles for arbitrary sponsorship widget.

* Fixed a regression that a Capybara test caught.

* Fixed user followed tags on home page tests.

* Fixed logic for loading user data on homepage.
2020-02-11 12:09:23 -05:00
rhymes
bc876465fc
Assign teams to files and directories (#6020) 2020-02-11 12:04:01 -05:00
Molly Struve
3fed9338d2
Index Tags to Elasticsearch after they are created (#5958) [deploy]
* Index tags to Elasticsearch after they are created
* add rules_html to Tag index since we show it in search drop down
* change get method to find_document to make it more explicit
2020-02-11 11:58:58 -05:00
Michael Kohl
38e980917d
Add Elasticsearch to Docker Compose (#5978)
* Copy .ruby-version into Dockerfile
* Add Elasticsearch to Docker Compose
2020-02-11 11:45:16 -05:00
Ben Halpern
30e2fd5017
Add /embed to list of disallowed path matches (#6019) [deploy]
In service workers, we should not be adding the shell to these views.
2020-02-11 10:24:33 -05:00
Nick Taylor
4fe4c4d791
Fixed false negative of a frontend test suite failing. (#6005) 2020-02-10 18:41:45 -06:00
Vaidehi Joshi
c33d6936b5
Do not allow staff_user_id to be mutated (#6009) [deploy]
Allowing ids to be mutated by admins from the /internal/config pages is dangerous.
This could cause issues if an admin tries to update the SiteConfig.staff_user_id to an id that is another user's id, or to an id that isn't valid.
2020-02-10 16:35:18 -08:00
dependabot-preview[bot]
b9b6281ec3
Bump draper from 3.1.0 to 4.0.0 (#5987) 2020-02-10 18:33:05 -05:00
dependabot-preview[bot]
cedc755195
Bump feedjira from 3.1.0 to 3.1.1 (#5993) 2020-02-10 18:32:47 -05:00
Michael Kohl
d016356d7f
Copy .ruby-version into Dockerfile (#5976) 2020-02-10 17:10:10 -05:00
Anna Buianova
611323f508
Remove full_page from the Page TEMPLATE_OPTIONS (#5981) 2020-02-10 17:04:59 -05:00
Molly Struve
0eecdf616c
soft save notification_subscription and then check persisted (#5962) [deploy] 2020-02-10 16:37:28 -05:00
Mac Siri
a4a846fc74
Add foreman to bin/setup (#6007) 2020-02-10 16:08:57 -05:00
rhymes
3258bc357a
Sort reserved words (#6000)
* Sort reserved words

* Remove duplicate words

* Make it a set

* Nope, it cannot be a set
2020-02-10 16:07:27 -05:00
rhymes
085c0d1e01
Add multiplier for seeds and use it for articles and users (#6003)
* Add seeds multiplier and use it for articles and users

* Update DB documentation
2020-02-10 16:06:58 -05:00
dependabot-preview[bot]
2139765f0e
Bump ulid from 1.1.0 to 1.2.0 (#5996) 2020-02-10 13:49:20 -05:00
dependabot-preview[bot]
0962f6656c
Bump twilio-video from 2.0.1 to 2.1.0 (#5990) 2020-02-10 13:48:26 -05:00
dependabot-preview[bot]
644c974dc7
Bump jbuilder from 2.9.1 to 2.10.0 (#5989) 2020-02-10 13:46:30 -05:00
dependabot-preview[bot]
665fd822eb
Bump honeybadger-js from 2.1.0 to 2.1.1 (#5986) 2020-02-10 13:44:04 -05:00
dependabot-preview[bot]
358663c9a4
Bump octokit from 4.15.0 to 4.16.0 (#5985) 2020-02-10 13:43:21 -05:00
dependabot-preview[bot]
f5d4f89ed2
Bump doorkeeper from 5.3.0 to 5.3.1 (#5994)
Bumps [doorkeeper](https://github.com/doorkeeper-gem/doorkeeper) from 5.3.0 to 5.3.1.
- [Release notes](https://github.com/doorkeeper-gem/doorkeeper/releases)
- [Changelog](https://github.com/doorkeeper-gem/doorkeeper/blob/master/CHANGELOG.md)
- [Commits](https://github.com/doorkeeper-gem/doorkeeper/compare/v.5.3.0...v.5.3.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-10 13:37:17 -05:00
Michael Kohl
ec03ffa880
Remove unused images (#5923) [deploy]
* Remove unused images

* Restore ben.jpg
2020-02-10 08:35:11 -08:00
Molly Struve
0dfabf4324
Remove indexing from ChatChannel model in seed script (#6001) 2020-02-10 11:30:08 -05:00
Anna Buianova
8fb9e4940d
Removed unused special_sidebar (#5929) 2020-02-10 10:24:56 -05:00
Alex
78a25dfd54
Validate that API article params are a Hash (#5963)
* Add check for article param being a Hash & spec

* Remove unnecessary blank line

* Move logic to private method and before_action call

* Change check_if to validate

* Use is_a? to type check

* Fix type check for specs
2020-02-10 10:24:11 -05:00
rhymes
c41d66e900
Replace ban/banned with suspend/suspended in user facing text (#5816) [deploy] 2020-02-10 10:12:53 -05:00
dependabot-preview[bot]
d090ebf026
Bump vcr from 5.0.0 to 5.1.0 (#5995)
Bumps [vcr](https://github.com/vcr/vcr) from 5.0.0 to 5.1.0.
- [Release notes](https://github.com/vcr/vcr/releases)
- [Changelog](https://github.com/vcr/vcr/blob/master/CHANGELOG.md)
- [Commits](https://github.com/vcr/vcr/compare/v5.0.0...v5.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-10 09:37:34 -05:00
dependabot-preview[bot]
bdf0888590
Bump redoc-cli from 0.9.5 to 0.9.6 (#5988)
Bumps [redoc-cli](https://github.com/Redocly/redoc) from 0.9.5 to 0.9.6.
- [Release notes](https://github.com/Redocly/redoc/releases)
- [Changelog](https://github.com/Redocly/redoc/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Redocly/redoc/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-10 09:33:24 -05:00
dependabot-preview[bot]
3d2f2011fe
Bump libhoney from 1.14.3 to 1.14.4 (#5983)
Bumps [libhoney](https://github.com/honeycombio/libhoney-rb) from 1.14.3 to 1.14.4.
- [Release notes](https://github.com/honeycombio/libhoney-rb/releases)
- [Commits](https://github.com/honeycombio/libhoney-rb/compare/v1.14.3...v1.14.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-10 09:32:52 -05:00
dependabot-preview[bot]
6e62a49cf8
Bump gibbon from 3.3.2 to 3.3.3 (#5991)
Bumps [gibbon](https://github.com/amro/gibbon) from 3.3.2 to 3.3.3.
- [Release notes](https://github.com/amro/gibbon/releases)
- [Changelog](https://github.com/amro/gibbon/blob/master/CHANGELOG.md)
- [Commits](https://github.com/amro/gibbon/compare/v3.3.2...v3.3.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-10 09:29:18 -05:00
Juanito Fatas
33b8014677
Fix indentation in search.rake (#5971)
lib/tasks/search.rake:9:3: C: Layout/IndentationWidth: Use 2 (not 3) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
     Search::Cluster.update_mappings
  ^^^
2020-02-10 09:09:23 -05:00
Molly Struve
4691ae1e34
Log in Datadog When Sidekiq Worker Fails for Final Time (#5942) [deploy] 2020-02-10 08:56:41 -05:00
Alex
41d812b8a7
Revert "Update queue_adapter to Sidekiq (#5960)" (#5961) [deploy]
This reverts commit 05ce09b899.
2020-02-07 18:37:05 -05:00
Alex
05ce09b899
Update queue_adapter to Sidekiq (#5960) [deploy] 2020-02-07 14:48:19 -08:00
Alex
c98190742b
Remove Users::EstimateDefaultLanguageJob & spec (#5956) [deploy] 2020-02-07 12:40:12 -08:00
Anna Buianova
1c94ffb38e
Added template select to the pages admin form (#5952) [deploy] 2020-02-07 14:59:05 -05:00
Mohamed ABDELLANI
faad0b83e6
Handle Reactions Without Users When Sending Notifications (#5820)
* Add reaction's owner existence in the database

* Add test
2020-02-07 14:10:52 -05:00
Ben Halpern
2c07b08514
Add low-value landing pages to robots.txt disallow (#5944) [deploy]
* Add low-value landing pages to robots.txt disallow

* Update app/views/pages/robots.text.erb

* Update app/views/pages/robots.text.erb
2020-02-07 14:04:36 -05:00