rhymes
|
54ccef4766
|
Fix error with articles API and unknown username (#2247)
Currently the articles API breaks the server when called with an unknown username. It should return nothing like when called with an unknown tag.
|
2019-03-31 10:47:48 -04:00 |
|
Mac Siri
|
73127aca01
|
Remove controller specs (#2224)
* Create more request specs
* Update wording
* Update guard to work with requests
* Fix broken spec
* Remove rails-controller-testing gem
* Move article_specs
* Move last controller spec out
* Remove controller spec config
* Fix broken spec
* Remove all use of render_template
* Refactor spec
* Tweak User#remember_me
* Create ArticleAnalyticFetcher spec
* Undo User#remember_me
* Use srand in rspec
* Create FeedbackMessagesHelper spec
* Add DigestMailer spec
* Fix broken test
|
2019-03-29 19:05:02 -04:00 |
|
Abraham Williams
|
9cb40e546b
|
Enables Rails cops (#2186)
* Enable Rails cops
* Fix Rails/DynamicFindBy
* Fix Rails/HttpStatus
* Fix Rails/Blank
* Fix Rails/RequestReferer
* Fix Rails/ActiveRecordAliases
* Fix Rails/FindBy
* Fix Rails/Presence
* Fix Rails/Delegate
* Fix Rails/Validation
* Fix Rails/PluralizationGrammar
* Fix Rails/Present
* Fix Rails/Output
* Fix Rails/Blank
* Fix Rails/FilePath
* Fix Rails/InverseOf
* Fix Rails/LexicallyScopedActionFilter
* Add Rails/OutputSafety to TODO
* Add Rails/HasManyOrHasOneDependent to TODO
* Add Rails/SkipsModelValidations to TODO
|
2019-03-25 09:25:55 -04:00 |
|
Mac Siri
|
2e647cedb4
|
Add more test coverage (#1829)
* Create github repos request spec
* Create article_mutes_spec.rb
* Create moderation_service_spec.rb
* Create push notification subscriptions spec
* Add PodcastEpisodeDecorator specs
* Remove randomness in test
* Create specs for ArticleWithVideoCreationService
* Update spec/decorators/podcast_episode_decorator_spec.rb
Co-Authored-By: maestromac <krairit.siri@gmail.com>
|
2019-02-22 09:16:57 -08:00 |
|