Commit graph

12883 commits

Author SHA1 Message Date
depfu[bot]
37d8fc866a
Update eslint to version 8.48.0 (#20073)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-09-11 15:40:58 +05:30
Ridhwana
789907d289
Tags Dashboard Error Handling (#20051)
* feat: add an error modal for the dashboard page tags

* spec: add the tests for the tags dashboard pages

* spec: add the tests for the hiding tags dashboard pages
2023-09-11 11:41:56 +02:00
Ben Halpern
ed853f7e1e
Fix "register" bugs in invitations (#20071)
* Fix registered bugs in invitations

* Update spec/requests/api/v0/admin/users_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Move to v1 spec

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2023-09-08 17:00:37 -04:00
Rajat Talesra
07b5202ee5
Order badges in ascending order (#20068) 2023-09-08 21:23:19 +05:30
Anna Buianova
d6a273146b
Replace SiteConfig with Settings::General in the comments (#20066) 2023-09-08 15:17:09 +03:00
Mac Siri
1084179579
Update Gitpod's setup (#20026) 2023-09-07 16:36:56 -04:00
Jerin K C
6b996cfc61
Image auto orient (#20018) 2023-09-07 15:38:34 -04:00
Ridhwana
3c34de120b
Add snackbars to /tags (#20046)
* feat: add snackbars to /tags

* chore: update the props for the component"

* feat: update snackbar for following

* feat: add tests for snackbars

* feat: add error handling and show error on snackbar

* chore: tweaks to syntax

* refactor: abstract out the details

* fix: check for null explicitly

* refactor: use hidden instead of assigning a var
2023-09-07 12:03:41 +02:00
Ridhwana
4a8dc9abf6
Unhiding a tag should unfollow it too (#20040)
* feat: update the logic for hiding adn unhidng a tag on /tags

* feat: update the logic for hiding and unhidng a tag on /dashboard/following_tags|hidden_tags

* spec: update the tests for the /tags dashboard

* spec: removes the nav item count spec
2023-09-07 10:35:17 +02:00
Ridhwana
5951beebcb
Polish tag UI (#20038)
* feat: update the buttons

* chore: update the buttons to use c-btn

* feat: update the following tag to be crayons-btn crayons-btn--outlined

* feat: update the gap between the buttons

* feat: style for moile

* Empty commit
2023-09-07 10:32:53 +02:00
depfu[bot]
0f4e0300e0
Update sass-loader to version 13.3.2 (#20047)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-09-06 14:36:41 -07:00
Mac Siri
13c9ea8566
Address deprecated nodesource distributions (#20048) 2023-09-06 09:03:15 -04:00
ktmouk
40e63a16c9
Set reaction's z-index to show the tooltip in front of other comments (#20035) 2023-09-06 11:48:12 +02:00
Ben Halpern
22f836edc2
Add priority weight to billboards (#20019)
* Add priority weight to billboards

* Rewrite query as activerecord

* Change naming from priority_weight to just weight
2023-09-05 16:04:18 -04:00
depfu[bot]
c7ffe51649
Update eslint-config-prettier to version 8.10.0 (#19968)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
Co-authored-by: Duke Greene <dukegreene@gmail.com>
2023-09-05 15:32:08 -04:00
Ridhwana
a6d8767aaa
Use explicit points for following and hidden tags (#20032) 2023-09-05 19:17:27 +02:00
depfu[bot]
49a45f0618
Update @knapsack-pro/cypress to version 7.4.0 (#20025)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-09-05 12:20:11 -04:00
Mac Siri
40122a5c5c
[CI] Use actions/checkout@v4 (#20045) 2023-09-05 11:43:11 -04:00
depfu[bot]
46fd82be80
Update counter_culture to version 3.5.0 (#20027)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-09-04 23:54:43 -07:00
Anna Buianova
83f9e87aec
Changed admin docs url from display-ads url to billboards (#20023)
* Fixed updated billboards doc url

* Fixed HELP_URLS key for billboards
2023-09-04 16:42:34 +03:00
Mac Siri
ca6e635549
Improve docker local development (#19996) 2023-09-01 14:13:40 -04:00
depfu[bot]
6aee764304
[js] Update cypress 12.17.2 → 12.17.4 (patch) (#20020)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-09-01 14:04:55 -04:00
depfu[bot]
e0a3ff9cbd
Update postcss to version 8.4.28 (#20017)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-08-31 12:01:34 -07:00
depfu[bot]
0bb4e7d3fe
[js] Update autoprefixer 10.4.14 → 10.4.15 (patch) (#19965)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2023-08-31 12:00:54 -04:00
Rajat Talesra
cd0f53e413
Move navigation to bottom in onboarding (#20010)
* Shifted navigation to bottom in onboarding

* Padding changes
2023-08-30 23:22:41 +05:30
Anna Buianova
7e83f18eca
Renamed display ad leftovers (test descriptions, swagger) (#20007) 2023-08-30 17:52:55 +03:00
Ridhwana
f4a9c192c0
Follow and Hidden Buttons on /tags page (#20005) 2023-08-30 14:29:00 +02:00
Ben Halpern
02db638d9d
Remove cache headers from sidebars controller (#20002)
* Remove cache headers from sidebars controller

* Remove cache bust logic for sidebar
2023-08-29 13:42:10 -04:00
Narender Singh
358a9a4b8f
add id attr settings extensions (#20006)
* add id attr settings extensions

* Update _api_keys.html.erb

* fix typo  extensions keys

* update id for github extension

* Update comment response template extension

* Update web monetization extension
2023-08-29 13:15:20 -04:00
Ben Halpern
944991a432
Adjust ActiveThreadsQuery to use home_feed_minimum_score (#20004) 2023-08-29 09:35:09 -04:00
Joshua Wehner
d227e1d285
Suppressing articles negative-follow tags from appearing in the "relevant" feed (#19948)
* Try suppressing all negative-follow tags

* userData isn't always available

* Bolster test coverage for tag filter scenarios

* Antitags for the non-basic 'strategy'

* Rename antitags -> hidden_tags

* Rename 'anti_tags' -> 'hidden_tags' as well

* Use userData.followed_tags to derive hidden_tags
2023-08-28 10:11:20 -04:00
Ben Halpern
3324bf47f1
Add http_header to FastText for Fastly compatibility (#19999)
* Add http_header to FastText for Fastly compatibility

* Update app/services/articles/enrich_image_attributes.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update app/services/html/parser.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update spec/models/display_ad_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix rubocop

* Also accept canges to main image for this re-calc

* Rename display_ad_spec for compatibility with main

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2023-08-28 09:34:59 -04:00
Anna Buianova
2d6b740940
Renamed DisplayAd model to Billboard (#19993)
* Renamed Resource Admin: DisplayAd to Billboard

* Renamed DisplayAd to Billboard

* Added a data update script for roles
2023-08-28 08:09:36 -04:00
depfu[bot]
567aba455a
Update recaptcha to version 5.15.0 (#20000)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-08-28 16:41:50 +05:30
Ben Halpern
bba033ea2a
Fix content layout shift with mod-actions-menu-btn (#19991) 2023-08-25 10:52:28 -04:00
Ridhwana
5266dd1afb
Showing and hiding tags in the Following and Hidden Tags Pages (#19954)
* feat: remove updated weights

* feat: click on following on the following tags page

* feat: add and listen for the following button click

* fix: dropdowns

* feat: handle hide button click

* feat: update the nav link for following tags

* feat: handel the 'unhide button' on the hidden tags page

* feat: add the styling for the buttons

* feat: add localization

* feat: remove the brand from the card

* feat: add some styling to the page

* feat: init scrolling

* chore: update the name of the file

* feat: abstract out the comment fetch code

* fix: close the attribute

* feta: make some adjustments to where the tag adn the follow show up

* rename class from plural to singular

* feat: updae the comment

* feat: add a mutation observer to initialize the dropdown

* test: follow_craete

* chore: remove irrelevant test

* feat: update the cypress seeds

* feat: update the cypress seeds

* spec: write soem initial tests for the following tags page

* spec: update the unfollow cypress spec

* spec: update the hide cypress spec

* spec: update the posts published spec

* note to add test for pagination

* spec: hidden tags page

* feat: remove aria pressed attributes

* fix: ordering by explicit points gets the page params confused and returns the incorrect and not all results on pagination

* fix: use explicit points

* feat: remove the message at the top of the following and hidden tags page

* chore: remove comment and rather add it to the PR itself

* refactor: do all the actions on success

* feat: refactor the dashboard tag file

* refactor: only show the tagId and followId dataset attributes on the dashboard__tag__container

* feat: disconnect the observer

* chore: add some documentation

* feat: add fr localization

* chore: empty line

* fix: update the dashboardTags page to first declare the observer"
"
"

* fix: update the rails test

* Empty commit

* fix: because I added more tags, the dropdown was longre and covering the body of the editor hence it could not find the text, so I've escaped after selecting my tags
2023-08-25 14:49:39 +02:00
Rajat Talesra
5ef0f43636
Added limited role (#19969)
* Added limited role

* Nit fix

* Updated tetss

* Added spec tests

* Attempt at 100% code coverage

* Rollback DB migration

* Revert timestamp
2023-08-25 14:41:17 +05:30
Ben Halpern
98c92bcde2
Fix never_imagga for imgproxy (#19997) 2023-08-24 19:00:23 -04:00
Anna Buianova
fc034e41cd
Renamed display ads to billboards in tests descriptions (#19973) 2023-08-24 23:42:13 +03:00
depfu[bot]
4ba7e1e185
Update oj to version 3.16.0 (#19984)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-08-24 10:15:52 -04:00
Narender Singh
14e5d33f74
add lang attribute to viewed article (#19983) 2023-08-24 09:31:52 -04:00
Helio Cola
de1e79e722
Improve SVG regexp validation to use \A and \z (#19953) 2023-08-24 09:29:28 -04:00
Rajat Talesra
992ced1908
Tag moderation UI changes (#19906)
* Basic add remove functionality with few tests

* Updated cypress test and added more unit tests

* Rename display ads vars in the views (#19877)

* Renamed display_ads vars to billboards

* Rename local vars in the feed view

* Renamed display-ad in the comment

Co-authored-by: Rajat Talesra <rajattalesra4914@gmail.com>

* Renamed variables in the views

---------

Co-authored-by: Rajat Talesra <rajattalesra4914@gmail.com>

* Update js-routes to version 2.2.7 (#19883)

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>

* add field for billboard target geolocations, with unit and e2e tests (#19855)

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Duke Greene <dukegreene@gmail.com>
Co-authored-by: PJ <pj@forem.com>
Co-authored-by: Anna Buianova <lightallloy@gmail.com>
Co-authored-by: Mac Siri <mac@forem.com>
Co-authored-by: zhangted <tedcbook@gmail.com>
Co-authored-by: Josh Klar <jklar@forem.com>

* Added autocomplete value off (#19882)

* Bust cache of organization page when new member is added (#19861)

* Remove unused freezeScrolling (#19808)

* Remove unused freezeScrolling

* chore: try see if this helps to skip the flakey test that wasn't being skipped

* chore: try see if this helps to skip the flakey test that wasn't being skipped

* oops: revert the gemfile changes

---------

Co-authored-by: Mai Irie <mai@forem.com>
Co-authored-by: Mac Siri <mac@forem.com>
Co-authored-by: Ridhwana <ridhwana.khan16@gmail.com>

* ci: Allow workflow_dispatch runs to log in to GHCR. (#19885)

* ci: Fix base image builder... the right way... (#19889)

* Update postcss to version 8.4.27 (#19888)

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>

* Replace uses of toBeDefined with toExist  (#19862)

* Replaced toBeDefined with toExist

* Revert db changes

* Rename display ads to billboards: css and js code (#19887)

* Renamed js vars/css names

* Renamed display_ads to billboards in js functions, variables, components

* [ruby] Update sidekiq-unique-jobs 7.1.29 → 7.1.30 (patch) (#19902)

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>

* Update oj to version 3.15.1 (#19901)

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>

* Updated failing cypress test

* Removed commented code

* Attempt at fixing tests

* Fixed failing tests

* Added more tests

* Basic color and design changes part -1

* Disable/Enable buttons correctly

* Various design updates in Tag adjustement mod UI

* I18N and documentation

* Updated mod panel

* Fixed mod related cypress tests

* Minor design fixes

* Dark mode designs

* Test update

* Mod UI with some bugs

* Updated/simplified code fully-working

* Updated tests

* Added more tests

* Accessibility improvements

* hr line code fix

* Close mod icon bug fix

* Nit fixes

* Design fixes as suggested by Anuj.

* Design fixes

* Dark mode file usage

* Design fixes

* Nit fixes

---------

Co-authored-by: Anna Buianova <lightallloy@gmail.com>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Duke Greene <dukegreene@gmail.com>
Co-authored-by: PJ <pj@forem.com>
Co-authored-by: Mac Siri <mac@forem.com>
Co-authored-by: zhangted <tedcbook@gmail.com>
Co-authored-by: Josh Klar <jklar@forem.com>
Co-authored-by: Joshua Wehner <joshua@forem.com>
Co-authored-by: Mai Irie <mai@forem.com>
Co-authored-by: Ridhwana <ridhwana.khan16@gmail.com>
2023-08-24 00:31:21 +05:30
depfu[bot]
85b0a18880
Update all development Bundler dependencies (2023-08-23) (#19964)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-08-23 11:06:45 -07:00
Ben Halpern
98cccdf0ef
Change MAX_TAG_LIST_SIZE for billboards to 25 (#19981) 2023-08-23 12:35:07 -04:00
depfu[bot]
9309f27164
🚨 [security] [ruby] Update rails 7.0.5.1 → 7.0.7.2 (patch) (#19979)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-08-23 11:23:16 -04:00
Mac Siri
2c80aedc1e
Revert "Switch settings to safe yaml load (#19928)" (#19982) 2023-08-23 10:32:26 -04:00
depfu[bot]
7d1fabe3df
Update eslint-import-resolver-webpack to version 0.13.4 (#19972)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-08-22 11:01:42 -07:00
Ben Halpern
1463d8c98a
Do not crop with imagga if never_imagga is passed (#19975)
* Do not crop with imagga if never_imagga is passed

* Clean up code styles
2023-08-22 11:52:02 -04:00
Duke Greene
288206a2b4
speed up organization creation by removing some presence validations (#19952)
* remove presence validation for summary/url/proof, update UI

* simplify everything! use AR validation syntax

* Update app/models/organization.rb

revert reordering of url validation arguments. I had overcomplicated the work with a custom validation, and then upon resetting it, I changed the order unnecessarily
2023-08-22 06:36:16 -04:00