Commit graph

3542 commits

Author SHA1 Message Date
Molly Struve
36efb1b7bb Show count of users followed from API (#5229) [deploy] 2019-12-23 18:20:39 -05:00
Dan Silcox
e98d3cb7be Fix check for whether shell has changed (#5176)
Previously shell_top was being checked twice - now we check top + bottom :)
2019-12-23 18:19:50 -05:00
dependabot-preview[bot]
367f05695f Bump libhoney from 1.14.1 to 1.14.2 (#5217)
Bumps [libhoney](https://github.com/honeycombio/libhoney-rb) from 1.14.1 to 1.14.2.
- [Release notes](https://github.com/honeycombio/libhoney-rb/releases)
- [Commits](https://github.com/honeycombio/libhoney-rb/compare/v1.14.1...v1.14.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-23 18:18:10 -05:00
Ben Halpern
03c2404b13
Redo /mod for performance and usability (#5230) [deploy] 2019-12-23 18:10:25 -05:00
rhymes
d6a0ccb721 Routine Rubocop fixes (#5224) 2019-12-23 14:47:10 -05:00
dependabot-preview[bot]
ec16fc88e7 Bump twilio-ruby from 5.31.0 to 5.31.1 (#5215)
Bumps [twilio-ruby](https://github.com/twilio/twilio-ruby) from 5.31.0 to 5.31.1.
- [Release notes](https://github.com/twilio/twilio-ruby/releases)
- [Changelog](https://github.com/twilio/twilio-ruby/blob/master/CHANGES.md)
- [Commits](https://github.com/twilio/twilio-ruby/compare/5.31.0...5.31.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-23 13:48:07 -05:00
dependabot-preview[bot]
2898a1aa3f Bump faker from 2.8.1 to 2.9.0 (#5212)
Bumps [faker](https://github.com/faker-ruby/faker) from 2.8.1 to 2.9.0.
- [Release notes](https://github.com/faker-ruby/faker/releases)
- [Changelog](https://github.com/faker-ruby/faker/blob/master/CHANGELOG.md)
- [Commits](https://github.com/faker-ruby/faker/compare/v2.8.1...v2.9.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-23 13:43:31 -05:00
dependabot-preview[bot]
c74c60801b Bump rubocop-rspec from 1.37.0 to 1.37.1 (#5214)
Bumps [rubocop-rspec](https://github.com/rubocop-hq/rubocop-rspec) from 1.37.0 to 1.37.1.
- [Release notes](https://github.com/rubocop-hq/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-rspec/compare/v1.37.0...v1.37.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-23 13:34:52 -05:00
dependabot-preview[bot]
a7032b62f1 Bump google-api-client from 0.36.1 to 0.36.2 (#5211) [deploy]
Bumps [google-api-client](https://github.com/google/google-api-ruby-client) from 0.36.1 to 0.36.2.
- [Release notes](https://github.com/google/google-api-ruby-client/releases)
- [Changelog](https://github.com/googleapis/google-api-ruby-client/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/google-api-ruby-client/compare/0.36.1...0.36.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-23 12:23:44 -05:00
dependabot-preview[bot]
4cdad94c9c Bump dry-struct from 1.1.1 to 1.2.0 (#5210) 2019-12-23 12:22:59 -05:00
Mike Coutermarsh
3128c17fab Improve twitter card caching (#5206) [deploy]
* update test so it fails from badge randomness

* Better caching

This removes the randomness from the views. Which means the cache keys
won't get regenerated every request.

The badges will still be in random positions, but it will change per
user/article rather than every render.
2019-12-23 12:22:38 -05:00
dependabot-preview[bot]
ca71cb2c34 Bump rubocop from 0.77.0 to 0.78.0 (#5216) 2019-12-23 12:14:01 -05:00
Ben Halpern
737310f8ef
Add ability to open /new in connect sidecar (#5220) [deploy] 2019-12-23 09:11:02 -05:00
Sarthak Sharma
bb570a2d55 Bug Fix 🐞: Fixing missing edit and delete option (#5200)
* Feature 🚀 : Ability to delete messages in chat channels

- Sending message ID to frontend
- Deleting Message
- Use pusher to delete message realtime

* Minor Bug 🐞: Show message action only for current user

- User can delete or edit their own messages

* Test cases added

* Bug 🐞: Update message id for receiver

Message id was not sent to receiver by pusher

* Refactoring🛠: Message controller refactoring

* Test Cases📝 : Specs for Delete message added

* Feature 🚀 : Ability to edit messages

* Test Cases📝 : Specs for Edit message added

* Bug Fix 🐞:  Fixing missing edit and delete option
2019-12-23 08:20:15 -05:00
Ben Halpern
5812ecc383
Open /connect sidecar links in iframe (#5203) [deploy]
* Use iframe for connect sidecar

* Modify css of lefthand sidebar

* Add proper sidecar markup

* Update tests
2019-12-21 15:46:36 -05:00
Ben Halpern
cb3a0c462c
Separate chat channel unopened status from Algolia (#5198) [deploy] 2019-12-21 13:05:16 -05:00
Molly Struve
b1a71d0ac1 Ensure comment has a path when created for specs (#5197) 2019-12-20 17:23:59 -05:00
Ben Halpern
cd9805bc22 Fix tag badge task logic (#5189) [deploy] 2019-12-20 14:39:28 -05:00
Molly Struve
71fbad5387 Check user follow count after job is run (#5193) 2019-12-20 14:25:58 -05:00
Molly Struve
212a2a430d Return not_found response if we cant return users via the api (#5192) 2019-12-20 13:43:14 -05:00
Molly Struve
55b691c980
Ensure model properties in factories are unique (#5190) 2019-12-20 12:21:16 -06:00
Sarthak Sharma
b602b7b91f 🚀Feature/ability to edit messages (#5139) [deploy]
* Feature 🚀 : Ability to delete messages in chat channels

- Sending message ID to frontend
- Deleting Message
- Use pusher to delete message realtime

* Minor Bug 🐞: Show message action only for current user

- User can delete or edit their own messages

* Test cases added

* Bug 🐞: Update message id for receiver

Message id was not sent to receiver by pusher

* Refactoring🛠: Message controller refactoring

* Test Cases📝 : Specs for Delete message added

* Feature 🚀 : Ability to edit messages

* Test Cases📝 : Specs for Edit message added

* Refactoring🔩: Refactoring for edit messages

* Refactoring🔩: Refactoring:2 for edit messages

* Refactoring🔩: Refactoring:2 for edit messages

* Test Cases📝 : Test Cases for edit message added

* Minor Bug 🐞: Show message action only for current user

- User can delete or edit their own messages

* Test cases added

* Bug 🐞: Update message id for receiver

Message id was not sent to receiver by pusher

* Feature 🚀 : Ability to edit messages

* Test Cases📝 : Specs for Edit message added

* Refactoring🔩: Refactoring for edit messages

* Refactoring🔩: Refactoring:2 for edit messages

* Refactoring🔩: Refactoring:2 for edit messages

* Bug Fix 🐞: Added space between edited and timestamp

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2019-12-20 10:19:00 -05:00
Jared Harbison
07fd2281cd Implement GitPitchTag (#4942) 2019-12-19 19:59:15 -05:00
Molly Struve
1b2cdfb0c4 Return 422 if params are missing when creating an article via the API (#5182) 2019-12-19 19:21:21 -05:00
Molly Struve
672ea78cc6 Sequence factory podcast episode slugs and guids to ensure uniqueness (#5184) 2019-12-19 19:13:19 -05:00
Molly Struve
f26a6f49d2 Revert "Use raw SQL to Update page_views so new and existing Records can be updated (#5167) [deploy]" (#5185)
This reverts commit 9a7fb3b04e.
2019-12-19 16:43:37 -05:00
Ben Halpern
c6d94d4049
Add rake task to reward tag badges weekly (#5183) [deploy] 2019-12-19 16:34:22 -05:00
Molly Struve
9a7fb3b04e
Use raw SQL to Update page_views so new and existing Records can be updated (#5167) [deploy] 2019-12-19 14:28:32 -06:00
Ben Halpern
c5d4f293e6
Don't serviceworker cache ?preview= requests (#5181) [deploy] 2019-12-19 15:28:00 -05:00
Molly Struve
ac8e5b4fb0
Return not_found error if org is not found (#5179) [deploy] 2019-12-19 10:53:50 -06:00
Molly Struve
36aed0458e create social preview for comment that is missing commentable (#5171) [deploy] 2019-12-19 11:14:37 -05:00
Matheus Azzi
662a99ade3 Remove unnecessary reaction call (#5122) [deploy]
Clicking the button to follow people on search page was erroneously
triggering a reaction request, thus not having the reactable_id.

We've updated the handlers not to trigger it.
2019-12-19 11:03:34 -05:00
Molly Struve
4a2e55ff06
Return not_found Response If Video's Related Article is Not Found (#5169) [deploy] 2019-12-19 09:41:59 -06:00
Jacob Herrington
00dd84f9e1 Add a default message to badge award action (#5160)
* Add a default message to badge award action

Because:
 - The only badges routinely awarded manually use the same message
 - Right now, unfriendly/unsafe UI can result in an error notification

The only badges that are currently awarded manually (afaik) have the
message "Congrats!!!" so for the time being, if a message is not
supplied to the UI, it will simply use the "Congrats!!!" message as a
default.

That being said, I'm not totally convinced this message won't work for
the long term. Generally, if we are awarding badges by hand, I'd imagine
we'd want a specific message explaining why we are doing that, or just
be okay with "Congrats!"

After talking with Peter about it, the longer term goal should be to
move badge messages into the database so they can be modified in the app
and not hardcoded. That also make sense regarding the effort to
genericize the app eventually.

* Test Badge notifications
2019-12-19 10:38:57 -05:00
Anna Buianova
dcfa6d29b8 Fix Rubocop lints (#5155) 2019-12-19 10:09:37 -05:00
dependabot-preview[bot]
d5414eeac7 [Security] Bump rack from 2.0.7 to 2.0.8 (#5166) [deploy]
Bumps [rack](https://github.com/rack/rack) from 2.0.7 to 2.0.8. **This update includes a security fix.**
- [Release notes](https://github.com/rack/rack/releases)
- [Changelog](https://github.com/rack/rack/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rack/rack/compare/2.0.7...2.0.8)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-18 17:26:11 -05:00
Molly Struve
1156aff711
Ignore ActiveRecord::QueryCanceled errors in Honeybadger (#5165) [deploy] 2019-12-18 13:09:49 -06:00
Molly Struve
b5614a34e2
Dont Raise Error For Incorrect Liquid Tags (#5089) [deploy] 2019-12-18 11:23:39 -06:00
Jacob Herrington
9ad95cb6f9 Fix erb-lint config (#5148)
This was blowing up and making it impossible for me to commit stuff
without bypassing the hooks.
2019-12-17 18:56:23 -05:00
Ben Halpern
63f228c57c
Skip serviceworker logic for Twitter iOS referrals (#5159) [deploy] 2019-12-17 15:21:17 -05:00
Jacob Herrington
d98f8237bd Add view for managing organizations (#5149) [deploy]
* Add view for managing organizations

This adds only an index and show action for the internal/organizations
page. Eventually we'll flesh this out with features to automate the more
mechanical org management tasks.

* Use instance variable for search query

* Convert multiple expects into one

* Add pagination to organizations

* Add search spec for organizations

* Use size over count
2019-12-17 12:07:11 -05:00
Ben Halpern
4349843c05
Frontend bug fixes (#5158) [deploy]
* Frontend bug fixes

* One line fix
2019-12-17 10:56:51 -05:00
Molly Struve
1a76fa03d7 Return ActionController::RoutingError error when Invalid Format is Requested (#5140) [deploy]
* Return ActiveRecord::RecordNotFound error when an invalid format is requested

* raise ActionController::RoutingError when template is not found
2019-12-17 10:00:12 -05:00
Lucas Hiago
1d97f32285 Refactor UserPolicy (#5095) 2019-12-17 09:45:08 -05:00
Ben Halpern
7684c1e8b9
Add edge caching to shell (#5146) [deploy]
* Add edge caching to shell

* Add tests for shell
2019-12-16 19:08:59 -05:00
Ben Halpern
4eb0477223
Fix feedback_messages styling (#5147) [deploy] 2019-12-16 19:00:21 -05:00
Ben Halpern
07a7e9c075
Monkeypatch method to ensure https redirect (#5145) [deploy] 2019-12-16 18:15:14 -05:00
Dan Ingenthron
12dae72b72 Refactor/lint onboarding slides (#4240) 2019-12-16 17:22:59 -05:00
Ben Halpern
3d0ae601fb
Remove unnecessary catch (#5144) [deploy] 2019-12-16 15:28:11 -05:00
Jacob Herrington
2dac64b39d Expand the testing docs (#5112)
* Add context to Acceptance Testing guide

* Add docs on Regression testing

* Expand CI skip docs

* Expand documentation on testing controllers [ci skip]
2019-12-16 15:16:16 -05:00