Commit graph

3481 commits

Author SHA1 Message Date
Jacob Herrington
35ede32be7 Internal bulk badge awarder (#5110) [deploy]
* Move admin specs

These tests should probably be grouped together, so I moved them into a
directory called "internal"

This also encourages some additional internal tests.

* Add an internal badges controller

* Add internal view for running BadgeRewarder task

Because:
  - Peter is currently running this rake task from Heroku and this is
  going to make his workflow easier
  - It's a step towards having a decent tool under internal for managing
  badges (though I'd hesitate to call this decent)

This change adds a view and controller action to award badges in
batches, it's an improvment over the current workflow that Peter is
using, but it's still very rough around the edges.

We could definitely improve this with some error handling around the way
the BadgeRewarder works, but for now this is a net gain over how Peter
has been doing this task. I think it's worth merging as is and future
work to improve the experience and reliability of this tool can be
prioritized against other tasks.
2019-12-16 11:31:37 -05:00
dependabot-preview[bot]
9cd35d1b74 Bump google-api-client from 0.36.0 to 0.36.1 (#5131) [deploy] 2019-12-16 11:19:19 -05:00
dependabot-preview[bot]
d319641201 Bump nokogiri from 1.10.5 to 1.10.7 (#5129)
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.5 to 1.10.7.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.10.5...v1.10.7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-16 11:18:53 -05:00
Mac Siri
990b078d12 Bump httparty from 0.17.2 to 0.17.3 (#5136) [deploy] 2019-12-16 11:12:58 -05:00
dependabot-preview[bot]
ecada63c30 Bump redoc-cli from 0.9.2 to 0.9.4 (#5126)
Bumps [redoc-cli](https://github.com/Redocly/redoc) from 0.9.2 to 0.9.4.
- [Release notes](https://github.com/Redocly/redoc/releases)
- [Changelog](https://github.com/Redocly/redoc/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Redocly/redoc/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-16 11:09:31 -05:00
dependabot-preview[bot]
1e740f029f Bump parallel_tests from 2.29.2 to 2.30.0 (#5133)
Bumps [parallel_tests](https://github.com/grosser/parallel_tests) from 2.29.2 to 2.30.0.
- [Release notes](https://github.com/grosser/parallel_tests/releases)
- [Commits](https://github.com/grosser/parallel_tests/compare/v2.29.2...v2.30.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-16 11:03:13 -05:00
Lenmor Larroza Dimanalata
08b0886eb0 Fix Backend Guide > Roles admin links [ci skip] (#5118) 2019-12-16 09:25:48 -05:00
John Curcio
145c76bc08 Fix fullscreen button issue by allowing popups (#5115) [deploy] 2019-12-16 08:26:07 -05:00
James George
f03867f77d refactor: use Array.includes instead of indexOf (#5117) 2019-12-16 08:10:44 -05:00
dependabot-preview[bot]
b3b177ad8d Bump httparty from 0.17.1 to 0.17.2 (#5130)
Bumps [httparty](https://github.com/jnunemaker/httparty) from 0.17.1 to 0.17.2.
- [Release notes](https://github.com/jnunemaker/httparty/releases)
- [Changelog](https://github.com/jnunemaker/httparty/blob/master/Changelog.md)
- [Commits](https://github.com/jnunemaker/httparty/compare/v0.17.1...v0.17.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-16 08:10:08 -05:00
Jacob Herrington
6877534cce Add abuse report seed data (#5113) 2019-12-16 08:09:52 -05:00
dependabot-preview[bot]
683afb4fe8 Bump ruby-prof from 1.0.0 to 1.1.0 (#5127)
Bumps [ruby-prof](https://github.com/ruby-prof/ruby-prof) from 1.0.0 to 1.1.0.
- [Release notes](https://github.com/ruby-prof/ruby-prof/releases)
- [Changelog](https://github.com/ruby-prof/ruby-prof/blob/master/CHANGES)
- [Commits](https://github.com/ruby-prof/ruby-prof/compare/1.0.0...1.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-16 08:09:25 -05:00
Ben Halpern
b599b66ce1
Cosmetic adjustment + code cleanup for article/mod page (#5105) [deploy]
* Cosmetic adjustment + code cleanup for article/mod page

* Remove br tags and clean up css
2019-12-15 17:43:24 -05:00
Mac Siri
83e1313b1a
Expand Lint-staged's file coverage (#5109) [ci skip] 2019-12-13 16:28:31 -05:00
Molly Struve
9912bbcdb8
Asynchronously Update Algolia after a PageView Update (#5076) [deploy] 2019-12-13 14:07:33 -06:00
dependabot-preview[bot]
59ae0309e0 Bump rubocop from 0.76.0 to 0.77.0 (#5048) 2019-12-13 15:00:05 -05:00
Molly Struve
d6e513e1ac Default return all user notifications if filter is unknown (#5103) [deploy] 2019-12-13 14:35:53 -05:00
Molly Struve
cc808251ee Remove unused aggregation reaction cache (#5104) 2019-12-13 13:18:44 -05:00
Spencer
82f5bb9cdd Mod tooling: add tags via /mod refactor (#5017)
* mod view form changes

* add error validation for removal tag

* add error validation to tag_list count

* re-render tag_adjustment form errors

* refactor admin delete adjusted tags form

* add prompt to tag adjustment form select

* front end validations to add/remove tag_adjustment

* allow tag_mod to undo own tag adjustment

* update/add specs

* update send spec

* update tag adjustment spec
2019-12-13 13:02:45 -05:00
Nick Schwaderer
b7bb7b473c Respond to xml request with error on Articles#feed (#5077) 2019-12-13 12:30:26 -05:00
Ryan Smith
b809562a2f Fix Algolia signup link. (#5100) 2019-12-13 10:59:09 -06:00
Ben Halpern
9682394831
Remove unnecessary notifications fragment cache (#5083) [deploy] 2019-12-13 11:37:55 -05:00
Bolarinwa Balogun
a2c27ef4ef Remove special characters in tags for articles created via API (#4239) [deploy] 2019-12-13 11:30:35 -05:00
Bolarinwa Balogun
8c6adac7ba Remove special characters in tags for articles created via API (#4239) [deploy] 2019-12-13 11:29:02 -05:00
Anna Buianova
05fe308f5b Removed old user indexing code (#5102) 2019-12-13 10:44:12 -05:00
Molly Struve
aa9361798d
Return not_found response rather than trying to authorize a nil object (#5093) [deploy] 2019-12-13 09:39:40 -06:00
Jacob Herrington
ff32ed853f Remove commented specs (#5096) [deploy]
* Remove comment spec with no examples

* Delete commented out spec

This test could be refactored to a green state, but I'm not sure it's
worth the effort.

I started down that path, but it was time consuming. It might be more
effective to rewrite this test from scratch.

For the time being, since it has not been running, I think it should be
removed from the codebase.
2019-12-13 08:26:31 -05:00
Molly Struve
8f08ad2e99 add optimization option to PR template (#5097) 2019-12-13 08:24:27 -05:00
Jacob Herrington
a63a11f930 Write docs on rolify admin workaround [ci skip] (#5078) 2019-12-13 08:23:55 -05:00
Lucas Hiago
d1a89eab15 Refactor method in articles.rb (#5094) 2019-12-13 08:23:19 -05:00
Molly Struve
c8e712b6c8 remove caches for html that contains no external requests (#5098) 2019-12-13 08:22:27 -05:00
Ryan Smith
4dca3f9b24 Fix Technical Overview links [ci skip] (#5084) 2019-12-12 14:36:45 -05:00
Jacob Herrington
b34ae9b7d9 Remove dead code (#5090) [deploy] 2019-12-12 12:19:55 -06:00
Molly Struve
dc5ec4e52f
Use find_or_create_by to avoid duplicate records (#5092) 2019-12-12 12:01:15 -06:00
Glenn Carremans
ac4e7eca90 Changed .nvmrc to be more implicit (#5080) 2019-12-11 15:39:35 -05:00
Molly Struve
6ba2853168 Ensure that we have a slug and owner before attempting to lookup an article (#5079) 2019-12-11 13:19:45 -05:00
Jacob Herrington
145db47a3a Add single resource admin concept (#5069) [deploy]
* Add a trait for single_resource_admins to users factory

* Add single_resource_admin authrization for Growth view

* Expand GrowthController test coverage

* Add single resource admin workaround to models

* Add single resource admin to additional views
2019-12-11 13:17:55 -05:00
Anna Buianova
bbc5f95d86 Fix Algolia deserialization errors by indexing by record_type and id rather than AR object (#5063) [deploy] 2019-12-11 11:49:35 -06:00
Molly Struve
2d6d611634 switch back to update_column to improve performance (#5074) [deploy] 2019-12-10 18:38:04 -05:00
Andrew Sverdrup
2af033fca9 Add Next Tech Liquid Tag (#4958) [deploy]
* Add liquid tag for Next Tech

* Add liquid tag for Next Tech

* Use project share URL in liquid tag.

* Update docs and specs with share token URL.
2019-12-10 15:19:30 -05:00
Jacob Herrington
df776b8748 Fix pending tests (#5070) [deploy]
* Enable pending system spec

* Remove pending and useless tests

There is a pending test for functionality that does not exist, so I
removed it.

I removed some expect blocks that were essentially testing if Rspec
works / if Rails routing works. That's probably not necessary for us to
do and leaving the code in a spec encourages future contributors to
write similar specs.
2019-12-10 15:10:14 -05:00
Andy Zhao
71157c993e Hide comment feature (#4944)
* Add MVP of hide comment feature

* Slight copy adjustments

* Remove unused file oops

* Fix strange styling issues

* Add hide/unhide comment specs

* Authenticate user for hide/unhide

* Add tests for hide/unhide functionality

* Remove opacity CSS for hidden comments

* Fix hidden comment explanation logic

* Fix some styling issues

* Fix hiding top level comment logic

* Show only hidden comments in permalink and not thread

* Hide subtree properly if hidden comment

* Fix weird CSS issue

* Properly hide comments for permalink view

* Show children comments in permalink view

* Add tests for comment hiding visibility

* Remove superfluous code and adjust copy

* Remove some more logical duplication

* Add dedicated article column for any comments hidden

* Add reload in test
2019-12-10 15:09:47 -05:00
Molly Struve
98b832155f Ensure remember_user_token is present for Fastly with specs (#5065) 2019-12-10 15:01:26 -05:00
Molly Struve
3f8a6caa72
Use find_or_create_by when updating a pageview and use update in case of creation (#5066) [deploy] 2019-12-10 13:48:50 -06:00
Molly Struve
a2bef6aeec
Group Internal Errors when sending to HoneyBadger (#5067) 2019-12-10 13:48:06 -06:00
James Turner
b4507f21d4 Update itemprop to use mainEntity (#5060) 2019-12-10 14:43:24 -05:00
Ben Halpern
c746da3a5e
Remove unused "Edit" button as follow-on to #5056 (#5071) [deploy]
* Feature 🚀 : Ability to delete messages in chat channels

- Sending message ID to frontend
- Deleting Message
- Use pusher to delete message realtime

* Minor Bug 🐞: Show message action only for current user

- User can delete or edit their own messages

* Test cases added

* Bug 🐞: Update message id for receiver

Message id was not sent to receiver by pusher

* Refactoring🛠: Message controller refactoring

* Test Cases📝 : Specs for Delete message added

* Remove edit button and modify css
2019-12-10 14:15:56 -05:00
Molly Struve
7c650dcb1c
Remove RedisRailsCache and replace with Rails.cache (#5059) [deploy] 2019-12-10 13:11:08 -06:00
Sarthak Sharma
4db5399ee8 Feature🚀: Ability to Delete Messages realtime (#5056)
* Feature 🚀 : Ability to delete messages in chat channels

- Sending message ID to frontend
- Deleting Message
- Use pusher to delete message realtime

* Minor Bug 🐞: Show message action only for current user

- User can delete or edit their own messages

* Test cases added

* Bug 🐞: Update message id for receiver

Message id was not sent to receiver by pusher

* Refactoring🛠: Message controller refactoring

* Test Cases📝 : Specs for Delete message added
2019-12-10 13:58:34 -05:00
dependabot-preview[bot]
3c97bc5487 Bump honeycomb-beeline from 1.2.0 to 1.3.0 (#5052) 2019-12-10 08:52:50 -05:00