Commit graph

5949 commits

Author SHA1 Message Date
Alex
347a4bbc75
[deploy] Add contexts and permissions to liquid tags (#8917)
* Make liquid tags adhere to context and permission

* Undo updates to all liquid tags and update error

* ACTUALLY update errors this time

* Typo

* Refactor error handling and add support for Comment

* Fix specs

* Code cleanup

* Prettify error message

* Add comment clarifying error

* parsed --> parse

* Use a policy for validating roles

* Fix pretty error message

* Return early if valid source

* Get rid of duplicate current_user

* Add comment to Pundit.authorize

* LiquidTagPolicy specs

* Update liquid tag docs

* Update docs

* Use parse_context argument for clarity

* Remove duplicate guard clause for VALID_ROLES

* Update docs
2020-06-30 14:53:18 -04:00
Ben Lesh
e364a6ad19
Hide secret code from input history (#9032)
Currently, the secret code will show up in the input history. That, I think, means that anyone that can open that page in a shared browser instance could join the org.
2020-06-30 14:26:18 -04:00
dependabot-preview[bot]
ec71478762
Bump knapsack_pro from 1.22.2 to 2.0.0 (#8960) 2020-06-30 14:23:37 -04:00
Mac Siri
0e2fc110b2
[deploy] Delete hello-dev.js (#9025) 2020-06-30 14:13:04 -04:00
Fernando Valverde
2233952ceb
[deploy] Discoverable channel will open CTA to request join if not available (#8999) 2020-06-30 13:03:41 -05:00
Nick Taylor
efc3a124a0
Added spinner/upload message when uploading an image to a post's content (#8986) 2020-06-30 13:52:47 -04:00
Molly Struve
62f89f9c7c
Flaky Spec Fix: Make Sure to Allow All Sites After Reset (#9029) 2020-06-30 12:50:38 -05:00
Molly Struve
0cd40f5ffb
Refactor: Remove Unused UserSimilarity Class and Spec (#9030) 2020-06-30 12:39:34 -05:00
Molly Struve
9d18246875
[deploy] Refactor: Remove Unused Article Suggester Services and Specs (#9031) 2020-06-30 12:06:56 -05:00
Fernando Valverde
336cf119d9
[deploy] Fixes triggerSwitchChannel on channel list load (#8996) 2020-06-30 10:09:36 -06:00
Molly Struve
d9fd170a85
[deploy] Optimization: Dont Use Redis For Flare Tag IDs, Load Them On Boot (#8987) 2020-06-30 09:48:08 -05:00
dependabot-preview[bot]
56736aab15
[deploy] Bump flipper, flipper-active_record and flipper-ui (#8966)
* Bump flipper, flipper-active_record and flipper-ui

Bumps [flipper](https://github.com/jnunemaker/flipper), [flipper-active_record](https://github.com/jnunemaker/flipper) and [flipper-ui](https://github.com/jnunemaker/flipper). These dependencies needed to be updated together.

Updates `flipper` from 0.17.2 to 0.18.0
- [Release notes](https://github.com/jnunemaker/flipper/releases)
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md)
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.17.2...v0.18.0)

Updates `flipper-active_record` from 0.17.2 to 0.18.0
- [Release notes](https://github.com/jnunemaker/flipper/releases)
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md)
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.17.2...v0.18.0)

Updates `flipper-ui` from 0.17.2 to 0.18.0
- [Release notes](https://github.com/jnunemaker/flipper/releases)
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md)
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.17.2...v0.18.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump flipper, flipper-active_record and flipper-ui (Update vendor/cache)

* Removed outdated flipper UI configuration

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Josh Puetz <josh@dev.to>
2020-06-30 08:19:27 -05:00
OmarElKhatib
f3501d32f5
fix Issue #9013 , badge responsivity (#9014)
* fix Issue #9013 , badge responsivity

* remove d- prefix from d-block

* remove block because it behave the same without it
2020-06-30 12:52:47 +02:00
Mac Siri
d0b0944b32
Disable UserSubscriptionTag::script (#9005) 2020-06-30 09:13:44 +02:00
Jacob Herrington
8c4fd87599
Update maintainers documentation and contribution guides (#8939)
* Update contributing guide

In this change, I tried to simplify the language of the contributing
guide to make it more accessible and less wordy.

I also updated the information in a few places and fixed a couple of
typos.

* Remove table of contents

Since moving this doc to the docs site, our theme generates a ToC
automatically, hardcoding this one is redundant.

* Move the contributing guides

* Update maintainer documentation

This chnage updates the maintainers guide to include information on PR
reviews, deployments, and CI.

Housing this documentation here increases transparency with our
community.

* Edit with PR feedback

* Edit based on PR feedback
2020-06-30 09:11:59 +02:00
ludwiczakpawel
3a69f349be
[deploy] Refactor code blocks styling (#8975)
* flare tag line height

* .

* dropdown fix + actions bar fix

* actions bar on mob

* .

* missing bit

* document

* .

* little fix

* btn--highlight
2020-06-29 21:15:11 -04:00
Jacob Herrington
c0fc10ec1d
Override header padding for internal (#8992) 2020-06-29 20:27:30 -04:00
Ben Halpern
aa855e5f9b
[deploy] Remove dead styling code (#8991) 2020-06-29 20:26:49 -04:00
Molly Struve
619aa0a684
Refactor: Remove Unused and Unecessary Code (#9000) 2020-06-29 17:30:56 -05:00
Molly Struve
b43575aa21
Flaky Spec Fix: Use Host Only For Allowing Webmock Connections (#9001) 2020-06-29 17:28:10 -05:00
dependabot-preview[bot]
f135fd4338
[deploy] Bump pusher-push-notifications from 1.1.0 to 1.2.1 (#8952)
* Bump pusher-push-notifications from 1.1.0 to 1.2.1

Bumps [pusher-push-notifications](https://github.com/pusher/push-notifications-ruby) from 1.1.0 to 1.2.1.
- [Release notes](https://github.com/pusher/push-notifications-ruby/releases)
- [Changelog](https://github.com/pusher/push-notifications-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/pusher/push-notifications-ruby/compare/v1.1.0...v1.2.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* update vendored gems

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: mstruve <mollylbs@gmail.com>
2020-06-29 16:14:17 -05:00
dependabot-preview[bot]
aabbc3c5f6
Bump ddtrace from 0.36.0 to 0.37.0 (#8951)
* Bump ddtrace from 0.36.0 to 0.37.0

Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb) from 0.36.0 to 0.37.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases)
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md)
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v0.36.0...v0.37.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* update vendored gems

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: mstruve <mollylbs@gmail.com>
2020-06-29 16:13:51 -05:00
Molly Struve
4e0fee644c
[deploy] Feature: Setup Admin Area to Update Vault Secrets (#8935) 2020-06-29 15:08:09 -05:00
dependabot-preview[bot]
bacff174a6
Bump autoprefixer-rails from 9.8.1 to 9.8.4 (#8953) 2020-06-29 15:28:33 -04:00
Yash Dave
83bc91b961
Fix rbenv install failing for windows docs (#8854) 2020-06-29 15:27:58 -04:00
Mac Siri
50a7c2ffe0
Rename dir _tests to __tests__ & update .codeclimate.yml (#8982) 2020-06-29 15:18:39 -04:00
dependabot-preview[bot]
16073c5e49
Bump capybara from 3.32.2 to 3.33.0 (#8967) 2020-06-29 14:56:41 -04:00
Molly Struve
cbde1a1a6a
[deploy] Revert "Feature: Introduce KnapsackPro Queue Mode (#8938)" (#8994)
This reverts commit dbdd59b83a.
2020-06-29 13:32:25 -05:00
Vaidehi Joshi
38ae790183
Do not render active announcements in iframes (#8981) [deploy]
* Do not render active announcements in mod tools

* Add a TODO around refactoring broadcast initialization

* Refactor initializeBroadcast to short-circuit on window.frameElement
2020-06-29 11:15:27 -07:00
Molly Struve
dbdd59b83a
Feature: Introduce KnapsackPro Queue Mode (#8938)
* Feature: Introduce KnapsackPro Queue Mode
* Run specs at the end to get the greatest speedup
2020-06-29 12:18:00 -05:00
Vaidehi Joshi
33222e430c
Link to @jessitron's blog post in our documentation guides (#8985) 2020-06-29 13:03:17 -04:00
narender2031
09e70896fa
[deploy] 🚀 Bug: Fix iframe flashes on re render (#8974)
* Feature 🚀 : Ability to delete messages in chat channels

- Sending message ID to frontend
- Deleting Message
- Use pusher to delete message realtime

* Minor Bug 🐞: Show message action only for current user

- User can delete or edit their own messages

* Test cases added

* Bug 🐞: Update message id for receiver

Message id was not sent to receiver by pusher

* Refactoring🛠: Message controller refactoring

* Test Cases📝 : Specs for Delete message added

* Feature 🚀 : Ability to edit messages

* Test Cases📝 : Specs for Edit message added

* fix flashes on re-render chat ui

Co-authored-by: Sarthak Sharma <7lovesharma7@gmail.com>
2020-06-29 12:20:21 -04:00
Lisa Sy
c627086d74
Update Connect responsiveness on smaller viewports (#8829) [deploy]
* Improve responsive experience for Connect

- Create single-screen experience for channels list & chat container on
  small screens
- Remove `expanded` and `contracted` functionality
- Make small UI updates to channels-list
- Update tests accordingly

https://github.com/thepracticaldev/dev.to/issues/8442

* Iterate per first review

- Delete unnecessary conditional for displaying side filters
- Improve width display
- Use different animation for responsive experience
- Add top-border stroke to composer input

* Update app/assets/stylesheets/chat.scss

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* Update app/assets/stylesheets/chat.scss

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* Update app/assets/stylesheets/chat.scss

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* Update app/assets/stylesheets/chat.scss

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* Update app/assets/stylesheets/chat.scss

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* Update app/assets/stylesheets/chat.scss

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* layout fix

* Update test to reflect markup updates

* Fix channels position issue

* Use constants

* Lower coverage threshold

* Update line coverage threshold

https://github.com/thepracticaldev/dev.to/pull/8829#issuecomment-650140589

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
Co-authored-by: rhymes <rhymesete@gmail.com>
2020-06-29 09:08:18 -07:00
dependabot-preview[bot]
3d9d70bb5c
[deploy] Bump rubocop from 0.85.1 to 0.86.0 (#8962)
* Bump rubocop from 0.85.1 to 0.86.0

Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.85.1 to 0.86.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.85.1...v0.86.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* update vendored gems

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: mstruve <mollylbs@gmail.com>
2020-06-29 10:45:10 -05:00
dependabot-preview[bot]
fea3094bf7
Bump fog-aws from 3.6.5 to 3.6.6 (#8958)
* Bump fog-aws from 3.6.5 to 3.6.6

Bumps [fog-aws](https://github.com/fog/fog-aws) from 3.6.5 to 3.6.6.
- [Release notes](https://github.com/fog/fog-aws/releases)
- [Changelog](https://github.com/fog/fog-aws/blob/master/CHANGELOG.md)
- [Commits](https://github.com/fog/fog-aws/compare/v3.6.5...v3.6.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump fog-aws from 3.6.5 to 3.6.6 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-29 10:43:24 -05:00
dependabot-preview[bot]
8270100b71
Bump aws-sdk-lambda from 1.44.0 to 1.45.0 (#8955)
* Bump aws-sdk-lambda from 1.44.0 to 1.45.0

Bumps [aws-sdk-lambda](https://github.com/aws/aws-sdk-ruby) from 1.44.0 to 1.45.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sdk-lambda/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/compare/v1.44.0...v1.45.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump aws-sdk-lambda from 1.44.0 to 1.45.0 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-29 10:42:27 -05:00
Nick Taylor
b9c64e57f1
Added a comment mentioning that index.js overrides are for barrel files (#8978) 2020-06-29 10:52:35 -04:00
dependabot-preview[bot]
92c72ab2c5
[deploy] Bump twilio-ruby from 5.37.0 to 5.38.0 (#8968) 2020-06-29 09:39:41 -05:00
Molly Struve
8b8ee0a00e
Documentation: Vault Docs (#8936)
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2020-06-29 09:33:52 -05:00
rhymes
14c346c8ed
[deploy] Remove dead code in chat-channels-controller (#8943) 2020-06-29 09:32:20 -04:00
rhymes
d3a7f64d2b
Tell the service worker to skip /rss (#8944) 2020-06-29 09:30:56 -04:00
dependabot-preview[bot]
bbdbc4724c
Bump ibm-openapi-validator from 0.27.1 to 0.28.0 (#8959)
Bumps [ibm-openapi-validator](https://github.com/IBM/openapi-validator) from 0.27.1 to 0.28.0.
- [Release notes](https://github.com/IBM/openapi-validator/releases)
- [Changelog](https://github.com/IBM/openapi-validator/blob/master/CHANGELOG.md)
- [Commits](https://github.com/IBM/openapi-validator/compare/v0.27.1...v0.28.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-29 09:30:33 -04:00
dependabot-preview[bot]
fec0171742
Bump twilio-video from 2.5.1 to 2.6.0 (#8961)
Bumps [twilio-video](https://github.com/twilio/twilio-video.js) from 2.5.1 to 2.6.0.
- [Release notes](https://github.com/twilio/twilio-video.js/releases)
- [Changelog](https://github.com/twilio/twilio-video.js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/twilio/twilio-video.js/compare/2.5.1...2.6.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-29 09:30:18 -04:00
Nick Taylor
2130269f91
Documentation Improvements to Storybook (#8947) 2020-06-29 08:25:57 -05:00
Nick Taylor
30bfe1adfd
More frontend lint fixes (#8931) 2020-06-29 08:19:13 -04:00
Bolarinwa Balogun
2995687d0c
Move edit and delete buttons on chat messages to dropdown menu (#7820)
* Move edit and delete buttons on chat messages to dropdown menu

* Move edit and delete buttons on chat messages to dropdown menu

* Use 'up arrow' as shortcut to edit last message

* Use 'delete key' as shortcut to delete last message

* Change span to button and handle case when lastMessage is undefined

* Fix up code

* Fix code
2020-06-29 14:14:23 +02:00
dependabot-preview[bot]
c22caf265f
Bump eslint from 7.3.0 to 7.3.1 (#8954)
Bumps [eslint](https://github.com/eslint/eslint) from 7.3.0 to 7.3.1.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v7.3.0...v7.3.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-28 16:58:18 -04:00
dependabot-preview[bot]
93756ded4b
Bump intersection-observer from 0.10.0 to 0.11.0 (#8957)
Bumps [intersection-observer](https://github.com/w3c/IntersectionObserver) from 0.10.0 to 0.11.0.
- [Release notes](https://github.com/w3c/IntersectionObserver/releases)
- [Commits](https://github.com/w3c/IntersectionObserver/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-28 16:58:05 -04:00
dependabot-preview[bot]
fcdf25457f
Bump @testing-library/jest-dom from 5.10.1 to 5.11.0 (#8963)
Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) from 5.10.1 to 5.11.0.
- [Release notes](https://github.com/testing-library/jest-dom/releases)
- [Changelog](https://github.com/testing-library/jest-dom/blob/master/CHANGELOG.md)
- [Commits](https://github.com/testing-library/jest-dom/compare/v5.10.1...v5.11.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-28 16:57:34 -04:00
dependabot-preview[bot]
3da9086128
Bump eslint-plugin-import from 2.21.2 to 2.22.0 (#8964)
Bumps [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import) from 2.21.2 to 2.22.0.
- [Release notes](https://github.com/benmosher/eslint-plugin-import/releases)
- [Changelog](https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md)
- [Commits](https://github.com/benmosher/eslint-plugin-import/compare/v2.21.2...v2.22.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-28 16:57:19 -04:00