Commit graph

6272 commits

Author SHA1 Message Date
ludwiczakpawel
313cd61ee3
Listings redesign (#9349)
* flare tag line height

* .

* dropdown fix + actions bar fix

* actions bar on mob

* .

* css commented out

* .

* button fix

* preload adjustments

* tags

* Fixed listings modal to make it semantic HTML via <dialog />.

* Refactor an a11y fix.

* Removed test that is no longer needed.

* Added missing global function for test..

* Fixed broken <ListingFiltersCategories /> tests.

* Refactor of mobile dropdown for listing categories.

* Updated a TODO.

* Made the clear query button a crayons Preact button.

* padding

* Fixed listings modal for accessiblilty.

* Removed rspecs that are no longer valid.

* We're no longer using the <dialog /> element, at least for now, so CSS changes aren't necessary.

* Wasn't supposed to be committed.

Co-authored-by: Nick Taylor <nick@dev.to>
Co-authored-by: rhymes <rhymes@hey.com>
Co-authored-by: Nick Taylor <nick@iamdeveloper.com>
2020-07-30 17:53:35 -04:00
Sarthak Sharma
11820aa29b
[deploy] 🐞Fixes #9503 When joining a new room, user is not taken to the new room (#9564)
* Feature 🚀 : Ability to delete messages in chat channels

- Sending message ID to frontend
- Deleting Message
- Use pusher to delete message realtime

* Minor Bug 🐞: Show message action only for current user

- User can delete or edit their own messages

* Test cases added

* Bug 🐞: Update message id for receiver

Message id was not sent to receiver by pusher

* Refactoring🛠: Message controller refactoring

* Test Cases📝 : Specs for Delete message added

* Feature 🚀 : Ability to edit messages

* Test Cases📝 : Specs for Edit message added

* Merge conflict resolved

* 🐞 Fixes bug #9503 When joining a new room, user is not taken to the new room

Co-authored-by: Narender Singh <narender2031@gmail.com>
2020-07-30 16:21:55 -04:00
Yash Dave
691f0448fc
Update Windows Installation docs to WSL 2 (#9573)
* update wsl installation information

* update postgreSQL installation for windows to wsl2

* update elasticsearch instructions for wsl2

* Update imagemagick installation for wsl2

* implement suggestions
- fix typo
- provide elasticsearch install commands rathen than links
- switch wsl steps to numbered
2020-07-30 15:02:42 -05:00
Michael Kohl
1a6c6acd45
[deploy] Activate Devise::Lockable (#9535) 2020-07-30 10:28:51 -04:00
Michael Kohl
26ee8f194c
Rubocop: Move from OpenStruct to Struct in Organization (#9431)
* Move from OpenStruct to Struct in Organization

* Add data update script

* Introduce Articles::CachedEntity model

* Update data update script for new model

* Fix comment

* Update jbuilder
2020-07-30 21:04:05 +07:00
Molly Struve
6ac637b9ef
[deploy] Boost Scores For Adjacent Words (#9562)
* Feature:Boost Scores For Adjacent Words

* using equal for spec array to ensure order
2020-07-30 15:24:11 +02:00
dependabot-preview[bot]
0bfefe25da
[deploy] [Security] Bump elliptic from 6.5.2 to 6.5.3 (#9568)
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3. **This update includes a security fix.**
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.2...v6.5.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-30 15:21:28 +02:00
Takuma
2650092abb
[deploy] Fix showing unpublished article edit link (#9511)
* Fix showing unpublished article edit link

* Change if clauses to surround only edit link

* Fix: use ArticlePolicy.update? instead of checking article update authority manually
2020-07-30 15:18:30 +02:00
Ben Halpern
f72eba0fe1
[deploy] Attempt to get carrierwave configured correctly for containers and tests passing (#9558)
* Attempt to get tests passing

* Hardcode region

* Move keys

* Add region vars back in

* S3DirectUpload

* Fix asset host

* Carrierwave monkeypatch

* Add condition

* remove require

* Move carrierwave monkeypatch to initializer

* Remove aws secret and key from path that doesn't need it

* Put keys back in

* File storage location ENV var

* Move carrierwave around

* Change to placeholder on jdoss track

* Use config region

* File store path

* Remove AWS keys

* Change logic slightly

* Uncomment production.rb code

* Adjust carrierwave

* Adjust carrierwave
2020-07-29 17:27:13 -04:00
Nick Taylor
3402856fdc
Make <Modal /> component more accessible (#9563)
* Used <dialog /> for modal to stay on the semantic HTML train.

* Added tests and fixed a11y issues with <Modal /> component.
2020-07-29 10:35:42 -04:00
Cornelius A. Ludmann
603a8b4d7a
Prepare Gitpod setup for prebuilds (#9560)
This commit improves the Gitpod setup. It now allows you to benefit from prebuilds.

Also, Gitpod now waits until the server is ready before opening a preview window.
2020-07-29 10:03:05 -04:00
Alberto Pérez de Rada Fiol
115adbb1bd
[deploy] Add index and show pages for series (#9201)
* Add index and show pages for series

* Address code review

* Use `id` instead of `slug` to get collections

* Extract `collection_link` into the application helper

* Only count published articles

* Get rid of the `collection_link_class` method

* Add tests

* Fix test

* Use `**kwargs` instead of `options = {}`
2020-07-29 10:01:52 -04:00
Alberto Pérez de Rada Fiol
8b882dd512
Add workflow automating maintainers' comment on new issues (#9488)
* Add workflow automating maintainers' comment on new issues

* Add steps

* Convert steps to a list
2020-07-29 14:17:47 +02:00
Molly Struve
b40af82b66
Flaky Spec Fix:Remove let_it_be Test Prof Helper (#9556)
* Flaky Spec Fix:Remove let_it_be Test Prof Helper

* Spec cleanup and fixes
2020-07-29 11:31:01 +02:00
rhymes
5a2cae4fbb
Rubocop: enable and fix new Rails cops (#9537)
* Enable new Rails/* cops and use autocorrect on them

* Fixed Rails/PluckInWhere leftovers

* Fix Rails/DefaultScope

* Enable and fix Rails/PluckId

* Fix manual mistake with forcing autocorrection on Rails/PluckId

* Apply PR feedback to remove Rails/PluckId inline disables

* Apply PR feedback to get rid of Rails/PluckInWhere inline
2020-07-29 11:14:19 +02:00
rhymes
bbd56875c7
Rubocop: address feedback of #9430 and use kwargs (#9538)
* Use fetch.to_i

* Rubocop: address feedback of #9430 and use kwargs
2020-07-29 11:13:36 +02:00
Molly Struve
7460893159
[deploy] Optimization:Change Comment, Ad Events, and Github ID Code Ints to Bigints (#9543) 2020-07-28 14:35:03 -05:00
Molly Struve
e2e034b910
[deploy] Refactor:Remove No Longer Needed Timber Logging (#9555) 2020-07-28 14:00:38 -05:00
Andy Zhao
a589529269
[deploy] Allow org admins to delete their organizations (#9357)
* Add destroy organization backend

* Add view for deleting org

* Add new line to end of file

* Refactor and move destroyable? to model

* Use a nice card to distinguish the message

* Prevent organizations from being deleted if they have credits

* Fix codeclimate issues

* Remove let_it_be_changeable for flakiness
2020-07-28 12:00:15 -04:00
Yash Dave
c9ff792497
fix actions/checkout to v2 for rebase workflow (#9515) 2020-07-28 10:34:35 -05:00
Ben Halpern
8d1a9e7a1c
Show article year if article published last year (#9547)
* Show article year if article published last year

* Fix tests
2020-07-28 10:32:20 -04:00
Nick Taylor
11cd1cb0fc
Upgraded to css-loader 4.0.0 (#9548) 2020-07-28 09:45:13 -04:00
Mac Siri
e330298561
[deploy] Update instantClick's script clone logic (#9542) 2020-07-28 09:06:58 -04:00
Molly Struve
34458d5de9
[deploy] Bug Fix:Run Hypershield Refresh AFTER db:prepare (#9546) 2020-07-27 17:30:02 -05:00
Sophia
f9137b2abd
[deploy] Update <ImageUploader /> class component to use hooks (#9369) 2020-07-27 17:09:28 -04:00
Fernando Valverde
5d55299ac3
[deploy] Removes intrusive mobile video autoplay & adds ahoy for visibility (#9539)
* Removes intrusive mobile video autoplay & adds ahoy for visibility

* web video has autoplay enabled

* Implements feedback on video player ahoy events

* use strict equality
2020-07-27 13:11:40 -06:00
Emma Goto
d98f143146
[deploy] Make UX settings save button sticky when modified (#9478)
* Add sticky footer to UX settings page  when changes are made

* Add missing spaces to html object
2020-07-27 12:52:21 -04:00
Ben Halpern
bffa204310
[MERGE AFTER INVITATION PR] Add registered_at data script (#9331)
* Add registered_at data script

* Update lib/data_update_scripts/20200715140848_backfill_user_registered_at.rb
2020-07-27 12:28:06 -04:00
Molly Struve
386c3e9fa7
[deploy] Optimization/Bug Fix:Only Send Mentioned User Notifications, not all for every message (#9493) 2020-07-27 11:16:41 -05:00
Molly Struve
97882ce31c
[deploy] Optimization:Change Tag Related IDs to Bigints (#9533) 2020-07-27 10:51:56 -05:00
Michael Kohl
57359091a9
Replace dry-struct with ActiveModel (#9534) 2020-07-27 17:42:37 +02:00
dependabot-preview[bot]
0c8af6bd1e
Bump clipboard-polyfill from 2.8.6 to 3.0.0 (#9524)
Bumps [clipboard-polyfill](https://github.com/lgarron/clipboard-polyfill) from 2.8.6 to 3.0.0.
- [Release notes](https://github.com/lgarron/clipboard-polyfill/releases)
- [Commits](https://github.com/lgarron/clipboard-polyfill/compare/v2.8.6...v3.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-27 10:58:16 -04:00
Bogdan Covrig
90d53173f5
Change DEV doc to Forem doc on account page (#9507)
* Change DEV doc to Forem doc on account page

* Change Forem API to <community> API for clarification reasons

Make the copy more clear – there is no central Forem API, more like each instance of Forem is having its own API.

Co-authored-by: Molly Struve <mollylbs@gmail.com>

Co-authored-by: Molly Struve <mollylbs@gmail.com>
2020-07-27 10:14:27 -04:00
dependabot-preview[bot]
fac0f330c8
Bump redoc-cli from 0.9.8 to 0.9.9 (#9522)
Bumps [redoc-cli](https://github.com/Redocly/redoc) from 0.9.8 to 0.9.9.
- [Release notes](https://github.com/Redocly/redoc/releases)
- [Changelog](https://github.com/Redocly/redoc/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Redocly/redoc/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-27 10:13:06 -04:00
Ben Halpern
dba75110bb
Change copy away from dev.to (#9494) 2020-07-27 10:02:06 -04:00
Michael Kohl
f0c4197aab
Update seeds.rb with password confirmation (#9536) 2020-07-27 15:47:42 +02:00
Ben Halpern
aab0685b93
Add sign in options button to modal (#9506) 2020-07-27 09:28:41 -04:00
Ben Halpern
cbcd59edb3
Add more sign in options button to home sidebar (#9496) 2020-07-27 15:14:44 +02:00
dependabot-preview[bot]
3e6e7a4d1e
Bump strong_migrations from 0.6.8 to 0.7.0 (#9525)
* Bump strong_migrations from 0.6.8 to 0.7.0

Bumps [strong_migrations](https://github.com/ankane/strong_migrations) from 0.6.8 to 0.7.0.
- [Release notes](https://github.com/ankane/strong_migrations/releases)
- [Changelog](https://github.com/ankane/strong_migrations/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ankane/strong_migrations/compare/v0.6.8...v0.7.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump strong_migrations from 0.6.8 to 0.7.0 (Update vendor/cache)

* Enable safety check on rollbacks as well

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: rhymes <rhymes@hey.com>
2020-07-27 11:10:18 +02:00
dependabot-preview[bot]
f6d091213e
Bump rubocop-performance from 1.7.0 to 1.7.1 (#9380)
* Bump rubocop-performance from 1.7.0 to 1.7.1

Bumps [rubocop-performance](https://github.com/rubocop-hq/rubocop-performance) from 1.7.0 to 1.7.1.
- [Release notes](https://github.com/rubocop-hq/rubocop-performance/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-performance/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-performance/compare/v1.7.0...v1.7.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump rubocop-performance from 1.7.0 to 1.7.1 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-27 10:03:11 +02:00
Michael Kohl
a80d3f9082
[deploy] Move from OpenStruct to Struct (#9429) 2020-07-27 14:31:48 +07:00
Christina
c493ad1d2a
Change link in Contributing Docs (#9530)
Replacing https://docs.dev.to/contributing/forem/ new forem docs link per issue #9505.
2020-07-27 10:06:59 +07:00
Christina
112d7bb48f
Update README.md (#9531)
Replacing links to https://docs.dev.to in the Getting Started section with links to the newer https://docs.forem.com/ instead
2020-07-27 09:59:54 +07:00
dependabot-preview[bot]
160035fa2d
[deploy] Bump rubocop-rails from 2.6.0 to 2.7.1 (#9526)
* Bump rubocop-rails from 2.6.0 to 2.7.1

Bumps [rubocop-rails](https://github.com/rubocop-hq/rubocop-rails) from 2.6.0 to 2.7.1.
- [Release notes](https://github.com/rubocop-hq/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-rails/compare/v2.6.0...v2.7.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump rubocop-rails from 2.6.0 to 2.7.1 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-26 17:54:04 -05:00
dependabot-preview[bot]
4102a09777
Bump oj from 3.10.7 to 3.10.8 (#9523)
* Bump oj from 3.10.7 to 3.10.8

Bumps [oj](https://github.com/ohler55/oj) from 3.10.7 to 3.10.8.
- [Release notes](https://github.com/ohler55/oj/releases)
- [Changelog](https://github.com/ohler55/oj/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ohler55/oj/compare/v3.10.7...v3.10.8)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump oj from 3.10.7 to 3.10.8 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-26 17:53:10 -05:00
Molly Struve
f84f88f9bf
Flaky Spec Fix:Remove let_it_be usage from Comment Model Spec (#9529) 2020-07-26 17:22:51 -05:00
Molly Struve
4f20555221
[deploy] Optimization:Change Multiple Small Table Column IDs to Bigints (#9513) 2020-07-26 16:16:13 -05:00
dependabot-preview[bot]
9f48982f6e
Bump bootsnap from 1.4.6 to 1.4.7 (#9520)
* Bump bootsnap from 1.4.6 to 1.4.7

Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.4.6 to 1.4.7.
- [Release notes](https://github.com/Shopify/bootsnap/releases)
- [Changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Shopify/bootsnap/compare/v1.4.6...v1.4.7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump bootsnap from 1.4.6 to 1.4.7 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-26 21:51:12 +02:00
dependabot-preview[bot]
4b4749c29a
Bump ddtrace from 0.37.0 to 0.38.0 (#9521)
* Bump ddtrace from 0.37.0 to 0.38.0

Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb) from 0.37.0 to 0.38.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases)
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md)
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v0.37.0...v0.38.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump ddtrace from 0.37.0 to 0.38.0 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-26 21:50:59 +02:00
dependabot-preview[bot]
d54ca3f7ee
Bump twilio-ruby from 5.39.1 to 5.39.2 (#9516)
* Bump twilio-ruby from 5.39.1 to 5.39.2

Bumps [twilio-ruby](https://github.com/twilio/twilio-ruby) from 5.39.1 to 5.39.2.
- [Release notes](https://github.com/twilio/twilio-ruby/releases)
- [Changelog](https://github.com/twilio/twilio-ruby/blob/master/CHANGES.md)
- [Commits](https://github.com/twilio/twilio-ruby/compare/5.39.1...5.39.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump twilio-ruby from 5.39.1 to 5.39.2 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-26 21:50:37 +02:00