Ben Halpern
2fe2c6c6bb
Patch: Fix too-long code in comment previews via appropriate truncation ( #19540 )
...
* Fix too-long code in comment previews
* Update app/javascript/articles/components/CommentListItem.jsx
---------
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2023-05-30 10:02:09 -04:00
depfu[bot]
56414481ba
[ruby] Update metainspector 5.14.0 → 5.15.0 (minor) ( #19524 )
...
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-05-26 16:39:07 -04:00
depfu[bot]
94e394edc2
[ruby] Update fog-aws 3.18.0 → 3.19.0 (minor) ( #19537 )
...
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Mac Siri <mac@forem.com>
2023-05-26 15:55:45 -04:00
Mai Irie
282afaa6a2
Update PR template to include a11y checklist ( #19538 )
2023-05-26 12:37:48 -04:00
Mac Siri
67a65e0aa5
Temp disable flaky spec ( #19547 )
2023-05-26 11:56:28 -04:00
Ben Halpern
ca7c395bd9
Remove unique constraint from segmented users index ( #19544 )
2023-05-26 11:18:08 -04:00
PJ
453c2eeccb
Manual Audience Segments API read endpoints ( #19542 )
...
* getting and listing segments
* get list of users in segment
* docs???
2023-05-26 15:10:26 +01:00
Rajat Talesra
bbb9fd2e1e
Add more visibility to admins (part-2) ( #19375 )
...
* Basic thumbsup, thumbsdown and vomit
* Refined UI of flags and vomits
* If check
* Optimised code and added a method in article.rb
* Removed public keyword
* Nit fixes
* Section for flags and quality details
* Basic vomit item
* Quality item UI
* Separated code into partials
* UI changes and empty state added
* With correct implementation
* Fixed showing reaction items in all cases
* Dropdown visible
* Enabled click listerners and call functions for dropdown-button clicks
* Empty state UI fixed
* Tabs and divider UI
* Mark as valid/invalid conditions
* Nit fixes
* Logical fixes
* Added comments
* Partial item status update fix
* Reload page feature fixed
* Removed snackbar
* I18n strings
* Bug fix
* I18n strings
* Nit fixes
* Added date
* Added view details button
* Added view details test
* Sample test
* Test fixes
* Added tests for new article
* Flagged item tests added
* Added more tests
* Nit fix
* Suggested design changes
* Nit design fixes
* Tests with cy.intercept
* Nit fixes
* Nit fixes
* Hero Billboard Placement (#19467 )
* init
* add option to swagger docs
* in_house validation
* filtered ad quesry changes
* styling and prioritizing home hero banner over campaign banner
* rubocop
* typo
* broken spec
* more spec fixes
* found the spec break culprit
* derp
* Update app/views/shared/_display_ad.html.erb
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
* Update app/controllers/stories_controller.rb
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
* remove immediate return
* styling feedback and moving banner to articles index
* remove nil
* updated styling
* add signed in bool
* add feature flag
* remove feature flag data scripts
---------
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
* Fix typo / erroneous word in Admin Section (#19488 )
* Typo fixes
* Update admin_menu.rb
* Minor background and shadow change (#19501 )
* Refresh audience segment for 'active' user (#19470 )
* Refresh an individual user's segmentation
* Refresh segment if creating a published article
* Quick refactor
* Refresh segment if update publishing
* Quick refactor
* Refresh segment if update user settings
* Refresh segments after user update + role change
* Using latest_article_updated_at
* Sidekiq uses JSON for arguments, needs basic types
* Fix test issues with last_updated_at and sidekiq params
* Tests update continues
* Consolidate dependencies
* Method names acknowledging manual exclusive
* Fix test name copypasta
* Rubocop
* Try to clarify Creator#series
* Try to avoid naming predicate
* Remove erroneously included helper
* Improve onboarding “suggested tags” page design (#19475 )
* Onboarding tags
* Logical design issue fixes
* Posts count added
* Checkbox design fixes
* Optimised css
* Nit fixes
* Test case added
* Reduced data
* Nit fix
* Added more tests
* Nit fix
* Tests updatedt
* Update @honeybadger-io/js to version 5.4.1 (#19479 )
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
* Update sidekiq-cron to version 1.10.1 (#19473 )
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
* Update nokogiri to version 1.15.0 (#19495 )
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
* use tabindex instead of disabled to get proper keyboard nav on /onboarding tags (#19513 )
* Add billboard to safe param list in Fastly vcl (#19515 )
* Removed static article id from setup
* All tests passing
* Nit fixes
* Nit fixes
* Fixed tests with Joshua's help
* Added trusted user related tests
* Fixed few tests
* Added intercept and wait
* Removed tab and enter key
* Updated comment
* Updated tests
---------
Co-authored-by: Lawrence <lawrence@forem.com>
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
Co-authored-by: Peter Frank <peter.kim.frank@gmail.com>
Co-authored-by: Joshua Wehner <joshua@forem.com>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2023-05-26 19:15:12 +05:30
Mac Siri
a6a3417e5e
[CI] Move code-coverage upload into isolated process ( #19532 )
2023-05-26 09:09:39 -04:00
PJ
795cfc3da0
Manual Audience Segments API write endpoints ( #19476 )
...
* add composite index to segmented_users table
* bulk queries for segmented users
* create segment endpoint
* adding and removing users
* deleting segments 😪
* fix time precision in specs
* api docs 🎉
* pluck improvements that couldn't be cherry-picked
* better service objects; also introduce batch upserting
* docs???
2023-05-25 20:37:18 +01:00
Joshua Wehner
862cd54dc7
Refactoring onboarding ( #19525 )
...
* Quick refactor onboardings controller(s)
* Quick refactor onboardings controller(s), pt2
* Quick refactor onboardings controller(s), pt3
* Quick refactor onboardings controller(s), pt4
* Quick refactor onboardings controller(s), pt5
* Add test for checkboxes
2023-05-25 10:03:12 +02:00
anes
772f6cdd7b
Fix the org post count issue ( #19503 )
...
* Fix the org post count issue
* Add regression specs
* Move things around and sort them better
* Implement PR review
* Revert accidental changes
---------
Co-authored-by: Mac Siri <mac@forem.com>
2023-05-24 16:58:39 -04:00
Ben Halpern
e72160284c
Fix styling for long org promoted billboard ( #19528 )
2023-05-24 21:41:32 +05:30
Mac Siri
a5842bd779
Revert Uffizzi refactors ( #19526 )
2023-05-24 10:55:27 -04:00
Rajat Talesra
5829518f13
Fixed display ad index on home page ( #19506 )
2023-05-23 18:10:31 -04:00
Mac Siri
670dae96d5
Update experience_level's validation ( #19487 )
2023-05-23 14:10:32 -04:00
Joshua Wehner
6b80d99c1b
Update onboarding suggested tag logic ( #19477 )
...
* Onboarding suggested tags should include supported
* Migrate tags to add suggested boolean column
* Use new suggested attribute
* Sync Settings.suggested_tags with new form setting
* Better sort order
* Test logic update
* Add a little comment
2023-05-23 17:22:27 +02:00
Duke Greene
1798a1f845
notify mod on new user articles ( #19478 )
...
* update moderation notification view and message for articles
* update models to allow first published articles to notify mod after create
* update mod notifications worker and spec to support articles
* update mod notification send service and spec to support articles
* update helper and request spec to support article mod notifications
* update spec language to match updated notification message
* Update spec/workers/notifications/create_round_robin_moderation_notifications_worker_spec.rb
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
* Update spec/workers/notifications/create_round_robin_moderation_notifications_worker_spec.rb
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
* Update spec/workers/notifications/create_round_robin_moderation_notifications_worker_spec.rb
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
* Update spec/workers/notifications/create_round_robin_moderation_notifications_worker_spec.rb
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
* fix comment and refactor order of send_moderation_notification steps
* add fr.yml article mod notification config
* fix spacing around equal sign per rubocop
* fix spacing around equal sign per rubocop
* Update spec/workers/notifications/create_round_robin_moderation_notifications_worker_spec.rb
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
---------
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2023-05-23 10:51:46 -04:00
Joshua Wehner
50a286fe75
Change order of organizations on /admin ( #19499 )
...
* Change order of organizations on /admin
* Rubocop
2023-05-23 10:41:18 +02:00
Ben Halpern
56c914cc8a
Add billboard to safe param list in Fastly vcl ( #19515 )
2023-05-22 12:04:10 -04:00
Ben Halpern
45a44a797f
use tabindex instead of disabled to get proper keyboard nav on /onboarding tags ( #19513 )
2023-05-22 17:27:19 +05:30
depfu[bot]
3cced30628
Update nokogiri to version 1.15.0 ( #19495 )
...
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-05-22 11:45:37 +02:00
depfu[bot]
10e8e34af0
Update sidekiq-cron to version 1.10.1 ( #19473 )
...
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-05-22 11:44:26 +02:00
depfu[bot]
b518ca76b4
Update @honeybadger-io/js to version 5.4.1 ( #19479 )
...
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-05-22 11:42:04 +02:00
Rajat Talesra
a441358f01
Improve onboarding “suggested tags” page design ( #19475 )
...
* Onboarding tags
* Logical design issue fixes
* Posts count added
* Checkbox design fixes
* Optimised css
* Nit fixes
* Test case added
* Reduced data
* Nit fix
* Added more tests
* Nit fix
* Tests updatedt
2023-05-19 23:46:24 +05:30
Joshua Wehner
375cbfe946
Refresh audience segment for 'active' user ( #19470 )
...
* Refresh an individual user's segmentation
* Refresh segment if creating a published article
* Quick refactor
* Refresh segment if update publishing
* Quick refactor
* Refresh segment if update user settings
* Refresh segments after user update + role change
* Using latest_article_updated_at
* Sidekiq uses JSON for arguments, needs basic types
* Fix test issues with last_updated_at and sidekiq params
* Tests update continues
* Consolidate dependencies
* Method names acknowledging manual exclusive
* Fix test name copypasta
* Rubocop
* Try to clarify Creator#series
* Try to avoid naming predicate
* Remove erroneously included helper
2023-05-19 14:16:07 +02:00
Rajat Talesra
fdd49c0781
Minor background and shadow change ( #19501 )
2023-05-19 17:08:02 +05:30
Peter Frank
e69c642bf0
Fix typo / erroneous word in Admin Section ( #19488 )
...
* Typo fixes
* Update admin_menu.rb
2023-05-19 11:04:35 +02:00
Lawrence
1b32e9a8e3
Hero Billboard Placement ( #19467 )
...
* init
* add option to swagger docs
* in_house validation
* filtered ad quesry changes
* styling and prioritizing home hero banner over campaign banner
* rubocop
* typo
* broken spec
* more spec fixes
* found the spec break culprit
* derp
* Update app/views/shared/_display_ad.html.erb
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
* Update app/controllers/stories_controller.rb
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
* remove immediate return
* styling feedback and moving banner to articles index
* remove nil
* updated styling
* add signed in bool
* add feature flag
* remove feature flag data scripts
---------
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2023-05-18 12:37:32 -05:00
Ben Halpern
8b24e4c255
Quick fix: Remove double title from mod center item ✂️ ( #19482 )
...
* Remove double title from mod center item
* Minor css tweak
2023-05-18 11:22:57 -04:00
Mac Siri
a475fb9169
Update seed file ( #19480 )
2023-05-18 07:53:48 -04:00
Joshua Wehner
94ba297c43
Fix mangled github image embed ( #19455 )
2023-05-17 17:09:47 -04:00
Ben Halpern
27d6fbb285
Send user agent in open graph fetch so we don't block our own requests ( #19462 )
...
* Send user agent in open graph fetch
* Update app/services/open_graph.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Change user agent and test
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2023-05-17 15:49:35 -04:00
Mac Siri
f85db74b92
[CI] Refactor Uffizzi-build.yml ( #19463 )
...
* Simplify Uffizzi setup & use cached assets
* Remove cache assets usage
* Don't feature too many articles in seed
* Update db/seeds.rb
2023-05-16 09:41:52 -07:00
Mac Siri
8c8bc8c9bf
[CI] Remove seed container from Uffizzi ( #19468 )
2023-05-16 09:48:56 -04:00
Joshua Wehner
00a9db232b
Remove manual user follow suggestions ( #19457 )
...
* Remove manually user follow suggestions
* I honestly don't understand what this is doing here
* Remove suggested_users from config spec
2023-05-16 15:01:03 +02:00
dinozavrix
e9ce70d368
Don't skip indexing for old articles ( #19231 )
...
* Don't skip indexing for old articles
* add index_minimum_date to settings
---------
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2023-05-15 15:35:35 +02:00
Ben Halpern
0e6ac62737
Do not suggest user who is currently suspended ( #19466 )
2023-05-15 17:16:57 +05:30
Ben Halpern
f853b95ccd
Add feed experiment for 5/11 ( #19458 )
...
* Add feed experiment for 5/11
* Change number of articles
2023-05-12 12:17:25 -04:00
Ben Halpern
177e973259
Do not show link to welcome thread if it doesn't exist ( #19460 )
2023-05-12 21:25:43 +05:30
Ridhwana
d92e9d1af4
CTA Embed ( #19440 )
...
* feat: first pass at CTA Tag
* fix: strip_tags before using the link
* default hover
* feat: add the type of cta
* feat: add own ltag by copying the utility class
* feat: rename property to style
* feat: add style and width
* feat: add xit test
* feat: add spec for unordered options
* chore: some css
* feat: update the cta spec to remove style and width options
* feat: move billboard related code out of widgets
* fix: mobile display ad below the comments section
* feat: cta_tag strip tags input
* feat: update the editor docs
* feat: add help text to teh liquid guide and the editor guide
* feat: fix the css styles of the CTA
* cgore: alphabetical order
* chore: move everything on one line
---------
Co-authored-by: Mac Siri <mac@forem.com>
2023-05-12 14:30:30 +02:00
Mac Siri
a1ca675e6f
Add DisplayAd to seeds ( #19453 )
2023-05-11 15:33:10 -04:00
Peter Frank
b09b0207c6
Peter/update trusted emails ( #19454 )
...
* Update trusted_role_email.html.erb
* Update trusted_role_email.text.erb
2023-05-11 08:25:41 -04:00
Mac Siri
b4a4b30153
Add Staging specific seed file ( #19434 )
2023-05-10 16:10:19 -04:00
Ben Halpern
4c28a607ec
Change copy in ai-plugin ( #19451 )
2023-05-10 11:59:18 -03:00
PJ
5933f294e9
Follow all suggested users by default when onboarding ( #19435 )
2023-05-09 17:04:10 +01:00
Ben Halpern
d8ac9e27fb
Fix profile_image bug in org search ( #19444 )
2023-05-09 17:54:22 +02:00
Joshua Wehner
3097781882
Try to catch unhandled exception ( #19360 )
2023-05-09 11:10:29 -04:00
Ben Halpern
4d7fcb7359
Quick fix to pagination in /stories/feed ( #19423 )
...
* Quick fix to pagination in /stories/feed
* Fix whitespace
* Update app/services/articles/feeds/variant_query.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mac Siri <mac@forem.com>
2023-05-09 09:52:03 -03:00
depfu[bot]
89290b1bbb
Update recaptcha to version 5.14.0 ( #19442 )
...
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-05-09 14:23:07 +05:30
