maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
1398 commits 1 branch 0 tags 1.6 GiB
Commit graph

137 commits

Author SHA1 Message Date
Mac Siri
2b779d15c6 Fix inconsistent specs (#1674) 
* Force test colors in Travis

* Fix inconsistent analytic spec

* Fix local inconsistent specs

* Remove JS

*  Remove JS from spec
 2019-01-30 11:50:42 -05:00
Andy Zhao
f5f206e40e Render codespans properly in markdown (#1678) 
* Explain test properly

* Add tests for codespan parsing

* Add codespan parsing logic
 2019-01-29 11:52:18 -05:00
Juan Manuel Ramallo
49c9b5bc87 [Emojis in Markdown] (#1653) 
- Adds the ability to add emojis using colons 😂 🎉
- The emoji conversion is added to the markdown parser labor
- When no emoji is found with the alias, same text is returned
- No assets added (no emoji images), so this will only be supported when the browser supports emojis (https://blog.getemoji.com/post/57054354336/which-browsers-support-emoji)
- Emoji conversion logic is out of markdown parser labor
- Adds its own spec
 2019-01-28 16:28:59 -05:00
Ben Halpern
1cdbfe3af1
Remove hardcoded values in streak reward (#1671) 2019-01-28 14:14:45 -05:00
Ben Halpern
561882d9d5
Add writing streak badge rewarding algorithm (#1670) 
* Add 4 week streak badge rewarding algorithm

* Modify badge message

* Fix typo
 2019-01-28 13:46:00 -05:00
Vinicius Stock
ec2ce5d6e6 Upgrade rubocop and fix offenses (#1635) 2019-01-23 16:12:03 -05:00
Ben Halpern
ff405c0e90
Add occasional random fetches to article page_views_count (#1625) 2019-01-22 14:39:34 -05:00
Ben Halpern
865a1a6fdf
Remove article collection area caching (#1597) 2019-01-20 17:13:12 -05:00
Ben Halpern
6e4259baaf
Cache collection so it doesn't have to be re-fetched (#1576) 
* Cache collection so it doesn't have to be re-fetched

* Update app/views/articles/show.html.erb

Co-Authored-By: benhalpern <bendhalpern@gmail.com>

* Update app/views/articles/show.html.erb

Co-Authored-By: benhalpern <bendhalpern@gmail.com>

* Update app/views/articles/show.html.erb

Co-Authored-By: benhalpern <bendhalpern@gmail.com>
 2019-01-20 15:50:57 -05:00
Jess Lee
38091ba486 Update twitter validation and internal/articles query (#1571) 
* update validation and only show published articles

* update twitter satellite count

Co-Authored-By: jessleenyc <jessleenyc@gmail.com>
 2019-01-16 17:15:22 -05:00
rhymes
dee7429883 Replace each with find_each for AR queries (#1557) 2019-01-15 16:38:03 -05:00
Mac Siri
f780e5fbc9 Refactor RssReader (#1537) 
* Update RssReader::get_all_articles

* Move RssReader to services

* Create RssReader::Assembler

* Improve RssReader's spec
 2019-01-14 14:25:49 -05:00
Mario See
8bb1716935 connect chat message markdown styling (#1487) 
* remove inline markdown rule

* broaden evaluate_inline_markdown

basically same as evaluate_markdown but without class attributes

* remove inline markdown parser

* change code block color and background

* even out code padding top/bottom
 2019-01-08 17:48:12 -05:00
rhymes
dbf5fc63ad Fix Rubocop Security/Open (#1447) 
* Re-run rubocop autogen config

* Fix Layout/* violations

* Fix Security/Open and use HEAD if GET is not needed
 2019-01-02 16:35:19 -05:00
rhymes
6553f08d94 Rubocop cleanups (#1415) 
* Update rubocop-todo.yml with new violations

* Fix Layout/EmptyLine* rules

* Fix Layout/Indentation* rules

* Fix remaining Layout/* rules

* Fix Lint/DuplicateMethods by removing unused accessor

* Fix Lint/IneffectiveAccessModifier

* Fix Lint/MissingCopEnableDirective

* Re-run rubocop auto gen config

* Fix Layout/RescueEnsureAlignment

* Fix Naming/* rules

* Fix some RSpec/* rules

* Fix typos

* Fix RSpec/LetBeforeExamples

* Series should only be an attr_writer, not an attr_accessor

* Fix RSpec/InstanceVariable

* Fix RSpec/InstanceVariable

* Fix RSpec/RepeatedDescription and RSpec/RepeatedExample

* Fix Style/ClassAndModuleChildren

* Fix Style/ConditionalAssignment

* Fix some Style/* rules

* Trigger Travis CI build because failing tests are not failing locally

* Revert "Fix Style/ClassAndModuleChildren"

This reverts commit 1686801d8a1516ba1894f79e24401a20dea65f99.
 2019-01-02 11:20:02 -05:00
Arun Kumar
0f8c08629b Remove superfluous condition (#1441) 2019-01-01 17:05:18 -05:00
Arun Kumar
c859651081 Refactor !empty? calls with any? (#1442) 2019-01-01 17:04:52 -05:00
Ben Halpern
2bb48d27c4
Add two-year-club auto-rewarder (#1383) 2018-12-20 16:53:22 -05:00
Jess Lee
1586d9fd7d Include conditional for adding tag mods to connect channel (#1366) 
* fix slug typo

* fix specs

* use blank? instead of nil?
 2018-12-19 15:44:36 -05:00
Jess Lee
7ca3d5c542
Fix tag channel query 2018-12-19 13:47:16 -05:00
Jess Lee
d8ff236f69 Fix slug typo (#1364) 2018-12-19 13:39:50 -05:00
Jess Lee
1d2a6def4a Add tag moderation info page (#1360) 
* clarifies tag edit form and updates photo

* add better image

* add tag moderation route and page info

* adds labor module for assigning bulk tag moderators

* Apply Peter's changes from code review

Co-Authored-By: jessleenyc <jessleenyc@gmail.com>

* fix typo

Co-Authored-By: jessleenyc <jessleenyc@gmail.com>

* replace with cloudinary image links

* add specs
 2018-12-19 09:27:55 -05:00
rhymes
96d01b20a2 Use allow/allowed instead of whitelist (#1296) 
* Use allow/allowed instead of whitelist

* Remove duplication in comment
 2018-12-10 13:16:16 -05:00
Jibran Kalia
f569f33e4f [WIP] Really simple calculate reading time function (#1283) 
* Really simple calculate reading time function

* Move parse_it so that the number of methods in MarkdownParser is at 20

* Added test and default value for reading time
 2018-12-09 13:42:32 -05:00
Christine Yen
cff6b5d589 Add Honeycomb gem and initial instrumentation (#695) 
* Add basic Honeycomb initializers

* Add some basic instrumentation, capture basic IDs

* Correctly alphabetize Gemfile, embed env in dataset names

* Actually reorder Gemfile because I can read

* Add custom tracing instrumentation to RssReader

* Improve timing/tracing info in RssReader

* Even make sure Errors show up in trace if possible

* Make sure we capture this as Rails traffic

* Swap in dev/test Libhoney::Clients as appropriate

* Move context-snagging bits into lib/instrumentation.rb

* Merging Gemfile lines seems to be my Achilles heel
 2018-11-28 10:08:27 -05:00
Ben Halpern
115e52c748
Move follow and reaction aggregation into Notification model to avoid… (#1164) 
* Move follow and reaction aggregation into Notification model to avoid re-compute

* Ugh. Fixing schema

* Update tests

* Skip some tests in notifications_spec
 2018-11-20 15:00:21 -05:00
Andy Zhao
044de6a8b5 Make reads controller async and sanitize notification titles (#1158) 2018-11-19 19:33:00 -05:00
Andy Zhao
a1010201f2 Notifications part 2 (#1156) 
* Remove stream and add new notification views

* Actually remove Stream

* Move followers query to async method

* Remove unused tests and fix query

* Try using without delay instead

* Add without delay and escape HTML

* Make all tests pending for now
 2018-11-19 18:14:24 -05:00
Ben Halpern
61173bede1
Finalize new analytics style (#1117) 2018-11-14 10:50:05 -05:00
Ben Halpern
c5807205b5
Adjust dashboard analytics to be more reliable (#1115) 
* Update analytics

* Remove analytics file

* Remove unused files

* Add delete button back in on dashboard
 2018-11-13 20:37:29 -05:00
Ben Halpern
119b86c655
Fix action bar issue and adjust cache_buster (#1082) 2018-11-07 18:55:07 -05:00
Jess Lee
295b30ce3e Add Fab Five BadgeRewarder + Rake Task (#1048) 
* adds method and rake task

* Improve BadgeRewarder spac
 2018-11-05 11:46:08 -05:00
juniordevlearning
565d63e0ac Fix cognitive complexity lint (#1032) [ci skip] 2018-10-30 14:20:15 -04:00
Frédéric Planté
4a50c418c6 Automatically add contributor badges (#1016) 
* Basic proof of concept

* Use Octokit instead of HTTParty

* add rake task

* DEV Community iOS App should be checked too

* This only need to be computed once

* Add spec

* for consistency sake
 2018-10-29 20:21:37 -04:00
Mac Siri
5287d4a03b Create DelayedJob config and misc DX changes (#979) 
* Change from #after_save to #after_create

* Update .babelrc

* Update cloud_name for test

* Update SlackBot's RssReader channel

* Update helpful-hints.md

* Create .gitdocs.json

* Remove serve-docs script

* Update docs/helpful-hints.md

* Update approval

* Revert "Change from #after_save to #after_create"

This reverts commit 548ee0d2c0d56a1aa67316468f4106ac9f437662.

* Create delayed_job.rb

* Bump ancestry gem to 3.0.3

* Fix broken spec

* Remove manual Delayed::Job config in test

* Update spec_helper.rb

* Fix broken specs

* Mute SlackBot in test

* Remove weekly-dgiest.yml

* Create PodcastEpisodeDecorator
 2018-10-26 13:15:14 -04:00
Ben Halpern
ae3ec2e237
Add/fix org call-to-action box/copy (#1000) 2018-10-24 13:49:57 -04:00
rhymes
1b60ee5009 Use timezone aware methods (#893) 
* Use timezone aware datetime methods

* Use timezone aware date parse for GitHub issue tag

* Introduce a bit of chaos programming using Zonebie

Zonebie uses a random timezone to run tests, it's a really good way to see if the code is timezone dependent or not.

* Convert GitHub issue date as UTC
 2018-10-18 16:26:29 -04:00
Jess Lee
7bf9a8ce89 Delayed Jobs Investigation (#929) 
* disallow nil reactables to be saved

* investigation wip

* passes deleted comment info to async bust cache

* fixes failing cache buster spec

* Create user_delete_a_comment_spec.rb

* Fix broken spec

* Binstub RuboCop

* Do not save comments when they are getting destroyed

* break update_reactable into smaller methods
 2018-10-17 17:03:20 -04:00
Ben Halpern
305492c2c8
Add similarity score for users (#942) 2018-10-17 11:53:28 -04:00
Andy Zhao
0dab93bdad Allow Giphy links to be used and not from Cloudinary (#927) 
* Test for giphy images

* Allow giphy images to be used as-is
 2018-10-15 17:35:09 -04:00
Ben Halpern
8b12c1fb04
Fix logic in StickyArticleCollection (#906) 2018-10-14 12:37:49 -04:00
Ben Halpern
221c363af0
Reduce queries in typical stories#show response + small fixes (#903) 
* Reduce queries in typical stories#show response + small fixes

* Change const to git in non-es6 code
 2018-10-13 19:38:38 -04:00
Andy Zhao
eaf98d738a Unsubscribe users from newsletters before destroying (#878) 
* Unsubscribe users from newsletters before destroying

* Fix email messages not loading on show page

* Add mock for update method
 2018-10-10 15:22:20 -04:00
Benny Powers
7b52c21ef1 Fixes markdown nested lists by stripping all linebreaks (#815) 
* Fixes markdown nested lists by stripping all linebreaks

* tixes fypo
 2018-10-05 15:11:12 -04:00
Benny Powers
5f40607249 Add aside and abbr tags to markdown whitelist (#818) 2018-10-04 12:34:29 -04:00
Maksim Litvinov
33db32e5f4 Fix rubocop lints (#794) 2018-10-03 13:00:09 -04:00
Ben Halpern
2517bb555b
Add functionality for buffering to different accounts (#752) 
* Create initial buffer updates logic

* Add UI functionality and test for sattelite tweets

* Add additional /mod functionality and re-use script partial in /internal
 2018-09-26 15:51:39 -04:00
Ben Halpern
e80bf919fc
Add top param to article tag api (#741) 2018-09-25 15:13:49 -04:00
Ben Halpern
91f99036df
Update feed for slightly more customized top articles (#642) 
* Update home feed logic and display

* Remove console log
 2018-09-12 15:27:54 -04:00
Jess Lee
191588b34b Adds method to create bulk mentorship matches (#631) 
* add mentorship module

* update spec file name for consistency
 2018-09-11 16:46:01 -04:00