maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Refactor !empty? calls with any? (#1442)

Browse source
This commit is contained in:
Arun Kumar 2019-01-01 17:04:52 -05:00 • committed by Ben Halpern
parent a4fccb2f5b
commit c859651081
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
app/labor/user_states.rb
View file

@ -19,11 +19,11 @@ class UserStates
end
def made_first_article
!user.articles.where(published: true).empty?
user.articles.where(published: true).any?
end
def follows_a_tag
!user.follows.where(followable_type: "ActsAsTaggableOn::Tag").empty?
user.follows.where(followable_type: "ActsAsTaggableOn::Tag").any?
end
def fill_out_your_profile
@ -31,14 +31,14 @@ class UserStates
end
def leave_reactions
!user.reactions.empty?
user.reactions.any?
end
def follow_people
!user.follows.where(followable_type: "User").empty?
user.follows.where(followable_type: "User").any?
end
def leave_comments
!user.comments.empty?
user.comments.any?
end
end