Nick Taylor
2b135ab8e3
Small change to make the tools section of member details mobile friendly. ( #15159 )
2021-10-22 18:47:20 +02:00
Mac Siri
68821176d5
Parallelize cypress specs ( #15142 )
...
* Use forked cypress-rails
* Add @KnapsackPro/knapsack-pro-cypress
* Update .travis.yml
* Fix syntax error
* Add KNAPSACK_PRO_TEST_FILE_EXCLUDE_PATTERN
* Update to use KNAPSACK_PRO_TEST_FILE_PATTERN
* Update .travis.yml
* Upgrade custom cypress-rails
* Update custom cypress-rails gem again
* Update .travis.yml
* Create bin/knapsack_pro_cypress
* Add another e2e node
2021-10-22 12:41:56 -04:00
Jeremy Friesen
24929ba20d
Naming "magic numbers" to help clarify ( #15161 )
...
As part of my reading and seeking to understand the
`Articles::Feed::LargeForemExperimental` class, I figured I would come
in and add parameters. In adding parameters, one thought I had was that
we can more readily create a data structure that allows us to tweak the
various implicit values.
This is a first step to help me understand and name the numbers.
2021-10-22 12:37:11 -04:00
Mac Siri
e55d5a85fe
Use custom fork of cypress_rails gem ( #15157 )
...
* Use custom fork of cypress_rails
* Change fork repo
2021-10-22 11:40:38 -04:00
Ridhwana
cb6babc595
Fix Tooltips ( #15156 )
...
* fix; remove the bottom 100%
* refactor: make the tooltip appear at the top + no pointer-events
2021-10-22 07:49:15 -07:00
ludwiczakpawel
d1aac57053
Podcasts fixes ( #15130 )
2021-10-22 11:06:11 +02:00
Nick Taylor
bf2d673492
Created the Forem creator confirmation email template ( #14659 )
...
Co-authored-by: Michael Kohl <citizen428@forem.com>
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2021-10-21 14:56:09 -04:00
Daniel Uber
c10d582e2a
Ensure shown vomit reactions have reactable ( #15153 )
...
This is the counter-argument to #15152 - filter in the controller
rather than adding lots of conditional logic to the view to handle the
case where there was a vomit reaction left for a deleted user causing
the moderation reports page to fail to load.
2021-10-21 11:34:06 -05:00
Julianna Tetreault
a69a97b023
✂️ ✂️ Remove Extra Space From en.yml and fr.yml Files ✂️ ✂️ ( #15149 )
...
* Removes extra space from views/manager/fr.yml and en.yml
* Removes further spaces from views/manager/fr.yml and en.yml
2021-10-21 08:28:26 -06:00
dependabot[bot]
cb3c862f45
Bump webdrivers from 4.7.0 to 5.0.0 ( #15145 )
...
Bumps [webdrivers](https://github.com/titusfortner/webdrivers ) from 4.7.0 to 5.0.0.
- [Release notes](https://github.com/titusfortner/webdrivers/releases )
- [Changelog](https://github.com/titusfortner/webdrivers/blob/main/CHANGELOG.md )
- [Commits](https://github.com/titusfortner/webdrivers/compare/v4.7.0...v5.0.0 )
---
updated-dependencies:
- dependency-name: webdrivers
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-21 07:06:13 -06:00
rhymes
0dd11b3da5
Replace spread syntax with Object.assign in untranspiled JS file ( #15148 )
2021-10-21 14:01:05 +02:00
Ridhwana
085a506205
Navigation Links Validation ( #15139 )
...
* feat: add a required attribute for the fields on Navigation Links that are required
* remove the weird margin
* we want the field to be required only when we don't have a vallue from form.object[:icon] that is in the craete view
2021-10-21 12:43:05 +02:00
yheuhtozr
e826fabf18
views/liquids i18n ( #15060 )
...
* views/liquids i18n
* PR key name changes
* remove ja.yml
2021-10-21 12:25:30 +07:00
yheuhtozr
7eea2b6a22
article editor and manager i18n ( #15070 )
...
* article editor, manager i18n
* PR key name changes
* remove ja.yml
2021-10-21 08:18:48 +07:00
Arit Amana
55a6bc3644
Allow users to choose their default Home and Tags-View Feed (Part 1) ( #15128 )
...
* add new column & define enums
* add new column & define enums
* add tests; improve enum naming
* complete specs update 😅
* discard changes to schema.rb
* rename column name more appropriately
* update specs
* update specs properly 🤦🏾♀️
* Please Travis do the thing
* Add DB schema diff
Co-authored-by: Jamie Gaskins <jgaskins@hey.com>
2021-10-20 18:02:59 -04:00
Daniel Uber
f5a65c5f0c
Update i18n read_path to match our current localization file layout ( #15140 )
...
* Update read path to match our current file layout
The files specified under "more files" were expecting to be
named *.{locale}.yml, like misc.en.yml or tags.fr.yml. However, our
project layout is using a directory prefix like misc/en.yml or
tags/fr.yml.
Consequently, the locale files for views were not being tested (a
previous update ensured that they were being loaded).
Change the load pattern to match the files we use in the app, and
ensure they're tested.
This introduces test failures which will be addressed in the next commit.
* Add back the original pattern
This matches files like devise.en.yml and other existing files in
config/locales (not already in a subdirectory).
* Update inconsistent interpolation
The english version had `{community}` while the french version had
`{name}` for the videos.heading key, checking the call site at
https://github.com/forem/forem/blob/main/app/views/videos/index.html.erb#L26
we have `community:`, passed for interpolation to the translate call,
so change the french translations to include that, rather than name
* Update missing pluralization for badges
* make travis happy
2021-10-20 12:50:22 -05:00
yheuhtozr
cdb823bdf9
views/moderations i18n ( #15068 )
...
* views/moderations i18n
* PR key name changes
* remove ja.yml
2021-10-20 10:48:14 -05:00
yheuhtozr
8b87086200
views/badges etc i18n ( #15021 )
...
* views/badges etc i18n
* reformat for PR
* remove ja.yml
* PR argument error fix?
2021-10-20 09:36:30 -06:00
yheuhtozr
7504a243fd
views/tags etc i18n ( #15039 )
...
* views/tags etc i18n
* remove ja.yml
* YAML reformatting
2021-10-20 08:13:51 -06:00
Julianna Tetreault
22d1e6dd83
Adds a Creator user to the users.rb for testing purposes ( #15138 )
2021-10-20 07:15:41 -06:00
dependabot[bot]
8847d5062f
Bump @storybook/addon-links from 6.3.10 to 6.3.12 ( #15127 )
...
Bumps [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/addons/links ) from 6.3.10 to 6.3.12.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.3.12/addons/links )
---
updated-dependencies:
- dependency-name: "@storybook/addon-links"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-20 07:05:12 -06:00
dependabot[bot]
0f5660d5b6
Bump @storybook/manager-webpack5 from 6.3.11 to 6.3.12 ( #15120 )
...
Bumps [@storybook/manager-webpack5](https://github.com/storybookjs/storybook/tree/HEAD/lib/core ) from 6.3.11 to 6.3.12.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.3.12/lib/core )
---
updated-dependencies:
- dependency-name: "@storybook/manager-webpack5"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-20 14:37:52 +02:00
Ridhwana
262356806d
Fix the Creator Signup Spec ( #15119 )
...
* fix: uncomment the tests and set the param
* chore: update wording
* chore: split text on multiple lines
2021-10-20 14:37:35 +02:00
Ridhwana
656e1a6f79
Remove focus from username field when enter is pressed on any of the input fields ( #15125 )
...
* feat: add type button
* feat: open up the username field is we press keydown on the edit username element
* fix: remove the keypress
* fix: add type: button to the password field
* trigger github hooks
2021-10-19 18:26:20 +02:00
dependabot[bot]
a30badadc6
Bump @storybook/addon-a11y from 6.3.10 to 6.3.12 ( #15126 )
...
Bumps [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/addons/a11y ) from 6.3.10 to 6.3.12.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.3.12/addons/a11y )
---
updated-dependencies:
- dependency-name: "@storybook/addon-a11y"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-19 10:25:53 -06:00
dependabot[bot]
d84a1ae77d
Bump @storybook/preact from 6.3.10 to 6.3.12 ( #15121 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-19 12:13:52 -04:00
dependabot[bot]
590d6913e1
Bump babel-jest from 27.2.5 to 27.3.1 ( #15122 )
...
Bumps [babel-jest](https://github.com/facebook/jest/tree/HEAD/packages/babel-jest ) from 27.2.5 to 27.3.1.
- [Release notes](https://github.com/facebook/jest/releases )
- [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md )
- [Commits](https://github.com/facebook/jest/commits/v27.3.1/packages/babel-jest )
---
updated-dependencies:
- dependency-name: babel-jest
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-19 09:25:40 -06:00
dependabot[bot]
b3479cf706
Bump @storybook/addon-actions from 6.3.10 to 6.3.12 ( #15123 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-19 11:16:21 -04:00
Michael Kohl
26aef9da93
Don't notify authors about own org posts ( #15113 )
2021-10-19 21:32:44 +07:00
dependabot[bot]
36266eba39
Bump @storybook/builder-webpack5 from 6.3.11 to 6.3.12 ( #15124 )
...
Bumps [@storybook/builder-webpack5](https://github.com/storybookjs/storybook/tree/HEAD/lib/core ) from 6.3.11 to 6.3.12.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.3.12/lib/core )
---
updated-dependencies:
- dependency-name: "@storybook/builder-webpack5"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-19 07:57:22 -06:00
dependabot[bot]
ce963cc004
Bump jest from 27.2.5 to 27.3.1 ( #15116 )
...
Bumps [jest](https://github.com/facebook/jest ) from 27.2.5 to 27.3.1.
- [Release notes](https://github.com/facebook/jest/releases )
- [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md )
- [Commits](https://github.com/facebook/jest/compare/v27.2.5...v27.3.1 )
---
updated-dependencies:
- dependency-name: jest
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-19 06:41:44 -06:00
dependabot[bot]
aabc456dfb
Bump sass from 1.42.1 to 1.43.2 ( #15117 )
...
Bumps [sass](https://github.com/sass/dart-sass ) from 1.42.1 to 1.43.2.
- [Release notes](https://github.com/sass/dart-sass/releases )
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sass/dart-sass/compare/1.42.1...1.43.2 )
---
updated-dependencies:
- dependency-name: sass
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-19 13:20:55 +01:00
dependabot[bot]
c79ca7d0dc
Bump @storybook/addon-docs from 6.3.10 to 6.3.12 ( #15110 )
...
Bumps [@storybook/addon-docs](https://github.com/storybookjs/storybook/tree/HEAD/addons/docs ) from 6.3.10 to 6.3.12.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.3.12/addons/docs )
---
updated-dependencies:
- dependency-name: "@storybook/addon-docs"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-19 13:13:36 +01:00
dependabot[bot]
cd69d09cec
Bump eslint-plugin-import from 2.24.2 to 2.25.2 ( #15109 )
...
Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import ) from 2.24.2 to 2.25.2.
- [Release notes](https://github.com/import-js/eslint-plugin-import/releases )
- [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md )
- [Commits](https://github.com/import-js/eslint-plugin-import/compare/v2.24.2...v2.25.2 )
---
updated-dependencies:
- dependency-name: eslint-plugin-import
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-19 13:09:14 +01:00
dependabot[bot]
9af7efb1bb
Bump @reach/combobox from 0.16.1 to 0.16.3 ( #15118 )
...
Bumps [@reach/combobox](https://github.com/reach/reach-ui/tree/HEAD/packages/combobox ) from 0.16.1 to 0.16.3.
- [Release notes](https://github.com/reach/reach-ui/releases )
- [Commits](https://github.com/reach/reach-ui/commits/v0.16.3/packages/combobox )
---
updated-dependencies:
- dependency-name: "@reach/combobox"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-19 13:06:35 +01:00
dependabot[bot]
7b8c2c539a
Bump @testing-library/dom from 8.7.2 to 8.10.1 ( #15101 )
...
Bumps [@testing-library/dom](https://github.com/testing-library/dom-testing-library ) from 8.7.2 to 8.10.1.
- [Release notes](https://github.com/testing-library/dom-testing-library/releases )
- [Changelog](https://github.com/testing-library/dom-testing-library/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testing-library/dom-testing-library/compare/v8.7.2...v8.10.1 )
---
updated-dependencies:
- dependency-name: "@testing-library/dom"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-19 12:00:34 +01:00
dependabot[bot]
644c6721ba
Bump @testing-library/user-event from 13.3.0 to 13.5.0 ( #15103 )
...
Bumps [@testing-library/user-event](https://github.com/testing-library/user-event ) from 13.3.0 to 13.5.0.
- [Release notes](https://github.com/testing-library/user-event/releases )
- [Changelog](https://github.com/testing-library/user-event/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testing-library/user-event/compare/v13.3.0...v13.5.0 )
---
updated-dependencies:
- dependency-name: "@testing-library/user-event"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-19 11:59:44 +01:00
Suzanne Aitchison
5069cd681a
Markdown editor toolbar ( #14876 )
...
* rough starting point, roving tabindex in toolbar, bold and italic buttons
* refactor, add link
* add ul
* add ordered list
* core formatters in place, wip
* overflow options
* add keyboard shortcuts
* tidy up some dodgy classes
* add mocks for runtime in test and storybook, use correct modifier key for tooltip
* style tweaks
* refactor tooltips
* add markdown formatters tests
* add tests for toolbar component, fix mistake in overflow menu tooltips
* undo change no longer needed to button
* fix issue accessing runtime in formatters file
* only show darkened buttons and tooltips when focus-visible is true
* mobile view
* fix for responsive buttons & roving tabindex
* tweaks from PR review
* update cursor position on link insertion
* add a new line after block selection formatting
* align icons in center
* tidy up overflow menu listeners
* small refactors
* test for new text area util
* tidy up new lines after syntaxes
* fix logic in cursor offsets for links
* prevent scroll jumps after inserting syntax
* some style tweaks
* insert level 2 heading with new lines above and below
* update icons
* use margin instead of gap
2021-10-19 09:22:54 +01:00
Takuma
e8d04165b4
Fix hamburger menu scrolling ( #15000 )
2021-10-18 20:51:46 -04:00
Nick Taylor
d81aa19477
Removed 'test' test when the other E2E build node was created. ( #15111 )
2021-10-18 14:56:17 -05:00
dependabot[bot]
0ce7f0854c
Bump redis from 4.5.0 to 4.5.1 ( #15107 )
...
Bumps [redis](https://github.com/redis/redis-rb ) from 4.5.0 to 4.5.1.
- [Release notes](https://github.com/redis/redis-rb/releases )
- [Changelog](https://github.com/redis/redis-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/redis/redis-rb/compare/v4.5.0...v4.5.1 )
---
updated-dependencies:
- dependency-name: redis
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-18 12:36:33 -06:00
yheuhtozr
3e009e3e8b
views/reading_list_items i18n ( #15041 )
...
* views/reading_list_items i18n
* remove ja.yml
* reading list items PR typo fix
2021-10-18 11:32:57 -07:00
dependabot[bot]
130146ef3e
Bump @storybook/addon-storysource from 6.3.10 to 6.3.12 ( #15102 )
...
Bumps [@storybook/addon-storysource](https://github.com/storybookjs/storybook/tree/HEAD/addons/storysource ) from 6.3.10 to 6.3.12.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.3.12/addons/storysource )
---
updated-dependencies:
- dependency-name: "@storybook/addon-storysource"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-18 11:32:06 -07:00
dependabot[bot]
9572fc67fe
Bump core-js from 3.18.2 to 3.18.3 ( #15105 )
...
Bumps [core-js](https://github.com/zloirock/core-js ) from 3.18.2 to 3.18.3.
- [Release notes](https://github.com/zloirock/core-js/releases )
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zloirock/core-js/compare/v3.18.2...v3.18.3 )
---
updated-dependencies:
- dependency-name: core-js
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-18 11:31:56 -07:00
dependabot[bot]
564e529c3f
Bump rubocop-rails from 2.12.3 to 2.12.4 ( #15106 )
...
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from 2.12.3 to 2.12.4.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.12.3...v2.12.4 )
---
updated-dependencies:
- dependency-name: rubocop-rails
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-18 11:31:14 -07:00
yheuhtozr
d80f451c95
views/collections i18n ( #15019 )
...
* views/collections i18n
* reformat for PR
* remove ja.yml
2021-10-18 14:10:32 +07:00
Ben Halpern
09fa66a03f
Fix and clean up podcast pages ( #15004 )
...
* Fix and clean up podcast pages
* Adjust tests
* Fix a test
* Fix missing i18n
* Fix tests
* Fix tests
* Fiddle with test
* Sure up css and tests
* Add featured as allowed param
* Fix a couple tests
* xit out test
* Update app/views/podcast_episodes/index.html.erb
* Update app/views/podcast_episodes/index.html.erb
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
2021-10-15 17:38:57 -04:00
Nick Taylor
e79975f705
Now an error is raised in dev/test environments if translations are missing ( #15089 )
2021-10-15 17:29:30 -04:00
dependabot[bot]
4aa5786e96
Bump webdrivers from 4.6.1 to 4.7.0 ( #15087 )
...
Bumps [webdrivers](https://github.com/titusfortner/webdrivers ) from 4.6.1 to 4.7.0.
- [Release notes](https://github.com/titusfortner/webdrivers/releases )
- [Changelog](https://github.com/titusfortner/webdrivers/blob/main/CHANGELOG.md )
- [Commits](https://github.com/titusfortner/webdrivers/compare/v4.6.1...v4.7.0 )
---
updated-dependencies:
- dependency-name: webdrivers
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-15 15:45:14 -04:00
Jamie Gaskins
34a61abdca
Remove txn from with_statement_timeout block ( #15088 )
...
Turns out this caused a *different* problem. It would work for the first
delete batch in `BulkSqlDelete`, but subsequent `DELETE` queries would
then get their `statement_timeout`s reset to the global setting. The
issue was that `BulkSqlDelete` uses methods that don't respect nested
transactions, and we were already resetting the value of the setting to
its previous value anyway, so there was really no reason to run it
inside a transaction.
The only failure mode I know of here is that the `ensure` block breaks
because `connection` is severed. In that case, the value is reset anyway
when the connection pool replaces the connection so the failure does not
propagate.
2021-10-15 14:53:35 -04:00
