Commit graph

12930 commits

Author SHA1 Message Date
Josh Klar
2ae46a21b3
Developer Onboarding Simplification (#20077)
* readme: Remove redundant prerequisites section (already in install docs).

* readme: Link to both Linux and MacOS installation instructions.

* devxp: Track non-node/ruby devtool versions with rtx.

* devxp: Simplify MacOS system-level dependency installation with brew bundle.
2023-09-22 02:05:41 -07:00
Mac Siri
5dc7e889b9
Support devcontainers and GitHub codespace (#20126)
Co-authored-by: Josh Klar <jklar@forem.com>
2023-09-21 18:16:09 -04:00
Anna Buianova
61f3c517e1
Display post languages in the dashboard (#20137)
* Display post languages in the dashboard

* Added languages locales to several languages variations
2023-09-21 14:42:44 +03:00
Rajat Talesra
1d73f871f2
Janky bug fix (#20147) 2023-09-21 16:37:44 +05:30
depfu[bot]
1933f0445a
Update @cypress/code-coverage to version 3.12.1 (#20140)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-09-20 17:50:17 +01:00
Joshua Wehner
13f4aaa0fb
Username inputs for admin (#20123)
* Support username inputs on /admin/articles

* Support username input on tag admin moderator

* Support username input on admin community settings

* Support username input on admin mascot settings
2023-09-20 09:25:38 -04:00
depfu[bot]
8f5f9574db
[ruby] Update pghero 3.3.3 → 3.3.4 (patch) (#20096)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-09-20 08:59:26 -04:00
Rajat Talesra
54131cd94c
Move the digest email opt-in to the follow tags onboarding step (#20133)
* Removed intro slide and updated sequence

* Revert db change

* Initial save

* Design changes

* Mobile designs

* Added functionality

* Added tests

* Gradient effect added

* Added API call test
2023-09-20 17:55:29 +05:30
depfu[bot]
35c6c4bca7
[js] Update i18n-js 4.3.0 → 4.3.2 (patch) (#20135)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-09-19 19:38:51 -04:00
PJ
da73343540
Skip round robin mod notifications for limited users (#20128)
* return early if user is limited

* fix worker specs
2023-09-19 15:03:20 +01:00
depfu[bot]
45427e8547
Update eslint-plugin-import to version 2.28.1 (#20102)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-09-18 22:08:21 -07:00
Ben Halpern
4f8f828a44
New feed experiments for 9/18 (#20130) 2023-09-18 14:40:09 -07:00
PJ
67bb7a6e76
Revert "Bump sidekiq and sidekiq-unique-jobs dependencies in tandem" (#20132) 2023-09-18 13:27:08 -04:00
PJ
2a1c20b57f
Bump sidekiq and sidekiq-unique-jobs dependencies in tandem (#20131)
* bump sidekiq and sidekiq-unique-jobs in tandem

* ensure Articles::UpdatePageViewsWorker arg is a hash
2023-09-18 12:22:35 -04:00
Mai Irie
9332ef7123
Reduce Codecov's patch target to 60% (#20095)
* Reduce Codecov's patch target to 50%

* Update codecov.yml

After internal discussion, settled on 60% as the floor for the baseline.

* Code Cov note in PR template
2023-09-15 13:31:22 -04:00
PJ
90944bb36b
Skip feed events e2e specs (#20124) 2023-09-15 17:36:08 +01:00
Ben Halpern
cadebde66f
Add feed_success_score and other count tallies (#20106)
* Add initial feed events score

* Add feed events score

* Clean up code styles

* Adjust how tests are run

* Fix conflicts

* Update app/javascript/articles/Feed.jsx

* Add additional feed events tabulation queries for more reliable eventual consistency

* Add additional feed events tabulation queries for more reliable eventual consistency

* Fix test logic

* Updates from feedback
2023-09-15 12:02:26 -04:00
PJ
84a65f0a26
remove blocking attribute (#20116) 2023-09-15 10:35:35 -04:00
Ridhwana
aa201060e8
Override Tag Moderation Actions (#20088)
* feat: remove the validation for the article_id and tag_name to be unique on a tag_adjustment

* chore: remove unique index

* feat: update the validate_tag method to align with the removal of unique indexes on the table

* feat: do not allow removal and addition of tags that were added/removed by admins

* spec: add tests for the tag_adjustment_spec

* fix: update the validation of tags

* spec: article validation

* spec: test the action_panel helper

* chore: amend language

* add styles

* Empty commit
2023-09-15 15:06:58 +02:00
Joshua Wehner
c91a652245
Allow trusted users to see whether a user is suspended (#20061)
* Async append user suspended status pill

* Rubocop

* Relocate JS tests, for build & coverage

* Better error-handling for this controller

* Refactor HTML to render pill outside h1

* Continuing to tweak design

* JS class prepended
2023-09-15 08:44:31 -04:00
Joshua Wehner
6fe9d7d7a6
Allow org admins to add members as co-authors (#20008)
* Basics might be working?

* Stop propagating button clicks in autocomplete pills

* Better blank slate

* Better location to stop propagation

* Remove author_id from org co-authors

* Move UserStore and try testing it

* Remove extraneous comments

* OH... that's what that does!

* Very basic testing

* Re-organize javascripts

* Rename & re-org for testing

* Cleanup

* More tests

* Remove unnecessary nesting

* Coninuing to try to bump coverage

* Include /packs/ in code coverage metric

* Try tweaking jest coverage more?

We probably can't collect coverage from all of packs/* (because coverage is too low) but maybe we can try to opt-in for newer areas as we go?

* Relocate JS tests, for build & coverage

* User ID exception on search, not fetch

* Remove commented-out console.log

---------

Co-authored-by: Mac Siri <krairit.siri@gmail.com>
2023-09-15 08:12:41 -04:00
Ben Halpern
612c402887
Fix onboarding with implicit terms acceptance (#20117) 2023-09-14 16:02:34 -04:00
Rajat Talesra
c72c52dfdb
Removed intro slide and updated sequence (#20011)
* Removed intro slide and updated sequence

* Revert db change
2023-09-14 20:26:47 +05:30
Ridhwana
fb2978149d
Remove section from digest mailer (#20110)
* chore: remove listing related text

* feat: remove post-a-job

* Revert "feat: remove post-a-job"

This reverts commit e1c4cd449c328a43cc658882064a8312b71a18f1.
2023-09-14 14:31:15 +02:00
depfu[bot]
b4d41337f0
Update oj to version 3.16.1 (#20107)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-09-14 15:04:47 +03:00
Duke Greene
7d1d0ff80b
comment out flaky specs and add comments for exploration/refactor (#20103)
* comment out flaky specs and add commments for exploration/refactor context

* comment out only the specs which call reload for now

* use it.skip rather than commenting out
2023-09-14 06:25:27 -04:00
depfu[bot]
0db4c7e445
Update eslint-plugin-react to version 7.33.2 (#20094)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2023-09-14 12:14:59 +02:00
Ben Halpern
a079434397
Add new invitation params (#20074)
* Add new invitation fields

* SMTP enabled check

* Update spec/requests/api/v1/admin/users_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Add devise_mailer spec

* Add devise_mailer spec

* Update spec/mailers/devise_mailer_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update spec/mailers/devise_mailer_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update spec/mailers/devise_mailer_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2023-09-13 13:01:39 -04:00
Rajat Talesra
a679486572
Redesign sign-up and login pages (#20065)
* Signin Signup screen update

* Design for signin signup finished

* On hover effect

* Fixed few tests

* Fixed rSpec tests

* Minor design fixes

* Design changes suggested by Anuj

* Test fixes

* Updated test

* Nit fixes

* Path changes and footer and topbar hidden

* A bit simplified css

* Removed custom css

* Updated tests

* Nit css fixes

* Updates as per Ridhwana's review

* CSS fixes

* Used js-registration
2023-09-13 21:46:57 +05:30
depfu[bot]
1533936d7a
Update postcss to version 8.4.29 (#20099)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-09-13 11:57:38 -04:00
Ben Halpern
d6d7eeeb59
Add proper follow-user class to liquid when passed UserDecorator (#20101)
* Add proper follow-user class to liquid

* Adjust test
2023-09-13 11:36:21 -04:00
Joshua Wehner
dfe71c15a1
Record feed event for article comments (#20087) 2023-09-13 11:14:27 -04:00
Anna Buianova
56f2a58e95
Default content language for forems (#20089)
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2023-09-13 13:26:45 +03:00
depfu[bot]
c3c57bd047
Update all of babel7 to version 7.22.17 (#20098)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-09-13 15:43:37 +05:30
Narender Singh
da7c25c987
add new org button in settings (#20014)
* add new org button in settings

* add support for mobile view

* remove varible for new org check

* fix design suggestions

* fix org settings test

* remove the settings for test since this text does not exists in user settings

* remove un-used copy

* Update class name

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>

* Fix follow user spec

* fix the rspec test case

---------

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2023-09-13 11:52:57 +02:00
depfu[bot]
a4a1ecfb14
Update @babel/eslint-parser to version 7.22.15 (#20081)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-09-12 19:02:39 -07:00
depfu[bot]
5793f71f40
Update cypress and add cypress-multi-reporters (#20085)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Mac Siri <mac@forem.com>
2023-09-12 12:37:24 -04:00
PJ
3f922921e5
Admin setting to control enabled countries for billboard geotargeting (#20083)
* use instance setting for enabled target geolocations

* add validation for enabled geolocations setting

* a start on the UI?

* backend tweaks for UI

* proper crack at autocomplete component

* fix region targeting toggle

* e2e spec
2023-09-12 12:06:00 -04:00
Ben Halpern
eb17b73690
Add new countries to edge cache dictionary (#20084) 2023-09-12 12:05:34 -04:00
depfu[bot]
22286e6e69
Update pg to version 1.5.4 (#20064)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-09-12 17:45:22 +02:00
depfu[bot]
85bfd2c734
Update preact to version 10.17.1 (#20078)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-09-12 17:43:21 +02:00
PJ
95ca9d37c5
Record feed events for public reactions (#20079)
* create feed event on feed reaction

* move feed event creation to feed event model

* tiny whoops

* fix failing specs

* slightly less flaky e2e spec (maybe)

* tiny fixes (couldn't resist)
2023-09-12 08:36:10 -04:00
Duke Greene
bf4c34636e
display tag moderation history in article's mod panel (#20041)
* logic and markup to display tag adjustment history on article mod panel

* add tag adjustment reason to markup

* add specs for article's tag adjustment association and ordered tag adjustments

* style tag adjustment history

* sketch out cypress test for visible tag moderation history

* tweak spacing and sizing of adjustment history heading

* adjust cypress tests, tag adjustments still coming back empty in spec

* get past first cypress snag by waiting for request and reloading

* add spec for viewing multiple tag adjustments in a post history

* restore defer: true in actions panel js packs call

* add e2e tests for remaining mod views with tag adjustment UI
2023-09-12 07:08:44 -04:00
Anna Buianova
aa5cb535fa
Add languages to User model (#20059) 2023-09-11 11:44:19 -04:00
Juanito Fatas
e1c91d2a64
Fix typo of configuring redis at datadog initializer (#20016) 2023-09-11 10:40:04 -04:00
depfu[bot]
e8e74c0d8a
[js] Update lint-staged 13.1.2 → 13.3.0 (minor) (#20054)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-09-11 10:37:34 -04:00
PJ
3f7d1fbc1a
Create feed impression and click events (#20043)
* getting started: model setup

* basic controller action & spec

* somewhat working click events

* pick up on impressions

* there was an attempt at batching without duplicates

* (better) bulk upsert service

* fix specs?

* touch up feed events JS

* end-to-end specs??

* workers wip

* fix failing user delete spec
2023-09-11 13:32:36 +01:00
depfu[bot]
37d8fc866a
Update eslint to version 8.48.0 (#20073)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-09-11 15:40:58 +05:30
Ridhwana
789907d289
Tags Dashboard Error Handling (#20051)
* feat: add an error modal for the dashboard page tags

* spec: add the tests for the tags dashboard pages

* spec: add the tests for the hiding tags dashboard pages
2023-09-11 11:41:56 +02:00
Ben Halpern
ed853f7e1e
Fix "register" bugs in invitations (#20071)
* Fix registered bugs in invitations

* Update spec/requests/api/v0/admin/users_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Move to v1 spec

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2023-09-08 17:00:37 -04:00