* Fix some eslint and a11y issues
* Add a11y fixed to snapshot
* Fix missing whitespace that cause test fail
* Fix code duplicate
* Config eslint to allows the label as a sibling
* Use 'error' instead of 2 in eslintrc
* Correct propTypes in SingleListing
* Add missing id prop for select
* Add space between two functions
* onKeyPress only register Enter
* Allow space key also to activate action
* Use a common function for three event handlers
The readme should include instructions to run the docs site so that
people don't have to go searching for the contributing.md file if they
are stumbling upon the docs in their code editor instead of via the
docs.dev.to website.
* Add tag rules to article v2 editor
* Add bottom phrase to tag dropdown
* Remove console logs
* Remove empty space in css
* Remove commented code and clean up css
* Add type='button' for a11y
* The previous Dockerfile was using and outdated format and was causing
heavy load times.
The number of the lines in the Dockerfile are defined as layer, with more
layers more time and bigger is the final image.
There were many things that were able to be delegated to the official ruby
docker image.
* - Use yarn community package
- Don't create the workdir directory since is created by docker if doesn't exists
- Remove config/application.yml from .dockerignore
* Update Dockerfile
Co-Authored-By: Abenet Tamiru <mail@abenet.me>
* Update Dockerfile
Co-Authored-By: Abenet Tamiru <mail@abenet.me>
* Add directory copy, and user correct folder in compose
* Update docker-compose and Dockerfile
* Fix typo
Co-Authored-By: Mac Siri <krairit.siri@gmail.com>
* Update wording
Co-Authored-By: Mac Siri <krairit.siri@gmail.com>
* Regenerate rubocop todo
* Fix outstanding problems
* Fix Style/FormatStringToken
* Final update to rubocop todo file
* Set RSpec/ExampleLength to max 10 and regenerate todo file
* fix use global form of use strict error
* fix errors involving functions being used before being defined
* fix undefined function and == errors
* fix redeclared variable name error
* use arrow functions to fix unnamed function warnings
* specify global function at top of file instead of disabling line in eslint, change meta variable name
* Fix broken job specs
Many job specs were putting their assertions inside a block provided to
ActiveJob's perform_now. Unfortunately, this syntax does not error and
simply ignores the provided block.
The tests were therefore not executing their assertions. As a result
many of them were actually broken to begin with. Many used incorrect
stubbing, were trying to stub instances of models that wouldn't actually
be returned by ActiveRecord queries, etc.
This commit fixes the syntax and does it's best to fix the tests. Many
of these assertions/spec could use more TLC, but this work at least gets
them passing/executing.
* Avoid time comparison precision issues
* Implement review feedback
Adds negative test cases for when record is not found/nil. Also some
formatting changes as I was paying more attention to the rubocop setup
now.
* Add without article context to job spec
* Remove unused lets
- eslint configuration moved comments to a seperate line
in pre commit hook allowing the eslint-disable-line to
not work correctly.
- switched to eslint-disable-next-line to fix the same
