maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
7800 commits 1 branch 0 tags 1.6 GiB
Commit graph

7800 commits

This branch
This branch
All branches
Author SHA1 Message Date
Nick Taylor
2925a64eb8
Added webpack bundle analyzer (#12013) 
* Added webpack bundle analyzer.

* Renamed to bundleAnalyzer (no extension)

* Added some documentation.
 2020-12-22 19:13:40 -05:00
Ben Halpern
673b1406be
Allow any admin to publish welcome thread (#11597) 
* Allow any admin to publish welcome thread

* Update app/models/article.rb

Co-authored-by: rhymes <rhymes@hey.com>

* Fix specs by making user for welcome thread an admin

* revert spec changes and update code to include either admin, super_admin, or site mascot

* add specs for scope

* Modify tests and include mascot user

* Fix test

Co-authored-by: rhymes <rhymes@hey.com>
Co-authored-by: mstruve <mollylbs@gmail.com>
 2020-12-22 16:18:32 -05:00
Ben Halpern
68867e9384
Add config post route for admin api (#11698) 
* Add config post route for admin api

* Fix params

* Extract config_params to concern

* Remove print statement

* Some changes

* A couple changes

* Change controller method name and refactor upsert

* Fix tests and method names

* Fix routes and class stuff

* Fix styles

* Fix config params

* Fix styles

* Move regex to constant

* Remove single-use after action callbacks

* Expose success? method

* Fix syntax error

* Fix success? return

* Switch to guard clause

* Final clean ups?
 2020-12-22 15:50:34 -05:00
rhymes
00247bed99
Log error message inline when Feeds::Import fails (#12012) 2020-12-22 20:02:07 +01:00
rhymes
92fdf8d720
Upgrade to SimpleCov 0.20 (#12009) 
* Upgrade to simplecov 0.20

* Upgrade to latest CodeClimate reporter
 2020-12-22 18:46:52 +01:00
dependabot[bot]
05aa9a27fe
Bump rails-settings-cached from 2.5.1 to 2.5.2 (#12006) 
Bumps [rails-settings-cached](https://github.com/huacnlee/rails-settings-cached) from 2.5.1 to 2.5.2.
- [Release notes](https://github.com/huacnlee/rails-settings-cached/releases)
- [Changelog](https://github.com/huacnlee/rails-settings-cached/blob/master/CHANGELOG.md)
- [Commits](https://github.com/huacnlee/rails-settings-cached/compare/v2.5.1...v2.5.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
 2020-12-22 16:01:10 +01:00
dependabot[bot]
7bc50a28ba
Bump ransack from 2.4.0 to 2.4.1 (#12007) 
Bumps [ransack](https://github.com/activerecord-hackery/ransack) from 2.4.0 to 2.4.1.
- [Release notes](https://github.com/activerecord-hackery/ransack/releases)
- [Changelog](https://github.com/activerecord-hackery/ransack/blob/master/CHANGELOG.md)
- [Commits](https://github.com/activerecord-hackery/ransack/compare/2.4.0...2.4.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-22 09:07:30 -05:00
dependabot[bot]
239494a272
Bump cypress from 6.1.0 to 6.2.0 (#12008) 
Bumps [cypress](https://github.com/cypress-io/cypress) from 6.1.0 to 6.2.0.
- [Release notes](https://github.com/cypress-io/cypress/releases)
- [Changelog](https://github.com/cypress-io/cypress/blob/develop/.releaserc.base.js)
- [Commits](https://github.com/cypress-io/cypress/compare/v6.1.0...v6.2.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-22 07:35:19 -05:00
Mac Siri
ab95635dc6
Filter XSS in navigationLink's title (#12003) 2020-12-22 12:05:41 +01:00
Michael Kohl
bd13d21b4c
Enable paranoid mode for Devise (#11995) 
* Enable paranoid mode for Devise

* Remove two specs

These no longer make sense after enabling Devise's paranoid mode.
 2020-12-22 13:47:28 +07:00
Alex
d0c70e72d7
Update bust_tag to EdgeCache::BustTag (#11953) 2020-12-21 14:43:42 -05:00
Alex
e9886d106c
Update bust_events to EdgeCache::BustEvents (#11955) 2020-12-21 14:43:28 -05:00
dependabot[bot]
7f2f46f64c
Bump node-notifier from 8.0.0 to 8.0.1 (#11998) 
Bumps [node-notifier](https://github.com/mikaelbr/node-notifier) from 8.0.0 to 8.0.1.
- [Release notes](https://github.com/mikaelbr/node-notifier/releases)
- [Changelog](https://github.com/mikaelbr/node-notifier/blob/v8.0.1/CHANGELOG.md)
- [Commits](https://github.com/mikaelbr/node-notifier/compare/v8.0.0...v8.0.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-21 13:28:28 -05:00
Ben Halpern
5cd947336b
Declare winner in update points worker (#11974) 
* Declare winner in update points worker

* Remove tests

* Fix finalized_points style issue
 2020-12-21 12:59:54 -05:00
rhymes
3dae3ff797
Upgrade rubocop* packages to the latest version and fix violations (#11972) 
* Update erb_lint to track newer Rubocop versions

* Update rubocop-rspec to 2.1

* Fix Rails/WhereEquals and Style/RedundantParentheses

* Upgrade rubocop to 1.1.0

* Enable Rubocop 1.1 cops

* Upgrade rubocop to 1.2.0

* Enable Rubocop 1.2 cops

* Upgrade rubocop to 1.3.0

* Enable Rubocop 1.3 cops

* Enable Rubocop 1.4 cops

* Enable Rubocop 1.5 cops

* Upgrade rubocop to 1.6.x

* Restore previous .reject

* Fork the PR to make sure we don't inject unwanted code accidentally
 2020-12-21 18:29:43 +01:00
Peter Frank
97d00780b8
Use default social image on /listings (#11997) 
Following pattern from https://github.com/forem/forem/pull/11961 to generalize the social image on `/listings`
 2020-12-21 18:29:11 +01:00
dependabot[bot]
eba7c522db
Bump webmock from 3.10.0 to 3.11.0 (#11986) 
Bumps [webmock](https://github.com/bblimke/webmock) from 3.10.0 to 3.11.0.
- [Release notes](https://github.com/bblimke/webmock/releases)
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md)
- [Commits](https://github.com/bblimke/webmock/compare/v3.10.0...v3.11.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-21 11:57:13 -05:00
dependabot[bot]
6b11fc4f6c
Bump @storybook/addon-links from 6.1.5 to 6.1.11 (#11988) 
Bumps [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/addons/links) from 6.1.5 to 6.1.11.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.1.11/addons/links)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-21 16:36:35 +01:00
rhymes
20ecc52bb5
Add rel noopener to footer links (#11994) 2020-12-21 16:24:33 +01:00
dependabot[bot]
5f71697cbf
Bump flipper-ui, flipper-active_record and flipper (#11990) 
Bumps [flipper-ui](https://github.com/jnunemaker/flipper), [flipper-active_record](https://github.com/jnunemaker/flipper) and [flipper](https://github.com/jnunemaker/flipper). These dependencies needed to be updated together.

Updates `flipper-ui` from 0.19.1 to 0.20.0
- [Release notes](https://github.com/jnunemaker/flipper/releases)
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md)
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.19.1...v0.20.0)

Updates `flipper-active_record` from 0.19.1 to 0.20.0
- [Release notes](https://github.com/jnunemaker/flipper/releases)
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md)
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.19.1...v0.20.0)

Updates `flipper` from 0.19.1 to 0.20.0
- [Release notes](https://github.com/jnunemaker/flipper/releases)
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md)
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.19.1...v0.20.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-21 09:21:29 -06:00
dependabot[bot]
4f1e04b6f9
Bump intersection-observer from 0.11.0 to 0.12.0 (#11923) 
Bumps [intersection-observer](https://github.com/w3c/IntersectionObserver) from 0.11.0 to 0.12.0.
- [Release notes](https://github.com/w3c/IntersectionObserver/releases)
- [Commits](https://github.com/w3c/IntersectionObserver/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-21 15:34:01 +01:00
dependabot[bot]
bba592fc06
Bump eslint from 7.15.0 to 7.16.0 (#11987) 
Bumps [eslint](https://github.com/eslint/eslint) from 7.15.0 to 7.16.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v7.15.0...v7.16.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-21 15:33:43 +01:00
dependabot[bot]
9c5f7d956a
Bump eslint-config-prettier from 7.0.0 to 7.1.0 (#11989) 
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 7.0.0 to 7.1.0.
- [Release notes](https://github.com/prettier/eslint-config-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prettier/eslint-config-prettier/compare/v7.0.0...v7.1.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-21 15:33:26 +01:00
Nick Taylor
c24cf73b28
Fixed initial e2e test now that data updates are run. (#11958) 
* Fixed initial e2e test now that data updates are run.

* Clearing any indices created in ES during E2E tests.

* Fixed a typo.

* Fixed env vars not being loaded.

* Prefixed data updates command with bundle exec.

* Promoted setting secret to the global section of the Travis config.

* Stopped sourcing .env and promoted ELASTICSEARCH_URL to global section of Travis configuration.

* Had to fix cc reporter in my PR to get PR to work.
 2020-12-21 08:40:11 -05:00
Mac Siri
893151d76b
Fix API's broken organization's image (#11981) 2020-12-21 07:20:16 -05:00
Nick Taylor
04b91520c4
Reenable End to End Testing... Again 😄 (#11977) 
* Re-eneabled e2e tests in Travis.

* Explicitly set cache_template_loading to true for action views.
 2020-12-21 06:27:00 -05:00
Ben Halpern
3c297ff05e
Lengthen local caching max-age (#11970) 2020-12-20 11:08:10 -05:00
rhymes
1c8b44f326
Remove GitHub repositories when GitHub identity is removed (#11951) 
* Remove GitHub repositories when user deletes their own GitHub identity

* Remove GitHub repos also from the admin remove identity

* Add a notice in Settings/Extension

* Add data update script to cleanup orphan GitHub repos
 2020-12-20 15:15:40 +01:00
Dominic Duffin
361d09dd42
Improve date/time picker on admin/events/new (#11979) 2020-12-18 17:43:48 -05:00
Ben Halpern
32b5e5e317
Resolve problem where profile fields have not been properly imported (#11976) 
* Resolve problem where profile fields have not been properly imported

* Refactor complexity

* Rescue role adding
 2020-12-18 16:42:15 -05:00
Nick Taylor
093197fa8f
Disabling Cypress temporarily to figure out why the web server errors action template errors. (#11975) 2020-12-18 14:31:26 -05:00
dependabot[bot]
aa5a368355
Bump @storybook/addon-storysource from 6.1.10 to 6.1.11 (#11964) 
Bumps [@storybook/addon-storysource](https://github.com/storybookjs/storybook/tree/HEAD/addons/storysource) from 6.1.10 to 6.1.11.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.1.11/addons/storysource)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-18 14:21:15 -05:00
Ben Halpern
972cc6cc05
Remove config single resource admin from config logic (#11971) 
* Remove config single resource admin from config logic

* Remove single resource admin test
 2020-12-18 13:09:31 -05:00
Spencer
6e2aab623e
API: Endpoint to get an organization's listings (#11823) 
* add tests

* add route

* add controller action

* add jbuilder file

* update api docs

* update query

* update jbuilder listing

* add organization/user and category to listing

* update api docs/spec file
 2020-12-18 12:20:35 -05:00
Ben Halpern
908ab99939
Add missing default social image (and remove DEV version) from pod and events (#11961) 2020-12-18 11:51:05 -05:00
Ben Halpern
c6c2720a8d
Fix default favicon (#11962) 2020-12-18 11:50:52 -05:00
Fernando Valverde
fcc5c0d2a1
Add Sign in with Apple (#11934) 
* Add gem omniauth-apple

* Integrate omniauth-apple

* Integrate callback

* Add fields

* Add tests, fix bugs and make it all work

* Show only enabled providers for the current user

* Add default profile image for Apple

* Remove localhost patch

* Bring over the changed Apple username if the user changes it

* More specs fixed

* Incorporate feedback from PR

* Fix specs

* Simplify code and fix spec

* Fix Broadcast generators to take into account the new provider

* Fix spec

* Generate a truly unique apple_username

* Fix user specs

* Add omniauth-apple-0.0.2 to vendor cache

* Fix merge conflict and spec

* Update VCR fastly sloan cassette

* Revert "Generate a truly unique apple_username"

This reverts commit 2462875575b0bbd6b3c1d56b25afcd3189671608.

* Fix user specs

* Fix specs

* Fix specs

* Hide Connect Apple button behind a feature flag

* Revert "Hide Connect Apple button behind a feature flag"

This reverts commit 105bde0373389a4eb9b6e948f60734c7e0e99cba.

* Fix line lengths

* Fix spec

* ES tag

* CSRF bypass for Apple callback

* custom user_nickname in Apple provider with small tweaks + omniauth-apple bump

* Fixes username specs

* Makes Apple users default image Users::ProfileImageGenerator

* Fallback to mascot_image_url in test environment to avoid breaking Travis

* Fixes Apple CSRF error + makes default nickname more readable

* Trigger Travis

* Better devise config

* Apple SiteConfig entires in /admin/config

* Fixing specs

* Adds beta_access? to Authentication::Providers::Provider

* Fixes specs

* Codeclimate double quote fix in Gemfile

* Fixes /admin/config allowed params & adds feature flag for provider beta_access?

* Remove Enfile & adds temporary docs

* Adds custom apple auth provider settings

* Fix authenticator spec

* Fix configs spec (use last instead of first to avoid apple special case)

* Remove dangling fields from /admin/config

* updates feature flag

* More test fixes

* Hide config behind feature flag too

* omniauth-apple bump

* Takes care of edge case fallback

* Reverse apple_username update

* Adds auth_time to info hash in apple omniauth mock

* Switch to next instead of nesting for feature flag

* Fixes CVE-2015-9284

* Fixes specs after auth providers initiatior refactor from GET to POST

* Spec fixes

* More spec fixes

* Fix Rails codebase reference link

Co-authored-by: rhymes <rhymesete@gmail.com>
Co-authored-by: rhymes <rhymes@hey.com>
 2020-12-18 10:22:33 -06:00
Alex
f31470d8e5
Update .bust_page to EdgeCache::BustPage (#11952) 2020-12-18 11:21:54 -05:00
Ben Halpern
5a1658bb79
Make followers notification overflow-hidden (#11870) 2020-12-18 11:09:30 -05:00
Ridhwana
c8e56853b7
Updates the email_addresses hash with the contact info (#11967) 
* feat: add a new script that updates the email_addresses hash with the contact key

* add a comment to old data script

* feat: add a spec (not passing as yet)

* fix: test passing

* chore: comment script with reason
 2020-12-18 18:07:48 +02:00
Fernando Valverde
e48abdc586
Fix the way we check for AndroidBridge global (#11969) 
* Change the way we check for AndroidBridge global

* Modify logic to check for not undefined
 2020-12-18 09:44:53 -06:00
dependabot[bot]
ecd243c30e
Bump twilio-video from 2.9.0 to 2.10.0 (#11965) 
Bumps [twilio-video](https://github.com/twilio/twilio-video.js) from 2.9.0 to 2.10.0.
- [Release notes](https://github.com/twilio/twilio-video.js/releases)
- [Changelog](https://github.com/twilio/twilio-video.js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/twilio/twilio-video.js/compare/2.9.0...2.10.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-18 10:40:52 -05:00
dependabot[bot]
72de8c29df
Bump hypershield from 0.2.1 to 0.2.2 (#11966) 
Bumps [hypershield](https://github.com/ankane/hypershield) from 0.2.1 to 0.2.2.
- [Release notes](https://github.com/ankane/hypershield/releases)
- [Changelog](https://github.com/ankane/hypershield/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ankane/hypershield/compare/v0.2.1...v0.2.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-18 09:56:02 -05:00
dependabot[bot]
c5b5bd2640
Bump @testing-library/cypress from 7.0.2 to 7.0.3 (#11963) 
Bumps [@testing-library/cypress](https://github.com/kentcdodds/cypress-testing-library) from 7.0.2 to 7.0.3.
- [Release notes](https://github.com/kentcdodds/cypress-testing-library/releases)
- [Changelog](https://github.com/testing-library/cypress-testing-library/blob/master/CHANGELOG.md)
- [Commits](https://github.com/kentcdodds/cypress-testing-library/compare/v7.0.2...v7.0.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-18 05:54:19 -05:00
dependabot[bot]
2d398b354d
Bump @storybook/addon-knobs from 6.1.9 to 6.1.11 (#11942) 
Bumps [@storybook/addon-knobs](https://github.com/storybookjs/storybook/tree/HEAD/addons/knobs) from 6.1.9 to 6.1.11.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.1.11/addons/knobs)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-18 10:28:28 +01:00
Nick Taylor
ccb8352841
Fix end to end testing for Forem forked repositories (#11950) 
* Fixed e2e parallelization when no API token for Knapsack.

* Re-eneabled e2e tests in Travis.

* Checks for the KNAPSACK_PRO_TEST_SUITE_TOKEN_CYPRESS now.
 2020-12-17 18:38:17 -05:00
Molly Struve
978b698e78
Point acts_as_follower gem at Forem repo fork (#11954) 2020-12-17 14:33:12 -06:00
Manasa
4fac78f1b4
Allow admin to add users as podcast owners (MLH Fellowship) (#11728) [deploy] 
* added podcast_owner role

* changed view files

* added owner functions

* changed function name in view file

* removed owner role

* removed changes in view file

* controller changes

* added permitted attributes

* fixed the failing tests

* deleted the remove_owner feature for now

* changed controller

* fixed the build error

* added route to add_owner

* added another test

* made suggested changes
 2020-12-17 10:55:16 -07:00
Anna Buianova
1079c4e402
Removed slack notification for admins when user is deleted (#11929) 2020-12-17 20:31:22 +03:00
Anna Buianova
87a99a28ae
Fix Rails/OutputSafety violations (#11945) 
* Avoid Rails/OutputSafety violation in setup checks

* Avoid Rails/OutputSafety violation in admin config labels

* Added parentheses for tag.span
 2020-12-17 20:30:15 +03:00