Commit graph

578 commits

Author SHA1 Message Date
Fernando Valverde
2233952ceb
[deploy] Discoverable channel will open CTA to request join if not available (#8999) 2020-06-30 13:03:41 -05:00
Nick Taylor
efc3a124a0
Added spinner/upload message when uploading an image to a post's content (#8986) 2020-06-30 13:52:47 -04:00
Fernando Valverde
336cf119d9
[deploy] Fixes triggerSwitchChannel on channel list load (#8996) 2020-06-30 10:09:36 -06:00
ludwiczakpawel
3a69f349be
[deploy] Refactor code blocks styling (#8975)
* flare tag line height

* .

* dropdown fix + actions bar fix

* actions bar on mob

* .

* missing bit

* document

* .

* little fix

* btn--highlight
2020-06-29 21:15:11 -04:00
Mac Siri
50a7c2ffe0
Rename dir _tests to __tests__ & update .codeclimate.yml (#8982) 2020-06-29 15:18:39 -04:00
narender2031
09e70896fa
[deploy] 🚀 Bug: Fix iframe flashes on re render (#8974)
* Feature 🚀 : Ability to delete messages in chat channels

- Sending message ID to frontend
- Deleting Message
- Use pusher to delete message realtime

* Minor Bug 🐞: Show message action only for current user

- User can delete or edit their own messages

* Test cases added

* Bug 🐞: Update message id for receiver

Message id was not sent to receiver by pusher

* Refactoring🛠: Message controller refactoring

* Test Cases📝 : Specs for Delete message added

* Feature 🚀 : Ability to edit messages

* Test Cases📝 : Specs for Edit message added

* fix flashes on re-render chat ui

Co-authored-by: Sarthak Sharma <7lovesharma7@gmail.com>
2020-06-29 12:20:21 -04:00
Lisa Sy
c627086d74
Update Connect responsiveness on smaller viewports (#8829) [deploy]
* Improve responsive experience for Connect

- Create single-screen experience for channels list & chat container on
  small screens
- Remove `expanded` and `contracted` functionality
- Make small UI updates to channels-list
- Update tests accordingly

https://github.com/thepracticaldev/dev.to/issues/8442

* Iterate per first review

- Delete unnecessary conditional for displaying side filters
- Improve width display
- Use different animation for responsive experience
- Add top-border stroke to composer input

* Update app/assets/stylesheets/chat.scss

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* Update app/assets/stylesheets/chat.scss

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* Update app/assets/stylesheets/chat.scss

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* Update app/assets/stylesheets/chat.scss

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* Update app/assets/stylesheets/chat.scss

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* Update app/assets/stylesheets/chat.scss

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* layout fix

* Update test to reflect markup updates

* Fix channels position issue

* Use constants

* Lower coverage threshold

* Update line coverage threshold

https://github.com/thepracticaldev/dev.to/pull/8829#issuecomment-650140589

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
Co-authored-by: rhymes <rhymesete@gmail.com>
2020-06-29 09:08:18 -07:00
Nick Taylor
b9c64e57f1
Added a comment mentioning that index.js overrides are for barrel files (#8978) 2020-06-29 10:52:35 -04:00
Nick Taylor
2130269f91
Documentation Improvements to Storybook (#8947) 2020-06-29 08:25:57 -05:00
Nick Taylor
30bfe1adfd
More frontend lint fixes (#8931) 2020-06-29 08:19:13 -04:00
Bolarinwa Balogun
2995687d0c
Move edit and delete buttons on chat messages to dropdown menu (#7820)
* Move edit and delete buttons on chat messages to dropdown menu

* Move edit and delete buttons on chat messages to dropdown menu

* Use 'up arrow' as shortcut to edit last message

* Use 'delete key' as shortcut to delete last message

* Change span to button and handle case when lastMessage is undefined

* Fix up code

* Fix code
2020-06-29 14:14:23 +02:00
Arit Amana
4f476c1c5a
[deploy] Fix Mod Center v1 bugs post-launch (#8883)
* Fix article heading color on dark themes

* Fix hash shoing when no article tags

* Truncate article titles at 60 characters

* Add tests for bug fixes, make sundry corrections

* Refactor tests

* Truncate title with CSS instead of JS

* Use crayons tag over custom tag

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* Add specific height to fix weird anchor tag issues

* Add explicit pointer when hovering

Co-authored-by: Zhao-Andy <17884966+Zhao-Andy@users.noreply.github.com>
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
2020-06-26 11:50:55 -04:00
Nick Taylor
8e1dd6e323
[deploy] Fixed broken video capabilities of Connect (#8922)
* Fixes the broken video capabilities of Connect.

* Added tests for fullscreen check.

* Added tests.

* Fixed a typo.

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-06-26 11:32:34 -04:00
Nick Taylor
a7938ed287
Fixed a bunch of linting issues in components (#8921) 2020-06-26 10:26:02 -04:00
Any Ruiz
991ce29050
Fix incorrect styling of fork in repo list (#8876)
* Fix incorrect styling of fork in repo list

* Update styles with crayon-indicator component
2020-06-26 12:10:01 +02:00
Nick Taylor
63b4d9fdc0
More frontend test cleanup (#8919) 2020-06-25 18:04:01 -04:00
Nick Taylor
5bdbc0480d
Some frontend testing cleanup. (#8902) 2020-06-25 09:07:34 -04:00
Nick Taylor
ab4753079c
Enabled canned import rules as well as import order rule (fixable via --fix). (#8880) 2020-06-25 10:30:40 +02:00
Nick Taylor
09bb730f9d
Added a11y tests to frontend tests that were missing them (#8873) 2020-06-24 14:38:39 -04:00
Ben Halpern
cfa5e882ce
[deploy] Add SiteConfig for feed style (#8721)
* Add SiteConfig for feed style

* Merge master

* Merge master

* Fix typo
2020-06-24 12:14:33 -04:00
Ben Halpern
26d54e72cf
[deploy] Small mod fixes (#8885) 2020-06-24 10:45:11 -04:00
Arit Amana
e45742c212
Mod Center MVP 🎉 (#8744)
Co-authored-by: Andy Zhao <17884966+Zhao-Andy@users.noreply.github.com>
2020-06-23 14:58:16 -04:00
Nick Taylor
d1f43ae4f4
Fixed warning notice Storybook name (#8856) 2020-06-23 10:13:58 -04:00
Nick Taylor
a9c18b4359
Theme switcher in Storybook persists theme between stories and sessions now (#8855) 2020-06-23 09:05:24 -04:00
Rafi
ebc4534246
Fixing listing modal handler (#8773) 2020-06-22 19:11:59 -04:00
Molly Struve
b16606e613
[deploy] Optimization: Remove followed_user_ids from Async User Data Hash (#8837) 2020-06-22 18:45:16 -04:00
Vaidehi Joshi
c4d9c4aed9
Remove trailing slashes from URLs to improve SEO (#8836) [deploy] 2020-06-22 13:44:58 -07:00
Nick Taylor
6bcdae3712
Configure eslint to use Preact linter rules (#8828) 2020-06-22 14:44:55 -04:00
Nick Taylor
b03cd5e515
Created the spinner for the image uploader (#8781) 2020-06-22 10:35:42 -04:00
Michael Kohl
359f2cb2c5
Style hide link with Crayons (#8820) 2020-06-22 08:27:38 -04:00
Nick Taylor
52ac36dd0a
Added a11y Storybook addon. (#8814) 2020-06-22 10:56:03 +02:00
Nick Taylor
7fa3068e70
webpack aliases resolve properly for eslint now. (#8816) 2020-06-22 10:26:01 +02:00
Nick Taylor
568ada8fe6
Cleaned up some tests. (#8817) 2020-06-22 10:25:39 +02:00
Nick Taylor
be9a880e81
Fix eslint files for prettier (#8815)
* Fixed lint extends so that prettier is the last extends to override all other extends (recommended).

* Added prettier to extends of base eslint file.
2020-06-22 10:25:05 +02:00
Ben Halpern
4aa3240fde
[deploy] Fix comment/reaction count hiding issue on small screens (#8786) 2020-06-18 21:37:27 -04:00
Ben Halpern
e9a60d9f77
[deploy] Check for snackbar (#8783) 2020-06-18 19:51:21 -04:00
Nick Taylor
e117c7b766
nickytonline/comment subscription fix (#8768) 2020-06-18 11:26:48 -04:00
Nick Taylor
653ec12300
Upgrade to Preact 10.4.4 (#8739)
Co-authored-by: Nick Taylor <nick@iamdeveloper.com>
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2020-06-18 10:07:17 -04:00
Ben Halpern
2deadc2385
Change three-dots svg (#8746) 2020-06-17 15:53:55 -04:00
ludwiczakpawel
16f4d7d46a
[deploy] Article Design update (#8234)
* flare tag line height

* .

* init

* widgets

* widgets lists

* new tabs on home

* instantclick

* .

* rethinking css

* .

* .

* empty space

* init

* campaign widget

* .

* merge

* .

* update layout

* fix sidebars on home page

* .

* fix onboarding x

* test

* spec

* test

* toolbar fix

* more

* test

* better handling ads

* .

* spec

* card border

* .

* .

* actions bar

* cleanup

* animation

* test

* button width

* .

* better responsiveness and author boxes

* meta info

* padding

* better animation

* optimize videos

* fixes

* spec

* .

* codeblocks in comments

* whoops

* Use .present? correctly as it preloads items

* sticky nav

* Update app/views/articles/_sticky_nav.html.erb

I don't know what I'm doing but @benhalpern says so! e8c0f337a5 (r440248874)

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>

* Update app/views/articles/show.html.erb

I don't know what I'm doing but @benhalpern says so! e8c0f337a5 (r440247802)

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>

* little fixes

* Update app/assets/stylesheets/article-show.scss

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>

* pawel updating ruby code......

* actually better merge

* semantic updates

* .

Co-authored-by: rhymes <rhymesete@gmail.com>
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-06-17 09:57:57 -04:00
Ben Halpern
e6abadff6c
Generalize editor logo (#8720) 2020-06-17 10:51:50 +02:00
Lisa Sy
5e1fc2c4cd
Update connect chat container (part 2) (#8717) [deploy]
* Update chat container of Connect

- Rename certain class names to improve BEM syntax and naming
- Update typography of message cells
- Update header of message area
- Use new 'info' icon to expand sidebar
- Update form fields for both writing and editing a message
- Implement Crayons styling for 'delete' modal

https://github.com/thepracticaldev/dev.to/issues/8437

* Update some tests aand class names

* Update tests

* Update info icon

* Update reference
2020-06-16 15:15:59 -07:00
Rafi
6f3e89f4ed
Rendering html entity in home feed (#8472) 2020-06-16 13:39:07 -04:00
Lisa Sy
bfe663f407
Update chat container of Connect (#8456)
* Update chat container of Connect

- Rename certain class names to improve BEM syntax and naming
- Update typography of message cells
- Update header of message area
- Use new 'info' icon to expand sidebar
- Update form fields for both writing and editing a message
- Implement Crayons styling for 'delete' modal

https://github.com/thepracticaldev/dev.to/issues/8437

* Update some tests aand class names

* Update tests
2020-06-16 10:23:56 -07:00
narender2031
8b9670abd7
Skynox/fix eslint and redirection bug (#8513)
* Feature 🚀 : Ability to delete messages in chat channels

- Sending message ID to frontend
- Deleting Message
- Use pusher to delete message realtime

* Minor Bug 🐞: Show message action only for current user

- User can delete or edit their own messages

* Test cases added

* Bug 🐞: Update message id for receiver

Message id was not sent to receiver by pusher

* Refactoring🛠: Message controller refactoring

* Test Cases📝 : Specs for Delete message added

* Feature 🚀 : Ability to edit messages

* Test Cases📝 : Specs for Edit message added

* fix Content component esLint issue

* fix @all link

Co-authored-by: Sarthak Sharma <7lovesharma7@gmail.com>
2020-06-15 17:00:41 -04:00
Ben Halpern
1b37edeeb8
[deploy] Allow admins to define onboarding images in config (#8431)
* Add config for onboarding

* Fix tests/snapshot

* Improved specs
2020-06-12 08:48:20 -04:00
Vaidehi Joshi
38993608cf
Hide active announcements from logged-in users on the editor (#8427) [deploy] 2020-06-11 16:02:54 -07:00
Dana Scheider
f6a4c844cd
Implement chronological sorting of search results (#8193)
* Implement search ordering by allowing sort_by and sort_direction
params to be passed through from the search form/page.

* Change ID of select to 'sort' instead of 'order' for consistency

* Fix styling and data attributes of select options

* Enable front end to pass sort_by and sort_direction params for searches to the back end

* Ensure that only query string params that are supposed to be changed are changed in each function

* Respond to review comments (additional commits to come but these were the quick changes)

* Move options for select into template

* Use addEventListener instead of using onchange in response to review comments

* Add tabs for sorting search results

* Finish implementing tabs for ordering search results

* Remove CSS rule applying to element that no longer exists

* Remove more rules created for an element that has been removed

* Remove more code added for the select dropdown that I've removed

* Remove duplicate jobs banner
2020-06-11 13:11:01 +02:00
narender2031
e78a0078a7
[deploy] Refactor 🚀 : Replaced Chat Channel Setting page with Preact component. (#8271)
* Feature 🚀 : Ability to delete messages in chat channels

- Sending message ID to frontend
- Deleting Message
- Use pusher to delete message realtime

* Minor Bug 🐞: Show message action only for current user

- User can delete or edit their own messages

* Test cases added

* Bug 🐞: Update message id for receiver

Message id was not sent to receiver by pusher

* Refactoring🛠: Message controller refactoring

* Test Cases📝 : Specs for Delete message added

* Feature 🚀 : Ability to edit messages

* Test Cases📝 : Specs for Edit message added

* 🐞 Channel List bug in mobile view

* changes in joining request responses

* 🛠  Request Managers Frontend ready

* changes in routes for adding and removing remembership

* 🚀 New routes implemented for request manager

* fix issues

* changes in api for remove membership

* Merge conflict resolved

* 🐞 Channel List bug in mobile view

* changes in joining request responses

* 🛠  Request Managers Frontend ready

* changes in routes for adding and removing remembership

* 🚀 New routes implemented for request manager

* fix issues

* changes in api for remove membership

* 🛠Optimizing for CodeClimate

* 🛠Optimizing again for CodeClimate

* 🛠Optimizing again 2 for CodeClimate

* 🛠 Added more test cases

* 🛠 Optimizing code

* 🚀 Action to open setting page added

* 🛠  Dummy page added for chat setting

* add JSON routes for chat channel settings

* Integrate chat channel settings API with UI

* 🐞 Channel List bug in mobile view

* 🛠  Request Managers Frontend ready

* changes in routes for adding and removing remembership

* 🚀 New routes implemented for request manager

* fix issues

* 🐞 Channel List bug in mobile view

* 🛠  Request Managers Frontend ready

* changes in routes for adding and removing remembership

* 🚀 New routes implemented for request manager

* fix issues

* 🛠Optimizing again for CodeClimate

* 🚀 Action to open setting page added

* 🛠  Dummy page added for chat setting

* add JSON routes for chat channel settings

* Integrate chat channel settings API with UI

* Fix PR requested changes

* Add JSDoc documentation to exported functions

* fix/add rspec test cases

* refactor channelSettinngs render part

* add test cases for chat channel settings component

* fix code-climate

* add rest component tests

* add more test coverage

* fix code-climate bugs

* add API function test

Co-authored-by: Sarthak Sharma <7lovesharma7@gmail.com>
Co-authored-by: Parasgr-code <paras.gaur@skynox.tech>
2020-06-10 16:58:37 -04:00
Michael Kohl
60f235d6eb
Use official Asciinema player embed (#8339)
* Use official Asciinema player embed

* Use postscribe to force Asciinema scripts in preview
2020-06-10 12:44:03 +02:00