rhymes
1901ac9573
[15 min fix] Update Publishing from RSS guide with correct instructions ( #13756 )
...
* Update Publishing from RSS guide with correct instructions
* Use colons, not arrows
* Update app/views/pages/publishing_from_rss_guide.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-05-13 17:00:35 +02:00
Michael Kohl
f7293c3544
Fix wrong SiteConfig mentions ( #13739 )
2021-05-13 09:36:36 +00:00
Michael Kohl
3c92419311
Remove settings_mascots table ( #13737 )
...
* Remove settings_mascots table
* Remove DUS
2021-05-13 10:03:25 +07:00
Vaidehi Joshi
ba972b2c1d
Remove any preexisting mention notifications when article is unpublished ( #13749 )
...
Also add specs for this behavior, as well as specs for removing preexisting comment notificaitons when an article is unpublished
2021-05-12 11:48:12 -07:00
Alex
e53b6bff85
Auto-subscribe to comments on articles from feed ( #13717 )
...
* Auto-subscribe to comments on articles from feed
* Change specs
* Update spec again
2021-05-12 12:18:32 -04:00
Fernando Valverde
2463ac7194
Expose aasa for non-private Forems ( #13729 )
...
* Expose aasa non-private forems + small tweak to aasa
* Tests
* Update spec/requests/universal_links_spec.rb
Co-authored-by: Michael Kohl <citizen428@dev.to>
* Check empty array with be_empty
* Include Universal Links context
Co-authored-by: Michael Kohl <citizen428@dev.to>
2021-05-12 10:13:46 -06:00
Andrew Bone
f6e222f12e
Fix layout shift on active crayons-tabs change. ( #13300 )
2021-05-12 11:45:36 -04:00
Vaidehi Joshi
5e6aad98e3
Replace MAX_USER_MENTIONS with Settings::RateLimit.mention_creation ( #13736 )
...
* Replace MAX_USER_MENTIONS with Settings::RateLimit.mention_creation
* Remove Vaidehi-specific TODOs
* Remove unnecessary constant stubs
* Remove rate_limit_mention_creation from SiteConfig
2021-05-12 08:16:38 -07:00
Vaidehi Joshi
8f0c24c167
Expand @-mention functionality to posts ( #13367 )
...
* Initial work for @-mention notifications from posts
* Revert article.published changes to article updater, add clarifying comments
* Extract article preview into reusable partial for notification views
* Clean up Article Updater
* Address + remove some FIXMEs
* Add a whole buncha specs for @-mention functionality in posts YAY
* Refactor create all spec to use shared examples, add clarifying comments
* Add guard clause to create all service
* Update new mention and notifiable action specs
* Some additional cleanup
* Add specs + shared examples to SendEmailNotificationWorker spec
* Use aggregate_failures where applicable
Co-authored-by: Michael Kohl <citizen428@dev.to>
* Cleanup and address code review comments
* Add MentionDecorator + relevant specs
* Address comments/issues flagged by @rhymes
* Optimize plucking user_ids when checking for article followers
Co-authored-by: Michael Kohl <citizen428@dev.to>
2021-05-12 07:33:33 -07:00
Suzanne Aitchison
cdcb3b9be3
add accessibility section to editor guide ( #13727 )
...
* add accessibility section to editor guide
* Update app/views/pages/_editor_guide_text.html.erb
Co-authored-by: Jacob Herrington <jacobherringtondeveloper@gmail.com>
Co-authored-by: Jacob Herrington <jacobherringtondeveloper@gmail.com>
2021-05-12 10:19:34 +01:00
Madza
cac7fd1c55
Update GitPod setup description ( #13709 )
2021-05-12 10:30:42 +02:00
dependabot[bot]
25bf30ae43
Bump derailed_benchmarks from 2.0.1 to 2.1.0 ( #13743 )
...
Bumps [derailed_benchmarks](https://github.com/schneems/derailed_benchmarks ) from 2.0.1 to 2.1.0.
- [Release notes](https://github.com/schneems/derailed_benchmarks/releases )
- [Changelog](https://github.com/schneems/derailed_benchmarks/blob/main/CHANGELOG.md )
- [Commits](https://github.com/schneems/derailed_benchmarks/compare/v2.0.1...v2.1.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-12 10:30:26 +02:00
Michael Kohl
fa2ff578ab
Add documentation for Profiles::Update ( #13723 )
2021-05-12 09:59:39 +07:00
Jamie Gaskins
11bab732c0
Bump Puma to v5.3.1 ( #13731 )
...
This required an explicit `Gemfile` change because `bundle update puma`
did not actually update otherwise:
Bundler attempted to update puma but its version stayed the same
2021-05-11 13:43:18 -04:00
Michael Kohl
867d9a1a2f
Move services from Suggester::Users ( #13699 )
2021-05-11 12:57:12 -04:00
rhymes
f1ef665771
Hide the correct email PII on Blazer ( #13733 )
2021-05-11 18:43:46 +02:00
rhymes
860895a7cd
Add composite index to articles hotness_score and comments_count ( #13724 )
2021-05-11 18:39:56 +02:00
dependabot[bot]
423b2e8779
Bump factory_bot_rails from 6.1.0 to 6.2.0 ( #13722 )
...
Bumps [factory_bot_rails](https://github.com/thoughtbot/factory_bot_rails ) from 6.1.0 to 6.2.0.
- [Release notes](https://github.com/thoughtbot/factory_bot_rails/releases )
- [Changelog](https://github.com/thoughtbot/factory_bot_rails/blob/master/NEWS.md )
- [Commits](https://github.com/thoughtbot/factory_bot_rails/compare/v6.1.0...v6.2.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-11 12:31:17 -04:00
Jamie Gaskins
1649d14891
Pass a FlareTag instead of a string to URL.tag ( #13732 )
2021-05-11 12:10:42 -04:00
Jamie Gaskins
bcc42a130d
Sanitize tag urls ( #13720 )
...
* Sanitize tag URLs
For tags with non-ASCII names, we were generating busted URLs, which
would then cause errors. This commit fixes that particular error by
generating usable URLs.
* Use URL generator that will sanitize tag names
* Remove path prefix when using a URL generator
2021-05-11 11:21:03 -04:00
Michael Kohl
111b7316d9
Remove mascot footer image ( #13642 )
...
* Remove footer mascot image
* Move remaining mascot settings back to SiteConfig
* Add data update script
* Update usages
* Fix path
* Remove dead route
* Update tests
* Fix view and spec
* Fix e2e test
* Fix DUS
2021-05-11 13:55:18 +02:00
Anna Buianova
ce46ea2378
Organizations delete optimizations and refactoring ( #13610 )
...
* Delete org notifications in batches before org destroy
* Moved on destroy callbacks to a service for org delete
* Be consistent with org_id in specs
* Removed irrelevant code
* Moved article_ids to initializer for Organizations::Delete
* Update articles cached_organization explicitly after deleting an org
2021-05-11 12:14:55 +03:00
dependabot[bot]
21981b236d
Bump ibm-openapi-validator from 0.44.0 to 0.46.0 ( #13714 )
...
Bumps [ibm-openapi-validator](https://github.com/IBM/openapi-validator ) from 0.44.0 to 0.46.0.
- [Release notes](https://github.com/IBM/openapi-validator/releases )
- [Changelog](https://github.com/IBM/openapi-validator/blob/main/CHANGELOG.md )
- [Commits](https://github.com/IBM/openapi-validator/compare/v0.44.0...v0.46.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-11 08:29:28 +02:00
dependabot[bot]
dc7ab580ff
Bump lint-staged from 10.5.4 to 11.0.0 ( #13711 )
...
Bumps [lint-staged](https://github.com/okonet/lint-staged ) from 10.5.4 to 11.0.0.
- [Release notes](https://github.com/okonet/lint-staged/releases )
- [Commits](https://github.com/okonet/lint-staged/compare/v10.5.4...v11.0.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-11 08:28:51 +02:00
dependabot[bot]
028afc1c75
Bump flipper-ui, flipper-active_record, flipper, flipper, flipper and flipper ( #13704 )
...
* Bump flipper-ui, flipper-active_record, flipper, flipper, flipper and flipper
Bumps [flipper-ui](https://github.com/jnunemaker/flipper ), [flipper-active_record](https://github.com/jnunemaker/flipper ), [flipper](https://github.com/jnunemaker/flipper ), [flipper](https://github.com/jnunemaker/flipper ), [flipper](https://github.com/jnunemaker/flipper ) and [flipper](https://github.com/jnunemaker/flipper ). These dependencies needed to be updated together.
Updates `flipper-ui` from 0.20.4 to 0.21.0
- [Release notes](https://github.com/jnunemaker/flipper/releases )
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md )
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.20.4...v0.21.0 )
Updates `flipper-active_record` from 0.20.4 to 0.21.0
- [Release notes](https://github.com/jnunemaker/flipper/releases )
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md )
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.20.4...v0.21.0 )
Updates `flipper` from 0.20.4 to 0.21.0
- [Release notes](https://github.com/jnunemaker/flipper/releases )
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md )
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.20.4...v0.21.0 )
Updates `flipper` from 0.20.4 to 0.21.0
- [Release notes](https://github.com/jnunemaker/flipper/releases )
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md )
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.20.4...v0.21.0 )
Updates `flipper` from 0.20.4 to 0.21.0
- [Release notes](https://github.com/jnunemaker/flipper/releases )
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md )
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.20.4...v0.21.0 )
Updates `flipper` from 0.20.4 to 0.21.0
- [Release notes](https://github.com/jnunemaker/flipper/releases )
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md )
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.20.4...v0.21.0 )
Signed-off-by: dependabot[bot] <support@github.com>
* Fix dependency
* Turning on video to see the failed flaky test
* Turn cypress video off again
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andy Z <17884966+Zhao-Andy@users.noreply.github.com>
2021-05-11 08:27:15 +02:00
dependabot[bot]
66c05db0da
Bump @testing-library/dom from 7.30.4 to 7.31.0 ( #13716 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-10 17:05:31 -04:00
dependabot[bot]
dd0da3d8c6
Bump prettier from 2.2.1 to 2.3.0 ( #13702 )
...
Bumps [prettier](https://github.com/prettier/prettier ) from 2.2.1 to 2.3.0.
- [Release notes](https://github.com/prettier/prettier/releases )
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md )
- [Commits](https://github.com/prettier/prettier/compare/2.2.1...2.3.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-10 12:54:55 -07:00
dependabot[bot]
373a7a6d8b
Bump eslint-plugin-cypress from 2.11.2 to 2.11.3 ( #13713 )
...
Bumps [eslint-plugin-cypress](https://github.com/cypress-io/eslint-plugin-cypress ) from 2.11.2 to 2.11.3.
- [Release notes](https://github.com/cypress-io/eslint-plugin-cypress/releases )
- [Commits](https://github.com/cypress-io/eslint-plugin-cypress/compare/v2.11.2...v2.11.3 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-10 11:04:18 -07:00
dependabot[bot]
74390b7678
Bump sidekiq-unique-jobs from 7.0.9 to 7.0.10 ( #13707 )
...
Bumps [sidekiq-unique-jobs](https://github.com/mhenrixon/sidekiq-unique-jobs ) from 7.0.9 to 7.0.10.
- [Release notes](https://github.com/mhenrixon/sidekiq-unique-jobs/releases )
- [Changelog](https://github.com/mhenrixon/sidekiq-unique-jobs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/mhenrixon/sidekiq-unique-jobs/compare/v7.0.9...v7.0.10 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-10 09:21:57 -06:00
dependabot[bot]
70cc4da747
Bump @babel/preset-env from 7.14.0 to 7.14.1 ( #13712 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-10 11:01:56 -04:00
dependabot[bot]
afaf8ebb5d
Bump recaptcha from 5.7.0 to 5.8.0 ( #13708 )
...
Bumps [recaptcha](https://github.com/ambethia/recaptcha ) from 5.7.0 to 5.8.0.
- [Release notes](https://github.com/ambethia/recaptcha/releases )
- [Changelog](https://github.com/ambethia/recaptcha/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ambethia/recaptcha/compare/v5.7.0...v5.8.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-10 07:31:01 -07:00
dependabot[bot]
beda22d3b5
Bump eslint from 7.25.0 to 7.26.0 ( #13701 )
...
Bumps [eslint](https://github.com/eslint/eslint ) from 7.25.0 to 7.26.0.
- [Release notes](https://github.com/eslint/eslint/releases )
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md )
- [Commits](https://github.com/eslint/eslint/compare/v7.25.0...v7.26.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-10 07:30:31 -07:00
dependabot[bot]
8fba0b4f4f
Bump core-js from 3.11.2 to 3.12.1 ( #13700 )
...
Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js ) from 3.11.2 to 3.12.1.
- [Release notes](https://github.com/zloirock/core-js/releases )
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zloirock/core-js/commits/v3.12.1/packages/core-js )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-10 07:30:21 -07:00
dependabot[bot]
e3c2b180ff
Bump slack-notifier from 2.3.2 to 2.4.0 ( #13705 )
...
Bumps [slack-notifier](https://github.com/stevenosloan/slack-notifier ) from 2.3.2 to 2.4.0.
- [Release notes](https://github.com/stevenosloan/slack-notifier/releases )
- [Changelog](https://github.com/slack-notifier/slack-notifier/blob/main/changelog.md )
- [Commits](https://github.com/stevenosloan/slack-notifier/compare/2.3.2...2.4.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-10 07:29:38 -07:00
dependabot[bot]
f5ce9c9218
Bump hosted-git-info from 2.8.8 to 2.8.9 ( #13698 )
...
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info ) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases )
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md )
- [Commits](https://github.com/npm/hosted-git-info/compare/v2.8.8...v2.8.9 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-10 07:29:06 -07:00
Suzanne Aitchison
2829c7f848
stop adding a false class ( #13710 )
2021-05-10 13:54:23 +01:00
dependabot[bot]
5a9deac9b9
Bump postcss from 8.2.13 to 8.2.14 ( #13703 )
2021-05-10 08:17:00 -04:00
Olawale Oyeyipo
5107844251
Make comment box shrink on submit ( #13686 )
...
* Make comment box shrink on submit
* Add missing semicolon
* Reset height on both comment textboxes
2021-05-10 09:06:49 +01:00
Rafi
8ef1313e71
Fixing preview button text in comment section ( #13627 )
2021-05-07 10:48:33 -05:00
Suzanne Aitchison
783fb6fa24
Accessibility enhancements to navigation tabs ( #13559 )
...
* update storybook example and docs
* update desktop home feed tabs with a11y enhancements
* update storybook to reflect buttons usage, update post editor buttons
* update admin html variants tabs
* update admin sponsorships tabs
* re-add flex to the crayons-tab class to prevent regression in tab components not updated
* Revert "update admin sponsorships tabs"
This reverts commit d9e4a5e4b0d362e38a11c795b35ceb4442bc4d90.
* Revert "update admin html variants tabs"
This reverts commit 3d9f119e88dc2f2f102d664c57a1f56413490a36.
* update search tabs
* update v2 form erb html
* update tag index tabs
* update notifications tabs
* label the notifications nav
* update mod sidebar tabs
* update main analytics page tabs
* add cypress tests for home feed tabs
* add tab tests for the post editor
* add cypress tests for tags index navigation
* fix UI issue with search tabs, add search cypress tests
* add tests for the analytics dashboard tabs
* add mod nav tests
* add notifications navigation tests
* get new handles after view switch
* replace hardcoded mod paths
* apply review suggestions
2021-05-07 15:24:34 +01:00
Siddharth
f669907a8f
Updated replit url from repl.it to replit.com ( #13680 )
...
* Updated replit url from repl.it to replit.com
* Changed repl.it to replit
* Changed repl.it to replit
2021-05-07 08:00:45 -04:00
Nick Taylor
c48e31731d
[15 min fix] Fixed broken share button on article page. ( #13688 )
2021-05-07 06:33:30 -04:00
Siddharth
5462e0a1f9
Update badge CSS ( #13659 )
2021-05-07 10:47:25 +02:00
arunkc
47908d7a87
Update format specifiers in readable_publish_date ( #13660 )
...
* Update format specifiers in readable_publish_date
* Trigger Travis manually
* Update format specifiers in readable_publish_date
* Update format specifiers in readable_publish_date
Co-authored-by: rhymes <rhymes@hey.com>
2021-05-07 08:51:49 +02:00
rhymes
cf9f6094cd
Have specs run without Redis and refactor ConsumerApp and Device ( #13647 )
...
* Add fakeredis gem
* Mock Pusher::PushNotifications in specs
* Remove Redis from Travis
* Add Android tests to ConsumerApp specs
* Use mock for push notification tests and refactor ConsumerApp and Device code
* Fix remaining broken specs
* Use symbols
* Cleanup rpush helpers
* Pusher::PushNotifications is no more
* Use human friendly platform in Admin::ConsumerApps index page
2021-05-07 08:03:16 +02:00
rhymes
de488f331d
Remove inline comments and variable substitution from .env_sample ( #13685 )
...
* Remove inline comments from .env_sample
* Remove variable substitution as it's not supported by Foreman
2021-05-06 18:01:52 +02:00
Daniel Uber
8678cd5ae4
Fixes error in seeded navigation link svg icon ( #13683 )
...
I was seeing during testing this console error:
"Error: <path> attribute d: Expected path command, "…0-4 2 2 0 000 4z\\".
Removing the \" and leaving just " seems like it corrected that (the
error stops showing, the icon is unchanged since the prior path was
drawn before the error raised).
2021-05-06 10:37:52 -05:00
Daniel Uber
d7f9a18199
Clarify article link copy title ( #13682 )
...
Incorporating aitchiss's suggestion from https://github.com/forem/forem/pull/13668/
2021-05-06 09:04:14 -05:00
dependabot[bot]
b4373405f5
Bump rubocop from 1.13.0 to 1.14.0 ( #13678 )
...
* Bump rubocop from 1.13.0 to 1.14.0
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.13.0 to 1.14.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.13.0...v1.14.0 )
Signed-off-by: dependabot[bot] <support@github.com>
* Enable Bundler/GemVersion
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rhymes <me@rhymes.dev>
2021-05-06 08:32:42 -05:00
Thomas Bnt
7ad3aeb7ac
Edited the title on id="article-copy-link-input" ( #13668 )
2021-05-06 08:19:58 -05:00
