Commit graph

6937 commits

Author SHA1 Message Date
rhymes
13bc3fc402
Removed unused CodeMirror CSS class (#10611) 2020-10-06 10:02:10 +07:00
dependabot-preview[bot]
f1b0ab6a96
Bump cloudinary from 1.17.1 to 1.18.1 (#10553) 2020-10-05 15:28:17 -04:00
dependabot-preview[bot]
32a7b4047f
Bump stripe from 5.25.0 to 5.26.0 (#10559) 2020-10-05 15:27:18 -04:00
dependabot-preview[bot]
db304bcd82
Bump brakeman from 4.9.1 to 4.10.0 (#10562) 2020-10-05 15:26:56 -04:00
dependabot-preview[bot]
ee66a061fd
Bump @storybook/addons from 6.0.25 to 6.0.26 (#10607) 2020-10-05 15:26:21 -04:00
dependabot-preview[bot]
e8fce9bea1
Bump @testing-library/preact-hooks from 1.0.6 to 1.1.0 (#10557) 2020-10-05 15:25:45 -04:00
dependabot-preview[bot]
8f043c1c84
Bump @stoplight/spectral from 5.5.0 to 5.6.0 (#10552) 2020-10-05 15:25:17 -04:00
Ben Halpern
c60566b8a5
[deploy] Modify code to deal with flaky tests (#10616)
* Modify code to deal with flaky tests

* Remove uneeded x
2020-10-05 14:54:11 -04:00
Rachael Wright-Munn
348aa3df15
[deploy] Add twitch liquid tags (#10577)
* Add a Liquid Tag specifically for Twitch clips.

These will embed Twitch Clips in articles and comments.

* Update documentation to incorporate Twitch clip liquid tags.

* Include Twitch Clips in video embed logic

* Making a small change to rebuild
2020-10-05 11:55:27 -04:00
Michael Kohl
640f124033
Don't use "not_to raise_error" with specific class (#10602) 2020-10-05 17:29:01 +02:00
dependabot-preview[bot]
18672f24f0
Bump twilio-ruby from 5.40.2 to 5.40.4 (#10555) 2020-10-05 11:19:51 -04:00
dependabot-preview[bot]
725e1fac35
Bump ddtrace from 0.40.0 to 0.41.0 (#10551) 2020-10-05 11:04:34 -04:00
dependabot-preview[bot]
13be9027d7
Bump exifr from 1.3.7 to 1.3.8 (#10549) 2020-10-05 11:04:01 -04:00
Ben Halpern
c0d5486023
[deploy] Fix current_user cache issue in comments (#10609) 2020-10-05 10:52:12 -04:00
dependabot-preview[bot]
6b125dc4b2
Bump sidekiq-unique-jobs from 6.0.23 to 6.0.24 (#10548) 2020-10-05 10:37:01 -04:00
dependabot-preview[bot]
c41fc1d51f
Bump @storybook/addon-links from 6.0.22 to 6.0.25 (#10564) 2020-10-05 10:31:18 -04:00
dependabot-preview[bot]
b18ad2a155
Bump better_errors from 2.8.1 to 2.8.3 (#10550) 2020-10-05 10:13:09 -04:00
James Cote
4687707de1
Remove code link style so it uses the default link color (#10578) 2020-10-05 14:51:47 +02:00
ludwiczakpawel
1375e8a4df
[deploy] Redesigned Comment Form (#10355)
* init

* .

* .

* better

* last bits

* specs

* merge

* fix response templates for replies

* copy

* active inactive buttons + cleanup

* labels

* specs

* specs

* response templates fix

* ....

* wtf

* .
2020-10-05 12:01:48 +02:00
Brunno Souza
e5973ebf9c
Refactoring user_controller separating some classes to service (#10384)
* Refactoring user_controller separating some classes to service

* Replace service Credit::Manager and improve yours specs

* improve method with memoize
2020-10-05 10:41:59 +02:00
dependabot-preview[bot]
07c69b35ef
Bump eslint-config-prettier from 6.11.0 to 6.12.0 (#10554)
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 6.11.0 to 6.12.0.
- [Release notes](https://github.com/prettier/eslint-config-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-config-prettier/blob/master/CHANGELOG.md)
- [Commits](https://github.com/prettier/eslint-config-prettier/compare/v6.11.0...v6.12.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-10-04 15:31:33 +02:00
dependabot-preview[bot]
eea6ebb928
Bump eslint from 7.9.0 to 7.10.0 (#10561)
Bumps [eslint](https://github.com/eslint/eslint) from 7.9.0 to 7.10.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v7.9.0...v7.10.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-10-04 15:31:03 +02:00
dependabot-preview[bot]
442cf0e9ce
Bump style-loader from 1.2.1 to 1.3.0 (#10565)
Bumps [style-loader](https://github.com/webpack-contrib/style-loader) from 1.2.1 to 1.3.0.
- [Release notes](https://github.com/webpack-contrib/style-loader/releases)
- [Changelog](https://github.com/webpack-contrib/style-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/style-loader/compare/v1.2.1...v1.3.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-10-04 15:30:29 +02:00
dependabot-preview[bot]
3afbedfb4b
Bump eslint-plugin-import from 2.22.0 to 2.22.1 (#10566)
Bumps [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import) from 2.22.0 to 2.22.1.
- [Release notes](https://github.com/benmosher/eslint-plugin-import/releases)
- [Changelog](https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md)
- [Commits](https://github.com/benmosher/eslint-plugin-import/compare/v2.22.0...v2.22.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-10-04 15:30:11 +02:00
ludwiczakpawel
9d384e1a93
CSS Cleanups, part 2 (#10527)
* padding-top on body

* padding-top on body

* move cheese around

* .

* :(

* rename
2020-10-03 06:57:57 +02:00
Molly Struve
cf443c3ae7
Refactor:Remove Screenshot Monkey Patch (#10520) 2020-10-02 16:53:26 -05:00
Akshay Mahajan
b592ab6c83
added z-index to post editor options dropdown (#10536) 2020-10-02 15:55:46 -04:00
Sarthak Sharma
8c19d5d407
Copy Paste Images in connect (#10484) 2020-10-02 15:50:32 -04:00
Julianna Tetreault
8a01ed6a2c
Removes second_user_id and third_user_id From the Articles Table (#10383) [deploy]
* Removes second_user_id and third_user_id from the Articles table

* Adds updated schema file to (fingers crossed) resolve Travis failure

* Adds gaurd clause to data_update script to mitigate db issues
2020-10-02 13:14:32 -06:00
rhymes
aa39a1f801
Update CODEOWNERS to remove old teams (#10538) 2020-10-02 12:20:29 -04:00
rhymes
c0c1b0fd71
Rename misspelled spec file (#10537) 2020-10-02 17:25:22 +02:00
Ridhwana
21389ab05d
Admin Panel for Configurable Navigational Links (#9444) 2020-10-02 11:11:21 -04:00
Julianna Tetreault
c87974b7ac
[deploy] Add co_author_ids to Articles (#10339)
* Replaces second_user_id and third_user_id with co_author_ids on the Articles table

* Adjusts migration that adds co_author_ids to also add array: true

* Replaces second_user_id and third_user_id with co_author_ids in all applicable files
  - Use co_author_ids in _individual_article view
  - Use co_author_ids in articles and stories controllers
  - Use co_author_ids in article and podcast_episode models
  - Use co_author_ids in article_dashboard
  - Use co_author_ids in comments_helper
  - Use co_author_ids in articles_spec

* Replaces second_user_id and third_user_id with co_author_ids in article.rb model

* Remove unused #assign_co_authors method from the Stories::Controller

* Add #co_authors and #co_author_name_and_path to article_decorator.rb

* Adds a descriptive form field for co_author_ids for Admins in /admin/articles

* Adds a conditional in article/show.html.erb to render co_author names on an Article in a human-readable way

* Replaces get_co_author_name_and_path with proper method name, co_author_name_and_path in show.html.erb

* Adds latest schema to (hopefully) resolve Travis conflicts

* Adds the safe operator to show.html.erb

* Adjusts articles_spec.rb to use an array in the first test

* Replaces unless &.empty? with if ./present? in articles/show.html.erb

* Replaces second_user_id with co_author_ids in stories_show_spec.rb test

* Replaces elsif with else in articles/show.html.erb

* Cleans up show.html.erb by removing conditional in favor of decorator method

* Refactors splitting of params in Articles::Controller and optimizes query in #co_authors

* Reverts removal of second_user_id and third_user_id and migration file

* Adds a data_update script to update co_author_ids with existing second and third user_ids

* Adds validations to co_authors and flash_messages to indicate whether an update was successful or not
  - Adds to methods to article.rb to validate the IDs of co_authors and authors
  - Adds flash messages to the Admin::Articles::Controller and a redirect to the show page
  - Removes the JS highlighting upon submit when updating an Article in Admin
  - Refactors #update action in Admin::Articles::Controller

* Adds tests to article_spec.rb around co_author_id validations in article.rb

* Adjusts #validate_co_authors_must_not_be_the_same to use .include? instead

* Uses Field::Select.with_options in article_dashboard.rb to properly display co_author_ids

* Reverts removal of assigning co_author_ids in the Stories::Controller

* Adjusts error message and adjusts return logic in article.rb (thanks, Fernando!)

* Fixes failing article_spec.rb test that checks for co_author_ids uniqueness

* Adds a default array to co_author_ids and checks if they are .blank?

* Refactor data_update script to use a single SQL statement (thank you, Michael)

* Preserve array order of co_author_ids in article_decorator.rb

* Add db file for default: []

* Add validation to fix bug related to text inputs and invalid users when adding co_authors

* Adds tests to ensure that co_author_ids are both an integer and an integer > 0

* Updates admin/articles_spec.rb to default [] instead of nil

* Adjusts validations in article.rb to be DRY-er and more consistent

* Consolidates validations further

* Refactors validations in article.rb to use procs

* Refactors data_update script to remove nil values from array
2020-10-02 11:06:11 -04:00
Rafi
4a9f27163e
[deploy] Manage listing categories in dashboard (#10506)
* Displaying all listing

* Edit listing form

* Editing listing

* Searching listing categories

* Creating new listing category

* Deleting listing category

* Fixing error message and roles

* Tests

* Fixing aria label

* Fixing link class

* Fixing error message of destroy

* Changing placeholder text
2020-10-02 11:05:09 -04:00
rhymes
4e352020a9
[deploy] Remove additional superfluous indexes (#10530) 2020-10-02 16:20:08 +02:00
Molly Struve
e9761fde7c
Optimization:Dont Notify of Channel Leavings (#10518)
* Optimization:Dont Notify of Channel Leavings

* Add specs and dont send pusher notifications or mark chat channel as unread for left or removed chat actions
2020-10-02 16:19:54 +02:00
Anna Buianova
f6a7a42acc
Slack notification with reminder to delete user gdpr data (#10532) 2020-10-02 10:12:12 -04:00
ludwiczakpawel
bf8e2e53f1
Titles & subtitles cleanup (#10508)
* .

* .

* .
2020-10-02 12:37:39 +02:00
Robin Gagnon
87590e77d3
[deploy] feat: Disable autoplay on native videos (#10516) 2020-10-01 16:52:12 -06:00
Molly Struve
878c70bec9
Spec Fix:Dont Reuse Same Username and Let Factory Set Title (#10519) 2020-10-01 17:10:27 -05:00
Diogo Osório
3bc51a13cc
Fixes 500 error when viewing the "Tag Mods" page without having the role on the database (#10515)
* Makes the ModeratorsQuery not return an exception on invalid role

The current implementation of the query would yield an exception when
recieving an invalid state parameter. As per the [GH issue
discussion](https://github.com/forem/forem/issues/10060#issuecomment-692295217),
Zhao recommended to change its behaviour and not trigger an exception in
this condition.

This commit does just that. If the state argument is invalid, the query
now returns an empty result set.

* Adds a warning when there are no matching mods

* Re-trigger the build
2020-10-01 12:55:25 -06:00
Mac Siri
c2e61074e1
Refactor: Extract app-shell unsupported paths (#10504) 2020-10-01 13:41:59 -04:00
rhymes
aac94bb576
[deploy] Remove superfluous indexes on notifications (#10514) 2020-10-01 13:25:44 -04:00
Vaidehi Joshi
6a697173bc
Split EdgeCache::Bust into Fastly + Nginx-specific classes (#10505) [deploy]
* Split EdgeCache::Bust into Fastly + Nginx-specific classes

* Update EdgeCache::Bust service specs

* Move Nginx TODO comment into Nginx-specific file
2020-10-01 10:07:51 -07:00
Sabarish Rajamohan
e1b3844dfa
[deploy] Updated minimum requirements for local installation on Windows (#10513)
* Updated minimum requirements for local installation on Windows

* Added reference links to WSL 2 support in docs
2020-10-01 11:36:15 -04:00
rhymes
10efa25c0a
Add missing presence validators to models (#10495)
* Add missing presence validator for Tag

* Add missing presence validators to Follow

* Add missing presence validators to ProfileField

* Add missing presence validators to Comment

* Add missing presence validators to Profile

* Add missing presence validators to Organization

* Add missing presence validators to Badge

* Add missing presence validators to Webhook::Endpoint

* Add missing presence validators to NotificationSubscription

* Add missing presence validators to PodcastEpisode

* Add missing presence validators to Sponsorship

* Add missing presence validators to PollOption

* Add missing presence validators to Poll

* Add missing presence validators to Article

* Add missing presence validators to EmailAuthorization

* Add missing presence validators to AuditLog

* Add missing presence validators to DataUpdateScript

* Add missing presence validators to User

* Add missing presence validators to SiteConfig

* Fix specs
2020-10-01 16:15:32 +02:00
rhymes
2d92c5d8e0
API: add docs for api/follows/tags (#10471) 2020-10-01 07:21:44 +02:00
Molly Struve
d2d9984f28
[deploy] Return Cache Bust Response When Busting a Cached Path (#10500) 2020-09-30 17:17:04 -05:00
Mac Siri
7417d03884
Update README's Badge (#10489) 2020-09-30 16:38:23 -04:00
Alex
a35009e339
Remove redirect for listings#update (#10499)
* Remove redirect for listings update

* Quick refactor

* Extract query to convenience method
2020-09-30 16:20:39 -04:00